source: mainline/uspace/srv/audio/hound/audio_sink.h

Last change on this file was 2fbd49c, checked in by Jiri Svoboda <jiri@…>, 3 years ago

Audio synk needs locking

Without locking the list of sink connections, we are exposed
to a race between removing a connection at the end of playback
(typically while destroying a hound context) and audio device
event PCM_EVENT_FRAMES_PLAYED which causes audio mixing to occur
via audio_sink_mix_inputs(), causing hound to crash often at
the end of playback.

  • Property mode set to 100644
File size: 3.0 KB
Line 
1/*
2 * Copyright (c) 2012 Jan Vesely
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 *
9 * - Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * - Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * - The name of the author may not be used to endorse or promote products
15 * derived from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
18 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
19 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
20 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
21 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
22 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29/** @addtogroup audio
30 * @brief HelenOS sound server
31 * @{
32 */
33/** @file
34 */
35
36#ifndef AUDIO_SINK_H_
37#define AUDIO_SINK_H_
38
39#include <adt/list.h>
40#include <async.h>
41#include <stdbool.h>
42#include <fibril.h>
43#include <fibril_synch.h>
44#include <pcm/format.h>
45
46#include "audio_source.h"
47
48typedef struct audio_sink audio_sink_t;
49
50/** Audio sink abstraction structure */
51struct audio_sink {
52 /** Link in hound's sink list */
53 link_t link;
54 /** Protect sink including list of connections */
55 fibril_mutex_t lock;
56 /** List of all related connections */
57 list_t connections;
58 /** Sink's name */
59 char *name;
60 /** Consumes data in this format */
61 pcm_format_t format;
62 /** Backend data */
63 void *private_data;
64 /** Connect/disconnect callback */
65 errno_t (*connection_change)(audio_sink_t *, bool);
66 /** Backend callback to check data */
67 errno_t (*check_format)(audio_sink_t *);
68 /** new data notifier */
69 errno_t (*data_available)(audio_sink_t *);
70};
71
72/**
73 * List instance helper.
74 * @param l link
75 * @return pointer to a sink structure, NULL on failure.
76 */
77static inline audio_sink_t *audio_sink_list_instance(link_t *l)
78{
79 return l ? list_get_instance(l, audio_sink_t, link) : NULL;
80}
81
82errno_t audio_sink_init(audio_sink_t *sink, const char *name, void *private_data,
83 errno_t (*connection_change)(audio_sink_t *, bool),
84 errno_t (*check_format)(audio_sink_t *), errno_t (*data_available)(audio_sink_t *),
85 const pcm_format_t *f);
86
87void audio_sink_fini(audio_sink_t *sink);
88errno_t audio_sink_set_format(audio_sink_t *sink, const pcm_format_t *format);
89void audio_sink_mix_inputs(audio_sink_t *sink, void *dest, size_t size);
90
91#endif
92/**
93 * @}
94 */
Note: See TracBrowser for help on using the repository browser.