source: mainline/uspace/app/bdsh/cmds/modules/unalias/unalias.c

Last change on this file was 46288ee, checked in by Matthieu Riolo <matthieu.riolo@…>, 6 years ago

Improvement alias/unlias according to feedback

This commit will change the behaviour of unalias
when a not existing aliasname is given. The command
will newly return CMD_FAILURE and print a failure message.
Existings aliases will be deleted.

When updating an existing alias with the command alias,
then the old data structure will only be freed when
str_dup did not fail. This will prevent the data
of being corrupted in case of a memory failure.

  • Property mode set to 100644
File size: 3.2 KB
Line 
1/*
2 * Copyright (c) 2018 Matthieu Riolo
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 *
9 * - Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * - Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * - The name of the author may not be used to endorse or promote products
15 * derived from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
18 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
19 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
20 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
21 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
22 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29#include <stdio.h>
30#include <stdlib.h>
31#include <str.h>
32#include <adt/odict.h>
33
34#include "config.h"
35#include "util.h"
36#include "errors.h"
37#include "entry.h"
38#include "unalias.h"
39#include "cmds.h"
40
41static const char *cmdname = "unalias";
42
43static void free_alias(odlink_t *alias_link)
44{
45 alias_t *data = odict_get_instance(alias_link, alias_t, odict);
46 odict_remove(alias_link);
47
48 free(data->name);
49 free(data->value);
50 free(data);
51}
52
53/* Dispays help for unalias in various levels */
54void help_cmd_unalias(unsigned int level)
55{
56 if (level == HELP_SHORT) {
57 printf("`%s' removes an alias or all aliases with -a\n", cmdname);
58 } else {
59 help_cmd_unalias(HELP_SHORT);
60 printf("Usage: `%s' -a'\n"
61 "`%s' name [name ...]'\n\n"
62 "If no parameters are given it will display this help message.\n"
63 "If the flag -a is given, all existing aliases will be removed.\n"
64 "If one or multiple parameters are given, then those aliases will be removed.\n",
65 cmdname, cmdname);
66 }
67}
68
69/* Main entry point for unalias, accepts an array of arguments */
70int cmd_unalias(char **argv)
71{
72
73 if (argv[1] == NULL) {
74 help_cmd_unalias(HELP_LONG);
75 return CMD_SUCCESS;
76 }
77
78 odlink_t *alias_link;
79
80 unsigned int argc = cli_count_args(argv);
81 if (argc == 2) {
82 if (str_cmp(argv[1], "-a") == 0) {
83 alias_link = odict_first(&alias_dict);
84 while (alias_link != NULL) {
85 odlink_t *old_alias_link = alias_link;
86 alias_link = odict_next(old_alias_link, &alias_dict);
87 free_alias(old_alias_link);
88 }
89
90 return CMD_SUCCESS;
91 }
92 }
93
94 int rc = CMD_SUCCESS;
95 size_t i;
96 for (i = 1; argv[i] != NULL; i++) {
97 alias_link = odict_find_eq(&alias_dict, (void *)argv[i], NULL);
98
99 if (alias_link == NULL) {
100 cli_error(CL_ENOENT, "%s: No alias '%s' found\n", cmdname, argv[i]);
101 rc = CMD_FAILURE;
102 } else {
103 free_alias(alias_link);
104 }
105 }
106
107 return rc;
108}
Note: See TracBrowser for help on using the repository browser.