source: mainline/kernel/generic/src/ipc/ops/stchngath.c@ eadaeae8

lfn serial ticket/834-toolchain-update topic/msim-upgrade topic/simplify-dev-export
Last change on this file since eadaeae8 was eadaeae8, checked in by Jakub Jermar <jakub@…>, 7 years ago

Make capability handles type-safe

Define distinct pointer types for the handles of the supported
capability types and use them instead of integer handles. This makes it
virtually impossible to pass a non-handle or a handle of different type
instead of the proper handle. Also turn cap_handle_t into an "untyped"
capability handle that can be assigned to and from the "typed" handles.

This commit also fixes a bug in msim-con driver, which wrongly used the
IRQ number instead of the IRQ capability handle to unregister the IRQ.

This commit also fixes the wrong use of the capability handle instead
of error code in libusbhost.

  • Property mode set to 100644
File size: 3.9 KB
Line 
1/*
2 * Copyright (c) 2012 Jakub Jermar
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 *
9 * - Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * - Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * - The name of the author may not be used to endorse or promote products
15 * derived from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
18 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
19 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
20 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
21 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
22 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29/** @addtogroup genericipc
30 * @{
31 */
32/** @file
33 */
34
35#include <ipc/sysipc_ops.h>
36#include <ipc/ipc.h>
37#include <ipc/ipcrsc.h>
38#include <synch/mutex.h>
39#include <proc/task.h>
40#include <abi/errno.h>
41#include <macros.h>
42
43static errno_t request_preprocess(call_t *call, phone_t *phone)
44{
45 task_t *other_task_s;
46
47 kobject_t *sender_obj = kobject_get(TASK,
48 (cap_handle_t) IPC_GET_ARG5(call->data), KOBJECT_TYPE_PHONE);
49 if (!sender_obj)
50 return ENOENT;
51
52 mutex_lock(&sender_obj->phone->lock);
53 if (sender_obj->phone->state != IPC_PHONE_CONNECTED) {
54 mutex_unlock(&sender_obj->phone->lock);
55 kobject_put(sender_obj);
56 return EINVAL;
57 }
58
59 other_task_s = sender_obj->phone->callee->task;
60
61 mutex_unlock(&sender_obj->phone->lock);
62
63 /* Remember the third party task hash. */
64 IPC_SET_ARG5(call->data, (sysarg_t) other_task_s);
65
66 kobject_put(sender_obj);
67 return EOK;
68}
69
70static errno_t answer_preprocess(call_t *answer, ipc_data_t *olddata)
71{
72 errno_t rc = EOK;
73
74 if (!IPC_GET_RETVAL(answer->data)) {
75 /* The recipient authorized the change of state. */
76 task_t *other_task_s;
77 task_t *other_task_r;
78
79 kobject_t *recipient_obj = kobject_get(TASK,
80 (cap_handle_t) IPC_GET_ARG1(answer->data),
81 KOBJECT_TYPE_PHONE);
82 if (!recipient_obj) {
83 IPC_SET_RETVAL(answer->data, ENOENT);
84 return ENOENT;
85 }
86
87 mutex_lock(&recipient_obj->phone->lock);
88 if (recipient_obj->phone->state != IPC_PHONE_CONNECTED) {
89 mutex_unlock(&recipient_obj->phone->lock);
90 IPC_SET_RETVAL(answer->data, EINVAL);
91 kobject_put(recipient_obj);
92 return EINVAL;
93 }
94
95 other_task_r = recipient_obj->phone->callee->task;
96 other_task_s = (task_t *) IPC_GET_ARG5(*olddata);
97
98 /*
99 * See if both the sender and the recipient meant the
100 * same third party task.
101 */
102 if (other_task_r != other_task_s) {
103 IPC_SET_RETVAL(answer->data, EINVAL);
104 rc = EINVAL;
105 } else {
106 rc = event_task_notify_5(other_task_r,
107 EVENT_TASK_STATE_CHANGE, false,
108 IPC_GET_ARG1(*olddata),
109 IPC_GET_ARG2(*olddata),
110 IPC_GET_ARG3(*olddata),
111 LOWER32(olddata->task_id),
112 UPPER32(olddata->task_id));
113 IPC_SET_RETVAL(answer->data, rc);
114 }
115
116 mutex_unlock(&recipient_obj->phone->lock);
117 kobject_put(recipient_obj);
118 }
119
120 return rc;
121}
122
123sysipc_ops_t ipc_m_state_change_authorize_ops = {
124 .request_preprocess = request_preprocess,
125 .request_forget = null_request_forget,
126 .request_process = null_request_process,
127 .answer_cleanup = null_answer_cleanup,
128 .answer_preprocess = answer_preprocess,
129 .answer_process = null_answer_process,
130};
131
132/** @}
133 */
Note: See TracBrowser for help on using the repository browser.