Changeset fdf55a3 in mainline for uspace/lib/ui/src/filelist.c

Timestamp:

2022-06-02T19:13:12Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

453f9645

Parents:

03fc3a9

Message:

Do not select/open last entry if user clicks below

This behavior, meticulously copied from NC, is not really meaningful,
especially considering other circumstances. We also did it for double
click / open, which is very confusing.

File:

• uspace/lib/ui/src/filelist.c (modified) (3 diffs)

uspace/lib/ui/src/filelist.c

@@ -934 +934 @@
 /** Find the n-th entry of the current file list page.
  *
- * If the page is short and has less than n+1 entries, return the last entry.
- *
  * @param flist File list
  * @param n Which entry to get (starting from 0)
@@ -945 +943 @@
 {
         ui_file_list_entry_t *entry;
-        ui_file_list_entry_t *next;
         size_t i;
         size_t idx;
@@ -957 +954 @@
         idx = flist->page_idx;
         for (i = 0; i < n; i++) {
-                next = ui_file_list_next(entry);
-                if (next == NULL)
-                        break;
-
-                entry = next;
+                entry = ui_file_list_next(entry);
+                if (entry == NULL)
+                        return NULL;
+
                 ++idx;
         }