Changeset fde02a6 in mainline

Timestamp:

2024-11-15T14:38:38Z (6 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

8f7e1b1

Parents:

da0570a

Message:

hr: be more careful with assembly from metadata

Rewrite vol→extents only after all metadata
was successfully read and validated.

File:

• uspace/srv/bd/hr/superblock.c (modified) (2 diffs)

uspace/srv/bd/hr/superblock.c

@@ -133 +133 @@
 
         service_id_t cfg_svc_id_order[HR_MAXDEVS] = { 0 };
-        for (size_t i = 0; i < vol->dev_no; i++) {
+        for (size_t i = 0; i < vol->dev_no; i++)
                 cfg_svc_id_order[i] = vol->extents[i].svc_id;
-                vol->extents[i].svc_id = 0;
-                vol->extents[i].status = HR_EXT_MISSING;
-        }
 
         int32_t md_order[HR_MAXDEVS] = { 0 };
@@ -155 +152 @@
 
         for (size_t i = 0; i < vol->dev_no; i++) {
+                vol->extents[i].svc_id = 0;
+                vol->extents[i].status = HR_EXT_MISSING;
+        }
+
+        /* sort */
+        for (size_t i = 0; i < vol->dev_no; i++) {
                 for (size_t j = 0; j < vol->dev_no; j++) {
                         if (i == (uint32_t) md_order[j]) {