Changes in uspace/drv/test1/test1.c [ebcb05a:fc51296] in mainline

File:

• uspace/drv/test1/test1.c (modified) (4 diffs)

uspace/drv/test1/test1.c

@@ -59 +59 @@
  */
 static int register_fun_verbose(ddf_dev_t *parent, const char *message,
-    const char *name, const char *match_id, int match_score,
-    int expected_rc)
+    const char *name, const char *match_id, int match_score)
 {
-        ddf_fun_t *fun = NULL;
+        ddf_fun_t *fun;
         int rc;
 
-        ddf_msg(LVL_DEBUG, "Registering function `%s': %s.", name, message);
+        ddf_msg(LVL_DEBUG, "Registering function `%s': %s.\n", name, message);
 
         fun = ddf_fun_create(parent, fun_inner, name);
         if (fun == NULL) {
-                ddf_msg(LVL_ERROR, "Failed creating function %s", name);
-                rc = ENOMEM;
-                goto leave;
+                ddf_msg(LVL_ERROR, "Failed creating function %s\n", name);
+                return ENOMEM;
         }
 
-        rc = ddf_fun_add_match_id(fun, str_dup(match_id), match_score);
+        rc = ddf_fun_add_match_id(fun, match_id, match_score);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match IDs to function %s",
+                ddf_msg(LVL_ERROR, "Failed adding match IDs to function %s\n",
                     name);
-                goto leave;
+                ddf_fun_destroy(fun);
+                return rc;
         }
 
         rc = ddf_fun_bind(fun);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed binding function %s: %s", name,
+                ddf_msg(LVL_ERROR, "Failed binding function %s: %s\n", name,
                     str_error(rc));
-                goto leave;
+                ddf_fun_destroy(fun);
+                return rc;
         }
 
-        ddf_msg(LVL_NOTE, "Registered child device `%s'", name);
-        rc = EOK;
-
-leave:
-        if (rc != expected_rc) {
-                fprintf(stderr,
-                    NAME ": Unexpected error registering function `%s'.\n" 
-                    NAME ":     Expected \"%s\" but got \"%s\".\n",
-                    name, str_error(expected_rc), str_error(rc));
-        }
-
-        if ((rc != EOK) && (fun != NULL)) {
-                ddf_fun_destroy(fun);
-        }
-
-        return rc;
+        ddf_msg(LVL_NOTE, "Registered child device `%s'\n", name);
+        return EOK;
 }
 
@@ -128 +114 @@
         int rc;
 
-        ddf_msg(LVL_DEBUG, "add_device(name=\"%s\", handle=%d)",
+        ddf_msg(LVL_DEBUG, "add_device(name=\"%s\", handle=%d)\n",
             dev->name, (int) dev->handle);
 
         fun_a = ddf_fun_create(dev, fun_exposed, "a");
         if (fun_a == NULL) {
-                ddf_msg(LVL_ERROR, "Failed creating function 'a'.");
+                ddf_msg(LVL_ERROR, "Failed creating function 'a'.\n");
                 return ENOMEM;
         }
@@ -139 +125 @@
         rc = ddf_fun_bind(fun_a);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed binding function 'a'.");
+                ddf_msg(LVL_ERROR, "Failed binding function 'a'.\n");
                 return rc;
         }
@@ -149 +135 @@
                 ddf_fun_add_to_class(fun_a, "virt-null");
         } else if (str_cmp(dev->name, "test1") == 0) {
-                (void) register_fun_verbose(dev,
-                    "cloning myself ;-)", "clone",
-                    "virtual&test1", 10, EOK);
-                (void) register_fun_verbose(dev,
-                    "cloning myself twice ;-)", "clone",
-                    "virtual&test1", 10, EEXISTS);
+                (void) register_fun_verbose(dev, "cloning myself ;-)", "clone",
+                    "virtual&test1", 10);
         } else if (str_cmp(dev->name, "clone") == 0) {
-                (void) register_fun_verbose(dev,
-                    "run by the same task", "child",
-                    "virtual&test1&child", 10, EOK);
+                (void) register_fun_verbose(dev, "run by the same task", "child",
+                    "virtual&test1&child", 10);
         }
 
-        ddf_msg(LVL_DEBUG, "Device `%s' accepted.", dev->name);
+        ddf_msg(LVL_DEBUG, "Device `%s' accepted.\n", dev->name);
 
         return EOK;