Changes in uspace/srv/net/tl/icmp/icmp.c [ffaba00:f1938c6] in mainline

File:

• uspace/srv/net/tl/icmp/icmp.c (modified) (7 diffs)

uspace/srv/net/tl/icmp/icmp.c

@@ -123 +123 @@
 static bool error_reporting = true;
 static bool echo_replying = true;
-static packet_dimension_t icmp_dimension;
 
 /** ICMP client identification counter */
 static atomic_t icmp_client;
-
-/** ICMP identifier and sequence number (client-specific) */
+static packet_dimension_t icmp_dimension;
+
+/** ICMP identifier and sequence number */
 static fibril_local icmp_param_t icmp_id;
 static fibril_local icmp_param_t icmp_seq;
@@ -142 +142 @@
          * are 16-bit values.
          */
-        hash_index_t index = ((key[0] & 0xffff) << 16) | (key[1] & 0xffff);
-        return (index % REPLY_BUCKETS);
+        hash_index_t index = (key[0] & 0xffff) << 16 | (key[1] & 0xffff);
+        return index % REPLY_BUCKETS;
 }
 
@@ -209 +209 @@
         header->type = type;
         header->code = code;
-        
-        /*
-         * The checksum needs to be calculated
-         * with a virtual checksum field set to
-         * zero.
-         */
         header->checksum = 0;
         header->checksum = ICMP_CHECKSUM(header,
@@ -287 +281 @@
  *         zero.
  * @return ENOMEM if there is not enough memory left.
+ * @return EPARTY if there was an internal error.
  *
  */
@@ -333 +328 @@
         }
         
-        bzero(header, sizeof(icmp_header_t));
+        bzero(header, sizeof(*header));
         header->un.echo.identifier = id;
         header->un.echo.sequence_number = sequence;
@@ -444 +439 @@
         unsigned long key[REPLY_KEYS] =
             {header->un.echo.identifier, header->un.echo.sequence_number};
-        
-        /* The packet is no longer needed */
         icmp_release(packet);
         
@@ -705 +698 @@
 /** Per-connection initialization
  *
- * Initialize client-specific global variables.
- *
  */
 void tl_connection(void)