Changeset ebcb05a in mainline for uspace/srv/devman/main.c

Timestamp:

2011-04-01T19:00:51Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

969585f, ea53529

Parents:

bdbb6f6

Message:

Logging functions should append newline automatically. Since one has no
choice but to end log message with a newline, there is no need to do it
manually in every invocation.

File:

• uspace/srv/devman/main.c (modified) (24 diffs)

uspace/srv/devman/main.c

@@ -73 +73 @@
         driver_t *driver = NULL;
 
-        log_msg(LVL_DEBUG, "devman_driver_register\n");
+        log_msg(LVL_DEBUG, "devman_driver_register");
         
         iid = async_get_call(&icall);
@@ -90 +90 @@
         }
 
-        log_msg(LVL_DEBUG, "The `%s' driver is trying to register.\n",
+        log_msg(LVL_DEBUG, "The `%s' driver is trying to register.",
             drv_name);
         
@@ -97 +97 @@
         
         if (driver == NULL) {
-                log_msg(LVL_ERROR, "No driver named `%s' was found.\n", drv_name);
+                log_msg(LVL_ERROR, "No driver named `%s' was found.", drv_name);
                 free(drv_name);
                 drv_name = NULL;
@@ -108 +108 @@
         
         /* Create connection to the driver. */
-        log_msg(LVL_DEBUG, "Creating connection to the `%s' driver.\n",
+        log_msg(LVL_DEBUG, "Creating connection to the `%s' driver.",
             driver->name);
         ipc_call_t call;
@@ -122 +122 @@
         
         log_msg(LVL_NOTE, 
-            "The `%s' driver was successfully registered as running.\n",
+            "The `%s' driver was successfully registered as running.",
             driver->name);
         
@@ -147 +147 @@
         if (DEVMAN_ADD_MATCH_ID != IPC_GET_IMETHOD(call)) {
                 log_msg(LVL_ERROR, 
-                    "Invalid protocol when trying to receive match id.\n");
+                    "Invalid protocol when trying to receive match id.");
                 async_answer_0(callid, EINVAL); 
                 delete_match_id(match_id);
@@ -154 +154 @@
         
         if (match_id == NULL) {
-                log_msg(LVL_ERROR, "Failed to allocate match id.\n");
+                log_msg(LVL_ERROR, "Failed to allocate match id.");
                 async_answer_0(callid, ENOMEM);
                 return ENOMEM;
@@ -168 +168 @@
         if (rc != EOK) {
                 delete_match_id(match_id);
-                log_msg(LVL_ERROR, "Failed to receive match id string: %s.\n",
+                log_msg(LVL_ERROR, "Failed to receive match id string: %s.",
                     str_error(rc));
                 return rc;
@@ -175 +175 @@
         list_append(&match_id->link, &match_ids->ids);
         
-        log_msg(LVL_DEBUG, "Received match id `%s', score %d.\n",
+        log_msg(LVL_DEBUG, "Received match id `%s', score %d.",
             match_id->id, match_id->score);
         return rc;
@@ -232 +232 @@
                 /* Unknown function type */
                 log_msg(LVL_ERROR, 
-                    "Unknown function type %d provided by driver.\n",
+                    "Unknown function type %d provided by driver.",
                     (int) ftype);
 
@@ -280 +280 @@
         fibril_rwlock_write_unlock(&tree->rwlock);
         
-        log_msg(LVL_DEBUG, "devman_add_function(fun=\"%s\")\n", fun->pathname);
+        log_msg(LVL_DEBUG, "devman_add_function(fun=\"%s\")", fun->pathname);
         
         devman_receive_match_ids(match_count, &fun->match_ids);
@@ -362 +362 @@
         devmap_register_class_dev(class_info);
         
-        log_msg(LVL_NOTE, "Function `%s' added to class `%s' as `%s'.\n",
+        log_msg(LVL_NOTE, "Function `%s' added to class `%s' as `%s'.",
             fun->pathname, class_name, class_info->dev_name);
 
@@ -378 +378 @@
         
         initialize_running_driver(driver, &device_tree);
-        log_msg(LVL_DEBUG, "The `%s` driver was successfully initialized.\n",
+        log_msg(LVL_DEBUG, "The `%s` driver was successfully initialized.",
             driver->name);
         return 0;
@@ -401 +401 @@
         if (fid == 0) {
                 log_msg(LVL_ERROR, "Failed to create initialization fibril " \
-                    "for driver `%s' .\n", driver->name);
+                    "for driver `%s'.", driver->name);
                 return;
         }
@@ -537 +537 @@
         if (dev == NULL) {
                 log_msg(LVL_ERROR, "IPC forwarding failed - no device or "
-                    "function with handle %" PRIun " was found.\n", handle);
+                    "function with handle %" PRIun " was found.", handle);
                 async_answer_0(iid, ENOENT);
                 return;
@@ -544 +544 @@
         if (fun == NULL && !drv_to_parent) {
                 log_msg(LVL_ERROR, NAME ": devman_forward error - cannot "
-                    "connect to handle %" PRIun ", refers to a device.\n",
+                    "connect to handle %" PRIun ", refers to a device.",
                     handle);
                 async_answer_0(iid, ENOENT);
@@ -567 +567 @@
         if (driver == NULL) {
                 log_msg(LVL_ERROR, "IPC forwarding refused - " \
-                    "the device %" PRIun " is not in usable state.\n", handle);
+                    "the device %" PRIun " is not in usable state.", handle);
                 async_answer_0(iid, ENOENT);
                 return;
@@ -580 +580 @@
         if (driver->phone <= 0) {
                 log_msg(LVL_ERROR, 
-                    "Could not forward to driver `%s' (phone is %d).\n",
+                    "Could not forward to driver `%s' (phone is %d).",
                     driver->name, (int) driver->phone);
                 async_answer_0(iid, EINVAL);
@@ -588 +588 @@
         if (fun != NULL) {
                 log_msg(LVL_DEBUG, 
-                    "Forwarding request for `%s' function to driver `%s'.\n",
+                    "Forwarding request for `%s' function to driver `%s'.",
                     fun->pathname, driver->name);
         } else {
                 log_msg(LVL_DEBUG, 
-                    "Forwarding request for `%s' device to driver `%s'.\n",
+                    "Forwarding request for `%s' device to driver `%s'.",
                     dev->pfun->pathname, driver->name);
         }
@@ -626 +626 @@
             IPC_FF_NONE);
         log_msg(LVL_DEBUG, 
-            "Forwarding devmapper request for `%s' function to driver `%s'.\n",
+            "Forwarding devmapper request for `%s' function to driver `%s'.",
             fun->pathname, dev->drv->name);
 }
@@ -662 +662 @@
 static bool devman_init(void)
 {
-        log_msg(LVL_DEBUG, "devman_init - looking for available drivers.\n");
+        log_msg(LVL_DEBUG, "devman_init - looking for available drivers.");
         
         /* Initialize list of available drivers. */
@@ -668 +668 @@
         if (lookup_available_drivers(&drivers_list,
             DRIVER_DEFAULT_STORE) == 0) {
-                log_msg(LVL_FATAL, "no drivers found.");
+                log_msg(LVL_FATAL, "No drivers found.");
                 return false;
         }
 
-        log_msg(LVL_DEBUG, "devman_init - list of drivers has been initialized.\n");
+        log_msg(LVL_DEBUG, "devman_init - list of drivers has been initialized.");
 
         /* Create root device node. */
@@ -703 +703 @@
 
         if (!devman_init()) {
-                log_msg(LVL_ERROR, "Error while initializing service.\n");
+                log_msg(LVL_ERROR, "Error while initializing service.");
                 return -1;
         }
@@ -712 +712 @@
         /* Register device manager at naming service. */
         if (service_register(SERVICE_DEVMAN) != EOK) {
-                log_msg(LVL_ERROR, "Failed registering as a service.\n");
+                log_msg(LVL_ERROR, "Failed registering as a service.");
                 return -1;
         }