Changeset eb13ef8 in mainline for uspace/srv/hid/input

Timestamp:

2019-02-06T13:25:12Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fafb8e5

Parents:

bb97118

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-02 14:04:02)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-06 13:25:12)

Message:

Change IPC_GET_* and IPC_SET_* to accept pointer instead of lvalue

Location:

uspace/srv/hid/input

Files:

• ctl/kbdev.c (modified) (2 diffs)
• input.c (modified) (3 diffs)
• proto/mousedev.c (modified) (2 diffs)

uspace/srv/hid/input/ctl/kbdev.c

@@ -160 +160 @@
                 async_get_call(&call);
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         async_answer_0(&call, EOK);
                         kbdev_destroy(kbdev);
@@ -166 +166 @@
                 }
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case KBDEV_EVENT:
                         /* Got event from keyboard device */
                         retval = 0;
-                        type = IPC_GET_ARG1(call);
-                        key = IPC_GET_ARG2(call);
+                        type = IPC_GET_ARG1(&call);
+                        key = IPC_GET_ARG2(&call);
                         kbd_push_event(kbdev->kbd_dev, type, key);
                         break;

uspace/srv/hid/input/input.c

@@ -334 +334 @@
                 async_get_call(&call);
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         if (client->sess != NULL) {
                                 async_hangup(client->sess);
@@ -353 +353 @@
                                 async_answer_0(&call, ELIMIT);
                 } else {
-                        switch (IPC_GET_IMETHOD(call)) {
+                        switch (IPC_GET_IMETHOD(&call)) {
                         case INPUT_ACTIVATE:
                                 active_client = client;
@@ -368 +368 @@
 static void kconsole_event_handler(ipc_call_t *call, void *arg)
 {
-        if (IPC_GET_ARG1(*call)) {
+        if (IPC_GET_ARG1(call)) {
                 /* Kernel console activated */
                 active = false;

uspace/srv/hid/input/proto/mousedev.c

@@ -79 +79 @@
                 async_get_call(&call);
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         async_answer_0(&call, EOK);
                         mousedev_destroy(mousedev);
@@ -87 +87 @@
                 errno_t retval;
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case MOUSEEV_MOVE_EVENT:
                         mouse_push_event_move(mousedev->mouse_dev,
-                            IPC_GET_ARG1(call), IPC_GET_ARG2(call),
-                            IPC_GET_ARG3(call));
+                            IPC_GET_ARG1(&call), IPC_GET_ARG2(&call),
+                            IPC_GET_ARG3(&call));
                         retval = EOK;
                         break;
                 case MOUSEEV_ABS_MOVE_EVENT:
                         mouse_push_event_abs_move(mousedev->mouse_dev,
-                            IPC_GET_ARG1(call), IPC_GET_ARG2(call),
-                            IPC_GET_ARG3(call), IPC_GET_ARG4(call));
+                            IPC_GET_ARG1(&call), IPC_GET_ARG2(&call),
+                            IPC_GET_ARG3(&call), IPC_GET_ARG4(&call));
                         retval = EOK;
                         break;
                 case MOUSEEV_BUTTON_EVENT:
                         mouse_push_event_button(mousedev->mouse_dev,
-                            IPC_GET_ARG1(call), IPC_GET_ARG2(call));
+                            IPC_GET_ARG1(&call), IPC_GET_ARG2(&call));
                         retval = EOK;
                         break;