Changes in uspace/app/getterm/getterm.c [df747bd8:dd567c6] in mainline

File:

• uspace/app/getterm/getterm.c (modified) (3 diffs)

uspace/app/getterm/getterm.c

@@ -40 +40 @@
 #include <stdio.h>
 #include <task.h>
+#include <str_error.h>
+#include <errno.h>
 #include "version.h"
+#include "welcome.h"
+
+#define APP_NAME  "getterm"
 
 static void usage(void)
 {
-        printf("Usage: getterm <terminal> <path>\n");
+        printf("Usage: %s <terminal> [-w] <command> [<arguments...>]\n", APP_NAME);
 }
 
@@ -69 +74 @@
 }
 
-static task_id_t spawn(char *fname)
-{
-        char *args[2];
-        
-        args[0] = fname;
-        args[1] = NULL;
-        
-        task_id_t id = task_spawn(fname, args);
-        
-        if (id == 0)
-                printf("Error spawning %s\n", fname);
-        
-        return id;
-}
-
 int main(int argc, char *argv[])
 {
-        if (argc < 3) {
+        int rc;
+        task_exit_t texit;
+        int retval;
+        task_id_t id;
+        char *fname, *term;
+        char **cmd_args;
+        bool print_wmsg;
+
+        argv++;
+        argc--;
+        if (argc < 1) {
                 usage();
                 return -1;
         }
+
+        if (str_cmp(*argv, "-w") == 0) {
+                print_wmsg = true;
+                argv++;
+                argc--;
+        } else {
+                print_wmsg = false;
+        }
+
+        if (argc < 2) {
+                usage();
+                return -1;
+        }
+
+        term = *argv++;
+        fname = *argv;
+        cmd_args = argv;
         
-        reopen(&stdin, 0, argv[1], O_RDONLY, "r");
-        reopen(&stdout, 1, argv[1], O_WRONLY, "w");
-        reopen(&stderr, 2, argv[1], O_WRONLY, "w");
+        reopen(&stdin, 0, term, O_RDONLY, "r");
+        reopen(&stdout, 1, term, O_WRONLY, "w");
+        reopen(&stderr, 2, term, O_WRONLY, "w");
         
         /*
@@ -110 +127 @@
                 return -4;
         
-        version_print(argv[1]);
-        task_id_t id = spawn(argv[2]);
-        
-        if (id != 0) {
-                task_exit_t texit;
-                int retval;
-                task_wait(id, &texit, &retval);
-                
-                return 0;
+        version_print(term);
+        if (print_wmsg)
+                welcome_msg_print();
+
+        rc = task_spawnv(&id, fname, (const char * const *) cmd_args);
+        if (rc != EOK) {
+                printf("%s: Error spawning %s (%s)\n", APP_NAME, fname,
+                    str_error(rc));
+                return -5;
         }
-        
-        return -5;
+
+        rc = task_wait(id, &texit, &retval);
+        if (rc != EOK) {
+                printf("%s: Error waiting for %s (%s)\n", APP_NAME, fname,
+                    str_error(rc));
+                return -6;
+        }
+
+        return 0;
 }