Changeset da1bafb in mainline for kernel/generic/src/syscall/syscall.c

Timestamp:

2010-05-24T18:57:31Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/src/syscall/syscall.c (modified) (3 diffs)

kernel/generic/src/syscall/syscall.c

@@ -59 +59 @@
     unative_t a4, unative_t a5, unative_t a6, unative_t id)
 {
-        unative_t rc;
-        ipl_t ipl;
-
         /* Do userpace accounting */
-        ipl = interrupts_disable();
-        spinlock_lock(&THREAD->lock);
+        irq_spinlock_lock(&THREAD->lock, true);
         thread_update_accounting(true);
-        spinlock_unlock(&THREAD->lock);
-        interrupts_restore(ipl);
-
+        irq_spinlock_unlock(&THREAD->lock, true);
+        
 #ifdef CONFIG_UDEBUG
         /*
          * Early check for undebugged tasks. We do not lock anything as this
          * test need not be precise in either direction.
+         *
          */
-        if (THREAD->udebug.active) {
+        if (THREAD->udebug.active)
                 udebug_syscall_event(a1, a2, a3, a4, a5, a6, id, 0, false);
-        }
 #endif
         
+        unative_t rc;
         if (id < SYSCALL_END) {
                 rc = syscall_table[id](a1, a2, a3, a4, a5, a6);
@@ -93 +89 @@
         if (THREAD->udebug.active) {
                 udebug_syscall_event(a1, a2, a3, a4, a5, a6, id, rc, true);
-        
+                
                 /*
                  * Stopping point needed for tasks that only invoke
@@ -103 +99 @@
         }
 #endif
-
+        
         /* Do kernel accounting */
-        (void) interrupts_disable();
-        spinlock_lock(&THREAD->lock);
+        irq_spinlock_lock(&THREAD->lock, true);
         thread_update_accounting(false);
-        spinlock_unlock(&THREAD->lock);
-        interrupts_restore(ipl);
+        irq_spinlock_unlock(&THREAD->lock, true);
         
         return rc;