Changeset da1bafb in mainline for kernel/generic/include/cpu.h

Timestamp:

2010-05-24T18:57:31Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/include/cpu.h (modified) (3 diffs)

kernel/generic/include/cpu.h

@@ -42 +42 @@
 #include <arch/context.h>
 
-#define CPU_STACK_SIZE  STACK_SIZE
+#define CPU_STACK_SIZE  STACK_SIZE
 
 /** CPU structure.
@@ -49 +49 @@
  */
 typedef struct cpu {
-        SPINLOCK_DECLARE(lock);
-
+        IRQ_SPINLOCK_DECLARE(lock);
+        
         tlb_shootdown_msg_t tlb_messages[TLB_MESSAGE_QUEUE_LEN];
         size_t tlb_messages_count;
         
         context_t saved_context;
-
+        
         atomic_t nrdy;
         runq_t rq[RQ_COUNT];
         volatile size_t needs_relink;
-
-        SPINLOCK_DECLARE(timeoutlock);
+        
+        IRQ_SPINLOCK_DECLARE(timeoutlock);
         link_t timeout_active_head;
-
-        size_t missed_clock_ticks;      /**< When system clock loses a tick, it is recorded here
-                                             so that clock() can react. This variable is
-                                             CPU-local and can be only accessed when interrupts
-                                             are disabled. */
-
+        
+        /**
+         * When system clock loses a tick, it is
+         * recorded here so that clock() can react.
+         * This variable is CPU-local and can be
+         * only accessed when interrupts are
+         * disabled.
+         */
+        size_t missed_clock_ticks;
+        
         bool idle;
         uint64_t idle_ticks;
         uint64_t busy_ticks;
-
+        
         /**
          * Processor ID assigned by kernel.
          */
-        unsigned int id;
+        size_t id;
         
         bool active;
-        int tlb_active;
-
+        bool tlb_active;
+        
         uint16_t frequency_mhz;
         uint32_t delay_loop_const;
-
+        
         cpu_arch_t arch;
-
+        
         struct thread *fpu_owner;
         
@@ -100 +104 @@
 extern void cpu_arch_init(void);
 extern void cpu_identify(void);
-extern void cpu_print_report(cpu_t *m);
+extern void cpu_print_report(cpu_t *);
 
 #endif