Changeset d946c27 in mainline

Timestamp:

2025-03-29T13:58:15Z (3 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

2e7df2e

Parents:

49de61c

Message:

hr: initialize and populate in memory metadata

Location:

uspace/srv/bd/hr

Files:

• superblock.c (modified) (1 diff)
• util.c (modified) (7 diffs)

uspace/srv/bd/hr/superblock.c

@@ -89 +89 @@
 
         }
+
+        memcpy(vol->in_mem_md, metadata, sizeof(hr_metadata_t));
 error:
         free(metadata);

uspace/srv/bd/hr/util.c

@@ -109 +109 @@
         }
 
+        vol->in_mem_md = calloc(1, sizeof(hr_metadata_t));
+        if (vol->in_mem_md == NULL) {
+                free(vol->fge);
+                rc = ENOMEM;
+                goto error;
+        }
+
         vol->status = HR_VOL_NONE;
 
@@ -813 +820 @@
         memcpy(vol->devname, main_md->devname, HR_DEVNAME_LEN);
 
+        memcpy(vol->in_mem_md, main_md, sizeof(hr_metadata_t));
+
         list_foreach(*list, link, struct svc_id_linked, iter) {
                 vol->extents[iter->md->index].svc_id = iter->svc_id;
@@ -840 +849 @@
          * XXX: register it here
          * ... if it fails on EEXIST try different name... like + 1 on the end
+         *
+         * or have metadata edit utility as a part of hrctl..., or create
+         * the original name + 4 random characters, tell the user that the device
+         * was created with this new name, and add a option to hrctl to rename
+         * an active array, and then write the new dirty metadata...
+         *
+         * or just refuse to assemble a name that is already used...
          *
          * TODO: discuss
@@ -893 +909 @@
                 iter = list_pop(&dev_id_list, struct svc_id_linked, link);
 
-                printf("svc_id: %lu\n", iter->svc_id);
-
                 void *metadata_block;
                 hr_metadata_t metadata;
@@ -907 +921 @@
 
                 if (!hr_valid_md_magic(&metadata)) {
-                        printf("BAD magic\n");
                         block_fini(iter->svc_id);
                         free_svc_id_linked(iter);
@@ -913 +926 @@
                 }
 
-                hr_metadata_dump(&metadata);
+                /* hr_metadata_dump(&metadata); */
 
                 char *svc_name = NULL;
@@ -944 +957 @@
                 list_foreach(matching_svcs_list, link, struct svc_id_linked,
                     iter2) {
-                        printf("matching svc_id: %lu\n", iter2->svc_id);
                         struct svc_id_linked *to_remove;
                         list_foreach_safe(dev_id_list, cur_link, next_link) {