Changeset d6fe2a1 in mainline

Timestamp:

2025-03-06T20:42:44Z (4 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

f1be66bf

Parents:

10005fd

Message:

hr: hr_mark_vol_state_dirty() helper

Location:

uspace/srv/bd/hr

Files:

• hr.c (modified) (1 diff)
• raid1.c (modified) (5 diffs)
• util.c (modified) (2 diffs)
• util.h (modified) (1 diff)

uspace/srv/bd/hr/hr.c

@@ -318 +318 @@
                 /* TODO: maybe expose extent state callbacks */
                 hr_update_ext_status(vol, fail_extent, HR_EXT_FAILED);
-                atomic_store(&vol->state_changed, true);
+                hr_mark_vol_state_dirty(vol);
 
                 fibril_rwlock_read_unlock(&vol->extents_lock);

uspace/srv/bd/hr/raid1.c

@@ -105 +105 @@
 
         /* force volume state update */
-        atomic_store(&new_volume->state_changed, true);
+        hr_mark_vol_state_dirty(new_volume);
         hr_raid1_update_vol_status(new_volume);
 
@@ -167 +167 @@
         hr_update_hotspare_status(vol, hs_idx, HR_EXT_HOTSPARE);
 
-        atomic_store(&vol->state_changed, true);
+        hr_mark_vol_state_dirty(vol);
 error:
         fibril_mutex_unlock(&vol->hotspare_lock);
@@ -291 +291 @@
         }
 
-        atomic_store(&vol->state_changed, true);
+        hr_mark_vol_state_dirty(vol);
 
         fibril_rwlock_write_unlock(&vol->states_lock);
@@ -542 +542 @@
          */
         hr_update_vol_status(vol, HR_VOL_ONLINE);
-        atomic_store(&vol->state_changed, true);
+        hr_mark_vol_state_dirty(vol);
 
         fibril_rwlock_write_unlock(&vol->states_lock);
@@ -562 +562 @@
                 fibril_rwlock_write_lock(&vol->states_lock);
                 hr_update_vol_status(vol, HR_VOL_DEGRADED);
-                atomic_store(&vol->state_changed, true);
+                hr_mark_vol_state_dirty(vol);
                 fibril_rwlock_write_unlock(&vol->states_lock);
         }

uspace/srv/bd/hr/util.c

@@ -41 +41 @@
 #include <io/log.h>
 #include <loc.h>
+#include <stdatomic.h>
 #include <stdlib.h>
 #include <stdio.h>
@@ -410 +411 @@
 }
 
+void hr_mark_vol_state_dirty(hr_volume_t *vol)
+{
+        atomic_store(&vol->state_changed, true);
+}
+
 /** @}
  */

uspace/srv/bd/hr/util.h

@@ -66 +66 @@
 extern hr_range_lock_t *hr_range_lock_acquire(hr_volume_t *, uint64_t,
     uint64_t);
-extern void hr_range_lock_release(hr_range_lock_t *rl);
+extern void hr_range_lock_release(hr_range_lock_t *);
+extern void hr_mark_vol_state_dirty(hr_volume_t *);
 
 #endif