Changeset d2765ab3 in mainline

Timestamp:

2012-08-19T13:45:54Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d758301

Parents:

ff396ea

Message:

sb16: Use format test function to validate input parameters.

File:

• uspace/drv/audio/sb16/dsp.c (modified) (2 diffs)

uspace/drv/audio/sb16/dsp.c

@@ -336 +336 @@
         ddf_log_debug("Requested playback: %u frames, %uHz, %s, %u channel(s).",
             frames, sampling_rate, pcm_sample_format_str(format), channels);
-        if (channels != 1 && channels != 2)
-                return ENOTSUP;
-        if (sampling_rate > DSP_RATE_LIMIT)
-                return ENOTSUP;
-        // FIXME We only support 16 bit playback
-        if (format != PCM_SAMPLE_UINT16_LE && format != PCM_SAMPLE_SINT16_LE)
+        if (sb_dsp_test_format(dsp, &channels, &sampling_rate, &format) != EOK)
                 return ENOTSUP;
 
@@ -408 +403 @@
         ddf_log_debug("Requested record: %u frames, %uHz, %s, %u channel(s).",
             frames, sampling_rate, pcm_sample_format_str(format), channels);
-        if (channels != 1 && channels != 2)
-                return ENOTSUP;
-        if (sampling_rate > DSP_RATE_LIMIT)
-                return ENOTSUP;
-        // FIXME We only support 16 bit recording
-        if (format != PCM_SAMPLE_UINT16_LE && format != PCM_SAMPLE_SINT16_LE)
+        if (sb_dsp_test_format(dsp, &channels, &sampling_rate, &format) != EOK)
                 return ENOTSUP;