Changeset d1582b50 in mainline for uspace/drv/bus/usb/ohci/ohci_rh.c

Timestamp:

2020-12-14T20:41:53Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

02fe42e

Parents:

1382446

git-author:

Jiri Svoboda <jiri@…> (2020-12-14 20:33:54)

git-committer:

Jiri Svoboda <jiri@…> (2020-12-14 20:41:53)

Message:

Fix spacing in single-line comments using latest ccheck

This found incorrectly formatted section comments (with blocks of
asterisks or dashes). I strongly believe against using section comments
but I am not simply removing them since that would probably be
controversial.

File:

• uspace/drv/bus/usb/ohci/ohci_rh.c (modified) (6 diffs)

uspace/drv/bus/usb/ohci/ohci_rh.c

@@ -87 +87 @@
         instance->hub_descriptor.header.max_current = 0;
 
-        /* Device Removable and some legacy 1.0 stuff*/
+        /* Device Removable and some legacy 1.0 stuff */
         instance->hub_descriptor.rempow[0] =
             (port_desc >> RHDB_DR_SHIFT) & 0xff;
@@ -139 +139 @@
         OHCI_CLR(regs->rh_desc_a, RHDA_PSM_FLAG);
 
-        /* Turn off power (hub driver will turn this back on)*/
+        /* Turn off power (hub driver will turn this back on) */
         OHCI_WR(regs->rh_status, RHS_CLEAR_GLOBAL_POWER);
 
@@ -348 +348 @@
         /* Enabled features to clear: see page 269 of USB specs */
         switch (feature) {
-        case USB_HUB_FEATURE_PORT_POWER:          /*8*/
+        case USB_HUB_FEATURE_PORT_POWER:          /* 8 */
                 rhda = OHCI_RD(hub->registers->rh_desc_a);
                 /* No power switching */
@@ -362 +362 @@
                     RHPS_CLEAR_PORT_POWER);
                 return EOK;
-        case USB2_HUB_FEATURE_PORT_ENABLE:         /*1*/
+        case USB2_HUB_FEATURE_PORT_ENABLE:         /* 1 */
                 OHCI_WR(hub->registers->rh_port_status[port],
                     RHPS_CLEAR_PORT_ENABLE);
                 return EOK;
 
-        case USB2_HUB_FEATURE_PORT_SUSPEND:        /*2*/
+        case USB2_HUB_FEATURE_PORT_SUSPEND:        /* 2 */
                 OHCI_WR(hub->registers->rh_port_status[port],
                     RHPS_CLEAR_PORT_SUSPEND);
                 return EOK;
 
-        case USB_HUB_FEATURE_C_PORT_CONNECTION:   /*16*/
-        case USB2_HUB_FEATURE_C_PORT_ENABLE:       /*17*/
-        case USB2_HUB_FEATURE_C_PORT_SUSPEND:      /*18*/
-        case USB_HUB_FEATURE_C_PORT_OVER_CURRENT: /*19*/
-        case USB_HUB_FEATURE_C_PORT_RESET:        /*20*/
+        case USB_HUB_FEATURE_C_PORT_CONNECTION:   /* 16 */
+        case USB2_HUB_FEATURE_C_PORT_ENABLE:       /* 17 */
+        case USB2_HUB_FEATURE_C_PORT_SUSPEND:      /* 18 */
+        case USB_HUB_FEATURE_C_PORT_OVER_CURRENT: /* 19 */
+        case USB_HUB_FEATURE_C_PORT_RESET:        /* 20 */
                 usb_log_debug2("Clearing port C_CONNECTION, C_ENABLE, "
                     "C_SUSPEND, C_OC or C_RESET on port %u.", port);
@@ -408 +408 @@
 
         switch (feature) {
-        case USB_HUB_FEATURE_PORT_POWER:   /*8*/
+        case USB_HUB_FEATURE_PORT_POWER:   /* 8 */
                 rhda = OHCI_RD(hub->registers->rh_desc_a);
 
@@ -422 +422 @@
                 /* Fall through, for per port power */
                 /* Fallthrough */
-        case USB2_HUB_FEATURE_PORT_ENABLE:  /*1*/
-        case USB2_HUB_FEATURE_PORT_SUSPEND: /*2*/
-        case USB_HUB_FEATURE_PORT_RESET:   /*4*/
+        case USB2_HUB_FEATURE_PORT_ENABLE:  /* 1 */
+        case USB2_HUB_FEATURE_PORT_SUSPEND: /* 2 */
+        case USB_HUB_FEATURE_PORT_RESET:   /* 4 */
                 usb_log_debug2("Setting port POWER, ENABLE, SUSPEND or RESET "
                     "on port %u.", port);