Changeset cdd6fc9 in mainline for uspace/lib/inet/src/iplink_srv.c

Timestamp:

2023-01-03T20:38:44Z (2 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3c54869

Parents:

df54aa8

Message:

Add missing replies in IPC error paths

File:

• uspace/lib/inet/src/iplink_srv.c (modified) (9 diffs)

uspace/lib/inet/src/iplink_srv.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2021 Jiri Svoboda
+ * Copyright (c) 2023 Jiri Svoboda
  * All rights reserved.
  *
@@ -74 +74 @@
 
         rc = async_data_read_finalize(&call, &mac, size);
-        if (rc != EOK)
-                async_answer_0(&call, rc);
+        if (rc != EOK) {
+                async_answer_0(&call, rc);
+                async_answer_0(icall, rc);
+                return;
+        }
 
         async_answer_0(icall, rc);
@@ -94 +97 @@
         rc = srv->ops->set_mac48(srv, &mac);
         if (rc != EOK) {
+                async_answer_0(&call, rc);
                 async_answer_0(icall, rc);
                 return;
@@ -99 +103 @@
 
         rc = async_data_read_finalize(&call, &mac, sizeof(eth_addr_t));
-        if (rc != EOK)
-                async_answer_0(&call, rc);
+        if (rc != EOK) {
+                async_answer_0(&call, rc);
+                async_answer_0(icall, rc);
+                return;
+        }
 
         async_answer_0(icall, rc);
@@ -109 +116 @@
         ipc_call_t call;
         size_t size;
+
         if (!async_data_write_receive(&call, &size)) {
                 async_answer_0(&call, EREFUSED);
@@ -126 +134 @@
                 async_answer_0(&call, rc);
                 async_answer_0(icall, rc);
+                return;
         }
 
@@ -136 +145 @@
         ipc_call_t call;
         size_t size;
+
         if (!async_data_write_receive(&call, &size)) {
                 async_answer_0(&call, EREFUSED);
@@ -153 +163 @@
                 async_answer_0(&call, rc);
                 async_answer_0(icall, rc);
+                return;
         }
 
@@ -181 +192 @@
 {
         iplink_sdu6_t sdu;
-
-        ipc_call_t call;
-        size_t size;
+        ipc_call_t call;
+        size_t size;
+
         if (!async_data_write_receive(&call, &size)) {
                 async_answer_0(&call, EREFUSED);