Changeset c9ebbe71 in mainline

Timestamp:

2010-11-14T11:50:58Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fb04cba8

Parents:

71e3289

Message:

Fix invalid aliasing in nettest (gcc 4.4.2 warning).

Location:

uspace/app

Files:

• nettest1/nettest1.c (modified) (3 diffs)
• nettest2/nettest2.c (modified) (3 diffs)

uspace/app/nettest1/nettest1.c

@@ -287 +287 @@
 int main(int argc, char *argv[])
 {
-
-        socklen_t max_length;
-        uint8_t *address_data[sizeof(struct sockaddr_in6)];
-        struct sockaddr_in *address_in;
-        struct sockaddr_in6 *address_in6;
+        struct sockaddr_in address_in;
+        struct sockaddr_in6 address_in6;
         uint8_t *address_start;
 
@@ -300 +297 @@
 
         int rc;
-
-        max_length = sizeof(address_data);
-        address = (struct sockaddr *) address_data;
-        address_in = (struct sockaddr_in *) address;
-        address_in6 = (struct sockaddr_in6 *) address;
 
         sockets = 10;
@@ -334 +326 @@
 
         /* Prepare the address buffer */
-        bzero(address_data, max_length);
 
         switch (family) {
         case PF_INET:
-                address_in->sin_family = AF_INET;
-                address_in->sin_port = htons(port);
-                address_start = (uint8_t *) &address_in->sin_addr.s_addr;
-                addrlen = sizeof(struct sockaddr_in);
+                address_in.sin_family = AF_INET;
+                address_in.sin_port = htons(port);
+                address = (struct sockaddr *) &address_in;
+                addrlen = sizeof(address_in);
+                address_start = (uint8_t *) &address_in.sin_addr.s_addr;
                 break;
         case PF_INET6:
-                address_in6->sin6_family = AF_INET6;
-                address_in6->sin6_port = htons(port);
-                address_start = (uint8_t *) &address_in6->sin6_addr.s6_addr;
-                addrlen = sizeof(struct sockaddr_in6);
+                address_in6.sin6_family = AF_INET6;
+                address_in6.sin6_port = htons(port);
+                address = (struct sockaddr *) &address_in6;
+                addrlen = sizeof(address_in6);
+                address_start = (uint8_t *) &address_in6.sin6_addr.s6_addr;
                 break;
         default:

uspace/app/nettest2/nettest2.c

@@ -223 +223 @@
 int main(int argc, char *argv[])
 {
-        socklen_t max_length;
-        uint8_t address_data[sizeof(struct sockaddr_in6)];
         struct sockaddr *address;
-        struct sockaddr_in *address_in;
-        struct sockaddr_in6 *address_in6;
+        struct sockaddr_in address_in;
+        struct sockaddr_in6 address_in6;
         socklen_t addrlen;
         uint8_t *address_start;
@@ -247 +245 @@
         port = 7;
 
-        max_length = sizeof(address_data);
-        address = (struct sockaddr *) address_data;
-        address_in = (struct sockaddr_in *) address;
-        address_in6 = (struct sockaddr_in6 *) address;
-
         /*
          * Parse the command line arguments.
@@ -279 +272 @@
 
         /* Prepare the address buffer */
-        bzero(address_data, max_length);
 
         switch (family) {
         case PF_INET:
-                address_in->sin_family = AF_INET;
-                address_in->sin_port = htons(port);
-                address_start = (uint8_t *) &address_in->sin_addr.s_addr;
-                addrlen = sizeof(struct sockaddr_in);
+                address_in.sin_family = AF_INET;
+                address_in.sin_port = htons(port);
+                address = (struct sockaddr *) &address_in;
+                addrlen = sizeof(address_in);
+                address_start = (uint8_t *) &address_in.sin_addr.s_addr;
                 break;
         case PF_INET6:
-                address_in6->sin6_family = AF_INET6;
-                address_in6->sin6_port = htons(port);
-                address_start = (uint8_t *) &address_in6->sin6_addr.s6_addr;
-                addrlen = sizeof(struct sockaddr_in6);
+                address_in6.sin6_family = AF_INET6;
+                address_in6.sin6_port = htons(port);
+                address = (struct sockaddr *) &address_in6;
+                addrlen = sizeof(address_in6);
+                address_start = (uint8_t *) &address_in6.sin6_addr.s6_addr;
                 break;
         default: