Changeset c657bd7 in mainline for uspace/drv/hid/xtkbd/xtkbd.c

Timestamp:

2017-11-20T10:06:59Z (8 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

19ea61d

Parents:

5d50c419

git-author:

Jiri Svoboda <jiri@…> (2017-11-19 22:05:26)

git-committer:

Jiri Svoboda <jiri@…> (2017-11-20 10:06:59)

Message:

Less is sometimes more. Need chardev_read to be able to return less bytes than requested if less is available. Otherwise cannot read variable-sized packets except yte-by-byte.

File:

• uspace/drv/hid/xtkbd/xtkbd.c (modified) (1 diff)

uspace/drv/hid/xtkbd/xtkbd.c

@@ -353 +353 @@
                 
                 size_t nwr;
-                int rc = chardev_write(kbd->chardev, cmds, sizeof(cmds), &nwr);
-                if (nwr != sizeof(cmds))
-                        rc = EIO;
-
+                int rc = chardev_write(kbd->chardev, &cmds[0], 1, &nwr);
+                if (rc != EOK) {
+                        async_answer_0(icallid, rc);
+                        break;
+                }
+
+                rc = chardev_write(kbd->chardev, &cmds[1], 1, &nwr);
                 async_answer_0(icallid, rc);
                 break;