Changeset be15256 in mainline for uspace/srv/hid/display/main.c

Timestamp:

2019-11-05T08:00:18Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b2d1df3

Parents:

b3c185b6

git-author:

Jiri Svoboda <jiri@…> (2019-10-04 19:00:15)

git-committer:

Jiri Svoboda <jiri@…> (2019-11-05 08:00:18)

Message:

ds_client should not have reverse dependency on libdisplay's display_srv

Breaks layering and hampers testability

File:

• uspace/srv/hid/display/main.c (modified) (3 diffs)

uspace/srv/hid/display/main.c

@@ -52 +52 @@
 
 static void display_client_conn(ipc_call_t *, void *);
+static void display_client_ev_pending(void *);
+
+static ds_client_cb_t display_client_cb = {
+        .ev_pending = display_client_ev_pending
+};
 
 static void display_kbd_event(void *arg, kbd_event_t *event)
@@ -59 +64 @@
         printf("display_kbd_event\n");
         ds_display_post_kbd_event(disp, event);
+}
+
+static void display_client_ev_pending(void *arg)
+{
+        display_srv_t *srv = (display_srv_t *) arg;
+        printf("display_client_ev_pending\n");
+        display_srv_ev_pending(srv);
 }
 
@@ -137 +149 @@
         if (svc_id != 0) {
                 /* Create client object */
-                rc = ds_client_create(disp, &srv, &client);
+                rc = ds_client_create(disp, &display_client_cb, &srv, &client);
                 if (rc != EOK) {
                         async_answer_0(icall, ENOMEM);