Changeset bdae198 in mainline for uspace/srv

Timestamp:

2013-08-04T12:01:10Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ea509069

Parents:

b08879c2 (diff), d856110 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes

Location:

uspace/srv/net

Files:

• dnsrsrv/dns_msg.c (modified) (3 diffs)
• dnsrsrv/dns_msg.h (modified) (2 diffs)
• dnsrsrv/dns_std.h (modified) (1 diff)
• dnsrsrv/dnsrsrv.c (modified) (2 diffs)
• dnsrsrv/query.c (modified) (4 diffs)
• dnsrsrv/query.h (modified) (1 diff)
• ethip/ethip.c (modified) (4 diffs)
• ethip/ethip.h (modified) (2 diffs)
• ethip/ethip_nic.c (modified) (13 diffs)
• ethip/pdu.c (modified) (1 diff)
• inetsrv/Makefile (modified) (1 diff)
• inetsrv/addrobj.c (modified) (3 diffs)
• inetsrv/icmp.c (modified) (1 diff)
• inetsrv/icmpv6.c (modified) (7 diffs)
• inetsrv/icmpv6_std.h (modified) (5 diffs)
• inetsrv/inet_link.c (modified) (7 diffs)
• inetsrv/inet_link.h (modified) (1 diff)
• inetsrv/inet_std.h (modified) (4 diffs)
• inetsrv/inetping6.c (modified) (2 diffs)
• inetsrv/inetsrv.c (modified) (2 diffs)
• inetsrv/inetsrv.h (modified) (2 diffs)
• inetsrv/ndp.c (added)
• inetsrv/ndp.h (added)
• inetsrv/ntrans.c (added)
• inetsrv/ntrans.h (added)
• inetsrv/pdu.c (modified) (9 diffs)
• inetsrv/pdu.h (modified) (2 diffs)
• inetsrv/reass.c (modified) (1 diff)
• loopip/loopip.c (modified) (7 diffs)
• slip/slip.c (modified) (5 diffs)
• tcp/conn.c (modified) (3 diffs)
• tcp/pdu.c (modified) (1 diff)
• tcp/sock.c (modified) (6 diffs)
• tcp/std.h (modified) (3 diffs)
• tcp/tcp.c (modified) (1 diff)
• tcp/tqueue.c (modified) (1 diff)
• tcp/ucall.c (modified) (1 diff)
• udp/assoc.c (modified) (1 diff)
• udp/pdu.c (modified) (1 diff)
• udp/sock.c (modified) (5 diffs)
• udp/std.h (modified) (3 diffs)

uspace/srv/net/dnsrsrv/dns_msg.c

@@ -296 +296 @@
 uint32_t dns_uint32_t_decode(uint8_t *buf, size_t buf_size)
 {
-        uint32_t w;
         assert(buf_size >= 4);
-
-        w = ((uint32_t) buf[0] << 24) +
+        
+        uint32_t w = ((uint32_t) buf[0] << 24) +
             ((uint32_t) buf[1] << 16) +
             ((uint32_t) buf[2] << 8) +
             buf[3];
-
+        
         return w;
+}
+
+/** Decode unaligned big-endian 128-bit integer */
+void dns_addr128_t_decode(uint8_t *buf, size_t buf_size, addr128_t addr)
+{
+        assert(buf_size >= 16);
+        
+        addr128_t_be2host(buf, addr);
 }
 
@@ -400 +407 @@
         int rc;
 
-        rr = calloc(1, sizeof (dns_rr_t));
+        rr = calloc(1, sizeof(dns_rr_t));
         if (rr == NULL)
                 return ENOMEM;
@@ -427 +434 @@
 
         rr->rtype = dns_uint16_t_decode(bp, bsz);
-        bp += sizeof(uint16_t); bsz -= sizeof(uint16_t);
+        bp += sizeof(uint16_t);
+        bsz -= sizeof(uint16_t);
 
         rr->rclass = dns_uint16_t_decode(bp, bsz);
-        bp += sizeof(uint16_t); bsz -= sizeof(uint16_t);
+        bp += sizeof(uint16_t);
+        bsz -= sizeof(uint16_t);
 
         rr->ttl = dns_uint32_t_decode(bp, bsz);
-        bp += sizeof(uint32_t); bsz -= sizeof(uint32_t);
+        bp += sizeof(uint32_t);
+        bsz -= sizeof(uint32_t);
 
         rdlength = dns_uint16_t_decode(bp, bsz);
-        bp += sizeof(uint16_t); bsz -= sizeof(uint16_t);
+        bp += sizeof(uint16_t);
+        bsz -= sizeof(uint16_t);
 
         if (rdlength > bsz) {

uspace/srv/net/dnsrsrv/dns_msg.h

@@ -40 +40 @@
 #include <stdbool.h>
 #include <stdint.h>
+#include <inet/addr.h>
 #include "dns_std.h"
 #include "dns_type.h"
@@ -49 +50 @@
 extern int dns_name_decode(dns_pdu_t *, size_t, char **, size_t *);
 extern uint32_t dns_uint32_t_decode(uint8_t *, size_t);
+extern void dns_addr128_t_decode(uint8_t *, size_t, addr128_t);
 
 #endif

uspace/srv/net/dnsrsrv/dns_std.h

@@ -65 +65 @@
         DTYPE_MX        = 15,
         DTYPE_TXT       = 16,
+        DTYPE_AAAA      = 28,
         DQTYPE_AXFR     = 252,
         DQTYPE_MAILB    = 253,

uspace/srv/net/dnsrsrv/dnsrsrv.c

@@ -89 +89 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_get_srvaddr_srv()");
         
+        uint16_t af = IPC_GET_ARG1(*icall);
+        
         char *name;
         int rc = async_data_write_accept((void **) &name, true, 0,
@@ -98 +100 @@
         
         dns_host_info_t *hinfo;
-        rc = dns_name2host(name, &hinfo);
+        rc = dns_name2host(name, &hinfo, af);
         if (rc != EOK) {
                 async_answer_0(iid, rc);

uspace/srv/net/dnsrsrv/query.c

@@ -39 +39 @@
 #include <stdlib.h>
 #include <str.h>
-
+#include <net/socket_codes.h>
 #include "dns_msg.h"
 #include "dns_std.h"
@@ -48 +48 @@
 static uint16_t msg_id;
 
-int dns_name2host(const char *name, dns_host_info_t **rinfo)
+static int dns_name_query(const char *name, dns_qtype_t qtype,
+    dns_host_info_t *info)
 {
-        dns_message_t *msg;
-        dns_message_t *amsg;
-        dns_question_t *question;
-        dns_host_info_t *info;
-        char *sname, *cname;
-        size_t eoff;
-        int rc;
-
-        question = calloc(1, sizeof(dns_question_t));
-        if (question == NULL)
-                return ENOMEM;
-
-        question->qname = (char *)name;
-        question->qtype = DTYPE_A;
+        /* Start with the caller-provided name */
+        char *sname = str_dup(name);
+        if (sname == NULL)
+                return ENOMEM;
+        
+        char *qname = str_dup(name);
+        if (qname == NULL) {
+                free(sname);
+                return ENOMEM;
+        }
+        
+        dns_question_t *question = calloc(1, sizeof(dns_question_t));
+        if (question == NULL) {
+                free(qname);
+                free(sname);
+                return ENOMEM;
+        }
+        
+        question->qname = qname;
+        question->qtype = qtype;
         question->qclass = DC_IN;
-
-        msg = dns_message_new();
-        if (msg == NULL)
-                return ENOMEM;
-
-        list_append(&question->msg, &msg->question);
-
+        
+        dns_message_t *msg = dns_message_new();
+        if (msg == NULL) {
+                free(question);
+                free(qname);
+                free(sname);
+                return ENOMEM;
+        }
+        
         msg->id = msg_id++;
         msg->qr = QR_QUERY;
@@ -79 +88 @@
         msg->rd = true;
         msg->ra = false;
-
-        rc = dns_request(msg, &amsg);
+        
+        list_append(&question->msg, &msg->question);
+        
+        dns_message_t *amsg;
+        int rc = dns_request(msg, &amsg);
         if (rc != EOK) {
+                dns_message_destroy(msg);
+                free(sname);
                 return rc;
         }
-
-        /* Start with the caller-provided name */
-        sname = str_dup(name);
-
+        
         list_foreach(amsg->answer, link) {
                 dns_rr_t *rr = list_get_instance(link, dns_rr_t, msg);
-
+                
                 log_msg(LOG_DEFAULT, LVL_DEBUG, " - '%s' %u/%u, dsize %zu",
-                        rr->name, rr->rtype, rr->rclass, rr->rdata_size);
-
-                if (rr->rtype == DTYPE_CNAME && rr->rclass == DC_IN &&
-                    str_cmp(rr->name, sname) == 0) {
+                    rr->name, rr->rtype, rr->rclass, rr->rdata_size);
+                
+                if ((rr->rtype == DTYPE_CNAME) && (rr->rclass == DC_IN) &&
+                    (str_cmp(rr->name, sname) == 0)) {
+                        
                         log_msg(LOG_DEFAULT, LVL_DEBUG, "decode cname (%p, %zu, %zu)",
                             amsg->pdu.data, amsg->pdu.size, rr->roff);
+                        
+                        char *cname;
+                        size_t eoff;
                         rc = dns_name_decode(&amsg->pdu, rr->roff, &cname, &eoff);
                         if (rc != EOK) {
-                                log_msg(LOG_DEFAULT, LVL_DEBUG,
-                                    "error decoding cname");
-                                assert(rc == EINVAL || rc == ENOMEM);
+                                assert((rc == EINVAL) || (rc == ENOMEM));
+                                
+                                log_msg(LOG_DEFAULT, LVL_DEBUG, "error decoding cname");
+                                
                                 dns_message_destroy(msg);
                                 dns_message_destroy(amsg);
+                                free(sname);
+                                
                                 return rc;
                         }
-
+                        
                         log_msg(LOG_DEFAULT, LVL_DEBUG, "name = '%s' "
                             "cname = '%s'", sname, cname);
-
+                        
+                        /* Continue looking for the more canonical name */
                         free(sname);
-                        /* Continue looking for the more canonical name */
                         sname = cname;
                 }
-
-                if (rr->rtype == DTYPE_A && rr->rclass == DC_IN &&
-                        rr->rdata_size == sizeof(uint32_t) &&
-                            str_cmp(rr->name, sname) == 0) {
-
-                        info = calloc(1, sizeof(dns_host_info_t));
-                        if (info == NULL) {
+                
+                if ((qtype == DTYPE_A) && (rr->rtype == DTYPE_A) &&
+                    (rr->rclass == DC_IN) && (rr->rdata_size == sizeof(addr32_t)) &&
+                    (str_cmp(rr->name, sname) == 0)) {
+                        
+                        info->cname = str_dup(rr->name);
+                        if (info->cname == NULL) {
                                 dns_message_destroy(msg);
                                 dns_message_destroy(amsg);
+                                free(sname);
+                                
                                 return ENOMEM;
                         }
-
-                        info->cname = str_dup(rr->name);
+                        
                         inet_addr_set(dns_uint32_t_decode(rr->rdata, rr->rdata_size),
                             &info->addr);
@@ -133 +152 @@
                         dns_message_destroy(msg);
                         dns_message_destroy(amsg);
-                        *rinfo = info;
+                        free(sname);
+                        
                         return EOK;
                 }
-        }
-
+                
+                if ((qtype == DTYPE_AAAA) && (rr->rtype == DTYPE_AAAA) &&
+                    (rr->rclass == DC_IN) && (rr->rdata_size == sizeof(addr128_t)) &&
+                    (str_cmp(rr->name, sname) == 0)) {
+                
+                        info->cname = str_dup(rr->name);
+                        if (info->cname == NULL) {
+                                dns_message_destroy(msg);
+                                dns_message_destroy(amsg);
+                                free(sname);
+                                
+                                return ENOMEM;
+                        }
+                        
+                        addr128_t addr;
+                        dns_addr128_t_decode(rr->rdata, rr->rdata_size, addr);
+                        
+                        inet_addr_set6(addr, &info->addr);
+                        
+                        dns_message_destroy(msg);
+                        dns_message_destroy(amsg);
+                        free(sname);
+                        
+                        return EOK;
+                }
+        }
+        
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "'%s' not resolved, fail", sname);
+        
         dns_message_destroy(msg);
         dns_message_destroy(amsg);
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "'%s' not resolved, fail", sname);
-
+        free(sname);
+        
         return EIO;
+}
+
+int dns_name2host(const char *name, dns_host_info_t **rinfo, uint16_t af)
+{
+        dns_host_info_t *info = calloc(1, sizeof(dns_host_info_t));
+        if (info == NULL)
+                return ENOMEM;
+        
+        int rc;
+        
+        switch (af) {
+        case AF_NONE:
+                rc = dns_name_query(name, DTYPE_AAAA, info);
+                
+                if (rc != EOK)
+                        rc = dns_name_query(name, DTYPE_A, info);
+                
+                break;
+        case AF_INET:
+                rc = dns_name_query(name, DTYPE_A, info);
+                break;
+        case AF_INET6:
+                rc = dns_name_query(name, DTYPE_AAAA, info);
+                break;
+        default:
+                rc = EINVAL;
+        }
+        
+        if (rc == EOK)
+                *rinfo = info;
+        else
+                free(info);
+        
+        return rc;
 }
 

uspace/srv/net/dnsrsrv/query.h

@@ -39 +39 @@
 #include "dns_type.h"
 
-extern int dns_name2host(const char *, dns_host_info_t **);
+extern int dns_name2host(const char *, dns_host_info_t **, uint16_t);
 extern void dns_hostinfo_destroy(dns_host_info_t *);
 

uspace/srv/net/ethip/ethip.c

@@ -56 +56 @@
 static int ethip_close(iplink_srv_t *srv);
 static int ethip_send(iplink_srv_t *srv, iplink_sdu_t *sdu);
+static int ethip_send6(iplink_srv_t *srv, iplink_sdu6_t *sdu);
 static int ethip_get_mtu(iplink_srv_t *srv, size_t *mtu);
+static int ethip_get_mac48(iplink_srv_t *srv, addr48_t *mac);
 static int ethip_addr_add(iplink_srv_t *srv, inet_addr_t *addr);
 static int ethip_addr_remove(iplink_srv_t *srv, inet_addr_t *addr);
@@ -66 +68 @@
         .close = ethip_close,
         .send = ethip_send,
+        .send6 = ethip_send6,
         .get_mtu = ethip_get_mtu,
+        .get_mac48 = ethip_get_mac48,
         .addr_add = ethip_addr_add,
         .addr_remove = ethip_addr_remove
@@ -169 +173 @@
         
         ethip_nic_t *nic = (ethip_nic_t *) srv->arg;
-        
-        addr32_t src_v4;
-        addr128_t src_v6;
-        uint16_t src_af = inet_addr_get(&sdu->src, &src_v4, &src_v6);
-        
-        addr32_t dest_v4;
-        addr128_t dest_v6;
-        uint16_t dest_af = inet_addr_get(&sdu->dest, &dest_v4, &dest_v6);
-        
-        if (src_af != dest_af)
-                return EINVAL;
-        
-        int rc;
         eth_frame_t frame;
         
-        switch (src_af) {
-        case AF_INET:
-                rc = arp_translate(nic, src_v4, dest_v4, frame.dest);
-                if (rc != EOK) {
-                        log_msg(LOG_DEFAULT, LVL_WARN, "Failed to look up IPv4 address 0x%"
-                            PRIx32, dest_v4);
-                        return rc;
-                }
-                
-                addr48(nic->mac_addr, frame.src);
-                frame.etype_len = ETYPE_IP;
-                frame.data = sdu->data;
-                frame.size = sdu->size;
-                
-                break;
-        case AF_INET6:
-                // FIXME TODO
-                return ENOTSUP;
-        default:
-                return EINVAL;
-        }
+        int rc = arp_translate(nic, sdu->src, sdu->dest, frame.dest);
+        if (rc != EOK) {
+                log_msg(LOG_DEFAULT, LVL_WARN, "Failed to look up IPv4 address 0x%"
+                    PRIx32, sdu->dest);
+                return rc;
+        }
+        
+        addr48(nic->mac_addr, frame.src);
+        frame.etype_len = ETYPE_IP;
+        frame.data = sdu->data;
+        frame.size = sdu->size;
         
         void *data;
         size_t size;
         rc = eth_pdu_encode(&frame, &data, &size);
+        if (rc != EOK)
+                return rc;
+        
+        rc = ethip_nic_send(nic, data, size);
+        free(data);
+        
+        return rc;
+}
+
+static int ethip_send6(iplink_srv_t *srv, iplink_sdu6_t *sdu)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_send6()");
+        
+        ethip_nic_t *nic = (ethip_nic_t *) srv->arg;
+        eth_frame_t frame;
+        
+        addr48(sdu->dest, frame.dest);
+        addr48(nic->mac_addr, frame.src);
+        frame.etype_len = ETYPE_IPV6;
+        frame.data = sdu->data;
+        frame.size = sdu->size;
+        
+        void *data;
+        size_t size;
+        int rc = eth_pdu_encode(&frame, &data, &size);
         if (rc != EOK)
                 return rc;
@@ -268 +274 @@
 }
 
+static int ethip_get_mac48(iplink_srv_t *srv, addr48_t *mac)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_get_mac48()");
+        
+        ethip_nic_t *nic = (ethip_nic_t *) srv->arg;
+        addr48(nic->mac_addr, *mac);
+        
+        return EOK;
+}
+
 static int ethip_addr_add(iplink_srv_t *srv, inet_addr_t *addr)
 {

uspace/srv/net/ethip/ethip.h

@@ -46 +46 @@
 
 typedef struct {
-        link_t addr_list;
+        link_t link;
         inet_addr_t addr;
 } ethip_link_addr_t;
 
 typedef struct ethip_nic {
-        link_t nic_list;
+        link_t link;
         service_id_t svc_id;
         char *svc_name;
@@ -61 +61 @@
         /** MAC address */
         addr48_t mac_addr;
-        /** List of IP addresses configured on this link */
-        list_t addr_list; /* of ethip_link_addr_t */
+        
+        /**
+         * List of IP addresses configured on this link
+         * (of the type ethip_link_addr_t)
+         */
+        list_t addr_list;
 } ethip_nic_t;
 

uspace/srv/net/ethip/ethip_nic.c

@@ -45 +45 @@
 #include <device/nic.h>
 #include <stdlib.h>
-
+#include <net/socket_codes.h>
+#include <mem.h>
 #include "ethip.h"
 #include "ethip_nic.h"
@@ -83 +84 @@
                 already_known = false;
 
-                list_foreach(ethip_nic_list, nic_link) {
-                        ethip_nic_t *nic = list_get_instance(nic_link,
-                            ethip_nic_t, nic_list);
+                list_foreach(ethip_nic_list, link) {
+                        ethip_nic_t *nic = list_get_instance(link,
+                            ethip_nic_t, link);
                         if (nic->svc_id == svcs[i]) {
                                 already_known = true;
@@ -108 +109 @@
 {
         ethip_nic_t *nic = calloc(1, sizeof(ethip_nic_t));
-
         if (nic == NULL) {
                 log_msg(LOG_DEFAULT, LVL_ERROR, "Failed allocating NIC structure. "
@@ -114 +114 @@
                 return NULL;
         }
-
-        link_initialize(&nic->nic_list);
+        
+        link_initialize(&nic->link);
         list_initialize(&nic->addr_list);
-
+        
         return nic;
 }
@@ -130 +130 @@
         }
         
-        link_initialize(&laddr->addr_list);
+        link_initialize(&laddr->link);
         laddr->addr = *addr;
         
@@ -140 +140 @@
         if (nic->svc_name != NULL)
                 free(nic->svc_name);
+        
         free(nic);
 }
@@ -180 +181 @@
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "Opened NIC '%s'", nic->svc_name);
-        list_append(&nic->nic_list, &ethip_nic_list);
+        list_append(&nic->link, &ethip_nic_list);
         in_list = true;
 
@@ -209 +210 @@
 error:
         if (in_list)
-                list_remove(&nic->nic_list);
+                list_remove(&nic->link);
+        
         if (nic->sess != NULL)
                 async_hangup(nic->sess);
+        
         ethip_nic_delete(nic);
         return rc;
@@ -312 +315 @@
         list_foreach(ethip_nic_list, link) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_nic_find_by_iplink_sid - element");
-                ethip_nic_t *nic = list_get_instance(link, ethip_nic_t,
-                    nic_list);
+                ethip_nic_t *nic = list_get_instance(link, ethip_nic_t, link);
 
                 if (nic->iplink_sid == iplink_sid) {
@@ -334 +336 @@
 }
 
+/** Setup accepted multicast addresses
+ *
+ * Currently the set of accepted multicast addresses is
+ * determined only based on IPv6 addresses.
+ *
+ */
+static int ethip_nic_setup_multicast(ethip_nic_t *nic)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_nic_setup_multicast()");
+        
+        /* Count the number of multicast addresses */
+        
+        size_t count = 0;
+        
+        list_foreach(nic->addr_list, link) {
+                ethip_link_addr_t *laddr = list_get_instance(link,
+                    ethip_link_addr_t, link);
+                
+                uint16_t af = inet_addr_get(&laddr->addr, NULL, NULL);
+                if (af == AF_INET6)
+                        count++;
+        }
+        
+        if (count == 0)
+                return nic_multicast_set_mode(nic->sess, NIC_MULTICAST_BLOCKED,
+                    NULL, 0);
+        
+        nic_address_t *mac_list = calloc(count, sizeof(nic_address_t));
+        if (mac_list == NULL)
+                return ENOMEM;
+        
+        /* Create the multicast MAC list */
+        
+        size_t i = 0;
+        
+        list_foreach(nic->addr_list, link) {
+                assert(i < count);
+                
+                ethip_link_addr_t *laddr = list_get_instance(link,
+                    ethip_link_addr_t, link);
+                
+                addr128_t v6;
+                uint16_t af = inet_addr_get(&laddr->addr, NULL, &v6);
+                if (af != AF_INET6)
+                        continue;
+                
+                addr48_t mac;
+                addr48_solicited_node(v6, mac);
+                
+                /* Avoid duplicate addresses in the list */
+                
+                bool found = false;
+                
+                for (size_t j = 0; j < i; j++) {
+                        if (addr48_compare(mac_list[j].address, mac)) {
+                                found = true;
+                                break;
+                        }
+                }
+                
+                if (!found) {
+                        addr48(mac, mac_list[i].address);
+                        i++;
+                } else
+                        count--;
+        }
+        
+        /* Setup the multicast MAC list */
+        
+        int rc = nic_multicast_set_mode(nic->sess, NIC_MULTICAST_LIST,
+            mac_list, count);
+        
+        free(mac_list);
+        return rc;
+}
+
 int ethip_nic_addr_add(ethip_nic_t *nic, inet_addr_t *addr)
 {
@@ -342 +420 @@
                 return ENOMEM;
         
-        list_append(&laddr->addr_list, &nic->addr_list);
-        return EOK;
+        list_append(&laddr->link, &nic->addr_list);
+        
+        return ethip_nic_setup_multicast(nic);
 }
 
@@ -354 +433 @@
                 return ENOENT;
         
-        list_remove(&laddr->addr_list);
+        list_remove(&laddr->link);
         ethip_link_addr_delete(laddr);
-        return EOK;
+        
+        return ethip_nic_setup_multicast(nic);
 }
 
@@ -366 +446 @@
         list_foreach(nic->addr_list, link) {
                 ethip_link_addr_t *laddr = list_get_instance(link,
-                    ethip_link_addr_t, addr_list);
+                    ethip_link_addr_t, link);
                 
                 if (inet_addr_compare(addr, &laddr->addr))

uspace/srv/net/ethip/pdu.c

@@ -46 +46 @@
 #include "pdu.h"
 
-#define MAC48_BYTES 6
-
 /** Encode Ethernet PDU. */
 int eth_pdu_encode(eth_frame_t *frame, void **rdata, size_t *rsize)

uspace/srv/net/inetsrv/Makefile

@@ -39 +39 @@
         inetping.c \
         inetping6.c \
+        ndp.c \
+        ntrans.c \
         pdu.c \
         reass.c \

uspace/srv/net/inetsrv/addrobj.c

@@ -42 +42 @@
 #include <stdlib.h>
 #include <str.h>
+#include <net/socket_codes.h>
 #include "addrobj.h"
 #include "inetsrv.h"
 #include "inet_link.h"
+#include "ndp.h"
 
 static inet_addrobj_t *inet_addrobj_find_by_name_locked(const char *, inet_link_t *);
@@ -117 +119 @@
                     inet_addrobj_t, addr_list);
                 
-                if (inet_naddr_compare_mask(&naddr->naddr, addr)) {
-                        fibril_mutex_unlock(&addr_list_lock);
-                        log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_addrobj_find: found %p",
-                            naddr);
-                        return naddr;
+                switch (find) {
+                case iaf_net:
+                        if (inet_naddr_compare_mask(&naddr->naddr, addr)) {
+                                fibril_mutex_unlock(&addr_list_lock);
+                                log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_addrobj_find: found %p",
+                                    naddr);
+                                return naddr;
+                        }
+                        break;
+                case iaf_addr:
+                        if (inet_naddr_compare(&naddr->naddr, addr)) {
+                                fibril_mutex_unlock(&addr_list_lock);
+                                log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_addrobj_find: found %p",
+                                    naddr);
+                                return naddr;
+                        }
+                        break;
                 }
         }
@@ -214 +228 @@
         inet_naddr_addr(&addr->naddr, &lsrc_addr);
         
-        return inet_link_send_dgram(addr->ilink, &lsrc_addr, ldest, dgram,
-            proto, ttl, df);
+        addr32_t lsrc_v4;
+        addr128_t lsrc_v6;
+        uint16_t lsrc_af = inet_addr_get(&lsrc_addr, &lsrc_v4, &lsrc_v6);
+        
+        addr32_t ldest_v4;
+        addr128_t ldest_v6;
+        uint16_t ldest_af = inet_addr_get(ldest, &ldest_v4, &ldest_v6);
+        
+        if (lsrc_af != ldest_af)
+                return EINVAL;
+        
+        int rc;
+        addr48_t ldest_mac;
+        
+        switch (ldest_af) {
+        case AF_INET:
+                return inet_link_send_dgram(addr->ilink, lsrc_v4, ldest_v4,
+                    dgram, proto, ttl, df);
+        case AF_INET6:
+                /*
+                 * Translate local destination IPv6 address.
+                 */
+                rc = ndp_translate(lsrc_v6, ldest_v6, ldest_mac, addr->ilink);
+                if (rc != EOK)
+                        return rc;
+                
+                return inet_link_send_dgram6(addr->ilink, ldest_mac, dgram,
+                    proto, ttl, df);
+        }
+        
+        return ENOTSUP;
 }
 

uspace/srv/net/inetsrv/icmp.c

@@ -153 +153 @@
                 return ENOMEM;
         
-        icmp_echo_t *request = (icmp_echo_t *)rdata;
+        icmp_echo_t *request = (icmp_echo_t *) rdata;
         
         request->type = ICMP_ECHO_REQUEST;

uspace/srv/net/inetsrv/icmpv6.c

@@ -47 +47 @@
 #include "pdu.h"
 
-static int ndp_received(inet_dgram_t *dgram)
-{
-        // FIXME TODO
-        return ENOTSUP;
-}
-
 static int icmpv6_recv_echo_request(inet_dgram_t *dgram)
 {
@@ -84 +78 @@
         inet_dgram_t rdgram;
         
-        rdgram.src = dgram->dest;
+        inet_get_srcaddr(&dgram->src, 0, &rdgram.src);
         rdgram.dest = dgram->src;
         rdgram.tos = 0;
@@ -90 +84 @@
         rdgram.size = size;
         
-        icmpv6_pseudo_header phdr;
+        icmpv6_phdr_t phdr;
         
         host2addr128_t_be(dest_v6, phdr.src_addr);
@@ -100 +94 @@
         uint16_t cs_phdr =
             inet_checksum_calc(INET_CHECKSUM_INIT, &phdr,
-            sizeof(icmpv6_pseudo_header));
+            sizeof(icmpv6_phdr_t));
         
         uint16_t cs_all = inet_checksum_calc(cs_phdr, reply, size);
@@ -156 +150 @@
         case ICMPV6_NEIGHBOUR_SOLICITATION:
         case ICMPV6_NEIGHBOUR_ADVERTISEMENT:
-#ifdef ACCEPT_RA
         case ICMPV6_ROUTER_ADVERTISEMENT:
-#endif
                 return ndp_received(dgram);
         default:
@@ -192 +184 @@
         dgram.size = rsize;
         
-        icmpv6_pseudo_header phdr;
+        icmpv6_phdr_t phdr;
         
         host2addr128_t_be(sdu->src, phdr.src_addr);
@@ -202 +194 @@
         uint16_t cs_phdr =
             inet_checksum_calc(INET_CHECKSUM_INIT, &phdr,
-            sizeof(icmpv6_pseudo_header));
+            sizeof(icmpv6_phdr_t));
         
         uint16_t cs_all = inet_checksum_calc(cs_phdr, rdata, rsize);

uspace/srv/net/inetsrv/icmpv6_std.h

@@ -47 +47 @@
 #define INET6_HOP_LIMIT_MAX  255
 
+#define NDP_FLAG_ROUTER     0x80
+#define NDP_FLAG_OVERRIDE   0x40
+#define NDP_FLAG_SOLICITED  0x20
+
 /** ICMPv6 message type */
 enum icmpv6_type {
@@ -83 +87 @@
                         uint8_t flags;
                         /** Reserved bytes */
-                        uint8_t reserved [3];
+                        uint8_t reserved[3];
                 } ndp;
         } un;
@@ -91 +95 @@
 typedef struct {
         /** Source IPv6 address */
-        uint8_t src_addr [16];
+        uint8_t src_addr[16];
         /** Target IPv6 address */
-        uint8_t dest_addr [16];
+        uint8_t dest_addr[16];
         /** ICMPv6 length */
         uint32_t length;
         /** Zeroes */
-        uint8_t zeroes [3];
+        uint8_t zeroes[3];
         /** Next header */
         uint8_t next;
-} icmpv6_pseudo_header;
+} icmpv6_phdr_t;
 
 /** NDP neighbour body */
 typedef struct {
         /** Target IPv6 address */
-        uint8_t target_address [16];
+        uint8_t target_address[16];
         /** Option code */
         uint8_t option;
@@ -111 +115 @@
         uint8_t length;
         /** MAC address */
-        uint8_t mac [6];
+        uint8_t mac[6];
 } ndp_message_t;
 
@@ -131 +135 @@
         uint32_t reserved;
         /** Prefix */
-        uint8_t prefix [16];
+        uint8_t prefix[16];
 } ndp_prefix_t;
 

uspace/srv/net/inetsrv/inet_link.c

@@ -49 +49 @@
 #include "pdu.h"
 
+static bool first_link = true;
+static bool first_link6 = true;
+
+static FIBRIL_MUTEX_INITIALIZE(ip_ident_lock);
+static uint16_t ip_ident = 0;
+
 static int inet_link_open(service_id_t);
 static int inet_iplink_recv(iplink_t *, iplink_recv_sdu_t *, uint16_t);
@@ -58 +64 @@
 static LIST_INITIALIZE(inet_link_list);
 static FIBRIL_MUTEX_INITIALIZE(inet_discovery_lock);
+
+static addr128_t link_local_node_ip =
+    {0xfe, 0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xff, 0xfe, 0, 0, 0};
+
+static void inet_link_local_node_ip(addr48_t mac_addr,
+    addr128_t ip_addr)
+{
+        memcpy(ip_addr, link_local_node_ip, 16);
+        
+        ip_addr[8] = mac_addr[0] ^ 0x02;
+        ip_addr[9] = mac_addr[1];
+        ip_addr[10] = mac_addr[2];
+        ip_addr[13] = mac_addr[3];
+        ip_addr[14] = mac_addr[4];
+        ip_addr[15] = mac_addr[5];
+}
 
 static int inet_iplink_recv(iplink_t *iplink, iplink_recv_sdu_t *sdu, uint16_t af)
@@ -159 +181 @@
         if (ilink->svc_name != NULL)
                 free(ilink->svc_name);
+        
         free(ilink);
 }
@@ -201 +224 @@
                 goto error;
         }
+        
+        /*
+         * Get the MAC address of the link. If the link has a MAC
+         * address, we assume that it supports NDP.
+         */
+        rc = iplink_get_mac48(ilink->iplink, &ilink->mac);
+        ilink->mac_valid = (rc == EOK);
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "Opened IP link '%s'", ilink->svc_name);
         list_append(&ilink->link_list, &inet_link_list);
 
-        inet_addrobj_t *addr;
-        inet_addrobj_t *addr6;
-
-        static int first = 1;
-        
-        addr = inet_addrobj_new();
-        addr6 = inet_addrobj_new();
-        
-        if (first) {
+        inet_addrobj_t *addr = NULL;
+        
+        if (first_link) {
+                addr = inet_addrobj_new();
+                
                 inet_naddr(&addr->naddr, 127, 0, 0, 1, 24);
-                inet_naddr6(&addr6->naddr, 0, 0, 0, 0, 0, 0, 0, 1, 128);
-                first = 0;
+                first_link = false;
         } else {
                 /*
                  * FIXME
-                 * Setting static IP addresses for testing purposes
+                 * Setting static IPv4 address for testing purposes:
                  * 10.0.2.15/24
-                 * fd19:1680::4/120
                  */
+                addr = inet_addrobj_new();
+                
                 inet_naddr(&addr->naddr, 10, 0, 2, 15, 24);
-                inet_naddr6(&addr6->naddr, 0xfd19, 0x1680, 0, 0, 0, 0, 0, 4, 120);
-        }
-        
-        addr->ilink = ilink;
-        addr6->ilink = ilink;
-        addr->name = str_dup("v4a");
-        addr6->name = str_dup("v6a");
-        
-        rc = inet_addrobj_add(addr);
-        if (rc != EOK) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Failed adding IPv4 address.");
-                inet_addrobj_delete(addr);
-                /* XXX Roll back */
-                return rc;
-        }
-        
-        rc = inet_addrobj_add(addr6);
-        if (rc != EOK) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Failed adding IPv6 address.");
-                inet_addrobj_delete(addr6);
-                /* XXX Roll back */
-                return rc;
-        }
-        
-        inet_naddr_addr(&addr->naddr, &iaddr);
-        rc = iplink_addr_add(ilink->iplink, &iaddr);
-        if (rc != EOK) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Failed setting IPv4 address on internet link.");
-                inet_addrobj_remove(addr);
-                inet_addrobj_delete(addr);
-                /* XXX Roll back */
-                return rc;
-        }
-        
-        inet_naddr_addr(&addr6->naddr, &iaddr);
-        rc = iplink_addr_add(ilink->iplink, &iaddr);
-        if (rc != EOK) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Failed setting IPv6 address on internet link.");
-                inet_addrobj_remove(addr6);
-                inet_addrobj_delete(addr6);
-                /* XXX Roll back */
-                return rc;
+        }
+        
+        if (addr != NULL) {
+                addr->ilink = ilink;
+                addr->name = str_dup("v4a");
+                
+                rc = inet_addrobj_add(addr);
+                if (rc == EOK) {
+                        inet_naddr_addr(&addr->naddr, &iaddr);
+                        rc = iplink_addr_add(ilink->iplink, &iaddr);
+                        if (rc != EOK) {
+                                log_msg(LOG_DEFAULT, LVL_ERROR,
+                                    "Failed setting IPv4 address on internet link.");
+                                inet_addrobj_remove(addr);
+                                inet_addrobj_delete(addr);
+                        }
+                } else {
+                        log_msg(LOG_DEFAULT, LVL_ERROR, "Failed adding IPv4 address.");
+                        inet_addrobj_delete(addr);
+                }
+        }
+        
+        inet_addrobj_t *addr6 = NULL;
+        
+        if (first_link6) {
+                addr6 = inet_addrobj_new();
+                
+                inet_naddr6(&addr6->naddr, 0, 0, 0, 0, 0, 0, 0, 1, 128);
+                first_link6 = false;
+        } else if (ilink->mac_valid) {
+                addr6 = inet_addrobj_new();
+                
+                addr128_t link_local;
+                inet_link_local_node_ip(ilink->mac, link_local);
+                
+                inet_naddr_set6(link_local, 64, &addr6->naddr);
+        }
+        
+        if (addr6 != NULL) {
+                addr6->ilink = ilink;
+                addr6->name = str_dup("v6a");
+                
+                rc = inet_addrobj_add(addr6);
+                if (rc == EOK) {
+                        inet_naddr_addr(&addr6->naddr, &iaddr);
+                        rc = iplink_addr_add(ilink->iplink, &iaddr);
+                        if (rc != EOK) {
+                                log_msg(LOG_DEFAULT, LVL_ERROR,
+                                    "Failed setting IPv6 address on internet link.");
+                                inet_addrobj_remove(addr6);
+                                inet_addrobj_delete(addr6);
+                        }
+                } else {
+                        log_msg(LOG_DEFAULT, LVL_ERROR, "Failed adding IPv6 address.");
+                        inet_addrobj_delete(addr6);
+                }
         }
         
@@ -298 +338 @@
 }
 
-/** Send datagram over Internet link */
-int inet_link_send_dgram(inet_link_t *ilink, inet_addr_t *lsrc,
-    inet_addr_t *ldest, inet_dgram_t *dgram, uint8_t proto, uint8_t ttl, int df)
-{
+/** Send IPv4 datagram over Internet link
+ *
+ * @param ilink Internet link
+ * @param lsrc  Source IPv4 address
+ * @param ldest Destination IPv4 address
+ * @param dgram IPv4 datagram body
+ * @param proto Protocol
+ * @param ttl   Time-to-live
+ * @param df    Do-not-Fragment flag
+ *
+ * @return EOK on success
+ * @return ENOMEM when not enough memory to create the datagram
+ * @return ENOTSUP if networking mode is not supported
+ *
+ */
+int inet_link_send_dgram(inet_link_t *ilink, addr32_t lsrc, addr32_t ldest,
+    inet_dgram_t *dgram, uint8_t proto, uint8_t ttl, int df)
+{
+        addr32_t src_v4;
+        uint16_t src_af = inet_addr_get(&dgram->src, &src_v4, NULL);
+        if (src_af != AF_INET)
+                return EINVAL;
+        
+        addr32_t dest_v4;
+        uint16_t dest_af = inet_addr_get(&dgram->dest, &dest_v4, NULL);
+        if (dest_af != AF_INET)
+                return EINVAL;
+        
         /*
          * Fill packet structure. Fragmentation is performed by
          * inet_pdu_encode().
          */
+        
+        iplink_sdu_t sdu;
+        
+        sdu.src = lsrc;
+        sdu.dest = ldest;
         
         inet_packet_t packet;
@@ -314 +383 @@
         packet.proto = proto;
         packet.ttl = ttl;
+        
+        /* Allocate identifier */
+        fibril_mutex_lock(&ip_ident_lock);
+        packet.ident = ++ip_ident;
+        fibril_mutex_unlock(&ip_ident_lock);
+        
         packet.df = df;
         packet.data = dgram->data;
         packet.size = dgram->size;
         
-        iplink_sdu_t sdu;
+        int rc;
         size_t offs = 0;
-        int rc;
-        
-        sdu.src = *lsrc;
-        sdu.dest = *ldest;
         
         do {
                 /* Encode one fragment */
+                
                 size_t roffs;
-                rc = inet_pdu_encode(&packet, offs, ilink->def_mtu, &sdu.data,
-                    &sdu.size, &roffs);
+                rc = inet_pdu_encode(&packet, src_v4, dest_v4, offs, ilink->def_mtu,
+                    &sdu.data, &sdu.size, &roffs);
                 if (rc != EOK)
                         return rc;
@@ -335 +407 @@
                 /* Send the PDU */
                 rc = iplink_send(ilink->iplink, &sdu);
+                
                 free(sdu.data);
-                
+                offs = roffs;
+        } while (offs < packet.size);
+        
+        return rc;
+}
+
+/** Send IPv6 datagram over Internet link
+ *
+ * @param ilink Internet link
+ * @param ldest Destination MAC address
+ * @param dgram IPv6 datagram body
+ * @param proto Next header
+ * @param ttl   Hop limit
+ * @param df    Do-not-Fragment flag (unused)
+ *
+ * @return EOK on success
+ * @return ENOMEM when not enough memory to create the datagram
+ *
+ */
+int inet_link_send_dgram6(inet_link_t *ilink, addr48_t ldest,
+    inet_dgram_t *dgram, uint8_t proto, uint8_t ttl, int df)
+{
+        addr128_t src_v6;
+        uint16_t src_af = inet_addr_get(&dgram->src, NULL, &src_v6);
+        if (src_af != AF_INET6)
+                return EINVAL;
+        
+        addr128_t dest_v6;
+        uint16_t dest_af = inet_addr_get(&dgram->dest, NULL, &dest_v6);
+        if (dest_af != AF_INET6)
+                return EINVAL;
+        
+        iplink_sdu6_t sdu6;
+        addr48(ldest, sdu6.dest);
+        
+        /*
+         * Fill packet structure. Fragmentation is performed by
+         * inet_pdu_encode6().
+         */
+        
+        inet_packet_t packet;
+        
+        packet.src = dgram->src;
+        packet.dest = dgram->dest;
+        packet.tos = dgram->tos;
+        packet.proto = proto;
+        packet.ttl = ttl;
+        
+        /* Allocate identifier */
+        fibril_mutex_lock(&ip_ident_lock);
+        packet.ident = ++ip_ident;
+        fibril_mutex_unlock(&ip_ident_lock);
+        
+        packet.df = df;
+        packet.data = dgram->data;
+        packet.size = dgram->size;
+        
+        int rc;
+        size_t offs = 0;
+        
+        do {
+                /* Encode one fragment */
+                
+                size_t roffs;
+                rc = inet_pdu_encode6(&packet, src_v6, dest_v6, offs, ilink->def_mtu,
+                    &sdu6.data, &sdu6.size, &roffs);
+                if (rc != EOK)
+                        return rc;
+                
+                /* Send the PDU */
+                rc = iplink_send6(ilink->iplink, &sdu6);
+                
+                free(sdu6.data);
                 offs = roffs;
         } while (offs < packet.size);

uspace/srv/net/inetsrv/inet_link.h

@@ -42 +42 @@
 
 extern int inet_link_discovery_start(void);
-extern int inet_link_send_dgram(inet_link_t *, inet_addr_t *,
-    inet_addr_t *, inet_dgram_t *, uint8_t, uint8_t, int);
+extern int inet_link_send_dgram(inet_link_t *, addr32_t,
+    addr32_t, inet_dgram_t *, uint8_t, uint8_t, int);
+extern int inet_link_send_dgram6(inet_link_t *, addr48_t, inet_dgram_t *,
+    uint8_t, uint8_t, int);
 extern inet_link_t *inet_link_get_by_id(sysarg_t);
 

uspace/srv/net/inetsrv/inet_std.h

@@ -40 +40 @@
 #include <sys/types.h>
 
+#define IP6_NEXT_FRAGMENT  44
+
 /** IPv4 Datagram header (fixed part) */
 typedef struct {
@@ -48 +50 @@
         /** Total Length */
         uint16_t tot_len;
-        /** Identification */
+        /** Identifier */
         uint16_t id;
         /** Flags, Fragment Offset */
@@ -90 +92 @@
 };
 
+/** Bits in ip6_header_fragment_t.offsmf */
+enum flags_offsmt_bits {
+        /** More fragments */
+        OF_FLAG_M = 0,
+        /** Fragment offset, highest bit */
+        OF_FRAGOFF_h = 15,
+        /** Fragment offset, lowest bit */
+        OF_FRAGOFF_l = 3
+};
+
 /** IPv6 Datagram header (fixed part) */
 typedef struct {
@@ -114 +126 @@
         /** Reserved */
         uint8_t reserved;
-        /** Fragment Offset, Flags */
-        uint16_t foff_flags;
-        /** Identification */
+        /** Fragmentation offset, reserved and M flag */
+        uint16_t offsmf;
+        /** Identifier */
         uint32_t id;
 } ip6_header_fragment_t;

uspace/srv/net/inetsrv/inetping6.c

@@ -109 +109 @@
         aid_t req = async_send_1(exch, INETPING6_EV_RECV, sdu->seq_no, &answer);
         
-        int rc = async_data_write_start(exch, sdu->src, 16);
+        int rc = async_data_write_start(exch, sdu->src, sizeof(addr128_t));
         if (rc != EOK) {
                 async_exchange_end(exch);
@@ -116 +116 @@
         }
         
-        rc = async_data_write_start(exch, sdu->dest, 16);
+        rc = async_data_write_start(exch, sdu->dest, sizeof(addr128_t));
         if (rc != EOK) {
                 async_exchange_end(exch);

uspace/srv/net/inetsrv/inetsrv.c

@@ -62 +62 @@
 #define NAME "inetsrv"
 
+static inet_naddr_t solicited_node_mask = {
+        .family = AF_INET6,
+        .addr6 = {0xff, 0x02, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01, 0xff, 0, 0, 0},
+        .prefix = 104
+};
+
+static inet_addr_t multicast_all_nodes = {
+        .family = AF_INET6,
+        .addr6 = {0xff, 0x02, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01}
+};
+
 static void inet_client_conn(ipc_callid_t iid, ipc_call_t *icall, void *arg);
 
@@ -514 +525 @@
 
         addr = inet_addrobj_find(&packet->dest, iaf_addr);
-        if (addr != NULL) {
+        if ((addr != NULL) ||
+            (inet_naddr_compare_mask(&solicited_node_mask, &packet->dest)) ||
+            (inet_addr_compare(&multicast_all_nodes, &packet->dest))) {
                 /* Destined for one of the local addresses */
 

uspace/srv/net/inetsrv/inetsrv.h

@@ -113 +113 @@
         uint8_t ttl;
         /** Identifier */
-        uint16_t ident;
+        uint32_t ident;
         /** Do not fragment */
         bool df;
@@ -141 +141 @@
         iplink_t *iplink;
         size_t def_mtu;
+        addr48_t mac;
+        bool mac_valid;
 } inet_link_t;
 

uspace/srv/net/inetsrv/pdu.c

@@ -49 +49 @@
 #include "pdu.h"
 
-static FIBRIL_MUTEX_INITIALIZE(ip_ident_lock);
-static uint16_t ip_ident = 0;
-
 /** One's complement addition.
  *
@@ -88 +85 @@
 }
 
-/** Encode Internet PDU.
+/** Encode IPv4 PDU.
  *
  * Encode internet packet into PDU (serialized form). Will encode a
@@ -96 +93 @@
  * be set in the header, otherwise the offset will equal @a packet->size.
  *
- * @param packet        Packet to encode
- * @param offs          Offset into packet payload (in bytes)
- * @param mtu           MTU (Maximum Transmission Unit) in bytes
- * @param rdata         Place to store pointer to allocated data buffer
- * @param rsize         Place to store size of allocated data buffer
- * @param roffs         Place to store offset of remaning data
- */
-int inet_pdu_encode(inet_packet_t *packet, size_t offs, size_t mtu,
-    void **rdata, size_t *rsize, size_t *roffs)
-{
-        addr32_t src_v4;
-        addr128_t src_v6;
-        uint16_t src_af = inet_addr_get(&packet->src, &src_v4, &src_v6);
-        
-        addr32_t dest_v4;
-        addr128_t dest_v6;
-        uint16_t dest_af = inet_addr_get(&packet->dest, &dest_v4, &dest_v6);
-        
-        if (src_af != dest_af)
-                return EINVAL;
-        
+ * @param packet Packet to encode
+ * @param src    Source address
+ * @param dest   Destination address
+ * @param offs   Offset into packet payload (in bytes)
+ * @param mtu    MTU (Maximum Transmission Unit) in bytes
+ * @param rdata  Place to store pointer to allocated data buffer
+ * @param rsize  Place to store size of allocated data buffer
+ * @param roffs  Place to store offset of remaning data
+ *
+ */
+int inet_pdu_encode(inet_packet_t *packet, addr32_t src, addr32_t dest,
+    size_t offs, size_t mtu, void **rdata, size_t *rsize, size_t *roffs)
+{
         /* Upper bound for fragment offset field */
         size_t fragoff_limit = 1 << (FF_FRAGOFF_h - FF_FRAGOFF_l);
@@ -124 +113 @@
                 return ELIMIT;
         
-        size_t hdr_size;
-        
-        switch (src_af) {
-        case AF_INET:
-                hdr_size = sizeof(ip_header_t);
-                break;
-        case AF_INET6:
-                hdr_size = sizeof(ip6_header_t);
-                break;
-        default:
-                assert(false);
-        }
-        
-        size_t data_offs = ROUND_UP(hdr_size, 4);
-        
+        size_t hdr_size = sizeof(ip_header_t);
+        if (hdr_size >= mtu)
+                return EINVAL;
+        
+        assert(hdr_size % 4 == 0);
         assert(offs % FRAG_OFFS_UNIT == 0);
         assert(offs / FRAG_OFFS_UNIT < fragoff_limit);
@@ -144 +123 @@
         /* Value for the fragment offset field */
         uint16_t foff = offs / FRAG_OFFS_UNIT;
-        
-        if (hdr_size >= mtu)
-                return EINVAL;
         
         /* Amount of space in the PDU available for payload */
@@ -171 +147 @@
                 return ENOMEM;
         
-        /* Allocate identifier */
-        fibril_mutex_lock(&ip_ident_lock);
-        uint16_t ident = ++ip_ident;
-        fibril_mutex_unlock(&ip_ident_lock);
-        
         /* Encode header fields */
-        ip_header_t *hdr;
-        ip6_header_t *hdr6;
-        
-        switch (src_af) {
-        case AF_INET:
-                hdr = (ip_header_t *) data;
-                
-                hdr->ver_ihl =
-                    (4 << VI_VERSION_l) | (hdr_size / sizeof(uint32_t));
-                hdr->tos = packet->tos;
-                hdr->tot_len = host2uint16_t_be(size);
-                hdr->id = host2uint16_t_be(ident);
-                hdr->flags_foff = host2uint16_t_be(flags_foff);
-                hdr->ttl = packet->ttl;
-                hdr->proto = packet->proto;
-                hdr->chksum = 0;
-                hdr->src_addr = host2uint32_t_be(src_v4);
-                hdr->dest_addr = host2uint32_t_be(dest_v4);
-                
-                /* Compute checksum */
-                uint16_t chksum = inet_checksum_calc(INET_CHECKSUM_INIT,
-                    (void *) hdr, hdr_size);
-                hdr->chksum = host2uint16_t_be(chksum);
-                
-                break;
-        case AF_INET6:
-                // TODO FIXME: fragmentation
-                
-                hdr6 = (ip6_header_t *) data;
-                
-                hdr6->ver_tc = (6 << (VI_VERSION_l));
-                memset(hdr6->tc_fl, 0, 3);
-                hdr6->payload_len = host2uint16_t_be(packet->size);
-                hdr6->next = packet->proto;
-                hdr6->hop_limit = packet->ttl;
-                
-                host2addr128_t_be(src_v6, hdr6->src_addr);
-                host2addr128_t_be(dest_v6, hdr6->dest_addr);
-                
-                break;
-        default:
-                assert(false);
-        }
+        ip_header_t *hdr = (ip_header_t *) data;
+        
+        hdr->ver_ihl =
+            (4 << VI_VERSION_l) | (hdr_size / sizeof(uint32_t));
+        hdr->tos = packet->tos;
+        hdr->tot_len = host2uint16_t_be(size);
+        hdr->id = host2uint16_t_be(packet->ident);
+        hdr->flags_foff = host2uint16_t_be(flags_foff);
+        hdr->ttl = packet->ttl;
+        hdr->proto = packet->proto;
+        hdr->chksum = 0;
+        hdr->src_addr = host2uint32_t_be(src);
+        hdr->dest_addr = host2uint32_t_be(dest);
+        
+        /* Compute checksum */
+        uint16_t chksum = inet_checksum_calc(INET_CHECKSUM_INIT,
+            (void *) hdr, hdr_size);
+        hdr->chksum = host2uint16_t_be(chksum);
         
         /* Copy payload */
-        memcpy((uint8_t *) data + data_offs, packet->data + offs, xfer_size);
+        memcpy((uint8_t *) data + hdr_size, packet->data + offs, xfer_size);
         
         *rdata = data;
@@ -231 +177 @@
 }
 
+/** Encode IPv6 PDU.
+ *
+ * Encode internet packet into PDU (serialized form). Will encode a
+ * fragment of the payload starting at offset @a offs. The resulting
+ * PDU will have at most @a mtu bytes. @a *roffs will be set to the offset
+ * of remaining payload. If some data is remaining, the MF flag will
+ * be set in the header, otherwise the offset will equal @a packet->size.
+ *
+ * @param packet Packet to encode
+ * @param src    Source address
+ * @param dest   Destination address
+ * @param offs   Offset into packet payload (in bytes)
+ * @param mtu    MTU (Maximum Transmission Unit) in bytes
+ * @param rdata  Place to store pointer to allocated data buffer
+ * @param rsize  Place to store size of allocated data buffer
+ * @param roffs  Place to store offset of remaning data
+ *
+ */
+int inet_pdu_encode6(inet_packet_t *packet, addr128_t src, addr128_t dest,
+    size_t offs, size_t mtu, void **rdata, size_t *rsize, size_t *roffs)
+{
+        /* IPv6 mandates a minimal MTU of 1280 bytes */
+        if (mtu < 1280)
+                return ELIMIT;
+        
+        /* Upper bound for fragment offset field */
+        size_t fragoff_limit = 1 << (OF_FRAGOFF_h - OF_FRAGOFF_l);
+        
+        /* Verify that total size of datagram is within reasonable bounds */
+        if (offs + packet->size > FRAG_OFFS_UNIT * fragoff_limit)
+                return ELIMIT;
+        
+        /* Determine whether we need the Fragment extension header */
+        bool fragment;
+        if (offs == 0)
+                fragment = (packet->size + sizeof(ip6_header_t) > mtu);
+        else
+                fragment = true;
+        
+        size_t hdr_size;
+        if (fragment)
+                hdr_size = sizeof(ip6_header_t) + sizeof(ip6_header_fragment_t);
+        else
+                hdr_size = sizeof(ip6_header_t);
+        
+        if (hdr_size >= mtu)
+                return EINVAL;
+        
+        assert(sizeof(ip6_header_t) % 8 == 0);
+        assert(hdr_size % 8 == 0);
+        assert(offs % FRAG_OFFS_UNIT == 0);
+        assert(offs / FRAG_OFFS_UNIT < fragoff_limit);
+        
+        /* Value for the fragment offset field */
+        uint16_t foff = offs / FRAG_OFFS_UNIT;
+        
+        /* Amount of space in the PDU available for payload */
+        size_t spc_avail = mtu - hdr_size;
+        spc_avail -= (spc_avail % FRAG_OFFS_UNIT);
+        
+        /* Amount of data (payload) to transfer */
+        size_t xfer_size = min(packet->size - offs, spc_avail);
+        
+        /* Total PDU size */
+        size_t size = hdr_size + xfer_size;
+        
+        /* Offset of remaining payload */
+        size_t rem_offs = offs + xfer_size;
+        
+        /* Flags */
+        uint16_t offsmf =
+            (rem_offs < packet->size ? BIT_V(uint16_t, OF_FLAG_M) : 0) +
+            (foff << OF_FRAGOFF_l);
+        
+        void *data = calloc(size, 1);
+        if (data == NULL)
+                return ENOMEM;
+        
+        /* Encode header fields */
+        ip6_header_t *hdr6 = (ip6_header_t *) data;
+        
+        hdr6->ver_tc = (6 << (VI_VERSION_l));
+        memset(hdr6->tc_fl, 0, 3);
+        hdr6->hop_limit = packet->ttl;
+        
+        host2addr128_t_be(src, hdr6->src_addr);
+        host2addr128_t_be(dest, hdr6->dest_addr);
+        
+        /* Optionally encode Fragment extension header fields */
+        if (fragment) {
+                assert(offsmf != 0);
+                
+                hdr6->payload_len = host2uint16_t_be(packet->size +
+                    sizeof(ip6_header_fragment_t));
+                hdr6->next = IP6_NEXT_FRAGMENT;
+                
+                ip6_header_fragment_t *hdr6f = (ip6_header_fragment_t *)
+                    (hdr6 + 1);
+                
+                hdr6f->next = packet->proto;
+                hdr6f->reserved = 0;
+                hdr6f->offsmf = host2uint16_t_be(offsmf);
+                hdr6f->id = host2uint32_t_be(packet->ident);
+        } else {
+                assert(offsmf == 0);
+                
+                hdr6->payload_len = host2uint16_t_be(packet->size);
+                hdr6->next = packet->proto;
+        }
+        
+        /* Copy payload */
+        memcpy((uint8_t *) data + hdr_size, packet->data + offs, xfer_size);
+        
+        *rdata = data;
+        *rsize = size;
+        *roffs = rem_offs;
+        
+        return EOK;
+}
+
+/** Decode IPv4 datagram
+ *
+ * @param data   Serialized IPv4 datagram
+ * @param size   Length of serialized IPv4 datagram
+ * @param packet IP datagram structure to be filled
+ *
+ * @return EOK on success
+ * @return EINVAL if the datagram is invalid or damaged
+ * @return ENOMEM if not enough memory
+ *
+ */
 int inet_pdu_decode(void *data, size_t size, inet_packet_t *packet)
 {
@@ -257 +334 @@
         if (tot_len > size) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "Total Length = %zu > PDU size = %zu",
-                        tot_len, size);
+                    tot_len, size);
                 return EINVAL;
         }
@@ -294 +371 @@
 }
 
+/** Decode IPv6 datagram
+ *
+ * @param data   Serialized IPv6 datagram
+ * @param size   Length of serialized IPv6 datagram
+ * @param packet IP datagram structure to be filled
+ *
+ * @return EOK on success
+ * @return EINVAL if the datagram is invalid or damaged
+ * @return ENOMEM if not enough memory
+ *
+ */
 int inet_pdu_decode6(void *data, size_t size, inet_packet_t *packet)
 {
-        // FIXME TODO
-        return ENOTSUP;
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "inet_pdu_decode6()");
+        
+        if (size < sizeof(ip6_header_t)) {
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "PDU too short (%zu)", size);
+                return EINVAL;
+        }
+        
+        ip6_header_t *hdr6 = (ip6_header_t *) data;
+        
+        uint8_t version = BIT_RANGE_EXTRACT(uint8_t, VI_VERSION_h,
+            VI_VERSION_l, hdr6->ver_tc);
+        if (version != 6) {
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "Version (%d) != 6", version);
+                return EINVAL;
+        }
+        
+        size_t payload_len = uint16_t_be2host(hdr6->payload_len);
+        if (payload_len + sizeof(ip6_header_t) > size) {
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "Payload Length = %zu > PDU size = %zu",
+                    payload_len + sizeof(ip6_header_t), size);
+                return EINVAL;
+        }
+        
+        uint32_t ident;
+        uint16_t offsmf;
+        uint16_t foff;
+        uint16_t next;
+        size_t data_offs = sizeof(ip6_header_t);
+        
+        /* Fragment extension header */
+        if (hdr6->next == IP6_NEXT_FRAGMENT) {
+                ip6_header_fragment_t *hdr6f = (ip6_header_fragment_t *)
+                    (hdr6 + 1);
+                
+                ident = uint32_t_be2host(hdr6f->id);
+                offsmf = uint16_t_be2host(hdr6f->offsmf);
+                foff = BIT_RANGE_EXTRACT(uint16_t, OF_FRAGOFF_h, OF_FRAGOFF_l,
+                    offsmf);
+                next = hdr6f->next;
+                data_offs += sizeof(ip6_header_fragment_t);
+                payload_len -= sizeof(ip6_header_fragment_t);
+        } else {
+                ident = 0;
+                offsmf = 0;
+                foff = 0;
+                next = hdr6->next;
+        }
+        
+        addr128_t src;
+        addr128_t dest;
+        
+        addr128_t_be2host(hdr6->src_addr, src);
+        inet_addr_set6(src, &packet->src);
+        
+        addr128_t_be2host(hdr6->dest_addr, dest);
+        inet_addr_set6(dest, &packet->dest);
+        
+        packet->tos = 0;
+        packet->proto = next;
+        packet->ttl = hdr6->hop_limit;
+        packet->ident = ident;
+        
+        packet->df = 1;
+        packet->mf = (offsmf & BIT_V(uint16_t, OF_FLAG_M)) != 0;
+        packet->offs = foff * FRAG_OFFS_UNIT;
+        
+        packet->size = payload_len;
+        packet->data = calloc(packet->size, 1);
+        if (packet->data == NULL) {
+                log_msg(LOG_DEFAULT, LVL_WARN, "Out of memory.");
+                return ENOMEM;
+        }
+        
+        memcpy(packet->data, (uint8_t *) data + data_offs, packet->size);
+        
+        return EOK;
+}
+
+/** Encode NDP packet
+ *
+ * @param ndp   NDP packet structure to be serialized
+ * @param dgram IPv6 datagram structure to be filled
+ *
+ * @return EOK on success
+ *
+ */
+int ndp_pdu_encode(ndp_packet_t *ndp, inet_dgram_t *dgram)
+{
+        inet_addr_set6(ndp->sender_proto_addr, &dgram->src);
+        inet_addr_set6(ndp->target_proto_addr, &dgram->dest);
+        dgram->tos = 0;
+        dgram->size = sizeof(icmpv6_message_t) + sizeof(ndp_message_t);
+        
+        dgram->data = calloc(1, dgram->size);
+        if (dgram->data == NULL)
+                return ENOMEM;
+        
+        icmpv6_message_t *icmpv6 = (icmpv6_message_t *) dgram->data;
+        
+        icmpv6->type = ndp->opcode;
+        icmpv6->code = 0;
+        memset(icmpv6->un.ndp.reserved, 0, 3);
+        
+        ndp_message_t *message = (ndp_message_t *) (icmpv6 + 1);
+        
+        if (ndp->opcode == ICMPV6_NEIGHBOUR_SOLICITATION) {
+                host2addr128_t_be(ndp->solicited_ip, message->target_address);
+                message->option = 1;
+                icmpv6->un.ndp.flags = 0;
+        } else {
+                host2addr128_t_be(ndp->sender_proto_addr, message->target_address);
+                message->option = 2;
+                icmpv6->un.ndp.flags = NDP_FLAG_OVERRIDE | NDP_FLAG_SOLICITED;
+        }
+        
+        message->length = 1;
+        addr48(ndp->sender_hw_addr, message->mac);
+        
+        icmpv6_phdr_t phdr;
+        
+        host2addr128_t_be(ndp->sender_proto_addr, phdr.src_addr);
+        host2addr128_t_be(ndp->target_proto_addr, phdr.dest_addr);
+        phdr.length = host2uint32_t_be(dgram->size);
+        memset(phdr.zeroes, 0, 3);
+        phdr.next = IP_PROTO_ICMPV6;
+        
+        uint16_t cs_phdr =
+            inet_checksum_calc(INET_CHECKSUM_INIT, &phdr,
+            sizeof(icmpv6_phdr_t));
+        
+        uint16_t cs_all = inet_checksum_calc(cs_phdr, dgram->data,
+            dgram->size);
+        
+        icmpv6->checksum = host2uint16_t_be(cs_all);
+        
+        return EOK;
+}
+
+/** Decode NDP packet
+ *
+ * @param dgram Incoming IPv6 datagram encapsulating NDP packet
+ * @param ndp   NDP packet structure to be filled
+ *
+ * @return EOK on success
+ * @return EINVAL if the Datagram is invalid
+ *
+ */
+int ndp_pdu_decode(inet_dgram_t *dgram, ndp_packet_t *ndp)
+{
+        uint16_t src_af = inet_addr_get(&dgram->src, NULL,
+            &ndp->sender_proto_addr);
+        if (src_af != AF_INET6)
+                return EINVAL;
+        
+        if (dgram->size < sizeof(icmpv6_message_t) + sizeof(ndp_message_t))
+                return EINVAL;
+        
+        icmpv6_message_t *icmpv6 = (icmpv6_message_t *) dgram->data;
+        
+        ndp->opcode = icmpv6->type;
+        
+        ndp_message_t *message = (ndp_message_t *) (icmpv6 + 1);
+        
+        addr128_t_be2host(message->target_address, ndp->target_proto_addr);
+        addr48(message->mac, ndp->sender_hw_addr);
+        
+        return EOK;
 }
 

uspace/srv/net/inetsrv/pdu.h

@@ -40 +40 @@
 #include <sys/types.h>
 #include "inetsrv.h"
+#include "ndp.h"
 
 #define INET_CHECKSUM_INIT 0xffff
@@ -45 +46 @@
 extern uint16_t inet_checksum_calc(uint16_t, void *, size_t);
 
-extern int inet_pdu_encode(inet_packet_t *, size_t, size_t, void **,
-    size_t *, size_t *);
+extern int inet_pdu_encode(inet_packet_t *, addr32_t, addr32_t, size_t, size_t,
+    void **, size_t *, size_t *);
+extern int inet_pdu_encode6(inet_packet_t *, addr128_t, addr128_t, size_t,
+    size_t, void **, size_t *, size_t *);
 extern int inet_pdu_decode(void *, size_t, inet_packet_t *);
 extern int inet_pdu_decode6(void *, size_t, inet_packet_t *);
+
+extern int ndp_pdu_decode(inet_dgram_t *, ndp_packet_t *);
+extern int ndp_pdu_encode(ndp_packet_t *, inet_dgram_t *);
 
 #endif

uspace/srv/net/inetsrv/reass.c

@@ -164 +164 @@
                 return NULL;
 
-        link_initialize(&rdg->map_link);
+        list_append(&rdg->map_link, &reass_dgram_map);
         list_initialize(&rdg->frags);
 

uspace/srv/net/loopip/loopip.c

@@ -40 +40 @@
 #include <inet/iplink_srv.h>
 #include <inet/addr.h>
+#include <net/socket_codes.h>
 #include <io/log.h>
 #include <loc.h>
@@ -50 +51 @@
 static int loopip_close(iplink_srv_t *srv);
 static int loopip_send(iplink_srv_t *srv, iplink_sdu_t *sdu);
+static int loopip_send6(iplink_srv_t *srv, iplink_sdu6_t *sdu);
 static int loopip_get_mtu(iplink_srv_t *srv, size_t *mtu);
+static int loopip_get_mac48(iplink_srv_t *srv, addr48_t *mac);
 static int loopip_addr_add(iplink_srv_t *srv, inet_addr_t *addr);
 static int loopip_addr_remove(iplink_srv_t *srv, inet_addr_t *addr);
@@ -60 +63 @@
         .close = loopip_close,
         .send = loopip_send,
+        .send6 = loopip_send6,
         .get_mtu = loopip_get_mtu,
+        .get_mac48 = loopip_get_mac48,
         .addr_add = loopip_addr_add,
         .addr_remove = loopip_addr_remove
@@ -162 +167 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "loopip_send()");
         
-        addr32_t src_v4;
-        addr128_t src_v6;
-        uint16_t src_af = inet_addr_get(&sdu->src, &src_v4, &src_v6);
-        
-        addr32_t dest_v4;
-        addr128_t dest_v6;
-        uint16_t dest_af = inet_addr_get(&sdu->dest, &dest_v4, &dest_v6);
-        
-        if (src_af != dest_af)
-                return EINVAL;
-        
         rqueue_entry_t *rqe = calloc(1, sizeof(rqueue_entry_t));
         if (rqe == NULL)
@@ -180 +174 @@
          * Clone SDU
          */
-        rqe->af = src_af;
+        rqe->af = AF_INET;
         rqe->sdu.data = malloc(sdu->size);
         if (rqe->sdu.data == NULL) {
@@ -198 +192 @@
 }
 
+static int loopip_send6(iplink_srv_t *srv, iplink_sdu6_t *sdu)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "loopip6_send()");
+        
+        rqueue_entry_t *rqe = calloc(1, sizeof(rqueue_entry_t));
+        if (rqe == NULL)
+                return ENOMEM;
+        
+        /*
+         * Clone SDU
+         */
+        rqe->af = AF_INET6;
+        rqe->sdu.data = malloc(sdu->size);
+        if (rqe->sdu.data == NULL) {
+                free(rqe);
+                return ENOMEM;
+        }
+        
+        memcpy(rqe->sdu.data, sdu->data, sdu->size);
+        rqe->sdu.size = sdu->size;
+        
+        /*
+         * Insert to receive queue
+         */
+        prodcons_produce(&loopip_rcv_queue, &rqe->link);
+        
+        return EOK;
+}
+
 static int loopip_get_mtu(iplink_srv_t *srv, size_t *mtu)
 {
@@ -203 +226 @@
         *mtu = 1500;
         return EOK;
+}
+
+static int loopip_get_mac48(iplink_srv_t *src, addr48_t *mac)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "loopip_get_mac48()");
+        return ENOTSUP;
 }
 

uspace/srv/net/slip/slip.c

@@ -58 +58 @@
 static int slip_close(iplink_srv_t *);
 static int slip_send(iplink_srv_t *, iplink_sdu_t *);
+static int slip_send6(iplink_srv_t *, iplink_sdu6_t *);
 static int slip_get_mtu(iplink_srv_t *, size_t *);
+static int slip_get_mac48(iplink_srv_t *, addr48_t *);
 static int slip_addr_add(iplink_srv_t *, inet_addr_t *);
 static int slip_addr_remove(iplink_srv_t *, inet_addr_t *);
@@ -68 +70 @@
         .close = slip_close,
         .send = slip_send,
+        .send6 = slip_send6,
         .get_mtu = slip_get_mtu,
+        .get_mac48 = slip_get_mac48,
         .addr_add = slip_addr_add,
         .addr_remove = slip_addr_remove
@@ -122 +126 @@
 int slip_send(iplink_srv_t *srv, iplink_sdu_t *sdu)
 {
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "slip_send()");
+        
         async_sess_t *sess = (async_sess_t *) srv->arg;
         uint8_t *data = sdu->data;
-        unsigned i;
-
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "slip_send()");
-
+        
         /*
-         * Strictly speaking, this is not prescribed by the RFC, but the RFC
-         * suggests to start with sending a SLIP_END byte as a synchronization
-         * measure for dealing with previous possible noise on the line.
-         */
+         * Strictly speaking, this is not prescribed by the RFC, but the RFC
+         * suggests to start with sending a SLIP_END byte as a synchronization
+         * measure for dealing with previous possible noise on the line.
+         */
         write_buffered(sess, SLIP_END);
-
-        for (i = 0; i < sdu->size; i++) {
+        
+        for (size_t i = 0; i < sdu->size; i++) {
                 switch (data[i]) {
                 case SLIP_END:
@@ -150 +153 @@
                 }
         }
+        
         write_buffered(sess, SLIP_END);
         write_flush(sess);
-
-        return EOK;
+        
+        return EOK;
+}
+
+int slip_send6(iplink_srv_t *srv, iplink_sdu6_t *sdu)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "slip_send6()");
+        
+        return ENOTSUP;
 }
 
@@ -161 +172 @@
         *mtu = SLIP_MTU;
         return EOK;
+}
+
+int slip_get_mac48(iplink_srv_t *src, addr48_t *mac)
+{
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "slip_get_mac48()");
+        return ENOTSUP;
 }
 

uspace/srv/net/tcp/conn.c

@@ -312 +312 @@
 static bool tcp_socket_match(tcp_sock_t *sock, tcp_sock_t *patt)
 {
+        log_msg(LOG_DEFAULT, LVL_DEBUG2,
+            "tcp_socket_match(sock=(%u), pat=(%u))", sock->port, patt->port);
+        
         if ((!inet_addr_is_any(&patt->addr)) &&
             (!inet_addr_compare(&patt->addr, &sock->addr)))
@@ -351 +354 @@
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "tcp_conn_find_ref(%p)", sp);
+        
+        log_msg(LOG_DEFAULT, LVL_DEBUG2, "compare conn (f:(%u), l:(%u))",
+            sp->foreign.port, sp->local.port);
         
         fibril_mutex_lock(&conn_list_lock);
@@ -357 +363 @@
                 tcp_conn_t *conn = list_get_instance(link, tcp_conn_t, link);
                 tcp_sockpair_t *csp = &conn->ident;
+                
+                log_msg(LOG_DEFAULT, LVL_DEBUG2, " - with (f:(%u), l:(%u))",
+                    csp->foreign.port, csp->local.port);
                 
                 if (tcp_sockpair_match(sp, csp)) {

uspace/srv/net/tcp/pdu.c

@@ -172 +172 @@
                 phdr6->tcp_length =
                     host2uint32_t_be(pdu->header_size + pdu->text_size);
-                memset(phdr6->zero, 0, 3);
+                memset(phdr6->zeroes, 0, 3);
                 phdr6->next = IP_PROTO_TCP;
                 break;

uspace/srv/net/tcp/sock.c

@@ -613 +613 @@
         ipc_callid_t wcallid;
         size_t length;
-        uint8_t buffer[TCP_SOCK_FRAGMENT_SIZE];
         tcp_error_t trc;
         int rc;
+        
+        uint8_t *buffer = calloc(TCP_SOCK_FRAGMENT_SIZE, 1);
+        if (buffer == NULL) {
+                async_answer_0(callid, ENOMEM);
+                return;
+        }
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "tcp_sock_send()");
@@ -625 +630 @@
         if (sock_core == NULL) {
                 async_answer_0(callid, ENOTSOCK);
-                return;
+                goto out;
         }
 
@@ -641 +646 @@
                         fibril_mutex_unlock(&socket->lock);
                         async_answer_0(callid, EINVAL);
-                        return;
+                        goto out;
                 }
 
@@ -651 +656 @@
                         fibril_mutex_unlock(&socket->lock);
                         async_answer_0(callid, rc);
-                        return;
+                        goto out;
                 }
 
@@ -676 +681 @@
                         fibril_mutex_unlock(&socket->lock);
                         async_answer_0(callid, rc);
-                        return;
+                        goto out;
                 }
         }
@@ -685 +690 @@
             IPC_GET_ARG2(answer));
         fibril_mutex_unlock(&socket->lock);
+        
+out:
+        free(buffer);
 }
 

uspace/srv/net/tcp/std.h

@@ -75 +75 @@
 };
 
-/** TCP IPv4 pseudo header */
+/** TCP over IPv4 checksum pseudo header */
 typedef struct {
         /** Source address */
@@ -89 +89 @@
 } tcp_phdr_t;
 
-/** TCP IPv6 pseudo header */
+/** TCP over IPv6 checksum pseudo header */
 typedef struct {
         /** Source address */
@@ -98 +98 @@
         uint32_t tcp_length;
         /** Zeroes */
-        uint8_t zero[3];
+        uint8_t zeroes[3];
         /** Next header */
         uint8_t next;

uspace/srv/net/tcp/tcp.c

@@ -54 +54 @@
 #define NAME       "tcp"
 
-#define IP_PROTO_TCP 6
-
 static int tcp_inet_ev_recv(inet_dgram_t *dgram);
 static void tcp_received_pdu(tcp_pdu_t *pdu);

uspace/srv/net/tcp/tqueue.c

@@ -282 +282 @@
 void tcp_transmit_segment(tcp_sockpair_t *sp, tcp_segment_t *seg)
 {
+        log_msg(LOG_DEFAULT, LVL_DEBUG,
+            "tcp_transmit_segment(f:(%u),l:(%u), %p)",
+            sp->local.port, sp->foreign.port, seg);
+        
         log_msg(LOG_DEFAULT, LVL_DEBUG, "SEG.SEQ=%" PRIu32 ", SEG.WND=%" PRIu32,
             seg->seq, seg->wnd);

uspace/srv/net/tcp/ucall.c

@@ -298 +298 @@
         tcp_conn_t *conn;
 
+        log_msg(LOG_DEFAULT, LVL_DEBUG,
+            "tcp_as_segment_arrived(f:(%u), l:(%u))",
+            sp->foreign.port, sp->local.port);
+
         conn = tcp_conn_find_ref(sp);
         if (conn == NULL) {

uspace/srv/net/udp/assoc.c

@@ -372 +372 @@
 static bool udp_socket_match(udp_sock_t *sock, udp_sock_t *patt)
 {
+        log_msg(LOG_DEFAULT, LVL_DEBUG,
+            "udp_socket_match(sock=(%u), pat=(%u))", sock->port, patt->port);
+        
         if ((!inet_addr_is_any(&patt->addr)) &&
             (!inet_addr_compare(&patt->addr, &sock->addr)))

uspace/srv/net/udp/pdu.c

@@ -110 +110 @@
                 host2addr128_t_be(dest_v6, phdr6->dest_addr);
                 phdr6->udp_length = host2uint32_t_be(pdu->data_size);
-                memset(phdr6->zero, 0, 3);
+                memset(phdr6->zeroes, 0, 3);
                 phdr6->next = IP_PROTO_UDP;
                 break;

uspace/srv/net/udp/sock.c

@@ -265 +265 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_send()");
         
+        uint8_t *buffer = calloc(UDP_FRAGMENT_SIZE, 1);
+        if (buffer == NULL) {
+                async_answer_0(callid, ENOMEM);
+                return;
+        }
+        
         struct sockaddr_in6 *addr6 = NULL;
         struct sockaddr_in *addr;
@@ -276 +282 @@
                 if (rc != EOK) {
                         async_answer_0(callid, rc);
-                        return;
+                        goto out;
                 }
                 
@@ -357 +363 @@
                         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_sendto: Failed to "
                             "determine local address.");
-                        return;
+                        goto out;
                 }
                 
@@ -379 +385 @@
                         length = UDP_FRAGMENT_SIZE;
                 
-                uint8_t buffer[UDP_FRAGMENT_SIZE];
                 int rc = async_data_write_finalize(wcallid, buffer, length);
                 if (rc != EOK) {
@@ -425 +430 @@
         if (addr6 != NULL)
                 free(addr6);
+        
+        free(buffer);
 }
 

uspace/srv/net/udp/std.h

@@ -54 +54 @@
 } udp_header_t;
 
-/** UDP IPv4 pseudo header */
+/** UDP over IPv4 checksum pseudo header */
 typedef struct {
         /** Source address */
@@ -68 +68 @@
 } udp_phdr_t;
 
-/** UDP IPv6 pseudo header */
+/** UDP over IPv6 checksum pseudo header */
 typedef struct {
         /** Source address */
@@ -76 +76 @@
         /** UDP length */
         uint32_t udp_length;
-        /** Reserved */
-        uint8_t zero[3];
+        /** Zeroes */
+        uint8_t zeroes[3];
         /** Next header */
         uint8_t next;