Changeset bcd7775 in mainline

Timestamp:

2020-01-09T01:04:58Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

7959879

Parents:

7fa8589

git-author:

Matthieu Riolo <matthieu.riolo@…> (2020-01-06 04:09:19)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2020-01-09 01:04:58)

Message:

Correcting sysman handler for ipc calls. The old handler would
wrongly accept a call twice.

Location:

uspace/srv/sysman

Files:

• connection_broker.c (modified) (1 diff)
• connection_ctl.c (modified) (1 diff)
• main.c (modified) (1 diff)

uspace/srv/sysman/connection_broker.c

@@ -113 +113 @@
 {
         sysman_log(LVL_DEBUG2, "%s", __func__);
-        /* First, accept connection */
-        async_answer_0(icall, EOK);
 
         while (true) {

uspace/srv/sysman/connection_ctl.c

@@ -295 +295 @@
 {
         sysman_log(LVL_DEBUG2, "%s", __func__);
-        /* First, accept connection */
-        async_answer_0(icall, EOK);
 
         while (true) {

uspace/srv/sysman/main.c

@@ -69 +69 @@
 static void sysman_connection(ipc_call_t *icall, void *arg)
 {
+        /* First, accept connection */
         async_accept_0(icall);
 
-        while (true) {
-                ipc_call_t call;
-                async_get_call(&call);
-
-                if (!ipc_get_imethod(&call)) {
-                        async_answer_0(&call, EOK);
-                        break;
-                }
-
-                sysman_interface_t iface = ipc_get_arg1(&call);
-                switch (iface) {
-                case SYSMAN_PORT_BROKER:
-                        sysman_connection_broker(&call);
-                        break;
-                case SYSMAN_PORT_CTL:
-                        sysman_connection_ctl(&call);
-                        break;
-                default:
-                        /* Unknown interface */
-                        async_answer_0(&call, ENOENT);
-                }
+        sysman_interface_t iface = ipc_get_arg2(icall);
+        switch (iface) {
+        case SYSMAN_PORT_BROKER:
+                sysman_connection_broker(icall);
+                break;
+        case SYSMAN_PORT_CTL:
+                sysman_connection_ctl(icall);
+                break;
+        default:
+                /* Unknown interface */
+                async_answer_0(icall, ENOENT);
         }
 }