Index: uspace/lib/congfx/src/console.c =================================================================== --- uspace/lib/congfx/src/console.c (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/congfx/src/console.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -57,4 +57,7 @@ static errno_t console_gc_bitmap_render(void *, gfx_rect_t *, gfx_coord2_t *); static errno_t console_gc_bitmap_get_alloc(void *, gfx_bitmap_alloc_t *); +static errno_t console_gc_cursor_get_pos(void *, gfx_coord2_t *); +static errno_t console_gc_cursor_set_pos(void *, gfx_coord2_t *); +static errno_t console_gc_cursor_set_visible(void *, bool); gfx_context_ops_t console_gc_ops = { @@ -66,5 +69,8 @@ .bitmap_destroy = console_gc_bitmap_destroy, .bitmap_render = console_gc_bitmap_render, - .bitmap_get_alloc = console_gc_bitmap_get_alloc + .bitmap_get_alloc = console_gc_bitmap_get_alloc, + .cursor_get_pos = console_gc_cursor_get_pos, + .cursor_set_pos = console_gc_cursor_set_pos, + .cursor_set_visible = console_gc_cursor_set_visible }; @@ -435,4 +441,57 @@ } +/** Get cursor position on console GC. + * + * @param arg Console GC + * @param pos Place to store position + * + * @return EOK on success or an error code + */ +static errno_t console_gc_cursor_get_pos(void *arg, gfx_coord2_t *pos) +{ + console_gc_t *cgc = (console_gc_t *) arg; + sysarg_t col; + sysarg_t row; + errno_t rc; + + rc = console_get_pos(cgc->con, &col, &row); + if (rc != EOK) + return rc; + + pos->x = col; + pos->y = row; + return EOK; +} + +/** Set cursor position on console GC. + * + * @param arg Console GC + * @param pos New cursor position + * + * @return EOK on success or an error code + */ +static errno_t console_gc_cursor_set_pos(void *arg, gfx_coord2_t *pos) +{ + console_gc_t *cgc = (console_gc_t *) arg; + + console_set_pos(cgc->con, pos->x, pos->y); + return EOK; +} + +/** Set cursor visibility on console GC. + * + * @param arg Console GC + * @param visible @c true iff cursor should be made visible + * + * @return EOK on success or an error code + */ +static errno_t console_gc_cursor_set_visible(void *arg, bool visible) +{ + console_gc_t *cgc = (console_gc_t *) arg; + + console_cursor_visibility(cgc->con, visible); + return EOK; +} + /** @} */ Index: uspace/lib/gfx/include/gfx/cursor.h =================================================================== --- uspace/lib/gfx/include/gfx/cursor.h (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) +++ uspace/lib/gfx/include/gfx/cursor.h (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -0,0 +1,51 @@ +/* + * Copyright (c) 2021 Jiri Svoboda + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * - Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * - Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * - The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +/** @addtogroup libgfx + * @{ + */ +/** + * @file Hardware cursor control + */ + +#ifndef _GFX_CURSOR_H +#define _GFX_CURSOR_H + +#include +#include +#include +#include + +extern errno_t gfx_cursor_get_pos(gfx_context_t *, gfx_coord2_t *); +extern errno_t gfx_cursor_set_pos(gfx_context_t *, gfx_coord2_t *); +extern errno_t gfx_cursor_set_visible(gfx_context_t *, bool); + +#endif + +/** @} + */ Index: uspace/lib/gfx/include/types/gfx/ops/context.h =================================================================== --- uspace/lib/gfx/include/types/gfx/ops/context.h (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/gfx/include/types/gfx/ops/context.h (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -44,4 +44,5 @@ #include #include +#include /** Graphics context ops */ @@ -64,4 +65,10 @@ /** Get bitmap allocation info */ errno_t (*bitmap_get_alloc)(void *, gfx_bitmap_alloc_t *); + /** Get hardware cursor position */ + errno_t (*cursor_get_pos)(void *, gfx_coord2_t *); + /** Set hardware cursor position */ + errno_t (*cursor_set_pos)(void *, gfx_coord2_t *); + /** Set hardware cursor visibility */ + errno_t (*cursor_set_visible)(void *, bool); } gfx_context_ops_t; Index: uspace/lib/gfx/meson.build =================================================================== --- uspace/lib/gfx/meson.build (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/gfx/meson.build (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -1,4 +1,4 @@ # -# Copyright (c) 2019 Jiri Svoboda +# Copyright (c) 2021 Jiri Svoboda # All rights reserved. # @@ -32,4 +32,5 @@ 'src/coord.c', 'src/context.c', + 'src/cursor.c', 'src/render.c' ) @@ -39,4 +40,5 @@ 'test/color.c', 'test/coord.c', + 'test/cursor.c', 'test/main.c', 'test/render.c', Index: uspace/lib/gfx/src/cursor.c =================================================================== --- uspace/lib/gfx/src/cursor.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) +++ uspace/lib/gfx/src/cursor.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -0,0 +1,93 @@ +/* + * Copyright (c) 2021 Jiri Svoboda + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * - Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * - Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * - The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +/** @addtogroup libgfx + * @{ + */ +/** + * @file Hardware cursor control + */ + +#include +#include +#include +#include +#include +#include +#include "../private/context.h" + +/** Get hardware cursor position. + * + * @param gc Graphic context + * @param pos Place to store cursor position + * + * @return EOK on success, ENOTSUP if not supported, + * EIO if grahic device connection was lost + */ +errno_t gfx_cursor_get_pos(gfx_context_t *gc, gfx_coord2_t *pos) +{ + if (gc->ops->cursor_get_pos != NULL) + return gc->ops->cursor_get_pos(gc->arg, pos); + else + return ENOTSUP; +} + +/** Set hardware cursor position. + * + * @param gc Graphic context + * @param pos New cursor position + * + * @return EOK on success, ENOTSUP if not supported, + * EIO if grahic device connection was lost + */ +errno_t gfx_cursor_set_pos(gfx_context_t *gc, gfx_coord2_t *pos) +{ + if (gc->ops->cursor_set_pos != NULL) + return gc->ops->cursor_set_pos(gc->arg, pos); + else + return ENOTSUP; +} + +/** Set hardware cursor visibility. + * + * @param gc Graphic context + * @param visible @c true iff cursor should be made visible + * + * @return EOK on success, ENOTSUP if not supported, + * EIO if grahic device connection was lost + */ +errno_t gfx_cursor_set_visible(gfx_context_t *gc, bool visible) +{ + if (gc->ops->cursor_set_visible != NULL) + return gc->ops->cursor_set_visible(gc->arg, visible); + else + return ENOTSUP; +} + +/** @} + */ Index: uspace/lib/gfx/test/cursor.c =================================================================== --- uspace/lib/gfx/test/cursor.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) +++ uspace/lib/gfx/test/cursor.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -0,0 +1,265 @@ +/* + * Copyright (c) 2021 Jiri Svoboda + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * - Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * - Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * - The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include + +PCUT_INIT; + +PCUT_TEST_SUITE(cursor); + +static errno_t testgc_cursor_get_pos(void *, gfx_coord2_t *); +static errno_t testgc_cursor_set_pos(void *, gfx_coord2_t *); +static errno_t testgc_cursor_set_visible(void *, bool); + +static gfx_context_ops_t ops = { + .cursor_get_pos = testgc_cursor_get_pos, + .cursor_set_pos = testgc_cursor_set_pos, + .cursor_set_visible = testgc_cursor_set_visible +}; + +/** Test graphics context data */ +typedef struct { + errno_t rc; + + bool cursor_get_pos; + gfx_coord2_t get_pos_pos; + + bool cursor_set_pos; + gfx_coord2_t set_pos_pos; + + bool cursor_set_visible; + bool set_visible_vis; +} test_gc_t; + +/** Get hardware cursor position with error return */ +PCUT_TEST(cursor_get_pos_failure) +{ + errno_t rc; + gfx_coord2_t pos; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EIO; + + rc = gfx_cursor_get_pos(gc, &pos); + PCUT_ASSERT_ERRNO_VAL(tgc.rc, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_get_pos); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +/** Get hardware cursor position */ +PCUT_TEST(cursor_get_pos_success) +{ + errno_t rc; + gfx_coord2_t pos; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EOK; + tgc.get_pos_pos.x = 1; + tgc.get_pos_pos.y = 2; + + rc = gfx_cursor_get_pos(gc, &pos); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_get_pos); + PCUT_ASSERT_INT_EQUALS(tgc.get_pos_pos.x, pos.x); + PCUT_ASSERT_INT_EQUALS(tgc.get_pos_pos.y, pos.y); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +/** Set hardware cursor position with error return */ +PCUT_TEST(cursor_set_pos_failure) +{ + errno_t rc; + gfx_coord2_t pos; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EIO; + pos.x = 1; + pos.y = 2; + + rc = gfx_cursor_set_pos(gc, &pos); + PCUT_ASSERT_ERRNO_VAL(tgc.rc, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_pos); + PCUT_ASSERT_INT_EQUALS(pos.x, tgc.set_pos_pos.x); + PCUT_ASSERT_INT_EQUALS(pos.y, tgc.set_pos_pos.y); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +/** Set hardware cursor position */ +PCUT_TEST(cursor_set_pos_success) +{ + errno_t rc; + gfx_coord2_t pos; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EOK; + pos.x = 1; + pos.y = 2; + + rc = gfx_cursor_set_pos(gc, &pos); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_pos); + PCUT_ASSERT_INT_EQUALS(pos.x, tgc.set_pos_pos.x); + PCUT_ASSERT_INT_EQUALS(pos.y, tgc.set_pos_pos.y); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +/** Set hardware cursor visibility with error return */ +PCUT_TEST(cursor_set_visible_failure) +{ + errno_t rc; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EIO; + + rc = gfx_cursor_set_visible(gc, true); + PCUT_ASSERT_ERRNO_VAL(tgc.rc, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_visible); + PCUT_ASSERT_TRUE(tgc.set_visible_vis); + + tgc.cursor_set_visible = false; + + rc = gfx_cursor_set_visible(gc, false); + PCUT_ASSERT_ERRNO_VAL(tgc.rc, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_visible); + PCUT_ASSERT_FALSE(tgc.set_visible_vis); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +/** Set hardware cursor visibility */ +PCUT_TEST(cursor_set_visible_success) +{ + errno_t rc; + gfx_context_t *gc = NULL; + test_gc_t tgc; + + memset(&tgc, 0, sizeof(tgc)); + + rc = gfx_context_new(&ops, &tgc, &gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + tgc.rc = EOK; + + rc = gfx_cursor_set_visible(gc, true); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_visible); + PCUT_ASSERT_TRUE(tgc.set_visible_vis); + + tgc.cursor_set_visible = false; + + rc = gfx_cursor_set_visible(gc, false); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + PCUT_ASSERT_TRUE(tgc.cursor_set_visible); + PCUT_ASSERT_FALSE(tgc.set_visible_vis); + + rc = gfx_context_delete(gc); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); +} + +static errno_t testgc_cursor_get_pos(void *arg, gfx_coord2_t *pos) +{ + test_gc_t *tgc = (test_gc_t *) arg; + + tgc->cursor_get_pos = true; + *pos = tgc->get_pos_pos; + + return tgc->rc; +} + +static errno_t testgc_cursor_set_pos(void *arg, gfx_coord2_t *pos) +{ + test_gc_t *tgc = (test_gc_t *) arg; + + tgc->cursor_set_pos = true; + tgc->set_pos_pos = *pos; + + return tgc->rc; +} + +static errno_t testgc_cursor_set_visible(void *arg, bool visible) +{ + test_gc_t *tgc = (test_gc_t *) arg; + + tgc->cursor_set_visible = true; + tgc->set_visible_vis = visible; + + return tgc->rc; +} + +PCUT_EXPORT(cursor); Index: uspace/lib/gfx/test/main.c =================================================================== --- uspace/lib/gfx/test/main.c (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/gfx/test/main.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -1,4 +1,4 @@ /* - * Copyright (c) 2017 Jiri Svoboda + * Copyright (c) 2021 Jiri Svoboda * All rights reserved. * @@ -34,4 +34,5 @@ PCUT_IMPORT(color); PCUT_IMPORT(coord); +PCUT_IMPORT(cursor); PCUT_IMPORT(render); Index: uspace/lib/ui/private/entry.h =================================================================== --- uspace/lib/ui/private/entry.h (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/ui/private/entry.h (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -67,4 +67,6 @@ extern void ui_entry_backspace(ui_entry_t *); extern ui_evclaim_t ui_entry_key_press_unmod(ui_entry_t *, kbd_event_t *); +extern void ui_entry_activate(ui_entry_t *); +extern void ui_entry_deactivate(ui_entry_t *); #endif Index: uspace/lib/ui/src/entry.c =================================================================== --- uspace/lib/ui/src/entry.c (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/ui/src/entry.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -39,4 +39,5 @@ #include #include +#include #include #include @@ -62,6 +63,5 @@ ui_entry_vpad_text = 0, ui_entry_cursor_overshoot = 1, - ui_entry_cursor_width = 2, - ui_entry_cursor_width_text = 1 + ui_entry_cursor_width = 2 }; @@ -107,4 +107,5 @@ entry->halign = gfx_halign_left; *rentry = entry; + return EOK; } @@ -194,17 +195,18 @@ gfx_rect_t rect; gfx_font_metrics_t metrics; - gfx_coord_t w; errno_t rc; res = ui_window_get_res(entry->window); + if (res->textmode) { + rc = gfx_cursor_set_pos(res->gc, pos); + return rc; + } + gfx_font_get_metrics(res->font, &metrics); - - w = res->textmode ? ui_entry_cursor_width_text : - ui_entry_cursor_width; rect.p0.x = pos->x; rect.p0.y = pos->y - ui_entry_cursor_overshoot; - rect.p1.x = pos->x + w; + rect.p1.x = pos->x + ui_entry_cursor_width; rect.p1.y = pos->y + metrics.ascent + metrics.descent + 1 + ui_entry_cursor_overshoot; @@ -399,8 +401,6 @@ ui_entry_backspace(entry); - if (event->key == KC_ESCAPE) { - entry->active = false; - (void) ui_entry_paint(entry); - } + if (event->key == KC_ESCAPE) + ui_entry_deactivate(entry); return ui_claimed; @@ -475,15 +475,9 @@ if (gfx_pix_inside_rect(&pos, &entry->rect)) { - if (!entry->active) { - entry->active = true; - (void) ui_entry_paint(entry); - } + ui_entry_activate(entry); return ui_claimed; } else { - if (entry->active) { - entry->active = false; - (void) ui_entry_paint(entry); - } + ui_entry_deactivate(entry); } } @@ -518,4 +512,44 @@ } +/** Activate text entry. + * + * @param entry Text entry + */ +void ui_entry_activate(ui_entry_t *entry) +{ + ui_resource_t *res; + + res = ui_window_get_res(entry->window); + + if (entry->active) + return; + + entry->active = true; + (void) ui_entry_paint(entry); + + if (res->textmode) + gfx_cursor_set_visible(res->gc, true); +} + +/** Deactivate text entry. + * + * @param entry Text entry + */ +void ui_entry_deactivate(ui_entry_t *entry) +{ + ui_resource_t *res; + + res = ui_window_get_res(entry->window); + + if (!entry->active) + return; + + entry->active = false; + (void) ui_entry_paint(entry); + + if (res->textmode) + gfx_cursor_set_visible(res->gc, false); +} + /** @} */ Index: uspace/lib/ui/src/ui.c =================================================================== --- uspace/lib/ui/src/ui.c (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/ui/src/ui.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -128,4 +128,6 @@ return EIO; + console_cursor_visibility(console, false); + /* ws == ui_ws_console */ rc = ui_create_cons(console, &ui); @@ -203,6 +205,8 @@ if (ui->cgc != NULL) console_gc_delete(ui->cgc); - if (ui->console != NULL) + if (ui->console != NULL) { + console_cursor_visibility(ui->console, true); console_done(ui->console); + } if (ui->display != NULL) display_close(ui->display); Index: uspace/lib/ui/test/entry.c =================================================================== --- uspace/lib/ui/test/entry.c (revision 695111767fafc5271a762ff1be8ac2bd6229f2d7) +++ uspace/lib/ui/test/entry.c (revision bb14312c8c42ea170b99a8d6db9a607a3b2aba04) @@ -270,3 +270,38 @@ } +/** ui_entry_activate() / ui_entry_deactivate() */ +PCUT_TEST(activate_deactivate) +{ + errno_t rc; + ui_t *ui = NULL; + ui_window_t *window = NULL; + ui_wnd_params_t params; + ui_entry_t *entry; + + rc = ui_create_disp(NULL, &ui); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + ui_wnd_params_init(¶ms); + params.caption = "Hello"; + + rc = ui_window_create(ui, ¶ms, &window); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + PCUT_ASSERT_NOT_NULL(window); + + rc = ui_entry_create(window, "ABC", &entry); + PCUT_ASSERT_ERRNO_VAL(EOK, rc); + + PCUT_ASSERT_FALSE(entry->active); + + ui_entry_activate(entry); + PCUT_ASSERT_TRUE(entry->active); + + ui_entry_deactivate(entry); + PCUT_ASSERT_FALSE(entry->active); + + ui_entry_destroy(entry); + ui_window_destroy(window); + ui_destroy(ui); +} + PCUT_EXPORT(entry);