Changeset b8409b9 in mainline

Timestamp:

2024-11-22T19:01:05Z (6 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

b56d88f

Parents:

d0f0744

Message:

hr: RAID1: fix WRITE to rebuilt extent

When writing to extent that is being rebuilt, allow
writes only to (ba < current rebuild position).

Location:

uspace/srv/bd/hr

Files:

• raid1.c (modified) (3 diffs)
• var.h (modified) (1 diff)

uspace/srv/bd/hr/raid1.c

@@ -331 +331 @@
         case HR_BD_WRITE:
                 for (i = 0; i < vol->dev_no; i++) {
-                        if (vol->extents[i].status != HR_EXT_ONLINE)
+                        if (vol->extents[i].status != HR_EXT_ONLINE ||
+                            (vol->extents[i].status == HR_EXT_REBUILD &&
+                            ba >= vol->rebuild_blk))
+                                /*
+                                 * When the extent is being rebuilt,
+                                 * we only write to the part that is already
+                                 * rebuilt. If ba is more than vol->rebuild_blk,
+                                 * the write is going to be replicated later
+                                 * in the rebuild. TODO: test
+                                 */
                                 continue;
                         rc = block_write_direct(vol->extents[i].svc_id, ba, cnt,
@@ -395 +404 @@
         size_t hotspare_idx = vol->hotspare_no - 1;
 
+        vol->rebuild_blk = 0;
         vol->extents[bad].svc_id = vol->hotspares[hotspare_idx].svc_id;
         hr_update_ext_status(vol, bad, HR_EXT_REBUILD);
@@ -430 +440 @@
         hr_add_ba_offset(vol, &ba);
         while (left != 0) {
+                vol->rebuild_blk = ba;
                 cnt = min(max_blks, left);
                 for (size_t i = 0; i < vol->dev_no; i++) {

uspace/srv/bd/hr/var.h

@@ -73 +73 @@
         uint32_t strip_size;
 
+        uint64_t rebuild_blk;
+
         service_id_t svc_id;
         hr_vol_status_t status;