Changeset b7fd2a0 in mainline for uspace/srv/fs/mfs/mfs_dentry.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/fs/mfs/mfs_dentry.c (modified) (6 diffs)

uspace/srv/fs/mfs/mfs_dentry.c

@@ -42 +42 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_read_dentry(struct mfs_node *mnode,
     struct mfs_dentry_info *d_info, unsigned index)
@@ -52 +52 @@
         block_t *b;
 
-        int r = mfs_read_map(&block, mnode, index * sbi->dirsize);
+        errno_t r = mfs_read_map(&block, mnode, index * sbi->dirsize);
         if (r != EOK)
                 goto out_err;
@@ -105 +105 @@
  * @return       EOK on success or an error code.
  */
-int
+errno_t
 mfs_write_dentry(struct mfs_dentry_info *d_info)
 {
@@ -114 +114 @@
         block_t *b;
         uint32_t block;
-        int r;
+        errno_t r;
 
         r = mfs_read_map(&block, mnode, d_off_bytes);
@@ -156 +156 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_remove_dentry(struct mfs_node *mnode, const char *d_name)
 {
         struct mfs_sb_info *sbi = mnode->instance->sbi;
         struct mfs_dentry_info d_info;
-        int r;
+        errno_t r;
 
         const size_t name_len = str_size(d_name);
@@ -197 +197 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 mfs_insert_dentry(struct mfs_node *mnode, const char *d_name,
     fs_index_t d_inum)
 {
-        int r;
+        errno_t r;
         struct mfs_sb_info *sbi = mnode->instance->sbi;
         struct mfs_dentry_info d_info;