Changeset b7fd2a0 in mainline for uspace/app/netecho/comm.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/app/netecho/comm.c

    r36f0738 rb7fd2a0  
    7171        size_t pos;
    7272        size_t now;
    73         int rc;
     73        errno_t rc;
    7474
    7575        size = udp_rmsg_size(rmsg);
     
    109109}
    110110
    111 int comm_open_listen(const char *port_s)
     111errno_t comm_open_listen(const char *port_s)
    112112{
    113113        inet_ep2_t epp;
    114         int rc;
     114        errno_t rc;
    115115
    116116        char *endptr;
     
    142142}
    143143
    144 int comm_open_talkto(const char *hostport)
     144errno_t comm_open_talkto(const char *hostport)
    145145{
    146146        inet_ep2_t epp;
    147147        const char *errmsg;
    148         int rc;
     148        errno_t rc;
    149149
    150150        inet_ep2_init(&epp);
     
    182182}
    183183
    184 int comm_send(void *data, size_t size)
     184errno_t comm_send(void *data, size_t size)
    185185{
    186         int rc = udp_assoc_send_msg(assoc, &remote, data, size);
     186        errno_t rc = udp_assoc_send_msg(assoc, &remote, data, size);
    187187        if (rc != EOK)
    188188                return EIO;
Note: See TracChangeset for help on using the changeset viewer.