Changeset b7fd2a0 in mainline for uspace/app/df/df.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/app/df/df.c

    r36f0738 rb7fd2a0  
    5656static bool display_blocks;
    5757
    58 static int size_to_human_readable(uint64_t, size_t, char **);
     58static errno_t size_to_human_readable(uint64_t, size_t, char **);
    5959static void print_header(void);
    60 static int print_statfs(struct statfs *, char *, char *);
     60static errno_t print_statfs(struct statfs *, char *, char *);
    6161static void print_usage(void);
    6262
     
    6565        int optres, errflg = 0;
    6666        struct statfs st;
    67         int rc;
     67        errno_t rc;
    6868
    6969        display_blocks = false;
     
    128128}
    129129
    130 static int size_to_human_readable(uint64_t nblocks, size_t block_size, char **rptr)
     130static errno_t size_to_human_readable(uint64_t nblocks, size_t block_size, char **rptr)
    131131{
    132132        cap_spec_t cap;
     
    147147}
    148148
    149 static int print_statfs(struct statfs *st, char *name, char *mountpoint)
     149static errno_t print_statfs(struct statfs *st, char *name, char *mountpoint)
    150150{
    151151        uint64_t const used_blocks = st->f_blocks - st->f_bfree;
    152152        unsigned const perc_used = PERCENTAGE(used_blocks, st->f_blocks);
    153153        char *str;
    154         int rc;
     154        errno_t rc;
    155155
    156156        printf("%10s", name);
Note: See TracChangeset for help on using the changeset viewer.