Changeset b7fd2a0 in mainline for uspace/app/df/df.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/df/df.c (modified) (4 diffs)

uspace/app/df/df.c

@@ -56 +56 @@
 static bool display_blocks;
 
-static int size_to_human_readable(uint64_t, size_t, char **);
+static errno_t size_to_human_readable(uint64_t, size_t, char **);
 static void print_header(void);
-static int print_statfs(struct statfs *, char *, char *);
+static errno_t print_statfs(struct statfs *, char *, char *);
 static void print_usage(void);
 
@@ -65 +65 @@
         int optres, errflg = 0;
         struct statfs st;
-        int rc;
+        errno_t rc;
 
         display_blocks = false;
@@ -128 +128 @@
 }
 
-static int size_to_human_readable(uint64_t nblocks, size_t block_size, char **rptr)
+static errno_t size_to_human_readable(uint64_t nblocks, size_t block_size, char **rptr)
 {
         cap_spec_t cap;
@@ -147 +147 @@
 }
 
-static int print_statfs(struct statfs *st, char *name, char *mountpoint)
+static errno_t print_statfs(struct statfs *st, char *name, char *mountpoint)
 {
         uint64_t const used_blocks = st->f_blocks - st->f_bfree;
         unsigned const perc_used = PERCENTAGE(used_blocks, st->f_blocks);
         char *str;
-        int rc;
+        errno_t rc;
 
         printf("%10s", name);