Changes in / [135486d:b546231] in mainline

Files:

• boot/Makefile.common (modified) (1 diff)
• uspace/Makefile (modified) (1 diff)
• uspace/app/sportdmp/sportdmp.c (modified) (1 diff)
• uspace/drv/char/ns8250/cyclic_buffer.h (modified) (1 diff)
• uspace/drv/char/ns8250/ns8250.c (modified) (11 diffs)
• uspace/lib/c/include/ipc/input.h (modified) (1 diff)
• uspace/lib/c/include/ipc/mouseev.h (modified) (1 diff)
• uspace/srv/hid/console/console.c (modified) (2 diffs)
• uspace/srv/hid/input/generic/input.c (modified) (1 diff)
• uspace/srv/hid/input/include/mouse.h (modified) (1 diff)
• uspace/srv/hid/input/proto/mousedev.c (modified) (1 diff)
• uspace/srv/hid/isdv4_tablet/Makefile (added)
• uspace/srv/hid/isdv4_tablet/isdv4.c (added)
• uspace/srv/hid/isdv4_tablet/isdv4.h (added)
• uspace/srv/hid/isdv4_tablet/main.c (added)

boot/Makefile.common

@@ -108 +108 @@
         $(USPACE_PATH)/srv/fs/ext4fs/ext4fs \
         $(USPACE_PATH)/srv/hid/remcons/remcons \
+        $(USPACE_PATH)/srv/hid/isdv4_tablet/isdv4_tablet \
         $(USPACE_PATH)/srv/net/ethip/ethip \
         $(USPACE_PATH)/srv/net/inetsrv/inetsrv \

uspace/Makefile

@@ -101 +101 @@
         srv/hid/console \
         srv/hid/s3c24xx_ts \
+        srv/hid/isdv4_tablet \
         srv/hid/fb \
         srv/hid/input \

uspace/app/sportdmp/sportdmp.c

@@ -140 +140 @@
                 ssize_t i;
                 for (i = 0; i < read; i++) {
-                        if ((buf[i] >= 32) && (buf[i] < 128))
-                                putchar((wchar_t) buf[i]);
-                        else
-                                putchar('.');
-                        fflush(stdout);
+                        printf("%02hhx ", buf[i]);
                 }
+                fflush(stdout);
         }
         

uspace/drv/char/ns8250/cyclic_buffer.h

@@ -36 +36 @@
 #define CYCLIC_BUFFER_H_
 
-#define BUF_LEN 256
+#define BUF_LEN 4096
 
 typedef struct cyclic_buffer {

uspace/drv/char/ns8250/ns8250.c

@@ -82 +82 @@
 /** Interrupt ID Register definition. */
 #define NS8250_IID_ACTIVE       (1 << 0)
+#define NS8250_IID_CAUSE_MASK 0x0e
+#define NS8250_IID_CAUSE_RXSTATUS 0x06
 
 /** FIFO Control Register definition. */
@@ -179 +181 @@
         /** The fibril mutex for synchronizing the access to the device. */
         fibril_mutex_t mutex;
+        /** Indicates that some data has become available */
+        fibril_condvar_t input_buffer_available;
         /** True if device is removed. */
         bool removed;
@@ -238 +242 @@
 {
         ns8250_t *ns = NS8250(fun);
-        int ret = EOK;
+        int ret = 0;
+        
+        if (count == 0) return 0;
         
         fibril_mutex_lock(&ns->mutex);
+        while (buf_is_empty(&ns->input_buffer))
+                fibril_condvar_wait(&ns->input_buffer_available, &ns->mutex);
         while (!buf_is_empty(&ns->input_buffer) && (size_t)ret < count) {
                 buf[ret] = (char)buf_pop_front(&ns->input_buffer);
@@ -460 +468 @@
 {
         /* Interrupt when data received. */
-        pio_write_8(&regs->ier, NS8250_IER_RXREADY);
+        pio_write_8(&regs->ier, NS8250_IER_RXREADY | NS8250_IER_RXSTATUS);
         pio_write_8(&regs->mcr, NS8250_MCR_DTR | NS8250_MCR_RTS 
             | NS8250_MCR_OUT2);
@@ -499 +507 @@
         async_exchange_end(exch);
 
+        /* Read LSR to clear possible previous LSR interrupt */
+        pio_read_8(&ns->regs->lsr);
+
         /* Enable interrupt on the serial port. */
         ns8250_port_interrupts_enable(ns->regs);
@@ -695 +706 @@
         /* 8 bits, no parity, two stop bits. */
         ns8250_port_set_com_props(ns->regs, SERIAL_NO_PARITY, 8, 2);
-        /* Enable FIFO, clear them, with 14-byte threshold. */
+        /*
+         * Enable FIFO, clear them, with 4-byte threshold for greater
+         * reliability.
+         */
         pio_write_8(&ns->regs->iid, NS8250_FCR_FIFOENABLE
-            | NS8250_FCR_RXFIFORESET | NS8250_FCR_TXFIFORESET 
-            | NS8250_FCR_RXTRIGGERLOW | NS8250_FCR_RXTRIGGERHI);
+            | NS8250_FCR_RXFIFORESET | NS8250_FCR_TXFIFORESET
+            | NS8250_FCR_RXTRIGGERLOW);
         /*
          * RTS/DSR set (Request to Send and Data Terminal Ready lines enabled),
@@ -731 +745 @@
         bool cont = true;
         
+        fibril_mutex_lock(&ns->mutex);
         while (cont) {
-                fibril_mutex_lock(&ns->mutex);
-                
                 cont = ns8250_received(regs);
                 if (cont) {
@@ -739 +752 @@
                         
                         if (ns->client_connected) {
+                                bool buf_was_empty = buf_is_empty(&ns->input_buffer);
                                 if (!buf_push_back(&ns->input_buffer, val)) {
                                         ddf_msg(LVL_WARN, "Buffer overflow on "
                                             "%s.", ns->dev->name);
+                                        break;
                                 } else {
                                         ddf_msg(LVL_DEBUG2, "Character %c saved "
                                             "to the buffer of %s.",
                                             val, ns->dev->name);
+                                        if (buf_was_empty)
+                                                fibril_condvar_broadcast(&ns->input_buffer_available);
                                 }
                         }
                 }
-                
-                fibril_mutex_unlock(&ns->mutex);
-                fibril_yield();
-        }
+        }
+        fibril_mutex_unlock(&ns->mutex);
+        fibril_yield();
 }
 
 /** The interrupt handler.
  *
- * The serial port is initialized to interrupt when some data come, so the
- * interrupt is handled by reading the incomming data.
+ * The serial port is initialized to interrupt when some data come or line
+ * status register changes, so the interrupt is handled by reading the incoming
+ * data and reading the line status register.
  *
  * @param dev           The serial port device.
@@ -765 +782 @@
     ipc_call_t *icall)
 {
-        ns8250_read_from_device(NS8250_FROM_DEV(dev));
+        ns8250_t *ns = NS8250_FROM_DEV(dev);
+
+        uint8_t iir = pio_read_8(&ns->regs->iid);
+        if ((iir & NS8250_IID_CAUSE_MASK) == NS8250_IID_CAUSE_RXSTATUS) {
+                uint8_t lsr = pio_read_8(&ns->regs->lsr);
+                if (lsr & NS8250_LSR_OE) {
+                        ddf_msg(LVL_WARN, "Overrun error on %s", ns->dev->name);
+                }
+        }
+        
+        ns8250_read_from_device(ns);
 }
 
@@ -811 +838 @@
         
         fibril_mutex_initialize(&ns->mutex);
+        fibril_condvar_initialize(&ns->input_buffer_available);
         ns->dev = dev;
         
@@ -1053 +1081 @@
 static void ns8250_init(void)
 {
-        ddf_log_init(NAME, LVL_ERROR);
+        ddf_log_init(NAME, LVL_WARN);
         
         ns8250_dev_ops.open = &ns8250_open;

uspace/lib/c/include/ipc/input.h

@@ -46 +46 @@
         INPUT_EVENT_KEY = IPC_FIRST_USER_METHOD,
         INPUT_EVENT_MOVE,
+        INPUT_EVENT_ABS_MOVE,
         INPUT_EVENT_BUTTON
 } input_notif_t;

uspace/lib/c/include/ipc/mouseev.h

@@ -47 +47 @@
 typedef enum {
         MOUSEEV_MOVE_EVENT = IPC_FIRST_USER_METHOD,
+        MOUSEEV_ABS_MOVE_EVENT,
         MOUSEEV_BUTTON_EVENT
 } mouseev_notif_t;

uspace/srv/hid/console/console.c

@@ -383 +383 @@
         
         fb_pointer_update(fb_sess, mouse.x, mouse.y, true);
+}
+
+static void cons_mouse_abs_move(sysarg_t x, sysarg_t y,
+    sysarg_t max_x, sysarg_t max_y)
+{
+        if (max_x && max_y) {
+                mouse.x = limit(x * xres / max_x, 0, xres);
+                mouse.y = limit(y * yres / max_y, 0, yres);
+                
+                fb_pointer_update(fb_sess, mouse.x, mouse.y, true);
+        }
 }
 
@@ -503 +514 @@
                         async_answer_0(callid, EOK);
                         break;
+                case INPUT_EVENT_ABS_MOVE:
+                        cons_mouse_abs_move(IPC_GET_ARG1(call), IPC_GET_ARG2(call),
+                            IPC_GET_ARG3(call), IPC_GET_ARG4(call));
+                        async_answer_0(callid, EOK);
+                        break;
                 case INPUT_EVENT_BUTTON:
                         /* Got pointer button press/release event */

uspace/srv/hid/input/generic/input.c

@@ -189 +189 @@
         }
         async_exchange_end(exch);
+}
+
+/** Mouse pointer has moved in absolute mode. */
+void mouse_push_event_abs_move(mouse_dev_t *mdev, unsigned int x, unsigned int y,
+    unsigned int max_x, unsigned int max_y)
+{
+        if (max_x && max_y) {
+                async_exch_t *exch = async_exchange_begin(client_sess);
+                async_msg_4(exch, INPUT_EVENT_ABS_MOVE, x, y, max_x, max_y);
+                async_exchange_end(exch);
+        }
 }
 

uspace/srv/hid/input/include/mouse.h

@@ -63 +63 @@
 extern void mouse_push_data(mouse_dev_t *, sysarg_t);
 extern void mouse_push_event_move(mouse_dev_t *, int, int, int);
+extern void mouse_push_event_abs_move(mouse_dev_t *, unsigned int, unsigned int,
+    unsigned int, unsigned int);
 extern void mouse_push_event_button(mouse_dev_t *, int, int);
 

uspace/srv/hid/input/proto/mousedev.c

@@ -96 +96 @@
                         retval = EOK;
                         break;
+                case MOUSEEV_ABS_MOVE_EVENT:
+                        mouse_push_event_abs_move(mousedev->mouse_dev,
+                                IPC_GET_ARG1(call), IPC_GET_ARG2(call),
+                                IPC_GET_ARG3(call), IPC_GET_ARG4(call));
+                        retval = EOK;
+                        break;
                 case MOUSEEV_BUTTON_EVENT:
                         mouse_push_event_button(mousedev->mouse_dev,