Changeset b00255a in mainline

Timestamp:

2012-05-04T11:40:50Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

738b549

Parents:

35a35651

Message:

Use bool and more descriptive variable names

File:

• uspace/app/bdsh/cmds/modules/mkdir/mkdir.c (modified) (7 diffs)

uspace/app/bdsh/cmds/modules/mkdir/mkdir.c

@@ -83 +83 @@
 /* This is kind of clunky, but effective for now */
 static unsigned int
-create_directory(const char *path, unsigned int p)
+create_directory(const char *path, bool create_parents)
 {
         DIR *dirp;
@@ -107 +107 @@
 
         /* Typical use without specifying the creation of parents */
-        if (p == 0) {
+        if (!create_parents) {
                 dirp = opendir(tmp);
                 if (dirp) {
@@ -182 +182 @@
 int cmd_mkdir(char **argv)
 {
-        unsigned int argc, create_parents = 0, i, ret = 0, follow = 0;
-        unsigned int verbose = 0;
+        unsigned int argc, i, ret = 0;
+        bool create_parents = false, follow = false, verbose = false;
         int c, opt_ind;
         char *cwd;
@@ -193 +193 @@
                 switch (c) {
                 case 'p':
-                        create_parents = 1;
+                        create_parents = true;
                         break;
                 case 'v':
-                        verbose = 1;
+                        verbose = true;
                         break;
                 case 'h':
@@ -205 +205 @@
                         return CMD_SUCCESS;
                 case 'f':
-                        follow = 1;
+                        follow = true;
                         break;
                 case 'm':
@@ -230 +230 @@
 
         for (i = optind; argv[i] != NULL; i++) {
-                if (verbose == 1)
+                if (verbose)
                         printf("%s: creating %s%s\n",
                                 cmdname, argv[i],
@@ -237 +237 @@
         }
 
-        if (follow == 0)
+        if (follow)
                 chdir(cwd);