Changes in uspace/lib/usbdev/src/altiface.c [160b75e:ab27e01] in mainline

File:

• uspace/lib/usbdev/src/altiface.c (modified) (9 diffs)

uspace/lib/usbdev/src/altiface.c

@@ -48 +48 @@
  * @return Number of alternate interfaces for @p interface_no interface.
  */
-size_t usb_interface_count_alternates(uint8_t *config_descr,
+size_t usb_interface_count_alternates(const uint8_t *config_descr,
     size_t config_descr_size, uint8_t interface_no)
 {
@@ -54 +54 @@
         assert(config_descr_size > 0);
 
-        usb_dp_parser_t dp_parser = {
+        const usb_dp_parser_t dp_parser = {
                 .nesting = usb_dp_standard_descriptor_nesting
         };
-        usb_dp_parser_data_t dp_data = {
+        const usb_dp_parser_data_t dp_data = {
                 .data = config_descr,
                 .size = config_descr_size,
@@ -65 +65 @@
         size_t alternate_count = 0;
 
-        uint8_t *iface_ptr = usb_dp_get_nested_descriptor(&dp_parser,
+        const uint8_t *iface_ptr = usb_dp_get_nested_descriptor(&dp_parser,
             &dp_data, config_descr);
         while (iface_ptr != NULL) {
@@ -90 +90 @@
  * @return Error code.
  */
-int usb_alternate_interfaces_create(uint8_t *config_descr,
-    size_t config_descr_size, int interface_number,
-    usb_alternate_interfaces_t **alternates_ptr)
+int usb_alternate_interfaces_init(usb_alternate_interfaces_t *alternates,
+    const uint8_t *config_descr, size_t config_descr_size, int interface_number)
 {
-        assert(alternates_ptr != NULL);
+        assert(alternates != NULL);
         assert(config_descr != NULL);
         assert(config_descr_size > 0);
 
+        alternates->alternatives = NULL;
+        alternates->alternative_count = 0;
+        alternates->current = 0;
+
         if (interface_number < 0) {
-                alternates_ptr = NULL;
                 return EOK;
-        }
-
-        usb_alternate_interfaces_t *alternates
-            = malloc(sizeof(usb_alternate_interfaces_t));
-
-        if (alternates == NULL) {
-                return ENOMEM;
         }
 
@@ -115 +110 @@
 
         if (alternates->alternative_count == 0) {
-                free(alternates);
                 return ENOENT;
         }
 
-        alternates->alternatives = malloc(alternates->alternative_count
-            * sizeof(usb_alternate_interface_descriptors_t));
+        alternates->alternatives = calloc(alternates->alternative_count,
+            sizeof(usb_alternate_interface_descriptors_t));
         if (alternates->alternatives == NULL) {
-                free(alternates);
                 return ENOMEM;
         }
 
-        alternates->current = 0;
-
-        usb_dp_parser_t dp_parser = {
+        const usb_dp_parser_t dp_parser = {
                 .nesting = usb_dp_standard_descriptor_nesting
         };
-        usb_dp_parser_data_t dp_data = {
+        const usb_dp_parser_data_t dp_data = {
                 .data = config_descr,
                 .size = config_descr_size,
@@ -140 +131 @@
             = &alternates->alternatives[0];
 
-        uint8_t *iface_ptr = usb_dp_get_nested_descriptor(&dp_parser,
+        const uint8_t *iface_ptr = usb_dp_get_nested_descriptor(&dp_parser,
             &dp_data, dp_data.data);
         while (iface_ptr != NULL) {
@@ -148 +139 @@
                     || (iface->interface_number != interface_number)) {
                         iface_ptr = usb_dp_get_sibling_descriptor(&dp_parser,
-                            &dp_data,
-                            dp_data.data, iface_ptr);
+                            &dp_data, dp_data.data, iface_ptr);
                         continue;
                 }
@@ -160 +150 @@
                     dp_data.data, iface_ptr);
                 if (iface_ptr == NULL) {
-                        uint8_t *next = dp_data.data + dp_data.size;
+                        const uint8_t *next = dp_data.data + dp_data.size;
                         cur_alt_iface->nested_descriptors_size
                             = next - cur_alt_iface->nested_descriptors;
@@ -171 +161 @@
         }
 
-        *alternates_ptr = alternates;
-
         return EOK;
 }
 
-
+void usb_alternate_interfaces_deinit(usb_alternate_interfaces_t *alternate)
+{
+        if (!alternate)
+                return;
+        free(alternate->alternatives);
+}
 /**
  * @}