Changeset a9bbe48d in mainline for uspace/app/trace

Timestamp:

2010-01-27T22:23:50Z (16 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e7aa9f4

Parents:

95e6c4f (diff), 1ccafee (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge formatting macros for userspace.

Location:

uspace/app/trace

Files:

• ipcp.c (modified) (4 diffs)
• trace.c (modified) (8 diffs)

uspace/app/trace/ipcp.c

@@ -36 +36 @@
 #include <stdlib.h>
 #include <adt/hash_table.h>
+#include <sys/typefmt.h>
 
 #include "ipc_desc.h"
@@ -200 +201 @@
 
         if ((display_mask & DM_IPC) != 0) {
-                printf("Call ID: 0x%lx, phone: %d, proto: %s, method: ", hash,
+                printf("Call ID: %p, phone: %d, proto: %s, method: ", hash,
                         phone, (proto ? proto->name : "n/a"));
                 ipc_m_print(proto, IPC_GET_METHOD(*call));
-                printf(" args: (%lu, %lu, %lu, %lu, %lu)\n", args[1], args[2],
+                printf(" args: (%" PRIuIPCARG ", %" PRIuIPCARG ", %" PRIuIPCARG
+                    ", %" PRIuIPCARG ", %" PRIuIPCARG ")\n", args[1], args[2],
                     args[3], args[4], args[5]);
         }
@@ -279 +281 @@
 
         if ((display_mask & DM_IPC) != 0) {
-                printf("Response to 0x%lx: retval=%ld, args = (%lu, %lu, %lu, %lu, %lu)\n",
-                        hash, retval, IPC_GET_ARG1(*answer),
-                        IPC_GET_ARG2(*answer), IPC_GET_ARG3(*answer),
-                        IPC_GET_ARG4(*answer), IPC_GET_ARG5(*answer));
+                printf("Response to %p: retval=%ld, args = (%" PRIuIPCARG
+                    ", %" PRIuIPCARG ", %" PRIuIPCARG ", %" PRIuIPCARG
+                    ", %" PRIuIPCARG ")\n",
+                    hash, retval, IPC_GET_ARG1(*answer),
+                    IPC_GET_ARG2(*answer), IPC_GET_ARG3(*answer),
+                    IPC_GET_ARG4(*answer), IPC_GET_ARG5(*answer));
         }
 
@@ -336 +340 @@
                 /* Not a response */
                 if ((display_mask & DM_IPC) != 0) {
-                        printf("Not a response (hash 0x%lx)\n", hash);
+                        printf("Not a response (hash %p)\n", hash);
                 }
                 return;

uspace/app/trace/trace.c

@@ -49 +49 @@
 #include <io/keycode.h>
 #include <fibril_synch.h>
+#include <sys/types.h>
+#include <sys/typefmt.h>
 
 #include <libc.h>
@@ -159 +161 @@
         if (rc < 0) {
                 printf("Error connecting\n");
-                printf("ipc_connect_task(%lld) -> %d ", task_id, rc);
+                printf("ipc_connect_task(%" PRIdTASKID ") -> %d ", task_id, rc);
                 return rc;
         }
@@ -198 +200 @@
         printf("Threads:");
         for (i = 0; i < n_threads; i++) {
-                printf(" [%d] (hash 0x%lx)", 1+i, thread_hash_buf[i]);
+                printf(" [%d] (hash %p)", 1+i, thread_hash_buf[i]);
         }
         printf("\ntotal of %u threads\n", tb_needed / sizeof(uintptr_t));
@@ -222 +224 @@
         case V_HASH:
         case V_PTR:
-                printf("0x%08lx", val);
+                printf("%p", val);
                 break;
 
@@ -275 +277 @@
 
         putchar('(');
-        if (n > 0) printf("%ld", sc_args[0]);
+        if (n > 0) printf("%" PRIdSYSARG, sc_args[0]);
         for (i = 1; i < n; i++) {
-                printf(", %ld", sc_args[i]);
+                printf(", %" PRIdSYSARG, sc_args[i]);
         }
         putchar(')');
@@ -508 +510 @@
         }
 
-        printf("Start tracing thread [%d] (hash 0x%lx).\n", thread_id, thread_hash);
+        printf("Start tracing thread [%d] (hash %p).\n", thread_id, thread_hash);
 
         while (!abort_trace) {
@@ -552 +554 @@
                                 break;
                         case UDEBUG_EVENT_THREAD_E:
-                                printf("Thread 0x%lx exited.\n", val0);
+                                printf("Thread %p exited.\n", val0);
                                 fibril_mutex_lock(&state_lock);
                                 abort_trace = true;
@@ -972 +974 @@
         rc = connect_task(task_id);
         if (rc < 0) {
-                printf("Failed connecting to task %lld.\n", task_id);
+                printf("Failed connecting to task %" PRIdTASKID ".\n", task_id);
                 return 1;
         }
 
-        printf("Connected to task %lld.\n", task_id);
+        printf("Connected to task %" PRIdTASKID ".\n", task_id);
 
         if (task_ldr != NULL)