Changeset a940f1d in mainline

Timestamp:

2013-07-15T19:37:32Z (11 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f3386d7, f4a27304

Parents:

12df1f1

Message:

am335x: the NEWIRQAGR bit of the ISR must be set *after* calling the interrupt handler which
deasserts the interrupt condition at the peripheral side.

Fixes the problem with ghost interrupts in the timer driver.

Location:

kernel

Files:

• arch/arm32/src/mach/beaglebone/beaglebone.c (modified) (2 diffs)
• genarch/src/drivers/am335x/timer.c (modified) (1 diff)

kernel/arch/arm32/src/mach/beaglebone/beaglebone.c

@@ -177 +177 @@
 {
         const unsigned inum = am335x_irc_inum_get(bbone.irc_addr);
-        am335x_irc_irq_ack(bbone.irc_addr);
 
         irq_t *irq = irq_dispatch_and_lock(inum);
@@ -187 +186 @@
                 printf("Spurious interrupt\n");
         }
+
+        am335x_irc_irq_ack(bbone.irc_addr);
 }
 

kernel/genarch/src/drivers/am335x/timer.c

@@ -119 +119 @@
         /* Disable compare mode */
         tclr &= ~AM335x_TIMER_TCLR_CE_FLAG;
-        /* Enable the prescaler, divisor = 2 */
-        tclr |= AM335x_TIMER_TCLR_PRE_FLAG;
-        tclr &= ~(AM335x_TIMER_TCLR_PTV_MASK << AM335x_TIMER_TCLR_PTV_SHIFT);
+
         /* Enable auto-reload mode */
         tclr |= AM335x_TIMER_TCLR_AR_FLAG;