Changeset a46da63 in mainline for libc/generic/async.c

Timestamp:

2006-06-16T20:50:51Z (19 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

153a209

Parents:

b34fab6

Message:

big code cleanup, compile with -Wall -Werror to enforce better coding
there is currently one warning that requires attention, please review

File:

• libc/generic/async.c (modified) (12 diffs)

libc/generic/async.c

@@ -27 +27 @@
  */
 
- /** @addtogroup libc
+/** @addtogroup libc
  * @{
  */
@@ -374 +374 @@
         PS_connection = (connection_t *)arg;
         PS_connection->cthread(PS_connection->callid, &PS_connection->call);
+        
         /* Remove myself from connection hash table */
         futex_down(&async_futex);
@@ -379 +380 @@
         hash_table_remove(&conn_hash_table, &key, 1);
         futex_up(&async_futex);
+        
         /* Answer all remaining messages with ehangup */
         while (!list_empty(&PS_connection->msg_queue)) {
@@ -390 +392 @@
         if (PS_connection->close_callid)
                 ipc_answer_fast(PS_connection->close_callid, 0, 0, 0);
+        
+        return 0;
 }
 
@@ -406 +410 @@
  * @return New thread id
  */
-pstid_t async_new_connection(ipcarg_t in_phone_hash,ipc_callid_t callid, 
-                             ipc_call_t *call,
-                             void (*cthread)(ipc_callid_t,ipc_call_t *))
-{
-        pstid_t ptid;
+pstid_t async_new_connection(ipcarg_t in_phone_hash,ipc_callid_t callid, ipc_call_t *call, void (*cthread)(ipc_callid_t, ipc_call_t *))
+{
         connection_t *conn;
         unsigned long key;
@@ -515 +516 @@
         while (1) {
                 if (psthread_schedule_next_adv(PS_FROM_MANAGER)) {
-                        futex_up(&async_futex); /* async_futex is always held
-                                                * when entering manager thread
-                                                */
+                        futex_up(&async_futex); 
+                        /* async_futex is always held
+                         * when entering manager thread
+                         */
                         continue;
                 }
@@ -547 +549 @@
                 handle_call(callid, &call);
         }
+        
+        return 0;
 }
 
@@ -558 +562 @@
 static int async_manager_thread(void *arg)
 {
-        futex_up(&async_futex); /* async_futex is always locked when entering
-                                * manager */
+        futex_up(&async_futex);
+        /* async_futex is always locked when entering
+         * manager */
         async_manager_worker();
+        
+        return 0;
 }
 
@@ -586 +593 @@
         }
         
+        return 0;
 }
 
@@ -680 +688 @@
 {
         amsg_t *msg = (amsg_t *) amsgid;
-        connection_t *conn;
 
         futex_down(&async_futex);
@@ -712 +719 @@
 {
         amsg_t *msg = (amsg_t *) amsgid;
-        connection_t *conn;
 
         /* TODO: Let it go through the event read at least once */
@@ -803 +809 @@
 
 
- /** @}
- */
- 
- 
+/** @}
+ */