Changeset a3fcfba in mainline

Timestamp:

2012-06-13T22:03:59Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

75b9c3d

Parents:

3f57fb7

Message:

In loc print server name instead of handle.

Location:

uspace

Files:

• app/loc/loc.c (modified) (2 diffs)
• lib/c/generic/loc.c (modified) (1 diff)
• lib/c/include/ipc/loc.h (modified) (1 diff)
• lib/c/include/loc.h (modified) (1 diff)
• srv/locsrv/locsrv.c (modified) (2 diffs)

uspace/app/loc/loc.c

@@ -48 +48 @@
         size_t svc_cnt;
         char *svc_name;
+        char *server_name;
         int rc;
         size_t j;
@@ -67 +68 @@
                         continue;
                 }
-                printf("\t%s (%" PRIun ")\n", svc_name, svc_ids[j]);
+
+                rc = loc_service_get_server_name(svc_ids[j], &server_name);
+                if (rc != EOK && rc != EINVAL) {
+                        free(svc_name);
+                        printf(NAME ": Unknown service name (SID %"
+                            PRIun ").\n", svc_ids[j]);
+                        continue;
+                }
+
+                if (rc == EOK)
+                        printf("\t%s : %s\n", svc_name, server_name);
+                else
+                        printf("\t%s\n", svc_name);
+        
                 free(svc_name);
+                free(server_name);
         }
 

uspace/lib/c/generic/loc.c

@@ -450 +450 @@
 }
 
+/** Get service server name.
+ *
+ * Provided ID of a service, return the name of its server.
+ *
+ * @param svc_id        Service ID
+ * @param name          Place to store pointer to new string. Caller should
+ *                      free it using free().
+ * @return              EOK on success or negative error code
+ */
+int loc_service_get_server_name(service_id_t svc_id, char **name)
+{
+        return loc_get_name_internal(LOC_SERVICE_GET_SERVER_NAME, svc_id, name);
+}
+
 int loc_namespace_get_id(const char *name, service_id_t *handle,
     unsigned int flags)

uspace/lib/c/include/ipc/loc.h

@@ -56 +56 @@
         LOC_SERVICE_GET_ID,
         LOC_SERVICE_GET_NAME,
+        LOC_SERVICE_GET_SERVER_NAME,
         LOC_NAMESPACE_GET_ID,
         LOC_CALLBACK_CREATE,

uspace/lib/c/include/loc.h

@@ -56 +56 @@
     unsigned int);
 extern int loc_service_get_name(service_id_t, char **);
+extern int loc_service_get_server_name(service_id_t, char **);
 extern int loc_namespace_get_id(const char *, service_id_t *,
     unsigned int);

uspace/srv/locsrv/locsrv.c

@@ -656 +656 @@
 }
 
+static void loc_service_get_server_name(ipc_callid_t iid, ipc_call_t *icall)
+{
+        ipc_callid_t callid;
+        size_t size;
+        size_t act_size;
+        loc_service_t *svc;
+        
+        if (!async_data_read_receive(&callid, &size)) {
+                async_answer_0(callid, EREFUSED);
+                async_answer_0(iid, EREFUSED);
+                return;
+        }
+        
+        fibril_mutex_lock(&services_list_mutex);
+        
+        svc = loc_service_find_id(IPC_GET_ARG1(*icall));
+        if (svc == NULL) {
+                fibril_mutex_unlock(&services_list_mutex);
+                async_answer_0(callid, ENOENT);
+                async_answer_0(iid, ENOENT);
+                return;
+        }
+        
+        if (svc->server == NULL) {
+                fibril_mutex_unlock(&services_list_mutex);
+                async_answer_0(callid, EINVAL);
+                async_answer_0(iid, EINVAL);
+                return;
+        }
+        
+        act_size = str_size(svc->server->name);
+        if (act_size > size) {
+                fibril_mutex_unlock(&services_list_mutex);
+                async_answer_0(callid, EOVERFLOW);
+                async_answer_0(iid, EOVERFLOW);
+                return;
+        }
+        
+        sysarg_t retval = async_data_read_finalize(callid, svc->server->name,
+            min(size, act_size));
+        
+        fibril_mutex_unlock(&services_list_mutex);
+        
+        async_answer_0(iid, retval);
+}
+
 /** Connect client to the service.
  *
@@ -1404 +1450 @@
                 case LOC_SERVICE_GET_NAME:
                         loc_service_get_name(callid, &call);
+                        break;
+                case LOC_SERVICE_GET_SERVER_NAME:
+                        loc_service_get_server_name(callid, &call);
                         break;
                 case LOC_NAMESPACE_GET_ID: