Changes in / [d1538a1:a1e2df13] in mainline

Files:

• boot/Makefile.common (modified) (1 diff)
• uspace/Makefile (modified) (1 diff)
• uspace/srv/net/dnsres/Makefile (added)
• uspace/srv/net/dnsres/dns_msg.c (added)
• uspace/srv/net/dnsres/dns_msg.h (added)
• uspace/srv/net/dnsres/dns_std.h (added)
• uspace/srv/net/dnsres/dns_type.h (added)
• uspace/srv/net/dnsres/dnsres.c (added)
• uspace/srv/net/dnsres/query.c (added)
• uspace/srv/net/dnsres/query.h (added)
• uspace/srv/net/dnsres/transport.c (added)
• uspace/srv/net/dnsres/transport.h (added)
• uspace/srv/net/inetsrv/addrobj.c (modified) (1 diff)
• uspace/srv/net/inetsrv/inet_link.c (modified) (1 diff)
• uspace/srv/net/udp/assoc.c (modified) (2 diffs)
• uspace/srv/net/udp/assoc.h (modified) (1 diff)
• uspace/srv/net/udp/sock.c (modified) (5 diffs)
• uspace/srv/net/udp/ucall.c (modified) (2 diffs)
• uspace/srv/net/udp/ucall.h (modified) (1 diff)
• uspace/srv/net/udp/udp_type.h (modified) (2 diffs)

boot/Makefile.common

@@ -113 +113 @@
         $(USPACE_PATH)/srv/hid/remcons/remcons \
         $(USPACE_PATH)/srv/hid/isdv4_tablet/isdv4_tablet \
+        $(USPACE_PATH)/srv/net/dnsres/dnsres \
         $(USPACE_PATH)/srv/net/ethip/ethip \
         $(USPACE_PATH)/srv/net/inetsrv/inetsrv \

uspace/Makefile

@@ -83 +83 @@
         srv/devman \
         srv/loader \
+        srv/net/dnsres \
         srv/net/ethip \
         srv/net/inetsrv \

uspace/srv/net/inetsrv/addrobj.c

@@ -221 +221 @@
 
         lsrc_addr.ipv4 = addr->naddr.ipv4;
-        ldest_addr = &dgram->dest;
+        ldest_addr = ldest;
 
         return inet_link_send_dgram(addr->ilink, &lsrc_addr, ldest_addr, dgram,

uspace/srv/net/inetsrv/inet_link.c

@@ -202 +202 @@
                 first = 0;
         } else {
-                addr->naddr.ipv4 = (192 << 24) + (168 << 16) + (0 << 8) + 4;
+                addr->naddr.ipv4 = (10 << 24) + (0 << 16) + (0 << 8) + 2;
         }
         addr->naddr.bits = 24;

uspace/srv/net/udp/assoc.c

@@ -264 +264 @@
 
         fibril_mutex_lock(&assoc->lock);
-        while (list_empty(&assoc->rcv_queue)) {
+        while (list_empty(&assoc->rcv_queue) && !assoc->reset) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_recv() - waiting");
                 fibril_condvar_wait(&assoc->rcv_queue_cv, &assoc->lock);
+        }
+
+        if (assoc->reset) {
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_recv() - association was reset");
+                fibril_mutex_unlock(&assoc->lock);
+                return ECONNABORTED;
         }
 
@@ -308 +314 @@
 }
 
+/** Reset association.
+ *
+ * This causes any pendingreceive operations to return immediately with
+ * UDP_ERESET.
+ */
+void udp_assoc_reset(udp_assoc_t *assoc)
+{
+        fibril_mutex_lock(&assoc->lock);
+        assoc->reset = true;
+        fibril_condvar_broadcast(&assoc->rcv_queue_cv);
+        fibril_mutex_unlock(&assoc->lock);
+}
+
 static int udp_assoc_queue_msg(udp_assoc_t *assoc, udp_sockpair_t *sp,
     udp_msg_t *msg)

uspace/srv/net/udp/assoc.h

@@ -50 +50 @@
 extern int udp_assoc_recv(udp_assoc_t *, udp_msg_t **, udp_sock_t *);
 extern void udp_assoc_received(udp_sockpair_t *, udp_msg_t *);
-
+extern void udp_assoc_reset(udp_assoc_t *);
 
 #endif

uspace/srv/net/udp/sock.c

@@ -359 +359 @@
                         rc = EOK;
                         break;
-/*              case TCP_ENOTEXIST:
+                case UDP_ENORES:
                         rc = ENOTCONN;
                         break;
-                case TCP_ECLOSING:
-                        rc = ENOTCONN;
-                        break;
-                case TCP_ERESET:
-                        rc = ECONNABORTED;
-                        break;*/
+                case UDP_EUNSPEC:
+                        rc = EINVAL;
+                        break;
+                case UDP_ENOROUTE:
+                        rc = EIO;
+                        break;
                 default:
                         assert(false);
@@ -543 +543 @@
         fibril_mutex_lock(&socket->lock);
 
+        fibril_mutex_lock(&socket->recv_buffer_lock);
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_close - set socket->sock_core = NULL");
+        socket->sock_core = NULL;
+        fibril_mutex_unlock(&socket->recv_buffer_lock);
+
+        udp_uc_reset(socket->assoc);
+
         rc = socket_destroy(NULL, socket_id, &client->sockets, &gsock,
             udp_free_sock_data);
         if (rc != EOK) {
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_close - socket_destroy failed");
                 fibril_mutex_unlock(&socket->lock);
                 async_answer_0(callid, rc);
                 return;
         }
+
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_close - broadcast recv_buffer_cv");
+        fibril_condvar_broadcast(&socket->recv_buffer_cv);
 
         fibril_mutex_unlock(&socket->lock);
@@ -576 +587 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_recv_fibril()");
 
+        fibril_mutex_lock(&sock->recv_buffer_lock);
+
         while (true) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "[] wait for rcv buffer empty()");
-                fibril_mutex_lock(&sock->recv_buffer_lock);
-                while (sock->recv_buffer_used != 0) {
+                while (sock->recv_buffer_used != 0 && sock->sock_core != NULL) {
                         fibril_condvar_wait(&sock->recv_buffer_cv,
                             &sock->recv_buffer_lock);
@@ -589 +601 @@
                 sock->recv_error = urc;
 
-                udp_sock_notify_data(sock->sock_core);
+                log_msg(LOG_DEFAULT, LVL_DEBUG, "[] udp_uc_receive -> %d", urc);
+
+                if (sock->sock_core != NULL)
+                        udp_sock_notify_data(sock->sock_core);
 
                 if (urc != UDP_EOK) {
+                        log_msg(LOG_DEFAULT, LVL_DEBUG, "[] urc != UDP_EOK, break");
                         fibril_condvar_broadcast(&sock->recv_buffer_cv);
-                        fibril_mutex_unlock(&sock->recv_buffer_lock);
                         break;
                 }
@@ -600 +615 @@
 
                 sock->recv_buffer_used = rcvd;
-                fibril_mutex_unlock(&sock->recv_buffer_lock);
                 fibril_condvar_broadcast(&sock->recv_buffer_cv);
         }
 
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_recv_fibril() exited loop");
+        fibril_mutex_unlock(&sock->recv_buffer_lock);
         udp_uc_destroy(sock->assoc);
+
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_sock_recv_fibril() terminated");
 
         return 0;

uspace/srv/net/udp/ucall.c

@@ -105 +105 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "%s: udp_uc_receive()", assoc->name);
         rc = udp_assoc_recv(assoc, &msg, fsock);
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_recv -> %d", rc);
         switch (rc) {
+        case EOK:
+                break;
+        case ECONNABORTED:
+                return UDP_ERESET;
+        default:
+                assert(false);
         }
 
@@ -125 +132 @@
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_uc_destroy()");
+        udp_assoc_reset(assoc);
         udp_assoc_remove(assoc);
         udp_assoc_delete(assoc);
+}
+
+void udp_uc_reset(udp_assoc_t *assoc)
+{
+        udp_assoc_reset(assoc);
 }
 

uspace/srv/net/udp/ucall.h

@@ -48 +48 @@
 extern void udp_uc_status(udp_assoc_t *, udp_assoc_status_t *);
 extern void udp_uc_destroy(udp_assoc_t *);
+extern void udp_uc_reset(udp_assoc_t *);
 
 #endif

uspace/srv/net/udp/udp_type.h

@@ -51 +51 @@
         UDP_EUNSPEC,
         /* No route to destination */
-        UDP_ENOROUTE
+        UDP_ENOROUTE,
+        /** Association reset by user */
+        UDP_ERESET
 } udp_error_t;
 
@@ -119 +121 @@
         udp_sockpair_t ident;
 
+        /** True if association was reset by user */
+        bool reset;
+
         /** True if association was deleted by user */
         bool deleted;