Changeset a1732929 in mainline for uspace/drv/bus/usb/usbmid

Timestamp:

2018-01-15T17:04:34Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

Location:

uspace/drv/bus/usb/usbmid

Files:

• dump.c (modified) (1 diff)
• explore.c (modified) (6 diffs)
• main.c (modified) (6 diffs)

uspace/drv/bus/usb/usbmid/dump.c

@@ -56 +56 @@
                 usb_standard_interface_descriptor_t *descriptor
                     = (usb_standard_interface_descriptor_t *) data;
-                usb_log_info("Found interface: %s (0x%02x/0x%02x/0x%02x).\n",
+                usb_log_info("Found interface: %s (0x%02x/0x%02x/0x%02x).",
                     usb_str_class(descriptor->interface_class),
                     (int) descriptor->interface_class,

uspace/drv/bus/usb/usbmid/explore.c

@@ -106 +106 @@
 
 
-                usb_log_info("Creating child for interface %d (%s).\n",
+                usb_log_info("Creating child for interface %d (%s).",
                     interface->interface_number,
                     usb_str_class(interface->interface_class));
@@ -144 +144 @@
                     dev_class, usb_str_class(dev_class),
                     USB_CLASS_USE_INTERFACE);
-                usb_log_error("Not a multi-interface device, refusing.\n");
+                usb_log_error("Not a multi-interface device, refusing.");
                 return ENOTSUP;
         }
@@ -160 +160 @@
             config_descriptor->configuration_number);
         if (rc != EOK) {
-                usb_log_error("Failed to set device configuration: %s.\n",
+                usb_log_error("Failed to set device configuration: %s.",
                     str_error(rc));
                 return rc;
@@ -168 +168 @@
         usb_mid_t *usb_mid = usb_device_data_alloc(dev, sizeof(usb_mid_t));
         if (!usb_mid) {
-                usb_log_error("Failed to create USB MID structure.\n");
+                usb_log_error("Failed to create USB MID structure.");
                 return ENOMEM;
         }
@@ -175 +175 @@
         usb_mid->ctl_fun = usb_device_ddf_fun_create(dev, fun_exposed, "ctl");
         if (usb_mid->ctl_fun == NULL) {
-                usb_log_error("Failed to create control function.\n");
+                usb_log_error("Failed to create control function.");
                 return ENOMEM;
         }
@@ -182 +182 @@
         rc = ddf_fun_bind(usb_mid->ctl_fun);
         if (rc != EOK) {
-                usb_log_error("Failed to bind control function: %s.\n",
+                usb_log_error("Failed to bind control function: %s.",
                     str_error(rc));
                 ddf_fun_destroy(usb_mid->ctl_fun);

uspace/drv/bus/usb/usbmid/main.c

@@ -51 +51 @@
 static int usbmid_device_add(usb_device_t *dev)
 {
-        usb_log_info("Taking care of new MID `%s'.\n", usb_device_get_name(dev));
+        usb_log_info("Taking care of new MID `%s'.", usb_device_get_name(dev));
 
         return usbmid_explore_device(dev);
@@ -68 +68 @@
                 const int pret = usbmid_interface_destroy(iface);
                 if (pret != EOK) {
-                        usb_log_error("Failed to remove child `%s': %s\n",
+                        usb_log_error("Failed to remove child `%s': %s",
                             ddf_fun_get_name(iface->fun), str_error(pret));
                         ret = pret;
@@ -91 +91 @@
         int ret = ddf_fun_unbind(usb_mid->ctl_fun);
         if (ret != EOK) {
-                usb_log_error("Failed to unbind USB MID ctl function: %s.\n",
+                usb_log_error("Failed to unbind USB MID ctl function: %s.",
                     str_error(ret));
                 return ret;
@@ -99 +99 @@
         /* Remove all children */
         list_foreach(usb_mid->interface_list, link, usbmid_interface_t, iface) {
-                usb_log_info("Removing child `%s'.\n",
+                usb_log_info("Removing child `%s'.",
                     ddf_fun_get_name(iface->fun));
 
@@ -105 +105 @@
                 int pret = ddf_fun_offline(iface->fun);
                 if (pret != EOK) {
-                        usb_log_warning("Failed to turn off child `%s': %s\n",
+                        usb_log_warning("Failed to turn off child `%s': %s",
                             ddf_fun_get_name(iface->fun), str_error(pret));
                         ret = pret;
@@ -125 +125 @@
         assert(usb_mid);
 
-        usb_log_info("USB MID gone: `%s'.\n", usb_device_get_name(dev));
+        usb_log_info("USB MID gone: `%s'.", usb_device_get_name(dev));
 
         /* Remove ctl function */
         int ret = ddf_fun_unbind(usb_mid->ctl_fun);
         if (ret != EOK) {
-                usb_log_error("Failed to unbind USB MID ctl function: %s.\n",
+                usb_log_error("Failed to unbind USB MID ctl function: %s.",
                     str_error(ret));
                 return ret;