Changeset a0d4afe in mainline for uspace/srv/hid/display/idevcfg.c

Timestamp:

2023-01-18T16:51:44Z (2 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3e7e226

Parents:

b0ae23f

Message:

Make sure input device configuration is destroyed together with seat

When a seat is destroyed without unassigning devices first, this causes
a dangling seat pointer that would cause the display server to crash
if the corresponding device generates an event.

File:

• uspace/srv/hid/display/idevcfg.c (modified) (3 diffs)

uspace/srv/hid/display/idevcfg.c

@@ -41 +41 @@
 #include "display.h"
 #include "idevcfg.h"
+#include "seat.h"
 
 /** Create input device configuration entry.
@@ -61 +62 @@
 
         idevcfg->svc_id = svc_id;
-        idevcfg->seat = seat;
+        ds_seat_add_idevcfg(seat, idevcfg);
 
         ds_display_add_idevcfg(display, idevcfg);
@@ -75 +76 @@
 {
         ds_display_remove_idevcfg(idevcfg);
+        ds_seat_remove_idevcfg(idevcfg);
         free(idevcfg);
 }