Changes in uspace/srv/net/tl/icmp/icmp.c [2e99277:a000878c] in mainline

File:

• uspace/srv/net/tl/icmp/icmp.c (modified) (7 diffs)

uspace/srv/net/tl/icmp/icmp.c

@@ -464 +464 @@
         ERROR_DECLARE;
 
-        measured_string_t       names[] = {{ "ICMP_ERROR_REPORTING", 20 }, { "ICMP_ECHO_REPLYING", 18 }};
+        measured_string_t       names[] = {{ str_dup("ICMP_ERROR_REPORTING"), 20 }, { str_dup("ICMP_ECHO_REPLYING"), 18 }};
         measured_string_ref     configuration;
         size_t                          count = sizeof( names ) / sizeof( measured_string_t );
@@ -658 +658 @@
         ipc_callid_t                    data_callid;
         icmp_echo_ref                   echo_data;
-        int                                             res;
 
         /*
@@ -664 +663 @@
          *  - Answer the first NET_ICMP_INIT call.
          */
-        res = EOK;
-        answer_count = 0;
+        ipc_answer_0( callid, EOK );
 
 //      fibril_rwlock_initialize( & lock );
@@ -671 +669 @@
         echo_data = ( icmp_echo_ref ) malloc( sizeof( * echo_data ));
         if( ! echo_data ) return ENOMEM;
-
         // assign a new identifier
         fibril_rwlock_write_lock( & icmp_globals.lock );
-        res = icmp_bind_free_id( echo_data );
+        ERROR_CODE = icmp_bind_free_id( echo_data );
         fibril_rwlock_write_unlock( & icmp_globals.lock );
-        if( res < 0 ){
+        if( ERROR_CODE < 0 ){
                 free( echo_data );
-                return res;
+                return ERROR_CODE;
         }
 
         while( keep_on_going ){
-
-                // answer the call
-                answer_call( callid, res, & answer, answer_count );
-
-                // refresh data
                 refresh_answer( & answer, & answer_count );
 
-                // get the next call
                 callid = async_get_call( & call );
 
-                // process the call
                 switch( IPC_GET_METHOD( call )){
                         case IPC_M_PHONE_HUNGUP:
                                 keep_on_going = false;
-                                res = EHANGUP;
+                                ERROR_CODE = EOK;
                                 break;
                         case NET_ICMP_ECHO:
 //                              fibril_rwlock_write_lock( & lock );
                                 if( ! async_data_write_receive( & data_callid, & length )){
-                                        res = EINVAL;
+                                        ERROR_CODE = EINVAL;
                                 }else{
                                         addr = malloc( length );
                                         if( ! addr ){
-                                                res = ENOMEM;
+                                                ERROR_CODE = ENOMEM;
                                         }else{
                                                 if( ! ERROR_OCCURRED( async_data_write_finalize( data_callid, addr, length ))){
                                                         fibril_rwlock_write_lock( & icmp_globals.lock );
-                                                        res = icmp_echo( echo_data->identifier, echo_data->sequence_number, ICMP_GET_SIZE( call ), ICMP_GET_TIMEOUT( call ), ICMP_GET_TTL( call ), ICMP_GET_TOS( call ), ICMP_GET_DONT_FRAGMENT( call ), addr, ( socklen_t ) length );
+                                                        ERROR_CODE = icmp_echo( echo_data->identifier, echo_data->sequence_number, ICMP_GET_SIZE( call ), ICMP_GET_TIMEOUT( call ), ICMP_GET_TTL( call ), ICMP_GET_TOS( call ), ICMP_GET_DONT_FRAGMENT( call ), addr, ( socklen_t ) length );
                                                         fibril_rwlock_write_unlock( & icmp_globals.lock );
                                                         free( addr );
@@ -717 +707 @@
                                                                 echo_data->sequence_number = 0;
                                                         }
-                                                }else{
-                                                        res = ERROR_CODE;
                                                 }
                                         }
@@ -725 +713 @@
                                 break;
                         default:
-                                res = icmp_process_message( & call );
+                                ERROR_CODE = icmp_process_message( & call );
                 }
+
+                answer_call( callid, ERROR_CODE, & answer, answer_count );
         }
 
@@ -733 +723 @@
         icmp_echo_data_exclude( & icmp_globals.echo_data, echo_data->identifier );
         fibril_rwlock_write_unlock( & icmp_globals.lock );
-        return res;
+        return EOK;
 }