Changes in uspace/lib/block/libblock.c [bc216a0:9d58539] in mainline

File:

• uspace/lib/block/libblock.c (modified) (12 diffs)

uspace/lib/block/libblock.c

@@ -62 +62 @@
 static LIST_INITIALIZE(dcl);
 
+#define CACHE_BUCKETS_LOG2  10
+#define CACHE_BUCKETS       (1 << CACHE_BUCKETS_LOG2)
 
 typedef struct {
@@ -254 +256 @@
 }
 
-static size_t cache_key_hash(void *key)
-{
-        aoff64_t *lba = (aoff64_t*)key;
-        return *lba;
-}
-
-static size_t cache_hash(const ht_link_t *item)
-{
-        block_t *b = hash_table_get_inst(item, block_t, hash_link);
-        return b->lba;
-}
-
-static bool cache_key_equal(void *key, const ht_link_t *item)
-{
-        aoff64_t *lba = (aoff64_t*)key;
-        block_t *b = hash_table_get_inst(item, block_t, hash_link);
-        return b->lba == *lba;
-}
-
-
-static hash_table_ops_t cache_ops = {
+static hash_index_t cache_hash(unsigned long *key)
+{
+        return MERGE_LOUP32(key[0], key[1]) & (CACHE_BUCKETS - 1);
+}
+
+static int cache_compare(unsigned long *key, hash_count_t keys, link_t *item)
+{
+        block_t *b = hash_table_get_instance(item, block_t, hash_link);
+        return b->lba == MERGE_LOUP32(key[0], key[1]);
+}
+
+static void cache_remove_callback(link_t *item)
+{
+}
+
+static hash_table_operations_t cache_ops = {
         .hash = cache_hash,
-        .key_hash = cache_key_hash,
-        .key_equal = cache_key_equal,
-        .equal = 0,
-        .remove_callback = 0
+        .compare = cache_compare,
+        .remove_callback = cache_remove_callback
 };
 
@@ -310 +305 @@
         cache->blocks_cluster = cache->lblock_size / devcon->pblock_size;
 
-        if (!hash_table_create(&cache->block_hash, 0, 0, &cache_ops)) {
+        if (!hash_table_create(&cache->block_hash, CACHE_BUCKETS, 2,
+            &cache_ops)) {
                 free(cache);
                 return ENOMEM;
@@ -348 +344 @@
                 }
 
-                hash_table_remove_item(&cache->block_hash, &b->hash_link);
+                unsigned long key[2] = {
+                        LOWER32(b->lba),
+                        UPPER32(b->lba)
+                };
+                hash_table_remove(&cache->block_hash, key, 2);
                 
                 free(b->data);
@@ -380 +380 @@
         fibril_rwlock_initialize(&b->contents_lock);
         link_initialize(&b->free_link);
+        link_initialize(&b->hash_link);
 }
 
@@ -399 +400 @@
         cache_t *cache;
         block_t *b;
-        link_t *link;
+        link_t *l;
+        unsigned long key[2] = {
+                LOWER32(ba),
+                UPPER32(ba)
+        };
 
         int rc;
@@ -415 +420 @@
 
         fibril_mutex_lock(&cache->lock);
-        ht_link_t *hlink = hash_table_find(&cache->block_hash, &ba);
-        if (hlink) {
+        l = hash_table_find(&cache->block_hash, key);
+        if (l) {
 found:
                 /*
                  * We found the block in the cache.
                  */
-                b = hash_table_get_inst(hlink, block_t, hash_link);
+                b = hash_table_get_instance(l, block_t, hash_link);
                 fibril_mutex_lock(&b->lock);
                 if (b->refcnt++ == 0)
@@ -459 +464 @@
                                 goto out;
                         }
-                        link = list_first(&cache->free_list);
-                        b = list_get_instance(link, block_t, free_link);
+                        l = list_first(&cache->free_list);
+                        b = list_get_instance(l, block_t, free_link);
 
                         fibril_mutex_lock(&b->lock);
@@ -500 +505 @@
                                         goto retry;
                                 }
-                                hlink = hash_table_find(&cache->block_hash, &ba);
-                                if (hlink) {
+                                l = hash_table_find(&cache->block_hash, key);
+                                if (l) {
                                         /*
                                          * Someone else must have already
@@ -523 +528 @@
                          */
                         list_remove(&b->free_link);
-                        hash_table_remove_item(&cache->block_hash, &b->hash_link);
+                        unsigned long temp_key[2] = {
+                                LOWER32(b->lba),
+                                UPPER32(b->lba)
+                        };
+                        hash_table_remove(&cache->block_hash, temp_key, 2);
                 }
 
@@ -531 +540 @@
                 b->lba = ba;
                 b->pba = ba_ltop(devcon, b->lba);
-                hash_table_insert(&cache->block_hash, &b->hash_link);
+                hash_table_insert(&cache->block_hash, key, &b->hash_link);
 
                 /*
@@ -643 +652 @@
                          * Take the block out of the cache and free it.
                          */
-                        hash_table_remove_item(&cache->block_hash, &block->hash_link);
+                        unsigned long key[2] = {
+                                LOWER32(block->lba),
+                                UPPER32(block->lba)
+                        };
+                        hash_table_remove(&cache->block_hash, key, 2);
                         fibril_mutex_unlock(&block->lock);
                         free(block->data);