Changes in kernel/arch/amd64/src/ddi/ddi.c [c5396c1:9d58539] in mainline

File:

• kernel/arch/amd64/src/ddi/ddi.c (modified) (7 diffs)

kernel/arch/amd64/src/ddi/ddi.c

@@ -42 +42 @@
 #include <errno.h>
 #include <arch/cpu.h>
-#include <cpu.h>
 #include <arch.h>
 #include <align.h>
@@ -59 +58 @@
 int ddi_iospace_enable_arch(task_t *task, uintptr_t ioaddr, size_t size)
 {
-        size_t elements = ioaddr + size;
-        if (elements > IO_PORTS)
+        size_t bits = ioaddr + size;
+        if (bits > IO_PORTS)
                 return ENOENT;
         
-        if (task->arch.iomap.elements < elements) {
+        if (task->arch.iomap.bits < bits) {
                 /*
                  * The I/O permission bitmap is too small and needs to be grown.
                  */
                 
-                void *store = malloc(bitmap_size(elements), FRAME_ATOMIC);
-                if (!store)
+                uint8_t *newmap = (uint8_t *) malloc(BITS2BYTES(bits), FRAME_ATOMIC);
+                if (!newmap)
                         return ENOMEM;
                 
                 bitmap_t oldiomap;
-                bitmap_initialize(&oldiomap, task->arch.iomap.elements,
+                bitmap_initialize(&oldiomap, task->arch.iomap.map,
                     task->arch.iomap.bits);
-                
-                bitmap_initialize(&task->arch.iomap, elements, store);
+                bitmap_initialize(&task->arch.iomap, newmap, bits);
                 
                 /*
                  * Mark the new range inaccessible.
                  */
-                bitmap_set_range(&task->arch.iomap, oldiomap.elements,
-                    elements - oldiomap.elements);
+                bitmap_set_range(&task->arch.iomap, oldiomap.bits,
+                    bits - oldiomap.bits);
                 
                 /*
@@ -90 +88 @@
                 if (oldiomap.bits) {
                         bitmap_copy(&task->arch.iomap, &oldiomap,
-                            oldiomap.elements);
-                        
-                        free(oldiomap.bits);
+                            oldiomap.bits);
+                        free(oldiomap.map);
                 }
         }
@@ -99 +96 @@
          * Enable the range and we are done.
          */
-        bitmap_clear_range(&task->arch.iomap, (size_t) ioaddr, size);
+        bitmap_clear_range(&task->arch.iomap, (size_t) ioaddr, (size_t) size);
         
         /*
@@ -121 +118 @@
         /* First, copy the I/O Permission Bitmap. */
         irq_spinlock_lock(&TASK->lock, false);
-        
         size_t ver = TASK->arch.iomapver;
-        size_t elements = TASK->arch.iomap.elements;
-        
-        if (elements > 0) {
-                ASSERT(TASK->arch.iomap.bits);
+        size_t bits = TASK->arch.iomap.bits;
+        if (bits) {
+                ASSERT(TASK->arch.iomap.map);
                 
                 bitmap_t iomap;
-                bitmap_initialize(&iomap, TSS_IOMAP_SIZE * 8,
-                    CPU->arch.tss->iomap);
-                bitmap_copy(&iomap, &TASK->arch.iomap, elements);
+                bitmap_initialize(&iomap, CPU->arch.tss->iomap,
+                    TSS_IOMAP_SIZE * 8);
+                bitmap_copy(&iomap, &TASK->arch.iomap, bits);
                 
                 /*
@@ -137 +132 @@
                  * I/O access.
                  */
-                bitmap_set_range(&iomap, elements,
-                    ALIGN_UP(elements, 8) - elements);
-                
+                bitmap_set_range(&iomap, bits, ALIGN_UP(bits, 8) - bits);
                 /*
                  * It is safe to set the trailing eight bits because of the
                  * extra convenience byte in TSS_IOMAP_SIZE.
                  */
-                bitmap_set_range(&iomap, ALIGN_UP(elements, 8), 8);
+                bitmap_set_range(&iomap, ALIGN_UP(bits, 8), 8);
         }
-        
         irq_spinlock_unlock(&TASK->lock, false);
         
         /*
          * Second, adjust TSS segment limit.
-         * Take the extra ending byte with all bits set into account.
+         * Take the extra ending byte will all bits set into account. 
          */
         ptr_16_64_t cpugdtr;
@@ -157 +149 @@
         
         descriptor_t *gdt_p = (descriptor_t *) cpugdtr.base;
-        size_t size = bitmap_size(elements);
-        gdt_tss_setlimit(&gdt_p[TSS_DES], TSS_BASIC_SIZE + size);
+        gdt_tss_setlimit(&gdt_p[TSS_DES], TSS_BASIC_SIZE + BITS2BYTES(bits));
         gdtr_load(&cpugdtr);