Changeset 9c0c0e1 in mainline for uspace/lib/ext4/libext4_filesystem.c

Timestamp:

2011-10-04T12:18:44Z (14 years ago)

Author:

Frantisek Princ <frantisek.princ@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a23297c

Parents:

01ab41b

Message:

part of code needed for successful mount (porting from ext2)

File:

• uspace/lib/ext4/libext4_filesystem.c (modified) (6 diffs)

uspace/lib/ext4/libext4_filesystem.c

@@ -52 +52 @@
         fs->device = service_id;
 
-        // TODO block size !!!
+        // TODO what does constant 2048 mean?
         rc = block_init(EXCHANGE_SERIALIZE, fs->device, 2048);
         if (rc != EOK) {
@@ -58 +58 @@
         }
 
+        /* Read superblock from device */
         rc = ext4_superblock_read_direct(fs->device, &temp_superblock);
         if (rc != EOK) {
@@ -64 +65 @@
         }
 
+        /* Read block size from superblock and check */
         block_size = ext4_superblock_get_block_size(temp_superblock);
-
         if (block_size > EXT4_MAX_BLOCK_SIZE) {
                 block_fini(fs->device);
@@ -71 +72 @@
         }
 
+        /* Initialize block caching */
         rc = block_cache_init(service_id, block_size, 0, CACHE_MODE_WT);
         if (rc != EOK) {
@@ -77 +79 @@
         }
 
+        /* Return loaded superblock */
         fs->superblock = temp_superblock;
 
-
-        // TODO
         return EOK;
 }
@@ -102 +103 @@
  * TODO doxy
  */
-int ext4_filesystem_check_flags(ext4_filesystem_t *fs, bool *o_read_only)
+int ext4_filesystem_check_features(ext4_filesystem_t *fs, bool *o_read_only)
 {
-        // TODO
+        /* Feature flags are present in rev 1 and later */
+        if (ext4_superblock_get_rev_level(fs->superblock) == 0) {
+                *o_read_only = false;
+                return EOK;
+        }
+
+        uint32_t incompatible_features;
+        incompatible_features = ext4_superblock_get_features_incompatible(fs->superblock);
+        incompatible_features &= ~EXT4_FEATURE_INCOMPAT_SUPP;
+        if (incompatible_features > 0) {
+                *o_read_only = true;
+                return ENOTSUP;
+        }
+
+        uint32_t compatible_read_only;
+        compatible_read_only = ext4_superblock_get_features_read_only(fs->superblock);
+        compatible_read_only &= ~EXT4_FEATURE_RO_COMPAT_SUPP;
+        if (compatible_read_only > 0) {
+                *o_read_only = true;
+        }
+
         return EOK;
 }