Changeset 95f1b8f in mainline for uspace/drv/bus/usb/ohci

Timestamp:

2018-02-24T19:51:28Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/fix-logger-deadlock, topic/msim-upgrade, topic/simplify-dev-export

Children:

5ef3afd

Parents:

0539c14

git-author:

Ondřej Hlavatý <aearsis@…> (2018-02-24 18:29:28)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-02-24 19:51:28)

Message:

usb: structures shared with hardware are both packed and aligned

Location:

uspace/drv/bus/usb/ohci/hw_struct

Files:

• endpoint_descriptor.h (modified) (1 diff)
• iso_transfer_descriptor.h (modified) (1 diff)
• transfer_descriptor.h (modified) (1 diff)

uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h

@@ -106 +106 @@
 #define ED_NEXT_PTR_MASK (0xfffffff0)
 #define ED_NEXT_PTR_SHIFT (0)
-} __attribute__((packed)) ed_t;
+} __attribute__((packed,aligned(32))) ed_t;
 
 void ed_init(ed_t *instance, const endpoint_t *ep, const td_t *td);

uspace/drv/bus/usb/ohci/hw_struct/iso_transfer_descriptor.h

@@ -69 +69 @@
 #define ITD_OFFSET_CC_SHIFT (12)
 
-} __attribute__((packed)) itd_t;
+} __attribute__((packed,aligned(32))) itd_t;
 
 #endif

uspace/drv/bus/usb/ohci/hw_struct/transfer_descriptor.h

@@ -90 +90 @@
          */
         volatile uint32_t be;
-} __attribute__((packed)) td_t;
+} __attribute__((packed,aligned(32))) td_t;
 
 void td_init(td_t *, const td_t *, usb_direction_t, const void *, size_t, int);