Changes in kernel/generic/src/mm/as.c [908bb96:94795812] in mainline

File:

• kernel/generic/src/mm/as.c (modified) (7 diffs)

kernel/generic/src/mm/as.c

@@ -79 +79 @@
 #include <syscall/copy.h>
 #include <arch/interrupt.h>
-#include <interrupt.h>
 
 /**
@@ -427 +426 @@
         /*
          * So far, the area does not conflict with other areas.
-         * Check if it is contained in the user address space.
+         * Check if it doesn't conflict with kernel address space.
          */
         if (!KERNEL_ADDRESS_SPACE_SHADOWED) {
-                return iswithin(USER_ADDRESS_SPACE_START,
-                    (USER_ADDRESS_SPACE_END - USER_ADDRESS_SPACE_START) + 1,
-                    addr, P2SZ(count));
+                return !overlaps(addr, P2SZ(count), KERNEL_ADDRESS_SPACE_START,
+                    KERNEL_ADDRESS_SPACE_END - KERNEL_ADDRESS_SPACE_START);
         }
         
@@ -698 +696 @@
                 return ENOENT;
         }
-
-        if (!area->backend->is_resizable(area)) {
-                /*
-                 * The backend does not support resizing for this area.
+        
+        if (area->backend == &phys_backend) {
+                /*
+                 * Remapping of address space areas associated
+                 * with memory mapped devices is not supported.
                  */
                 mutex_unlock(&area->lock);
@@ -1058 +1057 @@
         }
         
-        if (!src_area->backend->is_shareable(src_area)) {
-                /*
-                 * The backend does not permit sharing of this area.
+        if ((!src_area->backend) || (!src_area->backend->share)) {
+                /*
+                 * There is no backend or the backend does not
+                 * know how to share the area.
                  */
                 mutex_unlock(&src_area->lock);
@@ -1363 +1363 @@
 int as_page_fault(uintptr_t page, pf_access_t access, istate_t *istate)
 {
-        int rc = AS_PF_FAULT;
-
         if (!THREAD)
-                goto page_fault;
+                return AS_PF_FAULT;
         
         if (!AS)
-                goto page_fault;
+                return AS_PF_FAULT;
         
         mutex_lock(&AS->lock);
@@ -1425 +1423 @@
          * Resort to the backend page fault handler.
          */
-        rc = area->backend->page_fault(area, page, access);
-        if (rc != AS_PF_OK) {
+        if (area->backend->page_fault(area, page, access) != AS_PF_OK) {
                 page_table_unlock(AS, false);
                 mutex_unlock(&area->lock);
@@ -1447 +1444 @@
                 istate_set_retaddr(istate,
                     (uintptr_t) &memcpy_to_uspace_failover_address);
-        } else if (rc == AS_PF_SILENT) {
-                printf("Killing task %" PRIu64 " due to a "
-                    "failed late reservation request.\n", TASK->taskid);
-                task_kill_self(true);
         } else {
-                fault_if_from_uspace(istate, "Page fault: %p.", (void *) page);
-                panic_memtrap(istate, access, page, NULL);
+                return AS_PF_FAULT;
         }