Changeset 91b60499 in mainline for uspace/lib/usbhost/src/ddf_helpers.c

Timestamp:

2017-09-30T06:29:42Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

300f4c4

Parents:

d076f16 (diff), 6636fb19 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge support for capabilities from lp:~jakub/helenos/caps

This commit introduces capabilities as task-local names for references to kernel
objects. Kernel objects are reference-counted wrappers for a select group of
objects allocated in and by the kernel that can be made accessible to userspace
in a controlled way via integer handles.

So far, a kernel object encapsulates either an irq_t or a phone_t.

Support for the former lead to the removal of kernel-assigned devnos and
unsecure deregistration of IRQs in which a random task was able to unregister
some other task's IRQ.

File:

• uspace/lib/usbhost/src/ddf_helpers.c (modified) (7 diffs)

uspace/lib/usbhost/src/ddf_helpers.c

@@ -748 +748 @@
  * @param[in] gen_irq_code IRQ code generator.
  *
- * @return EOK on success or negative error code
+ * @return IRQ capability handle on success.
+ * @return Negative error code.
  */
 int hcd_ddf_setup_interrupts(ddf_dev_t *device,
@@ -770 +771 @@
 
         /* Register handler to avoid interrupt lockup */
-        int ret = register_interrupt_handler(device, irq, handler, &irq_code);
+        const int irq_cap = register_interrupt_handler(device, irq, handler,
+            &irq_code);
         irq_code_clean(&irq_code);
+        if (irq_cap < 0) {
+                usb_log_error("Failed to register interrupt handler: %s.\n",
+                    str_error(irq_cap));
+                return irq_cap;
+        }
+
+        /* Enable interrupts */
+        int ret = hcd_ddf_enable_interrupts(device);
         if (ret != EOK) {
                 usb_log_error("Failed to register interrupt handler: %s.\n",
                     str_error(ret));
-                return ret;
-        }
-
-        /* Enable interrupts */
-        ret = hcd_ddf_enable_interrupts(device);
-        if (ret != EOK) {
-                usb_log_error("Failed to register interrupt handler: %s.\n",
-                    str_error(ret));
-                unregister_interrupt_handler(device, irq);
-                return ret;
-        }
-        assert(irq > 0);
-        return irq;
+                unregister_interrupt_handler(device, irq_cap);
+                return ret;
+        }
+        return irq_cap;
 }
 
@@ -882 +883 @@
         interrupt_handler_t *irq_handler =
             driver->irq_handler ? driver->irq_handler : ddf_hcd_gen_irq_handler;
-        const int irq = hcd_ddf_setup_interrupts(device, &hw_res, irq_handler,
-            driver->irq_code_gen);
-        if (!(irq < 0)) {
+        const int irq_cap = hcd_ddf_setup_interrupts(device, &hw_res,
+            irq_handler, driver->irq_code_gen);
+        bool irqs_enabled = !(irq_cap < 0);
+        if (irqs_enabled) {
                 usb_log_debug("Hw interrupts enabled.\n");
         }
@@ -899 +901 @@
         /* Init hw driver */
         hcd_t *hcd = dev_to_hcd(device);
-        ret = driver->init(hcd, &hw_res, !(irq < 0));
+        ret = driver->init(hcd, &hw_res, irqs_enabled);
         hw_res_list_parsed_clean(&hw_res);
         if (ret != EOK) {
@@ -907 +909 @@
 
         /* Need working irq replacement to setup root hub */
-        if ((irq < 0) && hcd->ops.status_hook) {
+        if (!irqs_enabled && hcd->ops.status_hook) {
                 hcd->polling_fibril = fibril_create(interrupt_polling, hcd);
                 if (hcd->polling_fibril == 0) {
@@ -916 +918 @@
                 fibril_add_ready(hcd->polling_fibril);
                 usb_log_warning("Failed to enable interrupts: %s."
-                    " Falling back to polling.\n", str_error(irq));
+                    " Falling back to polling.\n", str_error(irq_cap));
         }
 
@@ -930 +932 @@
 irq_unregister:
                 /* Unregistering non-existent should be ok */
-                unregister_interrupt_handler(device, irq);
+                unregister_interrupt_handler(device, irq_cap);
                 hcd_ddf_clean_hc(device);
                 return ret;