Changeset 86b4ee0 in mainline

Timestamp:

2011-04-10T09:09:28Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0ede0c3

Parents:

edc4c66

Message:

Minor fixes

Size really does not matter for control and bulk endpoint registration,
we may just use max_packet_size for all.
Fix parameter order in error output.
Move debug output before endpoint creation (to see that message even if endpoint creation fails)

Location:

uspace/drv

Files:

• ohci/iface.c (modified) (3 diffs)
• uhci-hcd/iface.c (modified) (3 diffs)

uspace/drv/ohci/iface.c

@@ -68 +68 @@
                 usb_log_error("Endpoint(%d:%d) %s needs %zu bw "
                     "but only %zu is reserved.\n",
-                    name, target.address, target.endpoint, bw, res_bw);
+                    target.address, target.endpoint, name, bw, res_bw);
                 return ENOSPC;
         }
@@ -163 +163 @@
                 speed = ep_speed;
         }
-        const size_t size =
-            (transfer_type == USB_TRANSFER_INTERRUPT
-            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
-            max_packet_size : 0;
+        const size_t size = max_packet_size;
         int ret;
+
+        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
+            address, endpoint, usb_str_transfer_type(transfer_type),
+            usb_str_speed(speed), direction, size, max_packet_size, interval);
 
         endpoint_t *ep = malloc(sizeof(endpoint_t));
@@ -178 +179 @@
                 return ret;
         }
-
-        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
-            address, endpoint, usb_str_transfer_type(transfer_type),
-            usb_str_speed(speed), direction, size, max_packet_size, interval);
 
         ret = usb_endpoint_manager_register_ep(&hc->ep_manager, ep, size);

uspace/drv/uhci-hcd/iface.c

@@ -68 +68 @@
                 usb_log_error("Endpoint(%d:%d) %s needs %zu bw "
                     "but only %zu is reserved.\n",
-                    name, target.address, target.endpoint, bw, res_bw);
+                    target.address, target.endpoint, name, bw, res_bw);
                 return ENOSPC;
         }
@@ -146 +146 @@
         hc_t *hc = fun_to_hc(fun);
         assert(hc);
+        const size_t size = max_packet_size;
+        int ret;
         usb_speed_t speed = usb_device_keeper_get_speed(&hc->manager, address);
         if (speed >= USB_SPEED_MAX) {
                 speed = ep_speed;
         }
-        const size_t size =
-            (transfer_type == USB_TRANSFER_INTERRUPT
-            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
-            max_packet_size : 0;
-        int ret;
+        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
+            address, endpoint, usb_str_transfer_type(transfer_type),
+            usb_str_speed(speed), direction, size, max_packet_size, interval);
+
 
         endpoint_t *ep = malloc(sizeof(endpoint_t));
@@ -166 +167 @@
         }
 
-        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
-            address, endpoint, usb_str_transfer_type(transfer_type),
-            usb_str_speed(speed), direction, size, max_packet_size, interval);
-
         ret = usb_endpoint_manager_register_ep(&hc->ep_manager, ep, size);
         if (ret != EOK) {