Changeset 8486c07 in mainline for uspace/drv/bus/usb/uhci/hc.c

Timestamp:

2012-07-21T14:01:12Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

eb3683a

Parents:

56c167c

Message:

IRQ pseudocode improvements

• rename CMD_BTEST to CMD_AND (less cryptic)
• implement CMD_LOAD to load a constant value into a scratch register
• implement simple pseudocode static checker
• slightly alter the semantics of several pseudocode commands (scratch[0] is a usable field, although not propagated to the IPC notification)

File:

• uspace/drv/bus/usb/uhci/hc.c (modified) (2 diffs)

uspace/drv/bus/usb/uhci/hc.c

@@ -50 +50 @@
 static const irq_pio_range_t uhci_irq_pio_ranges[] = {
         {
-                .base = 0,      /* filled later */
+                .base = 0,
                 .size = sizeof(uhci_regs_t)
         }
@@ -56 +56 @@
 
 static const irq_cmd_t uhci_irq_commands[] = {
-        { .cmd = CMD_PIO_READ_16, .dstarg = 1, .addr = NULL/*filled later*/},
-        { .cmd = CMD_BTEST, .srcarg = 1, .dstarg = 2,
-          .value = UHCI_STATUS_USED_INTERRUPTS | UHCI_STATUS_NM_INTERRUPTS },
-        { .cmd = CMD_PREDICATE, .srcarg = 2, .value = 2 },
-        { .cmd = CMD_PIO_WRITE_A_16, .srcarg = 1, .addr = NULL/*filled later*/},
-        { .cmd = CMD_ACCEPT },
+        {
+                .cmd = CMD_PIO_READ_16,
+                .dstarg = 1,
+                .addr = NULL
+        },
+        {
+                .cmd = CMD_AND,
+                .srcarg = 1,
+                .dstarg = 2,
+                .value = UHCI_STATUS_USED_INTERRUPTS | UHCI_STATUS_NM_INTERRUPTS
+        },
+        {
+                .cmd = CMD_PREDICATE,
+                .srcarg = 2,
+                .value = 2
+        },
+        {
+                .cmd = CMD_PIO_WRITE_A_16,
+                .srcarg = 1,
+                .addr = NULL
+        },
+        {
+                .cmd = CMD_ACCEPT
+        }
 };