Changes in uspace/app/trace/trace.c [1ccafee:7e752b2] in mainline

File:

• uspace/app/trace/trace.c (modified) (22 diffs)

uspace/app/trace/trace.c

@@ -43 +43 @@
 #include <task.h>
 #include <mem.h>
-#include <string.h>
+#include <str.h>
 #include <bool.h>
 #include <loader/loader.h>
@@ -161 +161 @@
         if (rc < 0) {
                 printf("Error connecting\n");
-                printf("ipc_connect_task(%" PRIdTASKID ") -> %d ", task_id, rc);
+                printf("ipc_connect_task(%" PRIu64 ") -> %d ", task_id, rc);
                 return rc;
         }
@@ -200 +200 @@
         printf("Threads:");
         for (i = 0; i < n_threads; i++) {
-                printf(" [%d] (hash %p)", 1+i, thread_hash_buf[i]);
-        }
-        printf("\ntotal of %u threads\n", tb_needed / sizeof(uintptr_t));
+                printf(" [%d] (hash %p)", 1 + i, (void *) thread_hash_buf[i]);
+        }
+        printf("\ntotal of %zu threads\n", tb_needed / sizeof(uintptr_t));
 
         return 0;
@@ -224 +224 @@
         case V_HASH:
         case V_PTR:
-                printf("%p", val);
+                printf("%p", (void *) val);
                 break;
 
@@ -248 +248 @@
         case V_CHAR:
                 if (sval >= 0x20 && sval < 0x7f) {
-                        printf("'%c'", sval);
+                        printf("'%c'", (char) sval);
                 } else {
                         switch (sval) {
@@ -257 +257 @@
                         case '\t': printf("'\\t'"); break;
                         case '\\': printf("'\\\\'"); break;
-                        default: printf("'\\x%02lX'", val); break;
+                        default: printf("'\\x%02" PRIxn "'", val); break;
                         }
                 }
@@ -277 +277 @@
 
         putchar('(');
-        if (n > 0) printf("%" PRIdSYSARG, sc_args[0]);
+        if (n > 0) printf("%" PRIun, sc_args[0]);
         for (i = 1; i < n; i++) {
-                printf(", %" PRIdSYSARG, sc_args[i]);
+                printf(", %" PRIun, sc_args[i]);
         }
         putchar(')');
@@ -489 +489 @@
 {
         async_serialize_start();
-        printf("New thread, hash 0x%lx\n", hash);
+        printf("New thread, hash %p\n", (void *) hash);
         async_serialize_end();
 
@@ -510 +510 @@
         }
 
-        printf("Start tracing thread [%d] (hash %p).\n", thread_id, thread_hash);
+        printf("Start tracing thread [%u] (hash %p).\n",
+            thread_id, (void *) thread_hash);
 
         while (!abort_trace) {
@@ -516 +517 @@
                 fibril_mutex_lock(&state_lock);
                 if (paused) {
-                        printf("Thread [%d] paused. Press R to resume.\n",
+                        printf("Thread [%u] paused. Press R to resume.\n",
                             thread_id);
 
@@ -522 +523 @@
                                 fibril_condvar_wait(&state_cv, &state_lock);
 
-                        printf("Thread [%d] resumed.\n", thread_id);
+                        printf("Thread [%u] resumed.\n", thread_id);
                 }
                 fibril_mutex_unlock(&state_lock);
@@ -554 +555 @@
                                 break;
                         case UDEBUG_EVENT_THREAD_E:
-                                printf("Thread %p exited.\n", val0);
+                                printf("Thread %" PRIun " exited.\n", val0);
                                 fibril_mutex_lock(&state_lock);
                                 abort_trace = true;
@@ -585 +586 @@
 }
 
-static loader_t *preload_task(const char *path, char *const argv[],
+static loader_t *preload_task(const char *path, char **argv,
     task_id_t *task_id)
 {
@@ -591 +592 @@
         int rc;
 
-        /* Spawn a program loader */    
+        /* Spawn a program loader */
         ldr = loader_connect();
         if (ldr == NULL)
@@ -607 +608 @@
 
         /* Send arguments */
-        rc = loader_set_args(ldr, argv);
+        rc = loader_set_args(ldr, (const char **) argv);
         if (rc != EOK)
                 goto error;
@@ -870 +871 @@
 }
 
-static display_mask_t parse_display_mask(char *text)
+static display_mask_t parse_display_mask(const char *text)
 {
         display_mask_t dm;
-        char *c;
-
-        c = text;
-
+        const char *c = text;
+        
         while (*c) {
                 switch (*c) {
-                case 't': dm = dm | DM_THREAD; break;
-                case 's': dm = dm | DM_SYSCALL; break;
-                case 'i': dm = dm | DM_IPC; break;
-                case 'p': dm = dm | DM_SYSTEM | DM_USER; break;
+                case 't':
+                        dm = dm | DM_THREAD;
+                        break;
+                case 's':
+                        dm = dm | DM_SYSCALL;
+                        break;
+                case 'i':
+                        dm = dm | DM_IPC;
+                        break;
+                case 'p':
+                        dm = dm | DM_SYSTEM | DM_USER;
+                        break;
                 default:
                         printf("Unexpected event type '%c'.\n", *c);
                         exit(1);
                 }
-
+                
                 ++c;
         }
-
+        
         return dm;
 }
@@ -896 +903 @@
 static int parse_args(int argc, char *argv[])
 {
-        char *arg;
         char *err_p;
 
         task_id = 0;
 
-        --argc; ++argv;
+        --argc;
+        ++argv;
 
         while (argc > 0) {
-                arg = *argv;
+                char *arg = *argv;
                 if (arg[0] == '+') {
                         display_mask = parse_display_mask(&arg[1]);
@@ -910 +917 @@
                         if (arg[1] == 't') {
                                 /* Trace an already running task */
-                                --argc; ++argv;
+                                --argc;
+                                ++argv;
                                 task_id = strtol(*argv, &err_p, 10);
                                 task_ldr = NULL;
@@ -920 +928 @@
                                 }
                         } else {
-                                printf("Uknown option '%s'\n", arg[0]);
+                                printf("Uknown option '%c'\n", arg[0]);
                                 print_syntax();
                                 return -1;
@@ -927 +935 @@
                         break;
                 }
-
-                --argc; ++argv;
+                
+                --argc;
+                ++argv;
         }
 
         if (task_id != 0) {
-                if (argc == 0) return 0;
+                if (argc == 0)
+                        return 0;
                 printf("Extra arguments\n");
                 print_syntax();
@@ -946 +956 @@
         /* Preload the specified program file. */
         printf("Spawning '%s' with arguments:\n", *argv);
-        {
-                char **cp = argv;
-                while (*cp) printf("'%s'\n", *cp++);
-        }
+        
+        char **cp = argv;
+        while (*cp)
+                printf("'%s'\n", *cp++);
+        
         task_ldr = preload_task(*argv, argv, &task_id);
         task_wait_for = true;
@@ -974 +985 @@
         rc = connect_task(task_id);
         if (rc < 0) {
-                printf("Failed connecting to task %" PRIdTASKID ".\n", task_id);
+                printf("Failed connecting to task %" PRIu64 ".\n", task_id);
                 return 1;
         }
 
-        printf("Connected to task %" PRIdTASKID ".\n", task_id);
+        printf("Connected to task %" PRIu64 ".\n", task_id);
 
         if (task_ldr != NULL)