Index: abi/include/_bits/NULL.h =================================================================== --- abi/include/_bits/NULL.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/NULL.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/WCHAR_MAX.h =================================================================== --- abi/include/_bits/WCHAR_MAX.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/WCHAR_MAX.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/WCHAR_MIN.h =================================================================== --- abi/include/_bits/WCHAR_MIN.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/WCHAR_MIN.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/WEOF.h =================================================================== --- abi/include/_bits/WEOF.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/WEOF.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/all.h =================================================================== --- abi/include/_bits/all.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/all.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/errno.h =================================================================== --- abi/include/_bits/errno.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/errno.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/inttypes.h =================================================================== --- abi/include/_bits/inttypes.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/inttypes.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/limits.h =================================================================== --- abi/include/_bits/limits.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/limits.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ @@ -42,5 +43,6 @@ #include <_bits/macros.h> -/* _MIN macros for unsigned types are non-standard (and of course, always 0), +/* + * _MIN macros for unsigned types are non-standard (and of course, always 0), * but we already have them for some reason, so whatever. */ Index: abi/include/_bits/macros.h =================================================================== --- abi/include/_bits/macros.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/macros.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/native.h =================================================================== --- abi/include/_bits/native.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/native.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/opaque_handle.h =================================================================== --- abi/include/_bits/opaque_handle.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/opaque_handle.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/ptrdiff_t.h =================================================================== --- abi/include/_bits/ptrdiff_t.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/ptrdiff_t.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/size_t.h =================================================================== --- abi/include/_bits/size_t.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/size_t.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/ssize_t.h =================================================================== --- abi/include/_bits/ssize_t.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/ssize_t.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/stdint.h =================================================================== --- abi/include/_bits/stdint.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/stdint.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/wchar_t.h =================================================================== --- abi/include/_bits/wchar_t.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/wchar_t.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/_bits/wint_t.h =================================================================== --- abi/include/_bits/wint_t.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/_bits/wint_t.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: abi/include/abi/errno.h =================================================================== --- abi/include/abi/errno.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ abi/include/abi/errno.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -49,5 +49,6 @@ -/* POSIX error codes + whatever nonstandard names crop up in third-party +/* + * POSIX error codes + whatever nonstandard names crop up in third-party * software. These are not used in HelenOS code, but are defined here in * order to avoid nasty hacks in libposix. Index: boot/arch/arm32/include/arch/mm.h =================================================================== --- boot/arch/arm32/include/arch/mm.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ boot/arch/arm32/include/arch/mm.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -71,6 +71,8 @@ #define BCM2835_RAM_END 0x20000000 -/* Page table level 0 entry - "section" format is used - * (one-level paging, 1 MB sized pages). Used only while booting the kernel. +/** Page table level 0 entry + * + * "section" format is used (one-level paging, 1 MB sized pages). + * Used only while booting the kernel. */ typedef struct { Index: boot/arch/arm32/src/mm.c =================================================================== --- boot/arch/arm32/src/mm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ boot/arch/arm32/src/mm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -210,5 +210,6 @@ "mrc p15, 0, r0, c1, c0, 0\n" - /* Enable ICache, DCache, BPredictors and MMU, + /* + * Enable ICache, DCache, BPredictors and MMU, * we disable caches before jumping to kernel * so this is safe for all archs. @@ -224,5 +225,6 @@ "orr r0, r0, r1\n" - /* Invalidate the TLB content before turning on the MMU. + /* + * Invalidate the TLB content before turning on the MMU. * ARMv7-A Reference manual, B3.10.3 */ @@ -240,8 +242,10 @@ disable_paging(); #ifdef PROCESSOR_ARCH_armv7_a - /* Make sure we run in memory code when caches are enabled, + /* + * Make sure we run in memory code when caches are enabled, * make sure we read memory data too. This part is ARMv7 specific as * ARMv7 no longer invalidates caches on restart. - * See chapter B2.2.2 of ARM Architecture Reference Manual p. B2-1263*/ + * See chapter B2.2.2 of ARM Architecture Reference Manual p. B2-1263 + */ cache_invalidate(); #endif Index: boot/genarch/src/multiplication.c =================================================================== --- boot/genarch/src/multiplication.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ boot/genarch/src/multiplication.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -90,5 +90,6 @@ } - /* (if OF checked) a1 or b1 is zero => result fits in 64 bits, + /* + * (if OF checked) a1 or b1 is zero => result fits in 64 bits, * no need to another overflow check */ @@ -104,5 +105,6 @@ t2 += t1; - /* t2 & (1ull << 63) - if this bit is set in unsigned long long, + /* + * t2 & (1ull << 63) - if this bit is set in unsigned long long, * result does not fit in signed one */ Index: boot/generic/src/str.c =================================================================== --- boot/generic/src/str.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ boot/generic/src/str.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -215,6 +215,8 @@ return EINVAL; - /* Unsigned version of ch (bit operations should only be done - on unsigned types). */ + /* + * Unsigned version of ch (bit operations should only be done + * on unsigned types). + */ uint32_t cc = (uint32_t) ch; Index: kernel/arch/abs32le/include/arch/asm.h =================================================================== --- kernel/arch/abs32le/include/arch/asm.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/abs32le/include/arch/asm.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -46,8 +46,10 @@ NO_TRACE static inline __attribute__((noreturn)) void cpu_halt(void) { - /* On real hardware this should stop processing further - instructions on the CPU (and possibly putting it into - low-power mode) without any possibility of exitting - this function. */ + /* + * On real hardware this should stop processing further + * instructions on the CPU (and possibly putting it into + * low-power mode) without any possibility of exitting + * this function. + */ while (true) @@ -57,8 +59,10 @@ NO_TRACE static inline void cpu_sleep(void) { - /* On real hardware this should put the CPU into low-power - mode. However, the CPU is free to continue processing - futher instructions any time. The CPU also wakes up - upon an interrupt. */ + /* + * On real hardware this should put the CPU into low-power + * mode. However, the CPU is free to continue processing + * futher instructions any time. The CPU also wakes up + * upon an interrupt. + */ } Index: kernel/arch/abs32le/include/arch/atomic.h =================================================================== --- kernel/arch/abs32le/include/arch/atomic.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/abs32le/include/arch/atomic.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -47,6 +47,8 @@ REQUIRES(val->count < ATOMIC_COUNT_MAX) { - /* On real hardware the increment has to be done - as an atomic action. */ + /* + * On real hardware the increment has to be done + * as an atomic action. + */ val->count++; @@ -58,6 +60,8 @@ REQUIRES(val->count > ATOMIC_COUNT_MIN) { - /* On real hardware the decrement has to be done - as an atomic action. */ + /* + * On real hardware the decrement has to be done + * as an atomic action. + */ val->count--; @@ -69,7 +73,9 @@ REQUIRES(val->count < ATOMIC_COUNT_MAX) { - /* On real hardware both the storing of the previous - value and the increment have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the increment have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; @@ -84,7 +90,9 @@ REQUIRES(val->count > ATOMIC_COUNT_MIN) { - /* On real hardware both the storing of the previous - value and the decrement have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the decrement have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; @@ -101,7 +109,9 @@ REQUIRES_EXTENT_MUTABLE(val) { - /* On real hardware the retrieving of the original - value and storing 1 have to be done as a single - atomic action. */ + /* + * On real hardware the retrieving of the original + * value and storing 1 have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; Index: kernel/arch/abs32le/include/arch/istate.h =================================================================== --- kernel/arch/abs32le/include/arch/istate.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/abs32le/include/arch/istate.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -65,6 +65,8 @@ REQUIRES_EXTENT_MUTABLE(istate) { - /* On real hardware this checks whether the interrupted - context originated from user space. */ + /* + * On real hardware this checks whether the interrupted + * context originated from user space. + */ return !(istate->ip & UINT32_C(0x80000000)); Index: kernel/arch/abs32le/src/userspace.c =================================================================== --- kernel/arch/abs32le/src/userspace.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/abs32le/src/userspace.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -41,6 +41,8 @@ void userspace(uspace_arg_t *kernel_uarg) { - /* On real hardware this switches the CPU to user - space mode and jumps to kernel_uarg->uspace_entry. */ + /* + * On real hardware this switches the CPU to user + * space mode and jumps to kernel_uarg->uspace_entry. + */ while (true) Index: kernel/arch/amd64/include/arch/boot/memmap_struct.h =================================================================== --- kernel/arch/amd64/include/arch/boot/memmap_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/include/arch/boot/memmap_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2016 Jakub Jermar +/* + * Copyright (c) 2016 Jakub Jermar * All rights reserved. * Index: kernel/arch/amd64/include/arch/context_struct.h =================================================================== --- kernel/arch/amd64/include/arch/context_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/include/arch/context_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * @@ -46,5 +47,6 @@ typedef struct context { - /* We include only registers that must be preserved + /* + * We include only registers that must be preserved * during function call. */ Index: kernel/arch/amd64/include/arch/istate_struct.h =================================================================== --- kernel/arch/amd64/include/arch/istate_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/include/arch/istate_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * Index: kernel/arch/amd64/include/arch/kseg_struct.h =================================================================== --- kernel/arch/amd64/include/arch/kseg_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/include/arch/kseg_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2016 Jakub Jermar +/* + * Copyright (c) 2016 Jakub Jermar * All rights reserved. * Index: kernel/arch/amd64/src/fpu_context.c =================================================================== --- kernel/arch/amd64/src/fpu_context.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/src/fpu_context.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -57,6 +57,8 @@ { /* TODO: Zero all SSE, MMX etc. registers */ - /* Default value of SCR register is 0x1f80, - * it masks all FPU exceptions*/ + /* + * Default value of SCR register is 0x1f80, + * it masks all FPU exceptions + */ asm volatile ( "fninit\n" Index: kernel/arch/amd64/src/kseg.c =================================================================== --- kernel/arch/amd64/src/kseg.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/src/kseg.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -42,5 +42,5 @@ * Allocate and initialize a per-CPU structure to be accessible via the * GS_KERNEL segment register. - **/ + */ void kseg_init(void) { Index: kernel/arch/amd64/src/pm.c =================================================================== --- kernel/arch/amd64/src/pm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/src/pm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -268,7 +268,9 @@ tss_p = &tss; } else { - /* We are going to use malloc, which may return + /* + * We are going to use malloc, which may return * non boot-mapped pointer, initialize the CR3 register - * ahead of page_init */ + * ahead of page_init + */ write_cr3((uintptr_t) AS_KERNEL->genarch.page_table); Index: kernel/arch/amd64/src/syscall.c =================================================================== --- kernel/arch/amd64/src/syscall.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/amd64/src/syscall.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -52,5 +52,6 @@ /* Setup syscall entry address */ - /* This is _mess_ - the 64-bit CS is argument + 16, + /* + * This is _mess_ - the 64-bit CS is argument + 16, * the SS is argument + 8. The order is: * +0(KDATA_DES), +8(UDATA_DES), +16(UTEXT_DES) @@ -60,5 +61,6 @@ ((uint64_t) (GDT_SELECTOR(KTEXT_DES) | PL_KERNEL) << 32)); write_msr(AMD_MSR_LSTAR, (uint64_t)syscall_entry); - /* Mask RFLAGS on syscall + /* + * Mask RFLAGS on syscall * - disable interrupts, until we exchange the stack register * (mask the IF bit) Index: kernel/arch/arm32/include/arch/context_struct.h =================================================================== --- kernel/arch/arm32/include/arch/context_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/include/arch/context_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -34,5 +34,6 @@ // XXX: This struct must match assembly code in src/context.S -/* Thread context containing registers that must be preserved across +/* + * Thread context containing registers that must be preserved across * function calls. */ Index: kernel/arch/arm32/include/arch/fpu_context.h =================================================================== --- kernel/arch/arm32/include/arch/fpu_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/include/arch/fpu_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -42,5 +42,6 @@ #define FPU_CONTEXT_ALIGN 8 -/* ARM Architecture reference manual, p B-1529. +/* + * ARM Architecture reference manual, p B-1529. */ typedef struct { Index: kernel/arch/arm32/include/arch/mm/page_armv4.h =================================================================== --- kernel/arch/arm32/include/arch/mm/page_armv4.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/include/arch/mm/page_armv4.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -64,5 +64,6 @@ unsigned should_be_zero : 1; - /* Pointer to the coarse 2nd level page table (holding entries for small + /* + * Pointer to the coarse 2nd level page table (holding entries for small * (4KB) or large (64KB) pages. ARM also supports fine 2nd level page * tables that may hold even tiny pages (1KB) but they are bigger (4KB @@ -80,6 +81,8 @@ unsigned cacheable : 1; - /* access permissions for each of 4 subparts of a page - * (for each 1KB when small pages used */ + /* + * access permissions for each of 4 subparts of a page + * (for each 1KB when small pages used + */ unsigned access_permission_0 : 2; unsigned access_permission_1 : 2; Index: kernel/arch/arm32/include/arch/mm/page_armv6.h =================================================================== --- kernel/arch/arm32/include/arch/mm/page_armv6.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/include/arch/mm/page_armv6.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -66,5 +66,6 @@ unsigned should_be_zero_1 : 1; - /* Pointer to the coarse 2nd level page table (holding entries for small + /* + * Pointer to the coarse 2nd level page table (holding entries for small * (4KB) or large (64KB) pages. ARM also supports fine 2nd level page * tables that may hold even tiny pages (1KB) but they are bigger (4KB @@ -279,6 +280,8 @@ } - /* Shareable is ignored for devices (non-cacheable), - * turn it off for normal memory. */ + /* + * Shareable is ignored for devices (non-cacheable), + * turn it off for normal memory. + */ p->shareable = 0; Index: kernel/arch/arm32/src/cpu/cpu.c =================================================================== --- kernel/arch/arm32/src/cpu/cpu.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/src/cpu/cpu.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -147,13 +147,18 @@ /* Unaligned access is supported on armv6+ */ #if defined(PROCESSOR_ARCH_armv7_a) | defined(PROCESSOR_ARCH_armv6) - /* Enable unaligned access, RAZ/WI prior to armv6 + /* + * Enable unaligned access, RAZ/WI prior to armv6 * switchable on armv6, RAO/WI writes on armv7, * see ARM Architecture Reference Manual ARMv7-A and ARMv7-R edition - * L.3.1 (p. 2456) */ + * L.3.1 (p. 2456) + */ control_reg |= SCTLR_UNALIGNED_EN_FLAG; - /* Disable alignment checks, this turns unaligned access to undefined, - * unless U bit is set. */ + /* + * Disable alignment checks, this turns unaligned access to undefined, + * unless U bit is set. + */ control_reg &= ~SCTLR_ALIGN_CHECK_EN_FLAG; - /* Enable caching, On arm prior to armv7 there is only one level + /* + * Enable caching, On arm prior to armv7 there is only one level * of caches. Data cache is coherent. * "This means that the behavior of accesses from the same observer to @@ -169,5 +174,6 @@ #endif #ifdef PROCESSOR_ARCH_armv7_a - /* ICache coherency is elaborated on in barrier.h. + /* + * ICache coherency is elaborated on in barrier.h. * VIPT and PIPT caches need maintenance only on code modify, * so it should be safe for general use. Index: kernel/arch/arm32/src/exception.c =================================================================== --- kernel/arch/arm32/src/exception.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/src/exception.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -66,5 +66,6 @@ static void install_handler(unsigned handler_addr, unsigned *vector) { - /* relative address (related to exc. vector) of the word + /* + * Relative address (related to exc. vector) of the word * where handler's address is stored */ @@ -72,9 +73,9 @@ PREFETCH_OFFSET; - /* make it LDR instruction and store at exception vector */ + /* Make it LDR instruction and store at exception vector */ *vector = handler_address_ptr | LDR_OPCODE; smc_coherence(vector); - /* store handler's address */ + /* Store handler's address */ *(vector + EXC_VECTORS) = handler_addr; Index: kernel/arch/arm32/src/mach/beagleboardxm/beagleboardxm.c =================================================================== --- kernel/arch/arm32/src/mach/beagleboardxm/beagleboardxm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/src/mach/beagleboardxm/beagleboardxm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -106,6 +106,8 @@ omap_irc_init(beagleboard.irc_addr); - /* Initialize timer. Use timer1, because it is in WKUP power domain - * (always on) and has special capabilities for precise 1ms ticks */ + /* + * Initialize timer. Use timer1, because it is in WKUP power domain + * (always on) and has special capabilities for precise 1ms ticks + */ amdm37x_gpt_timer_ticks_init(&beagleboard.timer, AMDM37x_GPT1_BASE_ADDRESS, AMDM37x_GPT1_SIZE, HZ); @@ -161,5 +163,6 @@ } /** amdm37x manual ch. 12.5.2 (p. 2428) places irc ack at the end - * of ISR. DO this to avoid strange behavior. */ + * of ISR. DO this to avoid strange behavior. + */ omap_irc_irq_ack(beagleboard.irc_addr); } Index: kernel/arch/arm32/src/mm/page_fault.c =================================================================== --- kernel/arch/arm32/src/mm/page_fault.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/arm32/src/mm/page_fault.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -153,6 +153,8 @@ } - /* See ARM Architecture reference manual ARMv7-A and ARMV7-R edition - * A5.3 (PDF p. 206) */ + /* + * See ARM Architecture reference manual ARMv7-A and ARMV7-R edition + * A5.3 (PDF p. 206) + */ static const struct { uint32_t mask; Index: kernel/arch/ia32/include/arch/boot/memmap_struct.h =================================================================== --- kernel/arch/ia32/include/arch/boot/memmap_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia32/include/arch/boot/memmap_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: kernel/arch/ia32/include/arch/context_struct.h =================================================================== --- kernel/arch/ia32/include/arch/context_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia32/include/arch/context_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: kernel/arch/ia32/include/arch/istate_struct.h =================================================================== --- kernel/arch/ia32/include/arch/istate_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia32/include/arch/istate_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: kernel/arch/ia32/src/smp/smp.c =================================================================== --- kernel/arch/ia32/src/smp/smp.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia32/src/smp/smp.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -156,5 +156,6 @@ */ - /* XXX Flag FRAME_LOW_4_GiB was removed temporarily, + /* + * XXX Flag FRAME_LOW_4_GiB was removed temporarily, * it needs to be replaced by a generic fuctionality of * the memory subsystem Index: kernel/arch/ia64/include/arch/context_struct.h =================================================================== --- kernel/arch/ia64/include/arch/context_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia64/include/arch/context_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: kernel/arch/ia64/include/arch/istate_struct.h =================================================================== --- kernel/arch/ia64/include/arch/istate_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ia64/include/arch/istate_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: kernel/arch/mips32/include/arch/atomic.h =================================================================== --- kernel/arch/mips32/include/arch/atomic.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/mips32/include/arch/atomic.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -47,5 +47,5 @@ #define atomic_predec(x) atomic_add(x, -1) -/* Atomic addition of immediate value. +/** Atomic addition of immediate value. * * @param val Memory location to which will be the immediate value added. @@ -53,5 +53,4 @@ * * @return Value after addition. - * */ NO_TRACE static inline atomic_count_t atomic_add(atomic_t *val, Index: kernel/arch/mips32/src/exception.c =================================================================== --- kernel/arch/mips32/src/exception.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/mips32/src/exception.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -132,7 +132,9 @@ debugger_bpoint(istate); #else - /* it is necessary to not re-execute BREAK instruction after - returning from Exception handler - (see page 138 in R4000 Manual for more information) */ + /* + * It is necessary to not re-execute BREAK instruction after + * returning from Exception handler + * (see page 138 in R4000 Manual for more information) + */ istate->epc += 4; #endif Index: kernel/arch/mips32/src/mips32.c =================================================================== --- kernel/arch/mips32/src/mips32.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/mips32/src/mips32.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -49,5 +49,6 @@ #include -/* Size of the code jumping to the exception handler code +/* + * Size of the code jumping to the exception handler code * - J+NOP */ @@ -70,5 +71,6 @@ arch_ops_t *arch_ops = &mips32_ops; -/* Why the linker moves the variable 64K away in assembler +/* + * Why the linker moves the variable 64K away in assembler * when not in .text section? */ Index: kernel/arch/mips32/src/mm/frame.c =================================================================== --- kernel/arch/mips32/src/mm/frame.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/mips32/src/mm/frame.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -243,5 +243,6 @@ #if defined(MACHINE_lmalta) || defined(MACHINE_bmalta) - /* Blacklist memory regions used by YAMON. + /* + * Blacklist memory regions used by YAMON. * * The YAMON User's Manual vaguely says the following physical addresses Index: kernel/arch/ppc32/src/mm/frame.c =================================================================== --- kernel/arch/ppc32/src/mm/frame.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/ppc32/src/mm/frame.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -93,6 +93,8 @@ frame_common_arch_init(true); - /* First is exception vector, second is 'implementation specific', - third and fourth is reserved, other contain real mode code */ + /* + * First is exception vector, second is 'implementation specific', + * third and fourth is reserved, other contain real mode code + */ frame_mark_unavailable(0, 8); Index: kernel/arch/sparc64/src/smp/sun4v/smp.c =================================================================== --- kernel/arch/sparc64/src/smp/sun4v/smp.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/arch/sparc64/src/smp/sun4v/smp.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -191,7 +191,7 @@ /* - * if failed in previous CPUs, don't try - * to detect physical cores any more - */ + * if failed in previous CPUs, don't try + * to detect physical cores any more + */ if (exec_unit_assign_error) continue; @@ -250,5 +250,5 @@ exec_units[i].strand_count : max_core_strands; - /* detecting execution unit failed */ + /* detecting execution unit failed */ } else { exec_unit_assign_error = 1; @@ -260,8 +260,8 @@ /* - * A fallback code which will be executed if finding out which - * execution units belong to particular CPUs fails. Pretend there - * exists just one execution unit and all CPUs belong to it. - */ + * A fallback code which will be executed if finding out which + * execution units belong to particular CPUs fails. Pretend there + * exists just one execution unit and all CPUs belong to it. + */ if (exec_unit_assign_error) { bsp_exec_unit_index = 0; @@ -288,8 +288,8 @@ /* - * Reorder the execution units array elements and the cpuid array - * elements so that the BSP will always be the very first CPU of - * the very first execution unit. - */ + * Reorder the execution units array elements and the cpuid array + * elements so that the BSP will always be the very first CPU of + * the very first execution unit. + */ exec_unit_t temp_exec_unit = exec_units[0]; exec_units[0] = exec_units[bsp_exec_unit_index]; Index: kernel/genarch/include/genarch/drivers/am335x/timer_regs.h =================================================================== --- kernel/genarch/include/genarch/drivers/am335x/timer_regs.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/include/genarch/drivers/am335x/timer_regs.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -41,5 +41,6 @@ typedef struct am335x_timer_regs { - /* This read only register contains the + /* + * This read only register contains the * revision number of the module */ @@ -60,5 +61,6 @@ ioport32_t const pad1[3]; - /* This register allows controlling various + /* + * This register allows controlling various * parameters of the OCP interface. */ Index: kernel/genarch/include/genarch/multiboot/multiboot_info_struct.h =================================================================== --- kernel/genarch/include/genarch/multiboot/multiboot_info_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/include/genarch/multiboot/multiboot_info_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2016 Jakub Jermar +/* + * Copyright (c) 2016 Jakub Jermar * All rights preserved. * Index: kernel/genarch/include/genarch/multiboot/multiboot_memmap_struct.h =================================================================== --- kernel/genarch/include/genarch/multiboot/multiboot_memmap_struct.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/include/genarch/multiboot/multiboot_memmap_struct.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2016 Jakub Jermar +/* + * Copyright (c) 2016 Jakub Jermar * All rights preserved. * Index: kernel/genarch/src/drivers/omap/uart.c =================================================================== --- kernel/genarch/src/drivers/omap/uart.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/src/drivers/omap/uart.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -116,6 +116,8 @@ uart->regs->fcr = OMAP_UART_FCR_FIFO_EN_FLAG; - /* Enable fine granularity for RX FIFO and set trigger level to 1, - * TX FIFO, trigger level is irrelevant*/ + /* + * Enable fine granularity for RX FIFO and set trigger level to 1, + * TX FIFO, trigger level is irrelevant + */ uart->regs->lcr = 0xBF; /* Sets config mode B */ uart->regs->scr = OMAP_UART_SCR_RX_TRIG_GRANU1_FLAG; Index: kernel/genarch/src/softint/multiplication.c =================================================================== --- kernel/genarch/src/softint/multiplication.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/src/softint/multiplication.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -117,6 +117,8 @@ t2 += t1; - /* t2 & (1ull << 63) - if this bit is set in unsigned long long, - * result does not fit in signed one */ + /* + * t2 & (1ull << 63) - if this bit is set in unsigned long long, + * result does not fit in signed one + */ if (SOFTINT_CHECK_OF && ((t2 < t1) || (t2 & (1ull << 63)))) { // error, overflow Index: kernel/genarch/src/srln/srln.c =================================================================== --- kernel/genarch/src/srln/srln.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/genarch/src/srln/srln.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -106,6 +106,8 @@ } - /* Replace carriage return with line feed - and suppress any following line feed */ + /* + * Replace carriage return with line feed + * and suppress any following line feed + */ if ((ch == '\n') && (cr)) { cr = false; Index: kernel/generic/include/adt/btree.h =================================================================== --- kernel/generic/include/adt/btree.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/include/adt/btree.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -78,5 +78,6 @@ /** * Link connecting leaf-level nodes. Defined only when this node is a - * leaf. */ + * leaf. + */ link_t leaf_link; Index: kernel/generic/include/adt/cht.h =================================================================== --- kernel/generic/include/adt/cht.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/include/adt/cht.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -46,5 +46,6 @@ /** Concurrent hash table node link. */ typedef struct cht_link { - /* Must be placed first. + /* + * Must be placed first. * * The function pointer (rcu_link.func) is used to store the item's Index: kernel/generic/src/console/cmd.c =================================================================== --- kernel/generic/src/console/cmd.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/console/cmd.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1421,6 +1421,8 @@ printf("%s (%s)\n", test->name, test->desc); - /* Update and read thread accounting - for benchmarking */ + /* + * Update and read thread accounting + * for benchmarking + */ irq_spinlock_lock(&TASK->lock, true); uint64_t ucycles0, kcycles0; @@ -1474,6 +1476,8 @@ printf("%s (%u/%u) ... ", test->name, i + 1, cnt); - /* Update and read thread accounting - for benchmarking */ + /* + * Update and read thread accounting + * for benchmarking + */ irq_spinlock_lock(&TASK->lock, true); uint64_t ucycles0, kcycles0; Index: kernel/generic/src/ipc/event.c =================================================================== --- kernel/generic/src/ipc/event.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/ipc/event.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -354,6 +354,5 @@ * @return ELIMIT on unknown event type. * @return ENOENT if the notification of the given type is not - subscribed. - * + * subscribed. */ sys_errno_t sys_ipc_event_unsubscribe(sysarg_t evno) Index: kernel/generic/src/ipc/ipc.c =================================================================== --- kernel/generic/src/ipc/ipc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/ipc/ipc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -33,5 +33,6 @@ */ -/* Lock ordering +/* + * Lock ordering * * First the answerbox, then the phone. Index: kernel/generic/src/ipc/ipcrsc.c =================================================================== --- kernel/generic/src/ipc/ipcrsc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/ipc/ipcrsc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -33,5 +33,6 @@ */ -/* IPC resources management +/* + * IPC resources management * * The goal of this source code is to properly manage IPC resources and allow Index: kernel/generic/src/ipc/irq.c =================================================================== --- kernel/generic/src/ipc/irq.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/ipc/irq.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -514,5 +514,5 @@ } -/* IRQ top-half handler. +/** IRQ top-half handler. * * We expect interrupts to be disabled and the irq->lock already held. Index: kernel/generic/src/lib/str.c =================================================================== --- kernel/generic/src/lib/str.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/lib/str.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -225,6 +225,8 @@ return EINVAL; - /* Unsigned version of ch (bit operations should only be done - on unsigned types). */ + /* + * Unsigned version of ch (bit operations should only be done + * on unsigned types). + */ uint32_t cc = (uint32_t) ch; @@ -735,5 +737,5 @@ * @param ch Character to insert to. * @param pos Character index where to insert. - @ @param max_pos Characters in the buffer. + * @param max_pos Characters in the buffer. * * @return True if the insertion was sucessful, false if the position @@ -934,6 +936,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; Index: kernel/generic/src/lib/str_error.c =================================================================== --- kernel/generic/src/lib/str_error.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/lib/str_error.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -31,5 +31,6 @@ #include -/* The arrays below are automatically generated from the same file that +/* + * The arrays below are automatically generated from the same file that * errno.h constants are generated from. Triple-include of the same list * with redefinitions of __errno() macro are used to ensure that the @@ -61,5 +62,6 @@ static int find_errno(errno_t e) { - /* Just a dumb linear search. + /* + * Just a dumb linear search. * There too few entries to warrant anything smarter. */ Index: kernel/generic/src/main/main.c =================================================================== --- kernel/generic/src/main/main.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/main/main.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -95,5 +95,6 @@ #include -/* Ensure [u]int*_t types are of correct size. +/* + * Ensure [u]int*_t types are of correct size. * * Probably, this is not the best place for such tests Index: kernel/generic/src/mm/as.c =================================================================== --- kernel/generic/src/mm/as.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/mm/as.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -477,5 +477,6 @@ if (addr >= bound) { if (guarded) { - /* Leave an unmapped page between the lower + /* + * Leave an unmapped page between the lower * bound and the area's start address. */ @@ -499,5 +500,6 @@ if (guarded || area->flags & AS_AREA_GUARD) { - /* We must leave an unmapped page + /* + * We must leave an unmapped page * between the two areas. */ Index: kernel/generic/src/printf/vsnprintf.c =================================================================== --- kernel/generic/src/printf/vsnprintf.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/printf/vsnprintf.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -70,5 +70,6 @@ if (left == 1) { - /* We have only one free byte left in buffer + /* + * We have only one free byte left in buffer * -> store trailing zero */ @@ -79,5 +80,6 @@ if (left <= size) { - /* We do not have enough space for the whole string + /* + * We do not have enough space for the whole string * with the trailing zero => print only a part * of string @@ -92,5 +94,6 @@ } - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ @@ -104,5 +107,6 @@ data->len += size; - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ @@ -140,5 +144,6 @@ if (left == 1) { - /* We have only one free byte left in buffer + /* + * We have only one free byte left in buffer * -> store trailing zero */ @@ -154,5 +159,6 @@ } - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ Index: kernel/generic/src/proc/thread.c =================================================================== --- kernel/generic/src/proc/thread.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/proc/thread.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -621,6 +621,8 @@ void thread_sleep(uint32_t sec) { - /* Sleep in 1000 second steps to support - full argument range */ + /* + * Sleep in 1000 second steps to support + * full argument range + */ while (sec > 0) { uint32_t period = (sec > 1000) ? 1000 : sec; Index: kernel/generic/src/synch/waitq.c =================================================================== --- kernel/generic/src/synch/waitq.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/synch/waitq.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -441,5 +441,6 @@ THREAD->sleep_queue = wq; - /* Must be before entry to scheduler, because there are multiple + /* + * Must be before entry to scheduler, because there are multiple * return vectors. */ Index: kernel/generic/src/synch/workqueue.c =================================================================== --- kernel/generic/src/synch/workqueue.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/synch/workqueue.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -424,5 +424,5 @@ * until func() is entered. * @param func User supplied function to invoke in a worker thread. - + * * @return false if work queue is shutting down; function is not * queued for further processing. @@ -444,5 +444,5 @@ * until func() is entered. * @param func User supplied function to invoke in a worker thread. - + * * @return false if work queue is shutting down; function is not * queued for further processing. @@ -469,5 +469,5 @@ * @param func User supplied function to invoke in a worker thread. * @param can_block May adding this work item block? - + * * @return false if work queue is shutting down; function is not * queued for further processing. Index: kernel/generic/src/sysinfo/stats.c =================================================================== --- kernel/generic/src/sysinfo/stats.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/sysinfo/stats.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -222,5 +222,5 @@ } -/* Produce task statistics +/** Produce task statistics * * Summarize task information into task statistics. @@ -324,5 +324,5 @@ } -/* Produce thread statistics +/** Produce thread statistics * * Summarize thread information into thread statistics. Index: kernel/generic/src/sysinfo/sysinfo.c =================================================================== --- kernel/generic/src/sysinfo/sysinfo.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/generic/src/sysinfo/sysinfo.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -232,5 +232,6 @@ i++; - /* Check for perfect name and path match + /* + * Check for perfect name and path match * -> item is already present. */ @@ -251,5 +252,6 @@ &(cur->subtree.table)); default: - /* Subtree items handled by a function, this + /* + * Subtree items handled by a function, this * cannot be overriden by a constant item. */ @@ -258,5 +260,6 @@ } - /* No match and no more siblings to check + /* + * No match and no more siblings to check * -> create a new sibling item. */ @@ -457,6 +460,8 @@ sysinfo_item_t *item = sysinfo_create_path(name, root); - /* Change the type of the subtree only if it is not already - a fixed subtree */ + /* + * Change the type of the subtree only if it is not already + * a fixed subtree + */ if ((item != NULL) && (item->subtree_type != SYSINFO_SUBTREE_TABLE)) { item->subtree_type = SYSINFO_SUBTREE_FUNCTION; @@ -559,6 +564,8 @@ void sysinfo_dump(sysinfo_item_t *root) { - /* Avoid other functions to mess with sysinfo - while we are dumping it */ + /* + * Avoid other functions to mess with sysinfo + * while we are dumping it + */ mutex_lock(&sysinfo_lock); Index: kernel/test/mm/slab2.c =================================================================== --- kernel/test/mm/slab2.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ kernel/test/mm/slab2.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -197,5 +197,6 @@ static void multitest(int size) { - /* Start 8 threads that just allocate as much as possible, + /* + * Start 8 threads that just allocate as much as possible, * then release everything, then again allocate, then release */ Index: uspace/app/bdsh/cmds/builtin_cmds.c =================================================================== --- uspace/app/bdsh/cmds/builtin_cmds.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/builtin_cmds.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,6 +27,8 @@ */ -/* Almost identical (for now) to mod_cmds.c , however this will not be the case - * soon as builtin_t is going to grow way beyond module_t */ +/* + * Almost identical (for now) to mod_cmds.c, however this will not be the case + * soon as builtin_t is going to grow way beyond module_t + */ #include Index: uspace/app/bdsh/cmds/builtins/batch/batch.c =================================================================== --- uspace/app/bdsh/cmds/builtins/batch/batch.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/builtins/batch/batch.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -66,6 +66,7 @@ } -/* Main entry point for batch, accepts an array of arguments and a - * pointer to the cliuser_t structure */ +/** Main entry point for batch, accepts an array of arguments and a + * pointer to the cliuser_t structure + */ int cmd_batch(char **argv, cliuser_t *usr) { Index: uspace/app/bdsh/cmds/builtins/cd/cd.c =================================================================== --- uspace/app/bdsh/cmds/builtins/cd/cd.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/builtins/cd/cd.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -41,5 +41,6 @@ static const char *cmdname = "cd"; -/* Previous directory variables. +/* + * Previous directory variables. * * Declaring them static to avoid many "== NULL" checks. @@ -101,8 +102,10 @@ } - /* We don't yet play nice with whitespace, a getopt implementation should + /* + * We don't yet play nice with whitespace, a getopt implementation should * protect "quoted\ destination" as a single argument. Its not our job to * look for && || or redirection as the tokenizer should have done that - * (currently, it does not) */ + * (currently, it does not) + */ if (argc > 2) { Index: uspace/app/bdsh/cmds/builtins/exit/exit.c =================================================================== --- uspace/app/bdsh/cmds/builtins/exit/exit.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/builtins/exit/exit.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -44,6 +44,7 @@ } -/* Quits the program and returns the status of whatever command - * came before invoking 'quit' */ +/** Quits the program and returns the status of whatever command + * came before invoking 'quit' + */ int cmd_exit(char *argv[], cliuser_t *usr) { Index: uspace/app/bdsh/cmds/cmds.h =================================================================== --- uspace/app/bdsh/cmds/cmds.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/cmds.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -76,6 +76,8 @@ } builtin_t; -/* Declared in cmds/modules/modules.h and cmds/builtins/builtins.h - * respectively */ +/* + * Declared in cmds/modules/modules.h and cmds/builtins/builtins.h + * respectively + */ extern module_t modules[]; extern builtin_t builtins[]; Index: uspace/app/bdsh/cmds/mod_cmds.c =================================================================== --- uspace/app/bdsh/cmds/mod_cmds.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/mod_cmds.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* NOTES: +/* + * NOTES: * module_* functions are pretty much identical to builtin_* functions at this * point. On the surface, it would appear that making each function dual purpose @@ -37,9 +38,12 @@ * * To keep things easy to hack, everything is separated. In reality this only adds - * 6 - 8 extra functions, but keeps each function very easy to read and modify. */ + * 6 - 8 extra functions, but keeps each function very easy to read and modify. + */ -/* TODO: +/* + * TODO: * Many of these could be unsigned, provided the modules and builtins themselves - * can follow suit. Long term goal. */ + * can follow suit. Long term goal. + */ #include @@ -53,6 +57,8 @@ extern volatile unsigned int cli_interactive; -/* Checks if an entry function matching command exists in modules[], if so - * its position in the array is returned */ +/** Checks if an entry function matching command exists in modules[] + * + * If so, its position in the array is returned + */ int is_module(const char *command) { @@ -71,6 +77,8 @@ } -/* Checks if a module is an alias (sharing an entry point with another - * module). Returns 1 if so */ +/* + * Checks if a module is an alias (sharing an entry point with another + * module). Returns 1 if so + */ int is_module_alias(const char *command) { @@ -105,6 +113,8 @@ -/* Invokes the 'help' entry function for the module at position (int) module, - * which wants an unsigned int to determine brief or extended display. */ +/** Invokes the 'help' entry function for the module at position (int) module + * + * which wants an unsigned int to determine brief or extended display. + */ int help_module(int module, unsigned int extended) { @@ -121,6 +131,8 @@ } -/* Invokes the module entry point modules[module], passing argv[] as an argument - * stack. */ +/** Invokes the module entry point modules[module] + * + * passing argv[] as an argument stack. + */ int run_module(int module, char *argv[], iostate_t *new_iostate) { Index: uspace/app/bdsh/cmds/modules/cat/cat.c =================================================================== --- uspace/app/bdsh/cmds/modules/cat/cat.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/cat/cat.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -274,6 +274,8 @@ break; } else if (c == U_SPECIAL && offset + 2 >= (size_t)bytes) { - /* If an extended character is cut off due to the size of the buffer, - we will copy it over to the next buffer so it can be read correctly. */ + /* + * If an extended character is cut off due to the size of the buffer, + * we will copy it over to the next buffer so it can be read correctly. + */ copied_bytes = bytes - offset + 1; memcpy(buff, buff + offset - 1, copied_bytes); Index: uspace/app/bdsh/cmds/modules/cp/cp.c =================================================================== --- uspace/app/bdsh/cmds/modules/cp/cp.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/cp/cp.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -207,5 +207,6 @@ /* e.g. cp file_name /data/ */ - /* dest is a directory, + /* + * dest is a directory, * append the src filename to it. */ @@ -231,5 +232,6 @@ /* e.g. cp file_name existing_file */ - /* dest already exists, + /* + * dest already exists, * if force is set we will try to remove it. * if interactive is set user input is required. @@ -298,5 +300,6 @@ if (str_cmp(src_dirname, "..") && str_cmp(src_dirname, ".")) { - /* The last component of src_path is + /* + * The last component of src_path is * not '.' or '..' */ @@ -314,5 +317,6 @@ default: case TYPE_NONE: - /* dest does not exists, this means the user wants + /* + * dest does not exists, this means the user wants * to specify the name of the destination directory * @@ -336,5 +340,6 @@ } - /* Copy every single directory entry of src into the + /* + * Copy every single directory entry of src into the * destination directory. */ Index: uspace/app/bdsh/cmds/modules/ls/ls.c =================================================================== --- uspace/app/bdsh/cmds/modules/ls/ls.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/ls/ls.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,7 +27,9 @@ */ -/* NOTE: +/* + * NOTE: * This is a bit of an ugly hack, working around the absence of fstat / etc. - * As more stuff is completed and exposed in libc, this will improve */ + * As more stuff is completed and exposed in libc, this will improve + */ #include Index: uspace/app/bdsh/cmds/modules/module_aliases.h =================================================================== --- uspace/app/bdsh/cmds/modules/module_aliases.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/module_aliases.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -30,13 +30,17 @@ #define MODULE_ALIASES_H -/* Modules that declare multiple names for themselves but use the +/* + * Modules that declare multiple names for themselves but use the * same entry functions are aliases. This array helps to determine if * a module is an alias, as such it can be invoked differently. - * format is alias , real_name */ + * format is alias , real_name + */ -/* So far, this is only used in the help display but could be used to +/* + * So far, this is only used in the help display but could be used to * handle a module differently even prior to reaching its entry code. * For instance, 'exit' could behave differently than 'quit', prior to - * the entry point being reached. */ + * the entry point being reached. + */ const char *mod_aliases[] = { Index: uspace/app/bdsh/cmds/modules/modules.h =================================================================== --- uspace/app/bdsh/cmds/modules/modules.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/modules.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -30,5 +30,6 @@ #define MODULES_H -/* Each built in function has two files, one being an entry.h file which +/* + * Each built in function has two files, one being an entry.h file which * prototypes the run/help entry functions, the other being a .def file * which fills the modules[] array according to the cmd_t structure @@ -40,5 +41,6 @@ * * NOTE: See module_ aliases.h as well, this is where aliases (commands that - * share an entry point with others) are indexed */ + * share an entry point with others) are indexed + */ #include "config.h" @@ -64,7 +66,9 @@ #include "cmp/entry.h" -/* Each .def function fills the module_t struct with the individual name, entry +/* + * Each .def function fills the module_t struct with the individual name, entry * point, help entry point, etc. You can use config.h to control what modules - * are loaded based on what libraries exist on the system. */ + * are loaded based on what libraries exist on the system. + */ module_t modules[] = { Index: uspace/app/bdsh/cmds/modules/rm/rm.c =================================================================== --- uspace/app/bdsh/cmds/modules/rm/rm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/cmds/modules/rm/rm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -95,6 +95,8 @@ rm->safe = 0; - /* Make sure we can allocate enough memory to store - * what is needed in the job structure */ + /* + * Make sure we can allocate enough memory to store + * what is needed in the job structure + */ if (NULL == (rm->nwd = (char *) malloc(PATH_MAX))) return 0; Index: uspace/app/bdsh/compl.c =================================================================== --- uspace/app/bdsh/compl.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/compl.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -219,6 +219,8 @@ cs->path_list[0] = dirname; cs->path_list[1] = NULL; - /* The second const ensures that we can't assign a const - * string to the non-const array. */ + /* + * The second const ensures that we can't assign a const + * string to the non-const array. + */ cs->path = (const char *const *) cs->path_list; Index: uspace/app/bdsh/config.h =================================================================== --- uspace/app/bdsh/config.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/config.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,6 +27,8 @@ */ -/* Various things that are used in many places including a few - * tidbits left over from autoconf prior to the HelenOS port */ +/* + * Various things that are used in many places including a few + * tidbits left over from autoconf prior to the HelenOS port + */ /* Specific port work-arounds : */ @@ -44,6 +46,8 @@ #define LARGE_BUFLEN 1024 -/* How many words (arguments) are permitted, how big can a whole - * sentence be? Similar to ARG_MAX */ +/* + * How many words (arguments) are permitted, how big can a whole + * sentence be? Similar to ARG_MAX + */ #define WORD_MAX 1023 #define INPUT_MAX 4096 Index: uspace/app/bdsh/errors.c =================================================================== --- uspace/app/bdsh/errors.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/errors.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -44,6 +44,8 @@ -/* Look up errno in cl_errors and return the corresponding string. - * Return NULL if not found */ +/** Look up errno in cl_errors and return the corresponding string. + * + * Return NULL if not found + */ static const char *err2str(int err) { @@ -55,8 +57,10 @@ } -/* Print an error report signifying errno, which is translated to - * its corresponding human readable string. If errno > 0, raise the - * cli_quit int that tells the main program loop to exit immediately */ - +/** Print an error report signifying errno + * + * errno is translated to its corresponding human readable string. + * If errno > 0, raise the cli_quit int that tells the main program loop + * to exit immediately + */ void cli_error(int err, const char *fmt, ...) { @@ -71,7 +75,9 @@ printf(" (Unknown Error %d)\n", err); - /* If fatal, raise cli_quit so that we try to exit + /* + * If fatal, raise cli_quit so that we try to exit * gracefully. This will break the main loop and - * invoke the destructor */ + * invoke the destructor + */ if (err == CL_EFATAL) cli_quit = 1; Index: uspace/app/bdsh/exec.c =================================================================== --- uspace/app/bdsh/exec.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/exec.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,9 +27,11 @@ */ -/* The VERY basics of execute in place support. These are buggy, leaky +/* + * The VERY basics of execute in place support. These are buggy, leaky * and not nearly done. Only here for beta testing!! You were warned!! * TODO: * Hash command lookups to save time - * Create a running pointer to **path and advance/rewind it as we go */ + * Create a running pointer to **path and advance/rewind it as we go + */ #include @@ -66,6 +68,8 @@ } -/* Returns the full path of "cmd" if cmd is found, else just hand back - * cmd as it was presented */ +/** Returns the full path of "cmd" if cmd is found + * + * else just hand back cmd as it was presented + */ static char *find_command(char *cmd) { Index: uspace/app/bdsh/input.c =================================================================== --- uspace/app/bdsh/input.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/input.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -62,7 +62,9 @@ static void print_pipe_usage(void); -/* Tokenizes input from console, sees if the first word is a built-in, if so +/* + * Tokenizes input from console, sees if the first word is a built-in, if so * invokes the built-in entry point (a[0]) passing all arguments in a[] to - * the handler */ + * the handler + */ errno_t process_input(cliuser_t *usr) { @@ -105,5 +107,6 @@ } - /* Until full support for pipes is implemented, allow for a simple case: + /* + * Until full support for pipes is implemented, allow for a simple case: * [from |] command [| to ] * Index: uspace/app/bdsh/scli.c =================================================================== --- uspace/app/bdsh/scli.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/scli.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -43,11 +43,15 @@ static iostate_t stdiostate; -/* Globals that are modified during start-up that modules/builtins - * should be aware of. */ +/* + * Globals that are modified during start-up that modules/builtins + * should be aware of. + */ volatile unsigned int cli_quit = 0; volatile unsigned int cli_verbocity = 1; -/* The official name of this program - * (change to your liking in configure.ac and re-run autoconf) */ +/* + * The official name of this program + * (change to your liking in configure.ac and re-run autoconf) + */ const char *progname = PACKAGE_NAME; Index: uspace/app/bdsh/tok.c =================================================================== --- uspace/app/bdsh/tok.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/tok.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -97,5 +97,6 @@ while ((next_char = tok_look_char(tok)) != 0) { if (next_char == ' ') { - /* Push the token if there is any. + /* + * Push the token if there is any. * There may not be any pending char for a token in case * there are several spaces in the input. @@ -115,5 +116,6 @@ } else if (next_char == '|') { - /* Pipes are tokens that are delimiters and should be + /* + * Pipes are tokens that are delimiters and should be * output as a separate token */ @@ -137,5 +139,6 @@ } } else if (next_char == '\'') { - /* A string starts with a quote (') and ends again with a quote. + /* + * A string starts with a quote (') and ends again with a quote. * A literal quote is written as '' */ @@ -151,5 +154,6 @@ tok_start_token(tok, TOKTYPE_TEXT); } - /* If we are handling any other character, just append it to + /* + * If we are handling any other character, just append it to * the current token. */ Index: uspace/app/bdsh/util.c =================================================================== --- uspace/app/bdsh/util.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/bdsh/util.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -52,7 +52,9 @@ } -/* (re)allocates memory to store the current working directory, gets +/* + * (re)allocates memory to store the current working directory, gets * and updates the current working directory, formats the prompt - * string */ + * string + */ unsigned int cli_set_prompt(cliuser_t *usr) { Index: uspace/app/edit/sheet.c =================================================================== --- uspace/app/edit/sheet.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/edit/sheet.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -146,5 +146,5 @@ * * @return EOK on success or an error code. - **/ + */ errno_t sheet_delete(sheet_t *sh, spt_t *spos, spt_t *epos) { Index: uspace/app/mkexfat/mkexfat.c =================================================================== --- uspace/app/mkexfat/mkexfat.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/mkexfat/mkexfat.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -158,5 +158,6 @@ cfg->cluster_size = DEFAULT_CLUSTER_SIZE; - /* Compute the required cluster size to index + /* + * Compute the required cluster size to index * the entire storage device and to keep the FAT * size less or equal to 64 Mb. @@ -179,5 +180,6 @@ cfg->fat_sector_count, cfg->cluster_size / cfg->sector_size); - /* Subtract the FAT space from the total + /* + * Subtract the FAT space from the total * number of available clusters. */ @@ -369,5 +371,6 @@ } - /* The OEM record is not yet used + /* + * The OEM record is not yet used * by the official exFAT implementation, we'll fill * it with zeroes. @@ -467,5 +470,6 @@ if (cur_cls == fat_entries) { - /* This sector is full, there are no more free entries, + /* + * This sector is full, there are no more free entries, * commit the changes to disk and restart from the next * sector. @@ -477,5 +481,6 @@ goto loop; } else if (ncls == 1) { - /* This is the last cluster of this chain, mark it + /* + * This is the last cluster of this chain, mark it * with EOF. */ @@ -571,5 +576,6 @@ if (table_size < cfg->sector_size) { - /* Reset the content of the unused part + /* + * Reset the content of the unused part * of the last sector. */ @@ -656,5 +662,6 @@ goto exit; - /* Fill the content of the sectors not used by the + /* + * Fill the content of the sectors not used by the * root directory with zeroes. */ Index: uspace/app/sbi/src/parse.c =================================================================== --- uspace/app/sbi/src/parse.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/sbi/src/parse.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1397,5 +1397,5 @@ } -/* Parse @c with-except-finally statement. +/** Parse @c with-except-finally statement. * * @param parse Parser object. @@ -1443,5 +1443,5 @@ } -/* Parse expression statement. +/** Parse expression statement. * * @param parse Parser object. @@ -1465,5 +1465,5 @@ } -/* Parse @c except clause. +/** Parse @c except clause. * * @param parse Parser object. Index: uspace/app/tester/mm/common.c =================================================================== --- uspace/app/tester/mm/common.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/tester/mm/common.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -179,5 +179,5 @@ -/* Allocate block +/** Allocate block * * Allocate a block of memory of @size bytes and add record about it into @@ -321,5 +321,5 @@ } -/* Map memory area +/** Map memory area * * Map a memory area of @size bytes and add record about it into Index: uspace/app/top/top.c =================================================================== --- uspace/app/top/top.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/top/top.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -248,6 +248,8 @@ static void compute_percentages(data_t *old_data, data_t *new_data) { - /* For each CPU: Compute total cycles and divide it between - user and kernel */ + /* + * For each CPU: Compute total cycles and divide it between + * user and kernel + */ size_t i; Index: uspace/app/usbinfo/list.c =================================================================== --- uspace/app/usbinfo/list.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/usbinfo/list.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -81,6 +81,8 @@ printf("Bus %" PRIun ": %s\n", svc, path); - /* Construct device's path. - * That's "hc function path" - ( '/' + "hc function name" ) */ + /* + * Construct device's path. + * That's "hc function path" - ( '/' + "hc function name" ) + */ // TODO replace this with something sane Index: uspace/app/vuhid/device.c =================================================================== --- uspace/app/vuhid/device.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/vuhid/device.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -271,5 +271,6 @@ } - /* Allocation is okay, we can (actually have to now) overwrite the + /* + * Allocation is okay, we can (actually have to now) overwrite the * original pointer. */ Index: uspace/app/wavplay/dplay.c =================================================================== --- uspace/app/wavplay/dplay.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/app/wavplay/dplay.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -262,6 +262,8 @@ while (true) { size_t available = buffer_avail(pb, pos); - /* Writing might need wrap around the end, - * read directly to device buffer */ + /* + * Writing might need wrap around the end, + * read directly to device buffer + */ size_t bytes = fread(pb->buffer.write_ptr, sizeof(uint8_t), min(available, buffer_remain(pb)), pb->source); @@ -319,6 +321,8 @@ getuptime(&time); - /* we did not use all the space we had, - * that is the end */ + /* + * we did not use all the space we had, + * that is the end + */ if (available) break; Index: uspace/dist/src/c/demos/edit/sheet.c =================================================================== --- uspace/dist/src/c/demos/edit/sheet.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/dist/src/c/demos/edit/sheet.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -146,5 +146,5 @@ * * @return EOK on success or an error code. - **/ + */ errno_t sheet_delete(sheet_t *sh, spt_t *spos, spt_t *epos) { Index: uspace/dist/src/c/demos/top/top.c =================================================================== --- uspace/dist/src/c/demos/top/top.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/dist/src/c/demos/top/top.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -248,6 +248,8 @@ static void compute_percentages(data_t *old_data, data_t *new_data) { - /* For each CPU: Compute total cycles and divide it between - user and kernel */ + /* + * For each CPU: Compute total cycles and divide it between + * user and kernel + */ size_t i; Index: uspace/drv/audio/sb16/dsp.c =================================================================== --- uspace/drv/audio/sb16/dsp.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/audio/sb16/dsp.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -357,6 +357,8 @@ assert(size); - /* buffer is already setup by for someone, refuse to work until - * it's released */ + /* + * buffer is already setup by for someone, refuse to work until + * it's released + */ if (dsp->state != DSP_NO_BUFFER) return EBUSY; Index: uspace/drv/audio/sb16/sb16.c =================================================================== --- uspace/drv/audio/sb16/sb16.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/audio/sb16/sb16.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -49,6 +49,8 @@ }; -/* ISA interrupts should be edge-triggered so there should be no need for - * irq code magic, but we still need to ack those interrupts ASAP. */ +/* + * ISA interrupts should be edge-triggered so there should be no need for + * irq code magic, but we still need to ack those interrupts ASAP. + */ static const irq_cmd_t irq_cmds[] = { { .cmd = CMD_PIO_READ_8, .dstarg = 1 }, /* Address patched at runtime */ @@ -192,7 +194,9 @@ { assert(sb); - /* The acknowledgment of interrupts on DSP version 4.xx is different; + /* + * The acknowledgment of interrupts on DSP version 4.xx is different; * It can contain MPU-401 indicator and DMA16 transfers are acked - * differently */ + * differently + */ if (sb->dsp.version.major >= 4) { pio_write_8(&sb->regs->mixer_address, MIXER_IRQ_STATUS_ADDRESS); Index: uspace/drv/block/ahci/ahci_hw.h =================================================================== --- uspace/drv/block/ahci/ahci_hw.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/block/ahci/ahci_hw.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -273,5 +273,6 @@ /** AHCI PCI register Interrupt Information. */ typedef struct { - /* Software written value to indicate which interrupt vector + /* + * Software written value to indicate which interrupt vector * the interrupt is connected to. */ Index: uspace/drv/block/usbmast/bo_trans.c =================================================================== --- uspace/drv/block/usbmast/bo_trans.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/block/usbmast/bo_trans.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -209,5 +209,6 @@ void usb_massstor_reset_recovery(usbmast_dev_t *mdev) { - /* We would ignore errors here because if this fails + /* + * We would ignore errors here because if this fails * we are doomed anyway and any following transaction would fail. */ Index: uspace/drv/block/usbmast/scsi_ms.c =================================================================== --- uspace/drv/block/usbmast/scsi_ms.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/block/usbmast/scsi_ms.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -93,5 +93,6 @@ return rc; } - /* Ignore command error here. If there's something wrong + /* + * Ignore command error here. If there's something wrong * with the device the following commands will fail too. */ Index: uspace/drv/bus/isa/i8237.c =================================================================== --- uspace/drv/bus/isa/i8237.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/isa/i8237.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -485,7 +485,9 @@ uint16_t remain = (value_high << 8 | value_low); - /* 16 bit DMA size is in words, + /* + * 16 bit DMA size is in words, * the upper bits are bogus for 16bit transfers so we need to get - * rid of them. Using limited type works well.*/ + * rid of them. Using limited type works well. + */ if (is_dma16(channel)) remain <<= 1; Index: uspace/drv/bus/usb/ehci/ehci_batch.c =================================================================== --- uspace/drv/bus/usb/ehci/ehci_batch.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ehci/ehci_batch.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -47,8 +47,10 @@ #include "ehci_bus.h" -/* The buffer pointer list in the qTD is long enough to support a maximum +/* + * The buffer pointer list in the qTD is long enough to support a maximum * transfer size of 20K bytes. This case occurs when all five buffer pointers * are used and the first offset is zero. A qTD handles a 16Kbyte buffer - * with any starting buffer alignment. EHCI specs p. 87 (pdf p. 97) */ + * with any starting buffer alignment. EHCI specs p. 87 (pdf p. 97) + */ #define EHCI_TD_MAX_TRANSFER (16 * 1024) @@ -177,6 +179,8 @@ return false; - /* Now we may be sure that either the ED is inactive because of errors - * or all transfer descriptors completed successfully */ + /* + * Now we may be sure that either the ED is inactive because of errors + * or all transfer descriptors completed successfully + */ /* Assume all data got through */ @@ -192,5 +196,6 @@ ehci_batch->base.error = td_error(&ehci_batch->tds[i]); if (ehci_batch->base.error == EOK) { - /* If the TD got all its data through, it will report + /* + * If the TD got all its data through, it will report * 0 bytes remain, the sole exception is INPUT with * data rounding flag (short), i.e. every INPUT. Index: uspace/drv/bus/usb/ehci/ehci_rh.c =================================================================== --- uspace/drv/bus/usb/ehci/ehci_rh.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ehci/ehci_rh.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -72,7 +72,9 @@ instance->hub_descriptor.header.descriptor_type = USB_DESCTYPE_HUB; instance->hub_descriptor.header.port_count = instance->port_count; - /* Bits 0,1 indicate power switching mode + /* + * Bits 0,1 indicate power switching mode * Bit 2 indicates device type (compound device) - * Bits 3,4 indicate over-current protection mode */ + * Bits 3,4 indicate over-current protection mode + */ instance->hub_descriptor.header.characteristics = 0 | ((hcs & EHCI_CAPS_HCS_PPC_FLAG) ? 0x09 : 0x12) | @@ -313,6 +315,8 @@ EHCI2USB(reg, USB_PORTSC_OC_CHANGE_FLAG, USB_HUB_PORT_STATUS_C_OC) | (hub->reset_flag[port] ? USB_HUB_PORT_STATUS_C_RESET : 0)); - /* Note feature numbers for test and indicator feature do not - * correspond to the port status bit locations */ + /* + * Note feature numbers for test and indicator feature do not + * correspond to the port status bit locations + */ usb_log_debug2("RH(%p-%u) port status: %" PRIx32 "(%" PRIx32 ")", hub, port, status, reg); @@ -340,6 +344,8 @@ } usb_log_debug("RH(%p-%u): Reset complete", job->hub, job->port); - /* Handle port ownership, if the port is not enabled - * after reset it's a full speed device */ + /* + * Handle port ownership, if the port is not enabled + * after reset it's a full speed device + */ if (!(EHCI_RD(job->hub->registers->portsc[job->port]) & USB_PORTSC_ENABLED_FLAG)) { Index: uspace/drv/bus/usb/ehci/hc.c =================================================================== --- uspace/drv/bus/usb/ehci/hc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ehci/hc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -395,6 +395,8 @@ usb_log_debug("HC(%p): Starting HW.", instance); - /* Turn off the HC if it's running, Reseting a running device is - * undefined */ + /* + * Turn off the HC if it's running, Reseting a running device is + * undefined + */ if (!(EHCI_RD(instance->registers->usbsts) & USB_STS_HC_HALTED_FLAG)) { /* disable all interrupts */ @@ -487,8 +489,10 @@ return ret; } - /* Specs say "Software must set queue head horizontal pointer T-bits to + /* + * Specs say "Software must set queue head horizontal pointer T-bits to * a zero for queue heads in the asynchronous schedule" (4.4.0). * So we must maintain circular buffer (all horizontal pointers - * have to be valid */ + * have to be valid + */ endpoint_list_chain(&instance->async_list, &instance->async_list); Index: uspace/drv/bus/usb/ehci/hw_struct/queue_head.c =================================================================== --- uspace/drv/bus/usb/ehci/hw_struct/queue_head.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ehci/hw_struct/queue_head.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -61,6 +61,8 @@ EHCI_MEM32_WR(instance->alternate, LINK_POINTER_TERM); if (ep == NULL) { - /* Mark as halted and list head, - * used by endpoint lists as dummy */ + /* + * Mark as halted and list head, + * used by endpoint lists as dummy + */ EHCI_MEM32_WR(instance->ep_char, QH_EP_CHAR_H_FLAG); EHCI_MEM32_WR(instance->status, QH_STATUS_HALTED_FLAG); @@ -76,6 +78,8 @@ if (ep->device->speed != USB_SPEED_HIGH) EHCI_MEM32_SET(instance->ep_char, QH_EP_CHAR_C_FLAG); - /* Let BULK and INT use queue head managed toggle, - * CONTROL needs special toggle handling anyway */ + /* + * Let BULK and INT use queue head managed toggle, + * CONTROL needs special toggle handling anyway + */ EHCI_MEM32_SET(instance->ep_char, QH_EP_CHAR_DTC_FLAG); } @@ -96,6 +100,8 @@ EHCI_MEM32_WR(instance->ep_cap, ep_cap); - /* The rest of the fields are transfer working area, it should be ok to - * leave it NULL */ + /* + * The rest of the fields are transfer working area, it should be ok to + * leave it NULL + */ } Index: uspace/drv/bus/usb/ehci/res.c =================================================================== --- uspace/drv/bus/usb/ehci/res.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ehci/res.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -80,6 +80,8 @@ usb_log_debug2("USBLEGSUP: %" PRIx32 ".", usblegsup); - /* Request control from firmware/BIOS by writing 1 to highest - * byte. (OS Control semaphore)*/ + /* + * Request control from firmware/BIOS by writing 1 to highest + * byte. (OS Control semaphore) + */ usb_log_debug("Requesting OS control."); ret = pci_config_space_write_8(parent_sess, @@ -187,6 +189,8 @@ usb_log_debug2("Value of hcc params register: %x.", hcc_params); - /* Read value of EHCI Extended Capabilities Pointer - * position of EEC registers (points to PCI config space) */ + /* + * Read value of EHCI Extended Capabilities Pointer + * position of EEC registers (points to PCI config space) + */ const uint32_t eecp = (hcc_params >> EHCI_CAPS_HCC_EECP_SHIFT) & EHCI_CAPS_HCC_EECP_MASK; Index: uspace/drv/bus/usb/ohci/hc.c =================================================================== --- uspace/drv/bus/usb/ohci/hc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ohci/hc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -400,5 +400,6 @@ usb_log_debug("Requesting OHCI control."); if (OHCI_RD(instance->registers->revision) & R_LEGACY_FLAG) { - /* Turn off legacy emulation, it should be enough to zero + /* + * Turn off legacy emulation, it should be enough to zero * the lowest bit, but it caused problems. Thus clear all * except GateA20 (causes restart on some hw). @@ -447,6 +448,8 @@ } - /* HC is in reset (hw startup) => no other driver - * maintain reset for at least the time specified in USB spec (50 ms)*/ + /* + * HC is in reset (hw startup) => no other driver + * maintain reset for at least the time specified in USB spec (50 ms) + */ usb_log_debug("Host controller found in reset state."); async_usleep(50000); Index: uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.c =================================================================== --- uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -69,6 +69,8 @@ if (ep == NULL) { - /* Mark as dead, used for dummy EDs at the beginning of - * endpoint lists. */ + /* + * Mark as dead, used for dummy EDs at the beginning of + * endpoint lists. + */ OHCI_MEM32_WR(instance->status, ED_STATUS_K_FLAG); return; Index: uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h =================================================================== --- uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -51,5 +51,6 @@ * OHCI Endpoint Descriptor representation. * - * See OHCI spec. Chapter 4.2, page 16 (pdf page 30) for details */ + * See OHCI spec. Chapter 4.2, page 16 (pdf page 30) for details + */ typedef struct ed { /** Index: uspace/drv/bus/usb/ohci/hw_struct/transfer_descriptor.h =================================================================== --- uspace/drv/bus/usb/ohci/hw_struct/transfer_descriptor.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ohci/hw_struct/transfer_descriptor.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -44,7 +44,9 @@ #include "completion_codes.h" -/* OHCI TDs can handle up to 8KB buffers, however, it can use max 2 pages. +/* + * OHCI TDs can handle up to 8KB buffers, however, it can use max 2 pages. * Using 4KB buffers guarantees the page count condition. - * (OHCI assumes 4KB pages) */ + * (OHCI assumes 4KB pages) + */ #define OHCI_TD_MAX_TRANSFER (4 * 1024) @@ -76,5 +78,6 @@ /** * Current buffer pointer. - * Phys address of the first byte to be transferred. */ + * Phys address of the first byte to be transferred. + */ volatile uint32_t cbp; @@ -105,7 +108,9 @@ const int cc = (OHCI_MEM32_RD(instance->status) >> TD_STATUS_CC_SHIFT) & TD_STATUS_CC_MASK; - /* This value is changed on transfer completion, + /* + * This value is changed on transfer completion, * either to CC_NOERROR or and error code. - * See OHCI spec 4.3.1.3.5 p. 23 (pdf 37) */ + * See OHCI spec 4.3.1.3.5 p. 23 (pdf 37) + */ if (cc != CC_NOACCESS1 && cc != CC_NOACCESS2) { return true; Index: uspace/drv/bus/usb/ohci/ohci_batch.c =================================================================== --- uspace/drv/bus/usb/ohci/ohci_batch.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/ohci/ohci_batch.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -163,6 +163,8 @@ return false; - /* Now we may be sure that either the ED is inactive because of errors - * or all transfer descriptors completed successfully */ + /* + * Now we may be sure that either the ED is inactive because of errors + * or all transfer descriptors completed successfully + */ /* Assume all data got through */ @@ -178,5 +180,6 @@ usb_batch->error = td_error(ohci_batch->tds[i]); if (usb_batch->error == EOK) { - /* If the TD got all its data through, it will report + /* + * If the TD got all its data through, it will report * 0 bytes remain, the sole exception is INPUT with * data rounding flag (short), i.e. every INPUT. @@ -199,5 +202,6 @@ assert((ohci_ep->ed->td_head & ED_TDHEAD_HALTED_FLAG) != 0); - /* We don't care where the processing stopped, we just + /* + * We don't care where the processing stopped, we just * need to make sure it's not using any of the TDs owned * by the transfer. Index: uspace/drv/bus/usb/uhci/hw_struct/queue_head.h =================================================================== --- uspace/drv/bus/usb/uhci/hw_struct/queue_head.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/hw_struct/queue_head.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -78,7 +78,9 @@ static inline void qh_set_next_qh(qh_t *instance, qh_t *next) { - /* Physical address has to be below 4GB, + /* + * Physical address has to be below 4GB, * it is an UHCI limitation and malloc32 - * should guarantee this */ + * should guarantee this + */ const uint32_t pa = addr_to_phys(next); if (pa) { @@ -98,7 +100,9 @@ static inline void qh_set_element_td(qh_t *instance, td_t *td) { - /* Physical address has to be below 4GB, + /* + * Physical address has to be below 4GB, * it is an UHCI limitation and malloc32 - * should guarantee this */ + * should guarantee this + */ const uint32_t pa = addr_to_phys(td); if (pa) { Index: uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.c =================================================================== --- uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -127,6 +127,8 @@ return EIO; - /* CRC or timeout error, like device not present or bad data, - * it won't be reported unless err count reached zero */ + /* + * CRC or timeout error, like device not present or bad data, + * it won't be reported unless err count reached zero + */ if ((instance->status & TD_STATUS_ERROR_CRC) != 0) return EBADCHECKSUM; @@ -144,6 +146,8 @@ return EIO; - /* Stall might represent err count reaching zero or stall response from - * the device. If err count reached zero, one of the above is reported*/ + /* + * Stall might represent err count reaching zero or stall response from + * the device. If err count reached zero, one of the above is reported + */ if ((instance->status & TD_STATUS_ERROR_STALLED) != 0) return ESTALL; Index: uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.h =================================================================== --- uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/hw_struct/transfer_descriptor.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -90,5 +90,6 @@ volatile uint32_t buffer_ptr; - /* According to UHCI design guide, there is 16 bytes of + /* + * According to UHCI design guide, there is 16 bytes of * data available here. * According to Linux kernel the hardware does not care, Index: uspace/drv/bus/usb/uhci/main.c =================================================================== --- uspace/drv/bus/usb/uhci/main.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/main.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -76,6 +76,8 @@ return ENOMEM; - /* See UHCI design guide page 45 for these values. - * Write all WC bits in USB legacy register */ + /* + * See UHCI design guide page 45 for these values. + * Write all WC bits in USB legacy register + */ return pci_config_space_write_16(parent_sess, 0xc0, 0xaf00); } Index: uspace/drv/bus/usb/uhci/uhci_batch.c =================================================================== --- uspace/drv/bus/usb/uhci/uhci_batch.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/uhci_batch.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -87,5 +87,6 @@ } -/* Prepares batch for commiting. +/* + * Prepares batch for committing. * * Determines the number of needed transfer descriptors (TDs). Index: uspace/drv/bus/usb/uhci/uhci_rh.c =================================================================== --- uspace/drv/bus/usb/uhci/uhci_rh.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/uhci/uhci_rh.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -153,9 +153,13 @@ while ((port_status = pio_read_16(port)) & STATUS_IN_RESET) ; - /* PIO delay, should not be longer than 3ms as the device might - * enter suspend state. */ + /* + * PIO delay, should not be longer than 3ms as the device might + * enter suspend state. + */ udelay(10); - /* Drop ConnectionChange as some UHCI hw - * sets this bit after reset, that is incorrect */ + /* + * Drop ConnectionChange as some UHCI hw + * sets this bit after reset, that is incorrect + */ port_status &= ~STATUS_WC_BITS; pio_write_16(port, port_status | STATUS_ENABLED | STATUS_CONNECTED_CHANGED); @@ -376,6 +380,8 @@ RH_DEBUG(hub, port, "Set port change flag (status %" PRIx16 ")", status); - /* These are voluntary and don't have to be set - * there is no way we could do it on UHCI anyway */ + /* + * These are voluntary and don't have to be set + * there is no way we could do it on UHCI anyway + */ break; default: @@ -459,6 +465,8 @@ CLASS_REQ_OUT(USB_REQUEST_RECIPIENT_DEVICE, USB_HUB_REQUEST_CLEAR_FEATURE), .name = "ClearHubFeature", - /* Hub features are overcurrent and supply good, - * this request may only clear changes that we never report*/ + /* + * Hub features are overcurrent and supply good, + * this request may only clear changes that we never report + */ .callback = req_nop, }, @@ -471,6 +479,8 @@ CLASS_REQ_IN(USB_REQUEST_RECIPIENT_DEVICE, USB_HUB_REQUEST_GET_STATUS), .name = "GetHubStatus", - /* UHCI can't report OC condition or, - * lose power source */ + /* + * UHCI can't report OC condition or, + * lose power source + */ .callback = virthub_base_get_null_status, }, @@ -483,6 +493,8 @@ CLASS_REQ_OUT(USB_REQUEST_RECIPIENT_DEVICE, USB_HUB_REQUEST_SET_FEATURE), .name = "SetHubFeature", - /* Hub features are overcurrent and supply good, - * this request may only set changes that we never report*/ + /* + * Hub features are overcurrent and supply good, + * this request may only set changes that we never report + */ .callback = req_nop, }, Index: uspace/drv/bus/usb/usbhub/port.c =================================================================== --- uspace/drv/bus/usb/usbhub/port.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/usbhub/port.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -236,9 +236,11 @@ const bool overcurrent = !!(status & USB_HUB_PORT_STATUS_OC); - /* According to the USB specs: + /* + * According to the USB specs: * 11.13.5 Over-current Reporting and Recovery * Hub device is responsible for putting port in power off * mode. USB system software is responsible for powering port - * back on when the over-current condition is gone */ + * back on when the over-current condition is gone + */ usb_port_disabled(&port->base, &remove_device); Index: uspace/drv/bus/usb/usbhub/usbhub.c =================================================================== --- uspace/drv/bus/usb/usbhub/usbhub.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/usbhub/usbhub.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -460,6 +460,8 @@ } - /* Set configuration. Use the configuration that was in - * usb_device->descriptors.configuration i.e. The first one. */ + /* + * Set configuration. Use the configuration that was in + * usb_device->descriptors.configuration i.e. The first one. + */ errno_t opResult = usb_request_set_configuration( usb_device_get_default_pipe(usb_device), @@ -593,7 +595,9 @@ assert(status); - /* USB hub specific GET_PORT_STATUS request. See USB Spec 11.16.2.6 + /* + * USB hub specific GET_PORT_STATUS request. See USB Spec 11.16.2.6 * Generic GET_STATUS request cannot be used because of the difference - * in status data size (2B vs. 4B)*/ + * in status data size (2B vs. 4B) + */ const usb_device_request_setup_packet_t request = { .request_type = USB_HUB_REQ_TYPE_GET_PORT_STATUS, @@ -635,6 +639,8 @@ usb_hub_status_t status; size_t rcvd_size; - /* NOTE: We can't use standard USB GET_STATUS request, because - * hubs reply is 4byte instead of 2 */ + /* + * NOTE: We can't use standard USB GET_STATUS request, because + * hubs reply is 4byte instead of 2 + */ const errno_t opResult = usb_pipe_control_read(control_pipe, &get_hub_status_request, sizeof(get_hub_status_request), @@ -666,5 +672,6 @@ if (status & USB_HUB_STATUS_C_LOCAL_POWER) { - /* NOTE: Handling this is more complicated. + /* + * NOTE: Handling this is more complicated. * If the transition is from bus power to local power, all * is good and we may signal the parent hub that we don't Index: uspace/drv/bus/usb/usbmid/explore.c =================================================================== --- uspace/drv/bus/usb/usbmid/explore.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/usbmid/explore.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -85,6 +85,8 @@ usb_dp_get_nested_descriptor(&parser, &data, config_descriptor); - /* Walk all descriptors nested in the current configuration decriptor; - * i.e. all interface descriptors. */ + /* + * Walk all descriptors nested in the current configuration decriptor; + * i.e. all interface descriptors. + */ for (; interface_ptr != NULL; interface_ptr = usb_dp_get_sibling_descriptor( @@ -99,6 +101,8 @@ /* Skip alternate interfaces. */ if (interface_in_list(list, interface->interface_number)) { - /* TODO: add the alternatives and create match ids - * for them. */ + /* + * TODO: add the alternatives and create match ids + * for them. + */ continue; } Index: uspace/drv/bus/usb/xhci/commands.c =================================================================== --- uspace/drv/bus/usb/xhci/commands.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/xhci/commands.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -358,5 +358,6 @@ if (code == XHCI_TRBC_COMMAND_RING_STOPPED) { - /* This can either mean that the ring is being stopped, or + /* + * This can either mean that the ring is being stopped, or * a command was aborted. In either way, wake threads waiting * on stopped_cv. @@ -671,5 +672,6 @@ if (XHCI_REG_RD(hc->op_regs, XHCI_OP_CRR)) { - /* 4.6.1.2, implementation note + /* + * 4.6.1.2, implementation note * Assume there are larger problems with HC and * reset it. @@ -720,5 +722,6 @@ &cmd->_header.completed_mtx, XHCI_COMMAND_TIMEOUT); - /* The waiting timed out. Current command (not necessarily + /* + * The waiting timed out. Current command (not necessarily * ours) is probably blocked. */ Index: uspace/drv/bus/usb/xhci/hc.c =================================================================== --- uspace/drv/bus/usb/xhci/hc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/xhci/hc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -534,6 +534,8 @@ joinable_fibril_join(hc->event_worker); - /* Then, disconnect all roothub devices, which shall trigger - * disconnection of everything */ + /* + * Then, disconnect all roothub devices, which shall trigger + * disconnection of everything + */ xhci_rh_stop(&hc->rh); } @@ -576,6 +578,8 @@ XHCI_REG_WR(hc->rt_regs->ir, XHCI_INTR_IP, 1); - /* interrupt handler expects status from irq_commands, which is - * in xhci order. */ + /* + * interrupt handler expects status from irq_commands, which is + * in xhci order. + */ *status = host2xhci(32, *status); } @@ -873,6 +877,8 @@ xhci_endpoint_t *ep0 = xhci_endpoint_get(dev->base.endpoints[0]); - /* Although we have the precise PSIV value on devices of tier 1, - * we have to rely on reverse mapping on others. */ + /* + * Although we have the precise PSIV value on devices of tier 1, + * we have to rely on reverse mapping on others. + */ if (!usb_speed_to_psiv[dev->base.speed]) { usb_log_error("Device reported an USB speed (%s) that cannot be mapped " Index: uspace/drv/bus/usb/xhci/hw_struct/regs.h =================================================================== --- uspace/drv/bus/usb/xhci/hw_struct/regs.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/xhci/hw_struct/regs.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -368,5 +368,6 @@ ioport32_t dnctrl; - /* 3 2 1 0 + /* + * 3 2 1 0 * 3:0 - CRR CA CS RCS * 64:6 - Command Ring Pointer Index: uspace/drv/bus/usb/xhci/rh.c =================================================================== --- uspace/drv/bus/usb/xhci/rh.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/bus/usb/xhci/rh.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -291,5 +291,6 @@ joinable_fibril_start(rh->event_worker); - /* The reset changed status of all ports, and SW originated reason does + /* + * The reset changed status of all ports, and SW originated reason does * not cause an interrupt. */ Index: uspace/drv/fb/amdm37x_dispc/amdm37x_dispc.c =================================================================== --- uspace/drv/fb/amdm37x_dispc/amdm37x_dispc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/fb/amdm37x_dispc/amdm37x_dispc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -169,6 +169,8 @@ { assert(regs); - /* Init sequence for dispc is in chapter 7.6.5.1.4 p. 1810, - * no idea what parts of that work. */ + /* + * Init sequence for dispc is in chapter 7.6.5.1.4 p. 1810, + * no idea what parts of that work. + */ /* Disable all interrupts */ @@ -248,6 +250,8 @@ /* 0x03ff03c0 is the default */ regs->gfx.fifo_threshold = 0x03ff03c0; - /* This value should be stride - width, 1 means next pixel i.e. - * stride == width */ + /* + * This value should be stride - width, 1 means next pixel i.e. + * stride == width + */ regs->gfx.row_inc = 1; /* number of bytes to next pixel in BPP multiples */ Index: uspace/drv/hid/usbhid/kbd/kbddev.c =================================================================== --- uspace/drv/hid/usbhid/kbd/kbddev.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/hid/usbhid/kbd/kbddev.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -174,6 +174,8 @@ async_answer_0(icall_handle, EOK); break; - /* This might be ugly but async_callback_receive_start makes no - * difference for incorrect call and malloc failure. */ + /* + * This might be ugly but async_callback_receive_start makes no + * difference for incorrect call and malloc failure. + */ case IPC_M_CONNECT_TO_ME: sess = async_callback_receive_start(EXCHANGE_SERIALIZE, icall); @@ -579,6 +581,8 @@ } - /* Set LEDs according to initial setup. - * Set Idle rate */ + /* + * Set LEDs according to initial setup. + * Set Idle rate + */ usb_kbd_set_led(hid_dev, kbd_dev); @@ -649,6 +653,8 @@ } - /* Store the initialized HID device and HID ops - * to the DDF function. */ + /* + * Store the initialized HID device and HID ops + * to the DDF function. + */ ddf_fun_set_ops(fun, &kbdops); Index: uspace/drv/hid/usbhid/main.c =================================================================== --- uspace/drv/hid/usbhid/main.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/hid/usbhid/main.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -87,7 +87,9 @@ usb_log_debug("USB/HID device structure initialized."); - /* Start automated polling function. + /* + * Start automated polling function. * This will create a separate fibril that will query the device - * for the data continuously. */ + * for the data continuously. + */ rc = usb_polling_start(&hid_dev->polling); Index: uspace/drv/hid/usbhid/multimedia/multimedia.c =================================================================== --- uspace/drv/hid/usbhid/multimedia/multimedia.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/hid/usbhid/multimedia/multimedia.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -230,6 +230,8 @@ } else { usb_log_debug2("%s unbound.", ddf_fun_get_name(fun)); - /* This frees multim_dev too as it was stored in - * fun->data */ + /* + * This frees multim_dev too as it was stored in + * fun->data + */ ddf_fun_destroy(fun); } Index: uspace/drv/hid/usbhid/usbhid.c =================================================================== --- uspace/drv/hid/usbhid/usbhid.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/hid/usbhid/usbhid.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -511,6 +511,8 @@ if (ok) { - /* Save max input report size and - * allocate space for the report */ + /* + * Save max input report size and + * allocate space for the report + */ rc = usb_hid_init_report(hid_dev); if (rc != EOK) { Index: uspace/drv/nic/ne2k/ne2k.c =================================================================== --- uspace/drv/nic/ne2k/ne2k.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/nic/ne2k/ne2k.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -279,5 +279,6 @@ return EINVAL; } - /* Note: some frame with previous physical address may slip to NIL here + /* + * Note: some frame with previous physical address may slip to NIL here * (for a moment the filtering is not exact), but ethernet should be OK with * that. Some frames may also be lost, but this is not a problem. Index: uspace/drv/nic/rtl8139/driver.c =================================================================== --- uspace/drv/nic/rtl8139/driver.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/nic/rtl8139/driver.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -500,5 +500,6 @@ } -/* Reset receiver +/* + * Reset receiver * * Use in the case of receiver error (lost in the rx_buff) @@ -604,5 +605,6 @@ rx_offset = ALIGN_UP(rx_offset + size + RTL_FRAME_HEADER_SIZE, 4); - /* Write lesser value to prevent overflow into unread frame + /* + * Write lesser value to prevent overflow into unread frame * (the recomendation from the RealTech rtl8139 programming guide) */ @@ -793,5 +795,6 @@ } - /* Check transmittion interrupts first to allow transmit next frames + /* + * Check transmittion interrupts first to allow transmit next frames * sooner */ @@ -2097,5 +2100,6 @@ rtl8139->int_mask = INT_TIME_OUT; - /* Force timer interrupt start be writing nonzero value to timer + /* + * Force timer interrupt start be writing nonzero value to timer * interrutp register (should be small to prevent big delay) * Read TCTR to reset timer counter Index: uspace/drv/nic/rtl8139/general.c =================================================================== --- uspace/drv/nic/rtl8139/general.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/nic/rtl8139/general.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -65,5 +65,6 @@ size_t rem_size = data_size - to_src_end; - /* First copy the end part of the data (from the source begining), + /* + * First copy the end part of the data (from the source begining), * then copy the begining */ Index: uspace/drv/platform/amdm37x/amdm37x.c =================================================================== --- uspace/drv/platform/amdm37x/amdm37x.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/platform/amdm37x/amdm37x.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -127,6 +127,8 @@ { assert(device); - /* Get SYS_CLK value, it is used as reference clock by all DPLLs, - * NFI who sets this or why it is set to specific value. */ + /* + * Get SYS_CLK value, it is used as reference clock by all DPLLs, + * NFI who sets this or why it is set to specific value. + */ const unsigned osc_clk = pio_read_32(&device->prm.clocks->clksel) & CLOCK_CONTROL_PRM_CLKSEL_SYS_CLKIN_MASK; @@ -138,8 +140,10 @@ - /* DPLL1 provides MPU(CPU) clock. + /* + * DPLL1 provides MPU(CPU) clock. * It uses SYS_CLK as reference clock and core clock (DPLL3) as * high frequency bypass (MPU then runs on L3 interconnect freq). - * It should be setup by fw or u-boot.*/ + * It should be setup by fw or u-boot. + */ mpu_cm_regs_t *mpu = device->cm.mpu; @@ -183,6 +187,8 @@ // TODO: Enable this (automatic MPU downclocking): #if 0 - /* Enable low power bypass mode, this will take effect the next lock or - * relock sequence. */ + /* + * Enable low power bypass mode, this will take effect the next lock or + * relock sequence. + */ //TODO: We might need to force re-lock after enabling this pio_set_32(&mpu->clken_pll, MPU_CM_CLKEN_PLL_EN_MPU_DPLL_LP_MODE_FLAG, 5); @@ -191,11 +197,14 @@ #endif - /* DPLL2 provides IVA(video acceleration) clock. + /* + * DPLL2 provides IVA(video acceleration) clock. * It uses SYS_CLK as reference clokc and core clock (DPLL3) as * high frequency bypass (IVA runs on L3 freq). */ // TODO: We can probably turn this off entirely. IVA is left unused. - /* Enable low power bypass mode, this will take effect the next lock or - * relock sequence. */ + /* + * Enable low power bypass mode, this will take effect the next lock or + * relock sequence. + */ //TODO: We might need to force re-lock after enabling this pio_set_32(&device->cm.iva2->clken_pll, MPU_CM_CLKEN_PLL_EN_MPU_DPLL_LP_MODE_FLAG, 5); @@ -203,5 +212,6 @@ pio_change_32(&device->cm.iva2->autoidle_pll, MPU_CM_AUTOIDLE_PLL_AUTO_MPU_DPLL_ENABLED, MPU_CM_AUTOIDLE_PLL_AUTO_MPU_DPLL_MASK, 5); - /* DPLL3 provides tons of clocks: + /* + * DPLL3 provides tons of clocks: * CORE_CLK, COREX2_CLK, DSS_TV_CLK, 12M_CLK, 48M_CLK, 96M_CLK, L3_ICLK, * and L4_ICLK. It uses SYS_CLK as reference clock and low frequency @@ -252,5 +262,6 @@ CLOCK_CONTROL_CM_AUTOIDLE_PLL_AUTO_CORE_DPLL_MASK, 5); - /* DPLL4 provides peripheral domain clocks: + /* + * DPLL4 provides peripheral domain clocks: * CAM_MCLK, EMU_PER_ALWON_CLK, DSS1_ALWON_FCLK, and 96M_ALWON_FCLK. * It uses SYS_CLK as reference clock and low frequency bypass. @@ -263,5 +274,6 @@ CLOCK_CONTROL_CM_AUTOIDLE_PLL_AUTO_PERIPH_DPLL_MASK, 5); - /* DPLL5 provide peripheral domain clocks: 120M_FCLK. + /* + * DPLL5 provide peripheral domain clocks: 120M_FCLK. * It uses SYS_CLK as reference clock and low frequency bypass. * 120M clock is used by HS USB and USB TLL. @@ -271,6 +283,8 @@ CLOCK_CONTROL_CM_CLKEN2_PLL_EN_PERIPH2_DPLL_MASK) != CLOCK_CONTROL_CM_CLKEN2_PLL_EN_PERIPH2_DPLL_LOCK) { - /* Compute divisors and multiplier - * See AMDM37x TRM p. 300 for the formula */ + /* + * Compute divisors and multiplier + * See AMDM37x TRM p. 300 for the formula + */ // TODO: base_freq does not have to be rounded to Mhz // (that's why I used KHz as unit). @@ -383,6 +397,8 @@ UHH_SYSCONFIG_SIDLE_MODE_SMART, UHH_SYSCONFIG_SIDLE_MODE_MASK, 5); - /* Set all ports to go through TLL(UTMI) - * Direct connection can only work in HS mode */ + /* + * Set all ports to go through TLL(UTMI) + * Direct connection can only work in HS mode + */ pio_set_32(&device->uhh->hostconfig, UHH_HOSTCONFIG_P1_ULPI_BYPASS_FLAG | @@ -394,8 +410,10 @@ for (unsigned i = 0; i < 3; ++i) { - /* Serial mode is the only one capable of FS/LS operation. + /* + * Serial mode is the only one capable of FS/LS operation. * Select FS/LS mode, no idea what the difference is * one of bidirectional modes might be good choice - * 2 = 3pin bidi phy. */ + * 2 = 3pin bidi phy. + */ pio_change_32(&device->tll->channel_conf[i], TLL_CHANNEL_CONF_CHANMODE_UTMI_SERIAL_MODE | Index: uspace/drv/time/cmos-rtc/cmos-rtc.c =================================================================== --- uspace/drv/time/cmos-rtc/cmos-rtc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/drv/time/cmos-rtc/cmos-rtc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -326,5 +326,6 @@ if (rtc->boot_time.tv_sec) { - /* There is no need to read the current time from the + /* + * There is no need to read the current time from the * device because it has already been cached. */ @@ -404,5 +405,6 @@ if (t->tm_year < 100) { - /* tm_year is the number of years since 1900 but the + /* + * tm_year is the number of years since 1900 but the * RTC epoch is 2000. */ @@ -497,5 +499,6 @@ if (epoch == 2000) { - /* The RTC epoch is year 2000 but the tm_year + /* + * The RTC epoch is year 2000 but the tm_year * field counts years since 1900. */ Index: uspace/lib/bithenge/include/bithenge/blob.h =================================================================== --- uspace/lib/bithenge/include/bithenge/blob.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/include/bithenge/blob.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -43,5 +43,6 @@ /** A blob of raw binary data. - * @implements bithenge_node_t */ + * @implements bithenge_node_t + */ typedef struct { /** @privatesection */ @@ -50,5 +51,6 @@ /** Operations providing random access to binary data. - * @todo Should these be thread-safe? */ + * @todo Should these be thread-safe? + */ typedef struct bithenge_random_access_blob_ops_t { /** @copydoc bithenge_blob_t::bithenge_blob_size */ @@ -61,10 +63,12 @@ aoff64_t *size, bool little_endian); /** Destroy the blob. - * @param blob The blob. */ + * @param blob The blob. + */ void (*destroy)(bithenge_blob_t *self); } bithenge_random_access_blob_ops_t; /** A blob built from an object that supports only sequential reading. - * @implements bithenge_blob_t */ + * @implements bithenge_blob_t + */ typedef struct { /** @privatesection */ @@ -82,5 +86,6 @@ /** Operations providing sequential access to binary data. - * @memberof bithenge_sequential_blob_t */ + * @memberof bithenge_sequential_blob_t + */ typedef struct bithenge_sequential_blob_ops_t { @@ -112,5 +117,6 @@ /** Destroy the blob. - * @param self The blob. */ + * @param self The blob. + */ void (*destroy)(bithenge_sequential_blob_t *self); } bithenge_sequential_blob_ops_t; @@ -189,5 +195,6 @@ * @param self The blob. * @param[out] out Holds whether the blob is empty. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ static inline errno_t bithenge_blob_empty(bithenge_blob_t *self, bool *out) { @@ -203,5 +210,6 @@ * @memberof bithenge_blob_t * @param blob The blob to cast. - * @return The blob node as a generic node. */ + * @return The blob node as a generic node. + */ static inline bithenge_node_t *bithenge_blob_as_node(bithenge_blob_t *blob) { @@ -212,5 +220,6 @@ * @memberof bithenge_blob_t * @param node The node to cast, which must be a blob node. - * @return The generic node as a blob node. */ + * @return The generic node as a blob node. + */ static inline bithenge_blob_t *bithenge_node_as_blob(bithenge_node_t *node) { @@ -220,5 +229,6 @@ /** Increment a blob's reference count. - * @param blob The blob to reference. */ + * @param blob The blob to reference. + */ static inline void bithenge_blob_inc_ref(bithenge_blob_t *blob) { @@ -227,5 +237,6 @@ /** Decrement a blob's reference count. - * @param blob The blob to dereference, or NULL. */ + * @param blob The blob to dereference, or NULL. + */ static inline void bithenge_blob_dec_ref(bithenge_blob_t *blob) { Index: uspace/lib/bithenge/include/bithenge/expression.h =================================================================== --- uspace/lib/bithenge/include/bithenge/expression.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/include/bithenge/expression.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -55,10 +55,12 @@ bithenge_node_t **out); /** Destroy the expression. - * @param self The expression. */ + * @param self The expression. + */ void (*destroy)(bithenge_expression_t *self); } bithenge_expression_ops_t; /** Increment an expression's reference count. - * @param self The expression to reference. */ + * @param self The expression to reference. + */ static inline void bithenge_expression_inc_ref(bithenge_expression_t *self) { @@ -68,5 +70,6 @@ /** Decrement an expression's reference count and free it if appropriate. - * @param self The expression to dereference, or NULL. */ + * @param self The expression to dereference, or NULL. + */ static inline void bithenge_expression_dec_ref(bithenge_expression_t *self) { @@ -84,5 +87,6 @@ * @param scope The scope. * @param[out] out Where the output tree will be stored. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ static inline errno_t bithenge_expression_evaluate(bithenge_expression_t *self, bithenge_scope_t *scope, bithenge_node_t **out) Index: uspace/lib/bithenge/include/bithenge/print.h =================================================================== --- uspace/lib/bithenge/include/bithenge/print.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/include/bithenge/print.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -43,8 +43,10 @@ typedef enum { /** Print a Python value. Note that internal nodes will be represented - * as unordered dictionaries. */ + * as unordered dictionaries. + */ BITHENGE_PRINT_PYTHON, /** Print JSON. Due to the limitations of JSON, type information may be - * lost. */ + * lost. + */ BITHENGE_PRINT_JSON, } bithenge_print_type_t; Index: uspace/lib/bithenge/include/bithenge/transform.h =================================================================== --- uspace/lib/bithenge/include/bithenge/transform.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/include/bithenge/transform.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -64,5 +64,6 @@ /** Increment a scope's reference count. * @memberof bithenge_scope_t - * @param self The scope to reference. */ + * @param self The scope to reference. + */ static inline void bithenge_scope_inc_ref(bithenge_scope_t *self) { @@ -73,5 +74,6 @@ /** Operations that may be provided by a transform. All transforms must provide * apply and/or prefix_apply. To be used in struct transforms and repeat - * transforms, transforms must provide prefix_length and/or prefix_apply. */ + * transforms, transforms must provide prefix_length and/or prefix_apply. + */ typedef struct bithenge_transform_ops { /** @copydoc bithenge_transform_t::bithenge_transform_apply */ @@ -86,5 +88,6 @@ bithenge_node_t **out_node, aoff64_t *out_size); /** Destroy the transform. - * @param self The transform. */ + * @param self The transform. + */ void (*destroy)(bithenge_transform_t *self); } bithenge_transform_ops_t; @@ -93,5 +96,6 @@ * by the parser and param-wrapper. Takes ownership of nothing. * @param self The transform. - * @return The number of parameters required. */ + * @return The number of parameters required. + */ static inline int bithenge_transform_num_params(bithenge_transform_t *self) { @@ -101,5 +105,6 @@ /** Increment a transform's reference count. - * @param self The transform to reference. */ + * @param self The transform to reference. + */ static inline void bithenge_transform_inc_ref(bithenge_transform_t *self) { @@ -109,5 +114,6 @@ /** Decrement a transform's reference count and free it if appropriate. - * @param self The transform to dereference, or NULL. */ + * @param self The transform to dereference, or NULL. + */ static inline void bithenge_transform_dec_ref(bithenge_transform_t *self) { Index: uspace/lib/bithenge/include/bithenge/tree.h =================================================================== --- uspace/lib/bithenge/include/bithenge/tree.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/include/bithenge/tree.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -81,5 +81,6 @@ * @param value The value. * @param data Data provided to @a bithenge_node_t::bithenge_node_for_each. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ typedef errno_t (*bithenge_for_each_func_t)(bithenge_node_t *key, bithenge_node_t *value, void *data); @@ -92,5 +93,6 @@ bithenge_node_t **out); /** Destroys the internal node. - * @param self The node to destroy. */ + * @param self The node to destroy. + */ void (*destroy)(bithenge_node_t *self); } bithenge_internal_node_ops_t; @@ -99,5 +101,6 @@ * @memberof bithenge_node_t * @param node The node. - * @return The type of the node. */ + * @return The type of the node. + */ static inline bithenge_node_type_t bithenge_node_type(const bithenge_node_t *node) { @@ -107,5 +110,6 @@ /** Increment a node's reference count. * @memberof bithenge_node_t - * @param node The node to reference. */ + * @param node The node to reference. + */ static inline void bithenge_node_inc_ref(bithenge_node_t *node) { @@ -122,5 +126,6 @@ * @param func The callback function. * @param data Data to provide to the callback function. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ static inline errno_t bithenge_node_for_each(bithenge_node_t *self, bithenge_for_each_func_t func, void *data) @@ -137,5 +142,6 @@ * @memberof bithenge_node_t * @param self The boolean node. - * @return The node's value. */ + * @return The node's value. + */ static inline bool bithenge_boolean_node_value(bithenge_node_t *self) { @@ -147,5 +153,6 @@ * @memberof bithenge_node_t * @param self The integer node. - * @return The node's value. */ + * @return The node's value. + */ static inline bithenge_int_t bithenge_integer_node_value(bithenge_node_t *self) { @@ -157,5 +164,6 @@ * @memberof bithenge_node_t * @param self The string node. - * @return The node's value. */ + * @return The node's value. + */ static inline const char *bithenge_string_node_value(bithenge_node_t *self) { Index: uspace/lib/bithenge/src/blob.c =================================================================== --- uspace/lib/bithenge/src/blob.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/blob.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -239,5 +239,6 @@ * @param needs_free If true, the buffer will be freed with free() if this * function fails or the blob is destroyed. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_blob_from_buffer(bithenge_node_t **out, const void *buffer, size_t len, bool needs_free) @@ -277,5 +278,6 @@ * @param[in] data The data. * @param len The length of the data. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_blob_from_data(bithenge_node_t **out, const void *data, size_t len) @@ -435,5 +437,6 @@ * @param[in] source The input blob. * @param offset The offset within the input blob at which the new blob will start. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_offset_blob(bithenge_node_t **out, bithenge_blob_t *source, aoff64_t offset) @@ -448,5 +451,6 @@ * @param offset The offset within the input blob at which the new blob will start. * @param size The size of the new blob. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_subblob(bithenge_node_t **out, bithenge_blob_t *source, aoff64_t offset, aoff64_t size) Index: uspace/lib/bithenge/src/compound.c =================================================================== --- uspace/lib/bithenge/src/compound.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/compound.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -115,5 +115,6 @@ * @param[in] xforms The transforms to apply. * @param num The number of transforms. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_composed_transform(bithenge_transform_t **out, bithenge_transform_t **xforms, size_t num) @@ -231,5 +232,6 @@ * @param true_xform The transform to apply if the expression is true. * @param false_xform The transform to apply if the expression is false. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_if_transform(bithenge_transform_t **out, bithenge_expression_t *expr, bithenge_transform_t *true_xform, @@ -309,5 +311,6 @@ * @param[out] out Holds the new transform. * @param xform The subtransform to apply. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_partial_transform(bithenge_transform_t **out, bithenge_transform_t *xform) Index: uspace/lib/bithenge/src/expression.c =================================================================== --- uspace/lib/bithenge/src/expression.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/expression.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -47,5 +47,6 @@ * @param[out] self Expression to initialize. * @param[in] ops Operations provided by the expression. - * @return EOK or an error code from errno.h. */ + * @return EOK or an error code from errno.h. + */ errno_t bithenge_init_expression(bithenge_expression_t *self, const bithenge_expression_ops_t *ops) @@ -156,10 +157,12 @@ break; case BITHENGE_EXPRESSION_INTEGER_DIVIDE: - /* Integer division can behave in three major ways when the - operands are signed: truncated, floored, or Euclidean. When + /* + * Integer division can behave in three major ways when the + * operands are signed: truncated, floored, or Euclidean. When * b > 0, we give the same result as floored and Euclidean; * otherwise, we currently raise an error. See * https://en.wikipedia.org/wiki/Modulo_operation and its - * references. */ + * references. + */ if (b_int <= 0) { rc = EINVAL; @@ -249,5 +252,6 @@ * @param a The first operand. * @param b The second operand. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_binary_expression(bithenge_expression_t **out, bithenge_binary_op_t op, bithenge_expression_t *a, @@ -305,5 +309,6 @@ /** Create an expression that gets the current input node. * @param[out] out Holds the new expression. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_in_node_expression(bithenge_expression_t **out) { @@ -339,5 +344,6 @@ /** Create an expression that gets the current node being created. * @param[out] out Holds the new expression. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_current_node_expression(bithenge_expression_t **out) { @@ -389,5 +395,6 @@ * @param[out] out Holds the created expression. * @param index The index of the parameter to get. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_param_expression(bithenge_expression_t **out, int index) { @@ -454,5 +461,6 @@ * @param[out] out Holds the created expression. * @param node The constant. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_const_expression(bithenge_expression_t **out, bithenge_node_t *node) @@ -536,5 +544,6 @@ * @param[out] out Holds the new expression. * @param key The key to search for in nodes being created. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_scope_member_expression(bithenge_expression_t **out, bithenge_node_t *key) @@ -657,5 +666,6 @@ * @param absolute_limit If true, the limit is an absolute offset; otherwise, * it is relative to the start. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_subblob_expression(bithenge_expression_t **out, bithenge_expression_t *blob, bithenge_expression_t *start, @@ -815,5 +825,6 @@ * @param transform The transform for which parameters are calculated. * @param params The expressions used to calculate the parameters. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_param_wrapper(bithenge_transform_t **out, bithenge_transform_t *transform, bithenge_expression_t **params) @@ -899,5 +910,6 @@ * @param[out] out Holds the new transform. * @param expr The expression to evaluate. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_expression_transform(bithenge_transform_t **out, bithenge_expression_t *expr) @@ -956,5 +968,6 @@ * @param[out] out Holds the new transform. * @param expr The expression to evaluate. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_inputless_transform(bithenge_transform_t **out, bithenge_expression_t *expr) @@ -1117,5 +1130,6 @@ * @param a The first blob. * @param b The second blob. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_concat_blob(bithenge_node_t **out, bithenge_blob_t *a, bithenge_blob_t *b) @@ -1159,5 +1173,6 @@ * @param b_expr An expression to calculate the second blob. * @param scope The scope in which @a b_expr should be evaluated. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_concat_blob_lazy(bithenge_node_t **out, bithenge_blob_t *a, bithenge_expression_t *b_expr, bithenge_scope_t *scope) Index: uspace/lib/bithenge/src/failure.c =================================================================== --- uspace/lib/bithenge/src/failure.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/failure.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -47,5 +47,6 @@ #include "common.h" -/* This file raises fake errors from system calls, to test that Bithenge +/* + * This file raises fake errors from system calls, to test that Bithenge * handles the errors correctly. It has two primary modes of operation, * depending on an environment variable: @@ -60,5 +61,6 @@ * BITHENGE_FAILURE_INDEX set: the program runs normally until system call * number BITHENGE_FAILURE_INDEX is made; a fake error is returned from this - * call. */ + * call. + */ static int g_initialized = 0; @@ -94,6 +96,8 @@ } -/* Record a hit for a backtrace address and return whether this is the first - * hit. */ +/* + * Record a hit for a backtrace address and return whether this is the first + * hit. + */ static inline errno_t backtrace_item_hit(void *addr) { @@ -133,6 +137,8 @@ } - /* If all backtrace items have been seen already, there's no need to - * try raising an error. */ + /* + * If all backtrace items have been seen already, there's no need to + * try raising an error. + */ void *trace[256]; int size = backtrace(trace, 256); @@ -162,7 +168,9 @@ return 0; - /* The child had an error! We couldn't easily debug it because it was + /* + * The child had an error! We couldn't easily debug it because it was * in a separate process with redirected stdout and stderr. Do it again - * without redirecting or forking. */ + * without redirecting or forking. + */ fprintf(stderr, "** Fake error raised here (BITHENGE_FAILURE_INDEX=%d)\n", g_failure_index); Index: uspace/lib/bithenge/src/file.c =================================================================== --- uspace/lib/bithenge/src/file.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/file.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -140,5 +140,6 @@ * @param[out] out Stores the created blob. * @param filename The name of the file. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_file_blob(bithenge_node_t **out, const char *filename) { @@ -157,5 +158,6 @@ * @param[out] out Stores the created blob. * @param fd The file descriptor. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_file_blob_from_fd(bithenge_node_t **out, int fd) { @@ -167,5 +169,6 @@ * @param[out] out Stores the created blob. * @param file The file pointer. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_file_blob_from_file(bithenge_node_t **out, FILE *file) { Index: uspace/lib/bithenge/src/helenos/block.c =================================================================== --- uspace/lib/bithenge/src/helenos/block.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/helenos/block.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -95,5 +95,6 @@ * @param[out] out Stores the created blob. * @param service_id The service ID of the block device. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_block_blob(bithenge_node_t **out, service_id_t service_id) { Index: uspace/lib/bithenge/src/print.c =================================================================== --- uspace/lib/bithenge/src/print.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/print.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -222,5 +222,6 @@ * @param type The format to use. * @param tree The root node of the tree to print. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_print_node(bithenge_print_type_t type, bithenge_node_t *tree) { @@ -236,5 +237,6 @@ * @param type The format to use. * @param tree The root node of the tree to print. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_print_node_to_string(char **str, size_t *size, bithenge_print_type_t type, bithenge_node_t *tree) Index: uspace/lib/bithenge/src/script.c =================================================================== --- uspace/lib/bithenge/src/script.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/script.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -55,5 +55,6 @@ /** @cond internal * Single-character symbols are represented by the character itself. Every - * other token uses one of these values: */ + * other token uses one of these values: + */ typedef enum { TOKEN_ERROR = -128, @@ -98,5 +99,6 @@ typedef struct { /** Rather than constantly checking return values, the parser uses this - * to indicate whether an error has occurred. */ + * to indicate whether an error has occurred. + */ errno_t error; @@ -109,5 +111,6 @@ FILE *file; /** The buffer that holds script code. There is always a '\0' after the - * current position to prevent reading too far. */ + * current position to prevent reading too far. + */ char buffer[BUFFER_SIZE]; /** The start position within the buffer of the next unread token. */ @@ -124,5 +127,6 @@ union { /** The value of a TOKEN_IDENTIFIER token. Unless changed to - * NULL, it will be freed when the next token is read. */ + * NULL, it will be freed when the next token is read. + */ char *token_string; /** The value of a TOKEN_INTEGER token. */ @@ -139,5 +143,6 @@ /** Free the previous token's data. This must be called before changing - * state->token. */ + * state->token. + */ static void done_with_token(state_t *state) { @@ -346,5 +351,6 @@ /** Allocate memory and handle failure by setting the error in the state. The * caller must check the state for errors before using the return value of this - * function. */ + * function. + */ static void *state_malloc(state_t *state, size_t size) { @@ -358,5 +364,6 @@ /** Reallocate memory and handle failure by setting the error in the state. If - * an error occurs, the existing pointer will be returned. */ + * an error occurs, the existing pointer will be returned. + */ static void *state_realloc(state_t *state, void *ptr, size_t size) { @@ -372,5 +379,6 @@ /** Expect and consume a certain token. If the next token is of the wrong type, - * an error is caused. */ + * an error is caused. + */ static void expect(state_t *state, token_type_t type) { @@ -383,5 +391,6 @@ /** Expect and consume an identifier token. If the next token is not an - * identifier, an error is caused and this function returns null. */ + * identifier, an error is caused and this function returns null. + */ static char *expect_identifier(state_t *state) { @@ -397,5 +406,6 @@ /** Find a transform by name. A reference will be added to the transform. - * @return The found transform, or NULL if none was found. */ + * @return The found transform, or NULL if none was found. + */ static bithenge_transform_t *get_named_transform(state_t *state, const char *name) @@ -419,5 +429,6 @@ /** Add a named transform. This function takes ownership of the name and a - * reference to the transform. If an error has occurred, either may be null. */ + * reference to the transform. If an error has occurred, either may be null. + */ static void add_named_transform(state_t *state, bithenge_transform_t *xform, char *name) { @@ -809,5 +820,6 @@ /** Create a transform that just produces an empty node. * @param state The parser state. - * @return The new transform, or NULL on error. */ + * @return The new transform, or NULL on error. + */ static bithenge_transform_t *make_empty_transform(state_t *state) { @@ -1139,5 +1151,6 @@ /** Parse a transform without composition. - * @return The parsed transform, or NULL if an error occurred. */ + * @return The parsed transform, or NULL if an error occurred. + */ static bithenge_transform_t *parse_transform_no_compose(state_t *state) { @@ -1188,5 +1201,6 @@ /** Parse a transform. - * @return The parsed transform, or NULL if an error occurred. */ + * @return The parsed transform, or NULL if an error occurred. + */ static bithenge_transform_t *parse_transform(state_t *state) { @@ -1320,5 +1334,6 @@ * @param[out] out Stores the "main" transform. * @return EOK on success, EINVAL on syntax error, or an error code from - * errno.h. */ + * errno.h. + */ errno_t bithenge_parse_script(const char *filename, bithenge_transform_t **out) { Index: uspace/lib/bithenge/src/sequence.c =================================================================== --- uspace/lib/bithenge/src/sequence.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/sequence.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -150,6 +150,8 @@ if (index == self->num_ends) { - /* We can apply the subtransform and cache its prefix length at - * the same time. */ + /* + * We can apply the subtransform and cache its prefix length at + * the same time. + */ bithenge_node_t *blob_node; bithenge_blob_inc_ref(self->blob); @@ -418,27 +420,35 @@ struct_node_t *node = node_as_struct(base); - /* Treat the scope carefully because of the circular reference. In + /* + * Treat the scope carefully because of the circular reference. In * struct_transform_make_node, things are set up so node owns a * reference to the scope, but scope doesn't own a reference to node, - * so node's reference count is too low. */ + * so node's reference count is too low. + */ bithenge_scope_t *scope = seq_node_scope(struct_as_seq(node)); if (scope->refs == 1) { - /* Mostly normal destroy, but we didn't inc_ref(node) for the + /* + * Mostly normal destroy, but we didn't inc_ref(node) for the * scope in struct_transform_make_node, so make sure it doesn't - * try to dec_ref. */ + * try to dec_ref. + */ scope->current_node = NULL; seq_node_destroy(struct_as_seq(node)); } else if (scope->refs > 1) { - /* The scope is still needed, but node isn't otherwise needed. + /* + * The scope is still needed, but node isn't otherwise needed. * Switch things around so scope owns a reference to node, but - * not vice versa, and scope's reference count is too low. */ + * not vice versa, and scope's reference count is too low. + */ bithenge_node_inc_ref(base); bithenge_scope_dec_ref(scope); return; } else { - /* This happens after the previous case, when scope is no + /* + * This happens after the previous case, when scope is no * longer used and is being destroyed. Since scope is already * being destroyed, set it to NULL here so we don't try to - * destroy it twice. */ + * destroy it twice. + */ struct_as_seq(node)->scope = NULL; seq_node_destroy(struct_as_seq(node)); @@ -501,8 +511,10 @@ node->prefix = prefix; - /* We should inc_ref(node) here, but that would make a cycle. Instead, + /* + * We should inc_ref(node) here, but that would make a cycle. Instead, * we leave it 1 too low, so that when the only remaining use of node * is the scope, node will be destroyed. Also see the comment in - * struct_node_destroy. */ + * struct_node_destroy. + */ bithenge_scope_set_current_node(inner, struct_as_node(node)); bithenge_scope_dec_ref(inner); @@ -591,5 +603,6 @@ * @param[out] out Stores the created transform. * @param subtransforms The subtransforms and field names. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_struct(bithenge_transform_t **out, bithenge_named_transform_t *subtransforms) @@ -869,5 +882,6 @@ * @param expr Used to calculate the number of times @a xform will be applied. * May be NULL, in which case @a xform will be applied indefinitely. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_repeat_transform(bithenge_transform_t **out, bithenge_transform_t *xform, bithenge_expression_t *expr) @@ -1114,5 +1128,6 @@ * @param expr Applied in the result of each application of @a xform to * determine whether there will be more. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_do_while_transform(bithenge_transform_t **out, bithenge_transform_t *xform, bithenge_expression_t *expr) Index: uspace/lib/bithenge/src/source.c =================================================================== --- uspace/lib/bithenge/src/source.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/source.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -84,5 +84,6 @@ * @param[out] out Stores the created node. * @param source Specifies the node to be created. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_node_from_source(bithenge_node_t **out, const char *source) { Index: uspace/lib/bithenge/src/transform.c =================================================================== --- uspace/lib/bithenge/src/transform.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/transform.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -56,5 +56,6 @@ * whatever parameters it has, so they can be passed to any param_wrappers * within. - * @return EOK or an error code from errno.h. */ + * @return EOK or an error code from errno.h. + */ errno_t bithenge_init_transform(bithenge_transform_t *self, const bithenge_transform_ops_t *ops, int num_params) @@ -82,5 +83,6 @@ * @param in The input tree. * @param[out] out Where the output tree will be stored. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_transform_apply(bithenge_transform_t *self, bithenge_scope_t *scope, bithenge_node_t *in, bithenge_node_t **out) @@ -118,5 +120,6 @@ * @param[out] out Where the prefix length will be stored. * @return EOK on success, ENOTSUP if not supported, or another error code from - * errno.h. */ + * errno.h. + */ errno_t bithenge_transform_prefix_length(bithenge_transform_t *self, bithenge_scope_t *scope, bithenge_blob_t *blob, aoff64_t *out) @@ -149,5 +152,6 @@ * case the size is not determined. * @return EOK on success, ENOTSUP if not supported, or another error code from - * errno.h. */ + * errno.h. + */ errno_t bithenge_transform_prefix_apply(bithenge_transform_t *self, bithenge_scope_t *scope, bithenge_blob_t *blob, bithenge_node_t **out_node, @@ -187,5 +191,6 @@ * @param[out] out Holds the new scope. * @param outer The outer scope, or NULL. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_scope_new(bithenge_scope_t **out, bithenge_scope_t *outer) { @@ -209,5 +214,6 @@ /** Dereference a transform scope. * @memberof bithenge_scope_t - * @param self The scope to dereference, or NULL. */ + * @param self The scope to dereference, or NULL. + */ void bithenge_scope_dec_ref(bithenge_scope_t *self) { @@ -228,5 +234,6 @@ * @memberof bithenge_scope_t * @param self The scope to examine. - * @return The outer scope, which may be NULL. */ + * @return The outer scope, which may be NULL. + */ bithenge_scope_t *bithenge_scope_outer(bithenge_scope_t *self) { @@ -238,5 +245,6 @@ * @memberof bithenge_scope_t * @param scope The scope to get the error message from. - * @return The error message, or NULL. */ + * @return The error message, or NULL. + */ const char *bithenge_scope_get_error(bithenge_scope_t *scope) { @@ -250,5 +258,6 @@ * @param scope The scope. * @param format The format string. - * @return EINVAL normally, or another error code from errno.h. */ + * @return EINVAL normally, or another error code from errno.h. + */ errno_t bithenge_scope_error(bithenge_scope_t *scope, const char *format, ...) { @@ -299,5 +308,6 @@ * @memberof bithenge_scope_t * @param scope The scope to get the current node from. - * @return The node being created, or NULL. */ + * @return The node being created, or NULL. + */ bithenge_node_t *bithenge_scope_get_current_node(bithenge_scope_t *scope) { @@ -310,5 +320,6 @@ * @memberof bithenge_scope_t * @param scope The scope to set the current node in. - * @param node The current node being created, or NULL. */ + * @param node The current node being created, or NULL. + */ void bithenge_scope_set_current_node(bithenge_scope_t *scope, bithenge_node_t *node) @@ -321,5 +332,6 @@ * @memberof bithenge_scope_t * @param scope The scope to get the current input node from. - * @return The input node, or NULL. */ + * @return The input node, or NULL. + */ bithenge_node_t *bithenge_scope_in_node(bithenge_scope_t *scope) { @@ -332,5 +344,6 @@ * @memberof bithenge_scope_t * @param scope The scope to set the input node in. - * @param node The input node, or NULL. */ + * @param node The input node, or NULL. + */ void bithenge_scope_set_in_node(bithenge_scope_t *scope, bithenge_node_t *node) { @@ -341,5 +354,6 @@ /** Set a scope as a barrier. * @memberof bithenge_scope_t - * @param self The scope to change. */ + * @param self The scope to change. + */ void bithenge_scope_set_barrier(bithenge_scope_t *self) { @@ -351,5 +365,6 @@ * @memberof bithenge_scope_t * @param self The scope to check. - * @return Whether the scope is a barrier. */ + * @return Whether the scope is a barrier. + */ bool bithenge_scope_is_barrier(bithenge_scope_t *self) { @@ -363,5 +378,6 @@ * @param scope The scope in which to allocate parameters. * @param num_params The number of parameters to allocate. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_scope_alloc_params(bithenge_scope_t *scope, int num_params) { @@ -381,5 +397,6 @@ * @param i The index of the parameter to set. * @param node The value to store in the parameter. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_scope_set_param(bithenge_scope_t *scope, int i, bithenge_node_t *node) @@ -400,5 +417,6 @@ * @param i The index of the parameter to set. * @param[out] out Stores a new reference to the parameter. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_scope_get_param(bithenge_scope_t *scope, int i, bithenge_node_t **out) @@ -502,5 +520,6 @@ * @param base The barrier transform. * @param transform The subtransform to use for all operations. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_barrier_transform_set_subtransform(bithenge_transform_t *base, bithenge_transform_t *transform) @@ -526,5 +545,6 @@ * @param[out] out Holds the created transform. * @param num_params The number of parameters to require, which may be 0. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_barrier_transform(bithenge_transform_t **out, int num_params) { @@ -742,5 +762,6 @@ /** A transform that converts a byte blob to a bit blob, most-significant bit - * first. */ + * first. + */ bithenge_transform_t bithenge_bits_be_transform = { &bits_xe_ops, 1, 0 @@ -748,5 +769,6 @@ /** A transform that converts a byte blob to a bit blob, least-significant bit - * first. */ + * first. + */ bithenge_transform_t bithenge_bits_le_transform = { &bits_xe_ops, 1, 0 @@ -987,5 +1009,6 @@ /** A transform that reads an unsigned integer from an arbitrary number of - * bits, most-significant bit first. */ + * bits, most-significant bit first. + */ bithenge_transform_t bithenge_uint_be_transform = { &uint_xe_ops, 1, 1 @@ -993,5 +1016,6 @@ /** A transform that reads an unsigned integer from an arbitrary number of - * bits, least-significant bit first. */ + * bits, least-significant bit first. + */ bithenge_transform_t bithenge_uint_le_transform = { &uint_xe_ops, 1, 1 Index: uspace/lib/bithenge/src/tree.c =================================================================== --- uspace/lib/bithenge/src/tree.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/bithenge/src/tree.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -71,5 +71,6 @@ /** Decrement a node's reference count and free it if appropriate. * @memberof bithenge_node_t - * @param node The node to dereference, or NULL. */ + * @param node The node to dereference, or NULL. + */ void bithenge_node_dec_ref(bithenge_node_t *node) { @@ -112,5 +113,6 @@ * @param[out] out Holds the found node. * @return EOK on success, ENOENT if not found, or another error code from - * errno.h. */ + * errno.h. + */ errno_t bithenge_node_get(bithenge_node_t *self, bithenge_node_t *key, bithenge_node_t **out) @@ -154,5 +156,6 @@ * @param[out] self The node. * @param[in] ops The operations provided. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_init_internal_node(bithenge_node_t *self, const bithenge_internal_node_ops_t *ops) @@ -195,5 +198,6 @@ /** Create an empty internal node. * @param[out] out Holds the created node. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_empty_internal_node(bithenge_node_t **out) { @@ -262,5 +266,6 @@ * @param needs_free If true, when the internal node is destroyed it will free * the nodes array rather than just dereferencing each node inside it. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_simple_internal_node(bithenge_node_t **out, bithenge_node_t **nodes, bithenge_int_t len, bool needs_free) @@ -298,5 +303,6 @@ * @param[out] out Stores the created boolean node. * @param value The value for the node to hold. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_boolean_node(bithenge_node_t **out, bool value) { @@ -313,5 +319,6 @@ * @param[out] out Stores the created integer node. * @param value The value for the node to hold. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_integer_node(bithenge_node_t **out, bithenge_int_t value) { @@ -333,5 +340,6 @@ * @param needs_free Whether the string should be freed when the node is * destroyed. - * @return EOK on success or an error code from errno.h. */ + * @return EOK on success or an error code from errno.h. + */ errno_t bithenge_new_string_node(bithenge_node_t **out, const char *value, bool needs_free) { @@ -357,5 +365,6 @@ * @param a, b Nodes to compare. * @return EOK on success or an error code from errno.h. - * @todo Add support for internal nodes. */ + * @todo Add support for internal nodes. + */ errno_t bithenge_node_equal(bool *out, bithenge_node_t *a, bithenge_node_t *b) { Index: uspace/lib/block/block.c =================================================================== --- uspace/lib/block/block.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/block/block.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -399,5 +399,6 @@ cache = devcon->cache; - /* Check whether the logical block (or part of it) is beyond + /* + * Check whether the logical block (or part of it) is beyond * the end of the device or not. */ Index: uspace/lib/c/arch/abs32le/include/libarch/atomic.h =================================================================== --- uspace/lib/c/arch/abs32le/include/libarch/atomic.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/abs32le/include/libarch/atomic.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -55,6 +55,8 @@ static inline void atomic_inc(atomic_t *val) { - /* On real hardware the increment has to be done - as an atomic action. */ + /* + * On real hardware the increment has to be done + * as an atomic action. + */ val->count++; @@ -63,6 +65,8 @@ static inline void atomic_dec(atomic_t *val) { - /* On real hardware the decrement has to be done - as an atomic action. */ + /* + * On real hardware the decrement has to be done + * as an atomic action. + */ val->count++; @@ -71,7 +75,9 @@ static inline atomic_count_t atomic_postinc(atomic_t *val) { - /* On real hardware both the storing of the previous - value and the increment have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the increment have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; @@ -83,7 +89,9 @@ static inline atomic_count_t atomic_postdec(atomic_t *val) { - /* On real hardware both the storing of the previous - value and the decrement have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the decrement have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; Index: uspace/lib/c/arch/amd64/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/amd64/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/amd64/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * @@ -45,5 +46,6 @@ typedef struct context { - /* We include only registers that must be preserved + /* + * We include only registers that must be preserved * during function call. */ Index: uspace/lib/c/arch/arm32/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/arm32/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/arm32/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * Index: uspace/lib/c/arch/ia32/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/ia32/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/ia32/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: uspace/lib/c/arch/ia64/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/ia64/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/ia64/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights preserved. * Index: uspace/lib/c/arch/mips32/include/libarch/atomic.h =================================================================== --- uspace/lib/c/arch/mips32/include/libarch/atomic.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/mips32/include/libarch/atomic.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -50,5 +50,5 @@ #define atomic_predec(x) atomic_add(x, -1) -/* Atomic addition of immediate value. +/** Atomic addition of immediate value. * * @param val Memory location to which will be the immediate value added. Index: uspace/lib/c/arch/mips32/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/mips32/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/mips32/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * Index: uspace/lib/c/arch/mips32/include/libarch/tls.h =================================================================== --- uspace/lib/c/arch/mips32/include/libarch/tls.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/mips32/include/libarch/tls.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -46,5 +46,6 @@ #define CONFIG_TLS_VARIANT_1 -/* I did not find any specification (neither MIPS nor PowerPC), but +/* + * I did not find any specification (neither MIPS nor PowerPC), but * as I found it * - it uses Variant II Index: uspace/lib/c/arch/ppc32/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/ppc32/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/ppc32/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * Index: uspace/lib/c/arch/riscv64/include/libarch/atomic.h =================================================================== --- uspace/lib/c/arch/riscv64/include/libarch/atomic.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/riscv64/include/libarch/atomic.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -57,6 +57,8 @@ static inline void atomic_inc(atomic_t *val) { - /* On real hardware the increment has to be done - as an atomic action. */ + /* + * On real hardware the increment has to be done + * as an atomic action. + */ val->count++; @@ -65,6 +67,8 @@ static inline void atomic_dec(atomic_t *val) { - /* On real hardware the decrement has to be done - as an atomic action. */ + /* + * On real hardware the decrement has to be done + * as an atomic action. + */ val->count++; @@ -73,7 +77,9 @@ static inline atomic_count_t atomic_postinc(atomic_t *val) { - /* On real hardware both the storing of the previous - value and the increment have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the increment have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; @@ -85,7 +91,9 @@ static inline atomic_count_t atomic_postdec(atomic_t *val) { - /* On real hardware both the storing of the previous - value and the decrement have to be done as a single - atomic action. */ + /* + * On real hardware both the storing of the previous + * value and the decrement have to be done as a single + * atomic action. + */ atomic_count_t prev = val->count; Index: uspace/lib/c/arch/riscv64/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/riscv64/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/riscv64/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2016 Martin Decky +/* + * Copyright (c) 2016 Martin Decky * All rights reserved. * Index: uspace/lib/c/arch/sparc64/include/libarch/fibril_context.h =================================================================== --- uspace/lib/c/arch/sparc64/include/libarch/fibril_context.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/arch/sparc64/include/libarch/fibril_context.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,3 +1,4 @@ -/* Copyright (c) 2014 Jakub Jermar +/* + * Copyright (c) 2014 Jakub Jermar * All rights reserved. * Index: uspace/lib/c/generic/async.c =================================================================== --- uspace/lib/c/generic/async.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/async.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1205,5 +1205,6 @@ assert(fibril_connection); - /* Why doing this? + /* + * Why doing this? * GCC 4.1.0 coughs on fibril_connection-> dereference. * GCC 4.1.1 happilly puts the rdhwr instruction in delay slot. Index: uspace/lib/c/generic/double_to_str.c =================================================================== --- uspace/lib/c/generic/double_to_str.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/double_to_str.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -102,5 +102,6 @@ ac = a * c; - /* Denote 32 bit parts of x a y as: x == a b, y == c d. Then: + /* + * Denote 32 bit parts of x a y as: x == a b, y == c d. Then: * a b * * c d @@ -280,6 +281,8 @@ (rest + digit_val_diff < w_dist || rest - w_dist < w_dist - rest); - /* Of the shortest strings pick the one that is closest to the actual - floating point number. */ + /* + * Of the shortest strings pick the one that is closest to the actual + * floating point number. + */ while (next_closer) { assert('0' < buf[len - 1]); @@ -571,5 +574,5 @@ * |0 0 .. 0 1|0 0 .. 0 0| == one == 1.0 * | 0 |0 0 .. 0 1| == w_err == 1 * 2^w_scaled.e - */ + */ assert(alpha <= w_scaled.exponent && w_scaled.exponent <= gamma); assert(0 != w_scaled.significand); @@ -589,10 +592,14 @@ one.exponent = w_scaled.exponent; - /* Extract the integral part of w_scaled. - w_scaled / one == w_scaled >> -one.e */ + /* + * Extract the integral part of w_scaled. + * w_scaled / one == w_scaled >> -one.e + */ uint32_t int_part = (uint32_t)(w_scaled.significand >> (-one.exponent)); - /* Fractional part of w_scaled. - w_scaled % one == w_scaled & (one.f - 1) */ + /* + * Fractional part of w_scaled. + * w_scaled % one == w_scaled & (one.f - 1) + */ uint64_t frac_part = w_scaled.significand & (one.significand - 1); Index: uspace/lib/c/generic/elf/elf.c =================================================================== --- uspace/lib/c/generic/elf/elf.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/elf/elf.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -96,5 +96,6 @@ assert(elf_is_valid(hdr)); - /* There are two legal options for a HelenOS ELF file. + /* + * There are two legal options for a HelenOS ELF file. * Either the file is ET_DYN (shared library or PIE), and the base is * (required to be) at vaddr 0. Or the file is ET_EXEC (non-relocatable) Index: uspace/lib/c/generic/elf/elf_mod.c =================================================================== --- uspace/lib/c/generic/elf/elf_mod.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/elf/elf_mod.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -189,5 +189,6 @@ } - /* Read program header table. + /* + * Read program header table. * Normally, there are very few program headers, so don't bother * with allocating memory dynamically. @@ -239,5 +240,6 @@ } - /* Attempt to allocate a span of memory large enough for the + /* + * Attempt to allocate a span of memory large enough for the * shared object. */ Index: uspace/lib/c/generic/getopt.c =================================================================== --- uspace/lib/c/generic/getopt.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/getopt.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,5 +1,5 @@ /* $NetBSD: getopt_long.c,v 1.21.4.1 2008/01/09 01:34:14 matt Exp $ */ -/*- +/* * Copyright (c) 2000 The NetBSD Foundation, Inc. * All rights reserved. @@ -41,7 +41,9 @@ #include -/* HelenOS Port : We're incorporating only the modern getopt_long with wrappers +/* + * HelenOS Port : We're incorporating only the modern getopt_long with wrappers * to keep legacy getopt() usage from breaking. All references to REPLACE_GETOPT - * are dropped, we just include the code */ + * are dropped, we just include the code + */ int opterr = 1; /* if error message should be printed */ @@ -81,7 +83,9 @@ /* Error messages */ -/* HelenOS Port: Calls to warnx() were eliminated (as we have no stderr that +/* + * HelenOS Port: Calls to warnx() were eliminated (as we have no stderr that * may be redirected) and replaced with printf. As such, error messages now - * end in a newline */ + * end in a newline + */ static const char recargchar[] = "option requires an argument -- %c\n"; Index: uspace/lib/c/generic/ieee_double.c =================================================================== --- uspace/lib/c/generic/ieee_double.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/ieee_double.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -98,5 +98,6 @@ ret.pos_val.exponent = raw_exponent - exponent_bias; - /* The predecessor is closer to val than the successor + /* + * The predecessor is closer to val than the successor * if val is a normal value of the form 2^k (hence * raw_significand == 0) with the only exception being Index: uspace/lib/c/generic/io/io.c =================================================================== --- uspace/lib/c/generic/io/io.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/io/io.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -105,5 +105,6 @@ void __stdio_init(void) { - /* The first three standard file descriptors are assigned for compatibility. + /* + * The first three standard file descriptors are assigned for compatibility. * This will probably be removed later. */ Index: uspace/lib/c/generic/io/vsnprintf.c =================================================================== --- uspace/lib/c/generic/io/vsnprintf.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/io/vsnprintf.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -70,5 +70,6 @@ if (left == 1) { - /* We have only one free byte left in buffer + /* + * We have only one free byte left in buffer * -> store trailing zero */ @@ -79,5 +80,6 @@ if (left <= size) { - /* We do not have enough space for the whole string + /* + * We do not have enough space for the whole string * with the trailing zero => print only a part * of string @@ -92,5 +94,6 @@ } - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ @@ -104,5 +107,6 @@ data->len += size; - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ @@ -140,5 +144,6 @@ if (left == 1) { - /* We have only one free byte left in buffer + /* + * We have only one free byte left in buffer * -> store trailing zero */ @@ -154,5 +159,6 @@ } - /* Put trailing zero at end, but not count it + /* + * Put trailing zero at end, but not count it * into data->len so it could be rewritten next time */ Index: uspace/lib/c/generic/rtld/module.c =================================================================== --- uspace/lib/c/generic/rtld/module.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/rtld/module.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -353,5 +353,6 @@ rtld->tls_align = max(rtld->tls_align, m->tls_align); - /* We are allocating spans "backwards", here, + /* + * We are allocating spans "backwards", here, * as described in U. Drepper's paper. */ @@ -361,5 +362,6 @@ } - /* We are in negative offsets. In order for the alignments to + /* + * We are in negative offsets. In order for the alignments to * be correct, "zero" offset (i.e. the total size) must be aligned * to the strictest alignment present. Index: uspace/lib/c/generic/str.c =================================================================== --- uspace/lib/c/generic/str.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/str.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -202,6 +202,8 @@ return EINVAL; - /* Unsigned version of ch (bit operations should only be done - on unsigned types). */ + /* + * Unsigned version of ch (bit operations should only be done + * on unsigned types). + */ uint32_t cc = (uint32_t) ch; @@ -1222,5 +1224,5 @@ * @param ch Character to insert to. * @param pos Character index where to insert. - @ @param max_pos Characters in the buffer. + * @param max_pos Characters in the buffer. * * @return True if the insertion was sucessful, false if the position @@ -1531,6 +1533,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; @@ -1578,6 +1582,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; @@ -1625,6 +1631,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; @@ -1671,6 +1679,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; @@ -1711,6 +1721,8 @@ return EINVAL; - /* Check whether we are at the end of - the string in strict mode */ + /* + * Check whether we are at the end of + * the string in strict mode + */ if ((strict) && (*lendptr != 0)) return EINVAL; Index: uspace/lib/c/generic/str_error.c =================================================================== --- uspace/lib/c/generic/str_error.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/str_error.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -41,5 +41,6 @@ #define NOERR_LEN 64 -/* The arrays below are automatically generated from the same file that +/* + * The arrays below are automatically generated from the same file that * errno.h constants are generated from. Triple-include of the same list * with redefinitions of __errno() macro are used to ensure that the @@ -73,5 +74,6 @@ static int find_errno(errno_t e) { - /* Just a dumb linear search. + /* + * Just a dumb linear search. * There are too few entries to warrant anything smarter. */ Index: uspace/lib/c/generic/strtol.c =================================================================== --- uspace/lib/c/generic/strtol.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/strtol.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -57,5 +57,6 @@ } -/* FIXME: workaround for GCC "optimizing" the overflow check +/* + * FIXME: workaround for GCC "optimizing" the overflow check * into soft-emulated 128b multiplication using `__multi3`, * which we don't currently implement. @@ -139,5 +140,6 @@ if (endptr != NULL) { - /* Move the pointer to the end of the number, + /* + * Move the pointer to the end of the number, * in case it isn't there already. */ Index: uspace/lib/c/generic/vfs/inbox.c =================================================================== --- uspace/lib/c/generic/vfs/inbox.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/vfs/inbox.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -65,5 +65,5 @@ static LIST_INITIALIZE(inb_list); -/* Inserts a named file into the inbox. +/** Inserts a named file into the inbox. * * If a file with the same name is already present, it overwrites it and returns @@ -118,5 +118,5 @@ } -/* Retrieve a file with this name. +/** Retrieve a file with this name. * * @param name Name of the entry. @@ -138,5 +138,5 @@ } -/* Writes names of entries that are currently set into an array provided by the +/** Writes names of entries that are currently set into an array provided by the * user. * Index: uspace/lib/c/generic/vol.c =================================================================== --- uspace/lib/c/generic/vol.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/generic/vol.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -236,5 +236,6 @@ /** Erase partition (to the extent where we will consider it not containing - * a file system. */ + * a file system. + */ errno_t vol_part_empty(vol_t *vol, service_id_t sid) { Index: uspace/lib/c/include/getopt.h =================================================================== --- uspace/lib/c/include/getopt.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/include/getopt.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -1,5 +1,5 @@ /* $NetBSD: getopt.h,v 1.10.6.1 2008/05/18 12:30:09 yamt Exp $ */ -/*- +/* * Copyright (c) 2000 The NetBSD Foundation, Inc. * All rights reserved. Index: uspace/lib/c/include/io/pixelmap.h =================================================================== --- uspace/lib/c/include/io/pixelmap.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/include/io/pixelmap.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -54,5 +54,6 @@ PIXELMAP_EXTEND_SIDES, - /* If outside of a pixmap, return closest pixel from the edge, + /* + * If outside of a pixmap, return closest pixel from the edge, * with alpha = 0 */ Index: uspace/lib/c/include/wchar.h =================================================================== --- uspace/lib/c/include/wchar.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/c/include/wchar.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -27,5 +27,6 @@ */ -/* Authors: +/* + * Authors: * Jiří Zárevúcky (jzr) */ Index: uspace/lib/crypto/crc16_ibm.c =================================================================== --- uspace/lib/crypto/crc16_ibm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/crypto/crc16_ibm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -70,5 +70,6 @@ }; -/* Compute a CRC16 +/* + * Compute a CRC16 * * @param crc Init value of the CRC Index: uspace/lib/draw/drawctx.c =================================================================== --- uspace/lib/draw/drawctx.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/draw/drawctx.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -182,9 +182,11 @@ } - /* Note: + /* + * Note: * Antialiasing could be achieved by up-scaling path coordinates and * rendering into temporary higher-resolution surface. Then, the temporary * surface would be set as a source and its damaged region would be - * transferred to the original surface. */ + * transferred to the original surface. + */ list_foreach(*((list_t *) path), link, path_step_t, step) { Index: uspace/lib/draw/font.h =================================================================== --- uspace/lib/draw/font.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/draw/font.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -55,10 +55,14 @@ metric_t width; - /* Horizontal distance between right side of the glyph and origin - of the next glyph */ + /* + * Horizontal distance between right side of the glyph and origin + * of the next glyph + */ metric_t right_side_bearing; - /* Vertical distance between baseline and top of the glyph - (positive to top) */ + /* + * Vertical distance between baseline and top of the glyph + * (positive to top) + */ metric_t ascender; Index: uspace/lib/drv/generic/remote_audio_mixer.c =================================================================== --- uspace/lib/drv/generic/remote_audio_mixer.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/drv/generic/remote_audio_mixer.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -104,6 +104,8 @@ char *name_place = calloc(1, name_size); if (!name_place) { - /* Make the other side fail - * as it waits for read request */ + /* + * Make the other side fail + * as it waits for read request + */ async_data_read_start(exch, (void *)-1, 0); return ENOMEM; @@ -141,6 +143,8 @@ char *name_place = calloc(1, name_size); if (!name_place) { - /* Make the other side fail - * as it waits for read request */ + /* + * Make the other side fail + * as it waits for read request + */ async_data_read_start(exch, (void *)-1, 0); return ENOMEM; Index: uspace/lib/drv/generic/remote_audio_pcm.c =================================================================== --- uspace/lib/drv/generic/remote_audio_pcm.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/drv/generic/remote_audio_pcm.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -196,6 +196,8 @@ char *name_place = calloc(1, name_size); if (!name_place) { - /* Make the other side fail - * as it waits for read request */ + /* + * Make the other side fail + * as it waits for read request + */ async_data_read_start(exch, (void *)-1, 0); async_exchange_end(exch); @@ -286,6 +288,8 @@ async_exchange_end(exch); - /* All OK or something has changed. Verify that it was not one of the - * params we care about */ + /* + * All OK or something has changed. Verify that it was not one of the + * params we care about + */ if ((ret == EOK || ret == ELIMIT) && (!channels || *channels == channels_arg) && Index: uspace/lib/ext4/src/balloc.c =================================================================== --- uspace/lib/ext4/src/balloc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/ext4/src/balloc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -214,5 +214,6 @@ if ((first + count) >= limit) { - /* This extent spans over 2 or more block groups, + /* + * This extent spans over 2 or more block groups, * we'll break it into smaller parts. */ @@ -254,5 +255,6 @@ if (!ext4_superblock_has_feature_incompatible(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) { - /* If we are not using FLEX_BG, the first data block + /* + * If we are not using FLEX_BG, the first data block * is always after the inode table. */ Index: uspace/lib/ext4/src/filesystem.c =================================================================== --- uspace/lib/ext4/src/filesystem.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/ext4/src/filesystem.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -750,5 +750,6 @@ } else if (!ext4_superblock_has_feature_read_only(sb, EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) { - /* Very old fs were all block groups have + /* + * Very old fs were all block groups have * superblock and block descriptors backups. */ @@ -767,5 +768,6 @@ uint32_t block_size = ext4_superblock_get_block_size(sb); - /* Now we know that this block group has backups, + /* + * Now we know that this block group has backups, * we have to compute how many blocks are reserved * for them @@ -773,5 +775,6 @@ if (idx == 0 && block_size == 1024) { - /* Special case for first group were the boot block + /* + * Special case for first group were the boot block * resides */ Index: uspace/lib/ext4/src/ops.c =================================================================== --- uspace/lib/ext4/src/ops.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/ext4/src/ops.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -146,5 +146,5 @@ } -/* Finalization of the driver. +/** Finalization of the driver. * * This is only needed to destroy the hash table. Index: uspace/lib/fdisk/include/types/fdisk.h =================================================================== --- uspace/lib/fdisk/include/types/fdisk.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/fdisk/include/types/fdisk.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -182,5 +182,6 @@ aoff64_t b0; /** Next partition following the free range or @c NULL if the range - * is at the end. */ + * is at the end. + */ fdisk_part_t *npart; } fdisk_free_range_t; Index: uspace/lib/fmtutil/fmtutil.c =================================================================== --- uspace/lib/fmtutil/fmtutil.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/fmtutil/fmtutil.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -61,7 +61,5 @@ } -/** Line consumer that prints the lines aligned according to spec - * - **/ +/** Line consumer that prints the lines aligned according to spec */ static errno_t print_line(wchar_t *wstr, size_t chars, bool last, void *data) { @@ -228,5 +226,6 @@ line_len = last_word_end - line_start; } - /* Here we have less than width chars starting from line_start. + /* + * Here we have less than width chars starting from line_start. * Moreover, the last portion does not contain spaces or newlines */ Index: uspace/lib/fs/libfs.c =================================================================== --- uspace/lib/fs/libfs.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/fs/libfs.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -625,5 +625,6 @@ } - /* At this point, par is either NULL or a directory. + /* + * At this point, par is either NULL or a directory. * If cur is NULL, the looked up file does not exist yet. */ Index: uspace/lib/graph/graph.c =================================================================== --- uspace/lib/graph/graph.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/graph/graph.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -259,6 +259,8 @@ errno_t rc = vs->ops.yield(vs); - /* Now that the driver was given a chance to deallocate resources, - * current mode can be unset. */ + /* + * Now that the driver was given a chance to deallocate resources, + * current mode can be unset. + */ if (vs->mode_set) vs->mode_set = false; Index: uspace/lib/graph/graph.h =================================================================== --- uspace/lib/graph/graph.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/graph/graph.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -53,5 +53,6 @@ /** * Device driver shall allocate any necessary internal structures - * specific for a claimed visualizer. */ + * specific for a claimed visualizer. + */ errno_t (*claim)(struct visualizer *vs); @@ -60,5 +61,6 @@ * specific for a claimed visualizer. Driver shall also check whether * the mode is set and if so it shall change its internal state - * accordingly (e.g. deallocate frame buffers). */ + * accordingly (e.g. deallocate frame buffers). + */ errno_t (*yield)(struct visualizer *vs); @@ -71,5 +73,6 @@ * reason). If it is convenient for the device driver (e.g. for better * optimization), the pointer to the handle_damage operation can be - * changed at this point. */ + * changed at this point. + */ errno_t (*change_mode)(struct visualizer *vs, vslmode_t new_mode); @@ -81,5 +84,6 @@ * the shared backbuffer (i.e. when reading from backbuffer, the offsets * shall be added to the coordinates and if necessary the result shall be - * wrapped around the edge of the backbuffer). */ + * wrapped around the edge of the backbuffer). + */ errno_t (*handle_damage)(struct visualizer *vs, sysarg_t x, sysarg_t y, sysarg_t width, sysarg_t height, @@ -89,10 +93,12 @@ * Upper layers of the graphic stack might report inactivity. In such * case, device driver might enable power saving mode on the device - * corresponding to the visualizer. */ + * corresponding to the visualizer. + */ errno_t (*suspend)(struct visualizer *vs); /** * When upper layers detect activity on suspended visualizer, device - * driver shall disable power saving mode on the corresponding device. */ + * driver shall disable power saving mode on the corresponding device. + */ errno_t (*wakeup)(struct visualizer *vs); } visualizer_ops_t; @@ -105,5 +111,6 @@ /** * Link to the list of all visualizers belonging to the graphic device. - * Field is fully managed by libgraph. */ + * Field is fully managed by libgraph. + */ link_t link; @@ -112,5 +119,6 @@ * when equals 0, visualizer is not claimed. At the time, visualizer * can be claimed only by a single client. - * Field is fully managed by libgraph. */ + * Field is fully managed by libgraph. + */ atomic_t ref_cnt; @@ -121,5 +129,6 @@ * If the visualizer is registered through libgraph functions, then the * field is fully managed by libgraph. Otherwise, it is a driver - * responsibility to set and update this field. */ + * responsibility to set and update this field. + */ sysarg_t reg_svc_handle; @@ -130,5 +139,6 @@ * in the compositor). * Field is fully managed by libgraph. It is assigned when the visualizer - * gets claimed and is valid until it is yielded. */ + * gets claimed and is valid until it is yielded. + */ sysarg_t client_side_handle; @@ -141,5 +151,6 @@ * degrees, virtual monitor is resized by the user). * Field is fully managed by libgraph. Device driver can use it indirectly - * through notification functions. */ + * through notification functions. + */ async_sess_t *notif_sess; @@ -150,5 +161,6 @@ * dimensions when virtual monitor is resized). * Both device driver and libgraph must lock on this mutex when accessing - * modes list or default mode index. */ + * modes list or default mode index. + */ fibril_mutex_t mode_mtx; @@ -162,5 +174,6 @@ * and final output device (e.g. monitor). * Field is fully managed by device driver, libgraph reads it with locked - * mutex. */ + * mutex. + */ list_t modes; @@ -173,5 +186,6 @@ * mode list. * Field is fully managed by device driver, libgraph reads it with locked - * mutex. */ + * mutex. + */ sysarg_t def_mode_idx; @@ -181,5 +195,6 @@ * driver can also read it to properly interpret the cell type and its * internal structures when handling the damage. - * Field is fully managed by libgraph, can be read by device driver. */ + * Field is fully managed by libgraph, can be read by device driver. + */ vslmode_t cur_mode; @@ -187,5 +202,6 @@ * Determines whether the visualizer is currently set to some mode or not, * that is whether cur_mode field contains up-to-date data. - * Field is fully managed by libgraph, can be read by device driver. */ + * Field is fully managed by libgraph, can be read by device driver. + */ bool mode_set; @@ -193,5 +209,6 @@ * Device driver function pointers. * Field is fully managed by device driver, libgraph invokes driver's - * functions through it. */ + * functions through it. + */ visualizer_ops_t ops; @@ -200,5 +217,6 @@ * Device driver reads the cells when handling damage. Cells shall be * interpreted according to the currently set mode. - * Field is fully managed by libgraph, can be read by device driver. */ + * Field is fully managed by libgraph, can be read by device driver. + */ pixelmap_t cells; @@ -207,5 +225,6 @@ * contain pointers to frontbuffers or information representing the * final output device (e.g. hardware port for physical monitor). - * Field is fully managed by device driver. */ + * Field is fully managed by device driver. + */ void *dev_ctx; } visualizer_t; @@ -265,5 +284,6 @@ * Fill in the basic visualizer structure. The device driver shall take the * created torso and to complete it by adding its specific structures - * (device context, modes). */ + * (device context, modes). + */ extern void graph_init_visualizer(visualizer_t *); @@ -281,5 +301,6 @@ /** - * Allocate the visualizer so it can be initialized. */ + * Allocate the visualizer so it can be initialized. + */ extern visualizer_t *graph_alloc_visualizer(void); @@ -289,10 +310,12 @@ * is considered ready to handle client connection. Since visualizer * list is guarded by the mutex, visualizers might be added even after the - * initialialization of the device driver. */ + * initialialization of the device driver. + */ extern errno_t graph_register_visualizer(visualizer_t *); /** * Retrieve the visualizer from the visualizer list according to its - * service ID. */ + * service ID. + */ extern visualizer_t *graph_get_visualizer(sysarg_t); @@ -300,5 +323,6 @@ * Unregister the visualizer from the location service and remove it * from the driver visualizer list. Function shall be called by device driver - * before deallocating the resources for the visualizer. */ + * before deallocating the resources for the visualizer. + */ extern errno_t graph_unregister_visualizer(visualizer_t *); @@ -306,5 +330,6 @@ * Destroy the rest of the visualizer. Device driver shall call this function * only after it has unregistered the visualizer and deallocated all the - * resources for which the driver is responsible. */ + * resources for which the driver is responsible. + */ extern void graph_destroy_visualizer(visualizer_t *); @@ -320,5 +345,6 @@ * Device driver can call this function to notify the client through the * callback connection that the visualizer with a specified service ID should - * be switched to the mode with the given index. */ + * be switched to the mode with the given index. + */ extern errno_t graph_notify_mode_change(async_sess_t *, sysarg_t, sysarg_t); @@ -326,5 +352,6 @@ * Device driver can call this function to notify the client through the * callback connection that the visualizer with a specified service ID has - * lost its output device (e.g. virtual monitor was closed by a user). */ + * lost its output device (e.g. virtual monitor was closed by a user). + */ extern errno_t graph_notify_disconnect(async_sess_t *, sysarg_t); Index: uspace/lib/gui/widget.h =================================================================== --- uspace/lib/gui/widget.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/gui/widget.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -72,5 +72,6 @@ * Virtual destructor. Apart from deallocating the resources specific for * the particular widget, each widget shall remove itself from parents - * children and deallocate itself. */ + * children and deallocate itself. + */ void (*destroy)(widget_t *); @@ -82,5 +83,6 @@ * to be changed. If not, widget shall calculate new layout for its children * and call rearrange() on each of them. Otherwise, widget shall change its - * own properties and call reconfigure() on its parent. */ + * own properties and call reconfigure() on its parent. + */ void (*reconfigure)(widget_t *); @@ -90,5 +92,6 @@ * position and size according to provided arguments, paint itself, * calculate new layout for its children and call rearrange() on each - * of them. */ + * of them. + */ void (*rearrange)(widget_t *, sysarg_t, sysarg_t, sysarg_t, sysarg_t); @@ -97,5 +100,6 @@ * in top-bottom order and repaint() is called on each widget. Widget shall * either paint itself or copy its private buffer onto window surface. - * Widget shall also post damage event into window event loop. */ + * Widget shall also post damage event into window event loop. + */ void (*repaint)(widget_t *); @@ -104,5 +108,6 @@ * reaction to the event, widget might call reconfigure() on its parent or * rearrange() on its children. If the widget wants to change its visual - * information, refresh event should be posted to the window event loop. */ + * information, refresh event should be posted to the window event loop. + */ void (*handle_keyboard_event)(widget_t *, kbd_event_t); @@ -114,5 +119,6 @@ * should be posted to the window event loop. If the widget accepts * keyboard events, it should take ownership of keyboard focus. Widget can - * also acquire or release mouse grab. */ + * also acquire or release mouse grab. + */ void (*handle_position_event)(widget_t *, pos_event_t); }; Index: uspace/lib/gui/window.h =================================================================== --- uspace/lib/gui/window.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/gui/window.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -73,5 +73,6 @@ * compositor and asks all widgets in the tree to calculate their new properties * and to paint themselves on the new surface (top-bottom order). Should be - * called also after opening new window to obtain surface. */ + * called also after opening new window to obtain surface. + */ extern void window_resize(window_t *, sysarg_t, sysarg_t, sysarg_t, sysarg_t, window_placement_flags_t); @@ -84,5 +85,6 @@ * are asked to repaint themselves in top-bottom order. Should be called by * widget after such change of its internal state that does not need resizing - * of neither parent nor children (). */ + * of neither parent nor children (). + */ extern void window_refresh(window_t *); @@ -90,24 +92,29 @@ * Post damage event into event loop. Handler informs compositor to update the * window surface on the screen. Should be called by widget after painting - * itself or copying its buffer onto window surface. */ + * itself or copying its buffer onto window surface. + */ extern void window_damage(window_t *); /** * Retrieve dummy root widget of the window widget tree. Intended to be called - * by proper top-level widget to set his parent. */ + * by proper top-level widget to set his parent. + */ extern widget_t *window_root(window_t *); /** * Prepare and enqueue window fibrils for event loop and input fetching. When - * async_manager() function is called, event loop is executed. */ + * async_manager() function is called, event loop is executed. + */ extern void window_exec(window_t *); /** * Claim protected window surface. Intended for widgets painting from their - * internal fibrils (e.g. terminal, animation, video). */ + * internal fibrils (e.g. terminal, animation, video). + */ extern surface_t *window_claim(window_t *); /** - * Yield protected window surface after painting. */ + * Yield protected window surface after painting. + */ extern void window_yield(window_t *); @@ -119,5 +126,6 @@ * terminates. When event loop fibril handles closing event, all window * resources are deallocated and fibril also terminates. Moreover, if the - * window is main window of the application, whole task terminates. */ + * window is main window of the application, whole task terminates. + */ extern void window_close(window_t *); Index: uspace/lib/label/include/std/gpt.h =================================================================== --- uspace/lib/label/include/std/gpt.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/label/include/std/gpt.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -82,5 +82,6 @@ #define GPT_LINUX_FS_DATA "0FC63DAF-8483-4772-8E79-3D69D8477DE4" /** I could not find any definition of Minix GUID partition type. - * This is a randomly generated UUID */ + * This is a randomly generated UUID + */ #define GPT_MINIX_FAKE "8308e350-4e2d-46c7-8e3b-24b07e8ac674" Index: uspace/lib/nic/include/nic_impl.h =================================================================== --- uspace/lib/nic/include/nic_impl.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/nic/include/nic_impl.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -43,6 +43,8 @@ #include -/* Inclusion of this file is not prohibited, because drivers could want to - * inject some adaptation layer between the DDF call and NICF implementation */ +/* + * Inclusion of this file is not prohibited, because drivers could want to + * inject some adaptation layer between the DDF call and NICF implementation + */ extern errno_t nic_get_address_impl(ddf_fun_t *dev_fun, nic_address_t *address); Index: uspace/lib/nic/src/nic_driver.c =================================================================== --- uspace/lib/nic/src/nic_driver.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/nic/src/nic_driver.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -518,6 +518,8 @@ void nic_received_frame(nic_t *nic_data, nic_frame_t *frame) { - /* Note: this function must not lock main lock, because loopback driver - * calls it inside send_frame handler (with locked main lock) */ + /* + * Note: this function must not lock main lock, because loopback driver + * calls it inside send_frame handler (with locked main lock) + */ fibril_rwlock_read_lock(&nic_data->rxc_lock); nic_frame_type_t frame_type; @@ -1062,5 +1064,6 @@ if (remaining.tv_sec > 0) { time_t wait_sec = remaining.tv_sec; - /* wait maximaly 5 seconds to get reasonable reaction time + /* + * wait maximaly 5 seconds to get reasonable reaction time * when period is reset */ Index: uspace/lib/nic/src/nic_impl.c =================================================================== --- uspace/lib/nic/src/nic_impl.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/nic/src/nic_impl.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -123,7 +123,9 @@ sizeof(struct timeval)); if (rc != EOK) { - /* We have already ran the on stopped handler, even if we + /* + * We have already ran the on stopped handler, even if we * terminated the state change we would end up in undefined state. - * Therefore we just log the problem. */ + * Therefore we just log the problem. + */ } @@ -302,5 +304,6 @@ rc = nic_rxc_unicast_set_mode(&nic_data->rx_control, mode, addr_list, addr_count); - /* After changing the mode the addr db gets cleared, therefore we have + /* + * After changing the mode the addr db gets cleared, therefore we have * to reinsert also the physical address of NIC. */ @@ -737,6 +740,8 @@ { nic_t *nic_data = nic_get_from_ddf_fun(fun); - /* If the driver does not implement the poll mode change handler it cannot - * switch off interrupts and this is not supported. */ + /* + * If the driver does not implement the poll mode change handler it cannot + * switch off interrupts and this is not supported. + */ if (nic_data->on_poll_mode_change == NULL) return ENOTSUP; Index: uspace/lib/pcm/src/format.c =================================================================== --- uspace/lib/pcm/src/format.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/pcm/src/format.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -189,5 +189,6 @@ return EINVAL; - /* This is so ugly it eats kittens, and puppies, and ducklings, + /* + * This is so ugly it eats kittens, and puppies, and ducklings, * and all little fluffy things... */ Index: uspace/lib/posix/include/posix/float.h =================================================================== --- uspace/lib/posix/include/posix/float.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/include/posix/float.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -78,5 +78,6 @@ #define LDBL_MANT_DIG __LDBL_MANT_DIG__ #else -/* For something else than GCC, following definitions are provided. +/* + * For something else than GCC, following definitions are provided. * They are intentionally guarded by the given macro to ensure that anyone * who wants them states this explicitly. Index: uspace/lib/posix/include/posix/strings.h =================================================================== --- uspace/lib/posix/include/posix/strings.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/include/posix/strings.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -50,5 +50,6 @@ #endif -/* TODO: not implemented due to missing locale support +/* + * TODO: not implemented due to missing locale support * * int strcasecmp_l(const char *, const char *, locale_t); Index: uspace/lib/posix/src/fcntl.c =================================================================== --- uspace/lib/posix/src/fcntl.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/fcntl.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -55,6 +55,8 @@ case F_DUPFD: case F_DUPFD_CLOEXEC: - /* VFS currently does not provide the functionality to duplicate - * opened file descriptor. */ + /* + * VFS currently does not provide the functionality to duplicate + * opened file descriptor. + */ // FIXME: implement this once dup() is available errno = ENOTSUP; @@ -67,14 +69,20 @@ return 0; case F_GETFL: - /* File status flags (i.e. O_APPEND) are currently private to the - * VFS server so it cannot be easily retrieved. */ + /* + * File status flags (i.e. O_APPEND) are currently private to the + * VFS server so it cannot be easily retrieved. + */ flags = 0; - /* File access flags are currently not supported for file descriptors. - * Provide full access. */ + /* + * File access flags are currently not supported for file descriptors. + * Provide full access. + */ flags |= O_RDWR; return flags; case F_SETFL: - /* File access flags are currently not supported for file descriptors. - * Ignore arguments and report success. */ + /* + * File access flags are currently not supported for file descriptors. + * Ignore arguments and report success. + */ return 0; case F_GETOWN: Index: uspace/lib/posix/src/locale.c =================================================================== --- uspace/lib/posix/src/locale.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/locale.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -41,5 +41,6 @@ #include "posix/string.h" -/* Just a very basic dummy implementation. +/* + * Just a very basic dummy implementation. * This should allow code using locales to work properly, but doesn't provide * any localization functionality. Index: uspace/lib/posix/src/signal.c =================================================================== --- uspace/lib/posix/src/signal.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/signal.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -44,5 +44,6 @@ #include "libc/task.h" -/* This file implements a fairly dumb and incomplete "simulation" of +/* + * This file implements a fairly dumb and incomplete "simulation" of * POSIX signals. Since HelenOS doesn't support signals and mostly doesn't * have any equivalent functionality, most of the signals are useless. The @@ -356,5 +357,6 @@ } - /* Modifying signal mask is unnecessary, + /* + * Modifying signal mask is unnecessary, * signal handling is serialized. */ Index: uspace/lib/posix/src/stdio.c =================================================================== --- uspace/lib/posix/src/stdio.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/stdio.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -126,11 +126,15 @@ ++cnt; if (c == delimiter) { - /* Delimiter was just stored. Provide EOF as the next + /* + * Delimiter was just stored. Provide EOF as the next * character - it will be masked as NUL and output string - * will be properly terminated. */ + * will be properly terminated. + */ c = EOF; } else { - /* Neither delimiter nor EOF were encountered. Just fetch - * the next character from the stream. */ + /* + * Neither delimiter nor EOF were encountered. Just fetch + * the next character from the stream. + */ c = fgetc(stream); } Index: uspace/lib/posix/src/stdio/scanf.c =================================================================== --- uspace/lib/posix/src/stdio/scanf.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/stdio/scanf.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -61,5 +61,6 @@ _PROV_READY, /** Cursor is temporarily lent to the external entity. No action is - * possible until the cursor is returned. */ + * possible until the cursor is returned. + */ _PROV_CURSOR_LENT, }; @@ -74,5 +75,6 @@ int fetched; /** Elements are fetched from the source in batches (e.g. by getline()) - * to allow using strtol/strtod family even on streams. */ + * to allow using strtol/strtod family even on streams. + */ char *window; /** Size of the current window. */ @@ -84,22 +86,27 @@ /** Take control over data source. Finish initialization of the internal - * structures (e.g. allocation of window). */ + * structures (e.g. allocation of window). + */ void (*capture)(struct __input_provider *); /** Get a single element from the source and update the internal structures * accordingly (e.g. greedy update of the window). Return -1 if the - * element cannot be obtained. */ + * element cannot be obtained. + */ int (*pop)(struct __input_provider *); /** Undo the most recent not-undone pop operation. Might be necesarry to * flush current window and seek data source backwards. Return 0 if the - * pop history is exhausted, non-zero on success. */ + * pop history is exhausted, non-zero on success. + */ int (*undo)(struct __input_provider *); /** Lend the cursor to the caller. */ const char *(*borrow_cursor)(struct __input_provider *); /** Take control over possibly incremented cursor and update the internal - * structures if necessary. */ + * structures if necessary. + */ void (*return_cursor)(struct __input_provider *, const char *); /** Release the control over the source. That is, synchronize any * fetched but non-consumed elements (e.g. by seeking) and destruct - * internal structures (e.g. window deallocation). */ + * internal structures (e.g. window deallocation). + */ void (*release)(struct __input_provider *); } _input_provider; @@ -199,10 +206,12 @@ if (!self->cursor || self->window == self->cursor) { - /* Complex case. Either at EOF (cursor == NULL) or there is no more + /* + * Complex case. Either at EOF (cursor == NULL) or there is no more * place to retreat to inside the window. Seek the source backwards * and flush the window. Regarding the scanf, this could happend only * when matching unbounded string (%s) or unbounded scanset (%[) not * containing newline, while at the same time newline is the character - * that breaks the matching process. */ + * that breaks the matching process. + */ int rc = fseek(self->source.stream, -1, SEEK_CUR); if (rc == -1) { @@ -292,6 +301,8 @@ assert(self->consumed >= self->fetched); - /* Try to correct the difference between the stream position and what was - * actually consumed. If it is not possible, continue anyway. */ + /* + * Try to correct the difference between the stream position and what was + * actually consumed. If it is not possible, continue anyway. + */ fseek(self->source.stream, self->consumed - self->fetched, SEEK_CUR); @@ -412,6 +423,8 @@ return 1; case 'p': - /* According to POSIX, %p modifier is implementation defined but - * must correspond to its printf counterpart. */ + /* + * According to POSIX, %p modifier is implementation defined but + * must correspond to its printf counterpart. + */ case 'x': case 'X': @@ -506,9 +519,11 @@ int int_conv_base = 0; - /* Buffers allocated by scanf for optional 'm' specifier must be remembered + /* + * Buffers allocated by scanf for optional 'm' specifier must be remembered * to deallocaate them in case of an error. Because each of those buffers * corresponds to one of the argument from va_list, there is an upper bound * on the number of those arguments. In case of C99, this uppper bound is - * 127 arguments. */ + * 127 arguments. + */ char *buffers[127]; for (int i = 0; i < 127; ++i) { @@ -519,18 +534,22 @@ in->capture(in); - /* Interpret format string. Control shall prematurely jump from the cycle + /* + * Interpret format string. Control shall prematurely jump from the cycle * on input failure, matching failure or illegal format string. In order * to keep error reporting simple enough and to keep input consistent, * error condition shall be always manifested as jump from the cycle, * not function return. Format string pointer shall be updated specifically - * for each sub-case (i.e. there shall be no loop-wide increment).*/ + * for each sub-case (i.e. there shall be no loop-wide increment). + */ while (*fmt) { if (converting) { - /* Processing inside conversion specifier. Either collect optional + /* + * Processing inside conversion specifier. Either collect optional * parameters or execute the conversion. When the conversion * is successfully completed, increment conversion count and switch - * back to normal mode. */ + * back to normal mode. + */ if (*fmt == '*') { /* Assignment-supression (optional). */ @@ -564,7 +583,9 @@ fmt = fmt_new; } else { - /* Since POSIX requires width to be non-zero, it is + /* + * Since POSIX requires width to be non-zero, it is * sufficient to interpret zero width as error without - * referring to errno. */ + * referring to errno. + */ break; } @@ -572,6 +593,8 @@ /* Length modifier (optional). */ if (length_mod == LMOD_NONE) { - /* Already set. Illegal format string. The actual detection - * is carried out in the is_length_mod(). */ + /* + * Already set. Illegal format string. The actual detection + * is carried out in the is_length_mod(). + */ break; } @@ -590,7 +613,9 @@ } - /* Conversion of the integer with %p specifier needs special + /* + * Conversion of the integer with %p specifier needs special * handling, because it is not allowed to have arbitrary - * length modifier. */ + * length modifier. + */ if (*fmt == 'p') { if (length_mod == LMOD_NONE) { @@ -602,9 +627,11 @@ } - /* First consume any white spaces, so we can borrow cursor + /* + * First consume any white spaces, so we can borrow cursor * from the input provider. This way, the cursor will either * point to the non-white space while the input will be * prefetched up to the newline (which is suitable for strtol), - * or the input will be at EOF. */ + * or the input will be at EOF. + */ do { c = in->pop(in); @@ -616,6 +643,8 @@ break; } else { - /* Everything is OK, just undo the last pop, so the cursor - * can be borrowed. */ + /* + * Everything is OK, just undo the last pop, so the cursor + * can be borrowed. + */ in->undo(in); } @@ -626,12 +655,16 @@ const char *cur_updated = NULL; - /* Borrow the cursor. Until it is returned to the provider + /* + * Borrow the cursor. Until it is returned to the provider * we cannot jump from the cycle, because it would leave - * the input inconsistent. */ + * the input inconsistent. + */ cur_borrowed = in->borrow_cursor(in); - /* If the width is limited, the cursor horizont must be + /* + * If the width is limited, the cursor horizont must be * decreased accordingly. Otherwise the strtol could read more - * than allowed by width. */ + * than allowed by width. + */ if (width != -1) { cur_duplicated = strndup(cur_borrowed, width); @@ -661,7 +694,9 @@ cur_updated = NULL; cur_duplicated = NULL; - /* Return the cursor to the provider. Input consistency is again + /* + * Return the cursor to the provider. Input consistency is again * the job of the provider, so we can report errors from - * now on. */ + * now on. + */ in->return_cursor(in, cur_borrowed); cur_borrowed = NULL; @@ -673,6 +708,8 @@ } - /* If not supressed, assign the converted integer into - * the next output argument. */ + /* + * If not supressed, assign the converted integer into + * the next output argument. + */ if (!assign_supress) { if (int_conv_unsigned) { @@ -795,9 +832,11 @@ } - /* First consume any white spaces, so we can borrow cursor + /* + * First consume any white spaces, so we can borrow cursor * from the input provider. This way, the cursor will either * point to the non-white space while the input will be * prefetched up to the newline (which is suitable for strtof), - * or the input will be at EOF. */ + * or the input will be at EOF. + */ do { c = in->pop(in); @@ -809,6 +848,8 @@ break; } else { - /* Everything is OK, just undo the last pop, so the cursor - * can be borrowed. */ + /* + * Everything is OK, just undo the last pop, so the cursor + * can be borrowed. + */ in->undo(in); } @@ -819,12 +860,16 @@ const char *cur_updated = NULL; - /* Borrow the cursor. Until it is returned to the provider + /* + * Borrow the cursor. Until it is returned to the provider * we cannot jump from the cycle, because it would leave - * the input inconsistent. */ + * the input inconsistent. + */ cur_borrowed = in->borrow_cursor(in); - /* If the width is limited, the cursor horizont must be + /* + * If the width is limited, the cursor horizont must be * decreased accordingly. Otherwise the strtof could read more - * than allowed by width. */ + * than allowed by width. + */ if (width != -1) { cur_duplicated = strndup(cur_borrowed, width); @@ -862,7 +907,9 @@ cur_limited = NULL; cur_updated = NULL; - /* Return the cursor to the provider. Input consistency is again + /* + * Return the cursor to the provider. Input consistency is again * the job of the provider, so we can report errors from - * now on. */ + * now on. + */ in->return_cursor(in, cur_borrowed); cur_borrowed = NULL; @@ -874,6 +921,8 @@ } - /* If nto supressed, assign the converted floating point number - * into the next output argument. */ + /* + * If nto supressed, assign the converted floating point number + * into the next output argument. + */ if (!assign_supress) { float *pf; @@ -1008,6 +1057,8 @@ int my_buffer_idx = 0; - /* Retrieve the buffer into which popped characters - * will be stored. */ + /* + * Retrieve the buffer into which popped characters + * will be stored. + */ if (!assign_supress) { if (assign_alloc) { @@ -1047,6 +1098,8 @@ buf_size += alloc_step; } else { - /* Break just from this tight loop. Errno will - * be checked after it. */ + /* + * Break just from this tight loop. Errno will + * be checked after it. + */ break; } @@ -1071,6 +1124,8 @@ /* Check for failures. */ if (cur == buf) { - /* Matching failure. Input failure was already checked - * earlier. */ + /* + * Matching failure. Input failure was already checked + * earlier. + */ matching_failure = true; if (!assign_supress && assign_alloc) { @@ -1128,7 +1183,9 @@ } else { - /* Processing outside conversion specifier. Either skip white + /* + * Processing outside conversion specifier. Either skip white * spaces or match characters one by one. If conversion specifier - * is detected, switch to coversion mode. */ + * is detected, switch to coversion mode. + */ if (isspace(*fmt)) { /* Skip white spaces in the format string. */ @@ -1194,6 +1251,8 @@ } if (rc == EOF) { - /* Caller will not know how many arguments were successfully converted, - * so the deallocation of buffers is our responsibility. */ + /* + * Caller will not know how many arguments were successfully converted, + * so the deallocation of buffers is our responsibility. + */ for (int i = 0; i < next_unused_buffer_idx; ++i) { free(buffers[i]); Index: uspace/lib/posix/src/stdlib.c =================================================================== --- uspace/lib/posix/src/stdlib.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/stdlib.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -153,5 +153,6 @@ } if (middle == base) { - /* There is just one member left to check and it + /* + * There is just one member left to check and it * didn't match the key. Avoid infinite loop. */ @@ -234,5 +235,6 @@ // TODO: symlink resolution - /* Function absolutize is implemented in libc and declared in vfs.h. + /* + * Function absolutize is implemented in libc and declared in vfs.h. * No more processing is required as HelenOS doesn't have symlinks * so far (as far as I can tell), although this function will need @@ -242,5 +244,6 @@ if (absolute == NULL) { - /* POSIX requires some specific errnos to be set + /* + * POSIX requires some specific errnos to be set * for some cases, but there is no way to find out from * absolutize(). Index: uspace/lib/posix/src/string.c =================================================================== --- uspace/lib/posix/src/string.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/string.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -134,5 +134,6 @@ dest[i] = src[i]; - /* the standard requires that nul characters + /* + * the standard requires that nul characters * are appended to the length of n, in case src is shorter */ Index: uspace/lib/posix/src/sys/wait.c =================================================================== --- uspace/lib/posix/src/sys/wait.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/sys/wait.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -64,5 +64,6 @@ { assert(__posix_wifsignaled(status)); - /* There is no way to distinguish reason + /* + * There is no way to distinguish reason * for unexpected termination at the moment. */ Index: uspace/lib/posix/src/time.c =================================================================== --- uspace/lib/posix/src/time.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/time.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -53,5 +53,6 @@ // TODO: test everything in this file -/* In some places in this file, phrase "normalized broken-down time" is used. +/* + * In some places in this file, phrase "normalized broken-down time" is used. * This means time broken down to components (year, month, day, hour, min, sec), * in which every component is in its proper bounds. Non-normalized time could Index: uspace/lib/posix/src/unistd.c =================================================================== --- uspace/lib/posix/src/unistd.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/posix/src/unistd.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -110,6 +110,8 @@ { // TODO - /* Always returns false, because there is no easy way to find - * out under HelenOS. */ + /* + * Always returns false, because there is no easy way to find + * out under HelenOS. + */ return 0; } @@ -359,5 +361,6 @@ { if (amode == F_OK || (amode & (X_OK | W_OK | R_OK))) { - /* HelenOS doesn't support permissions, permission checks + /* + * HelenOS doesn't support permissions, permission checks * are equal to existence check. * Index: uspace/lib/softfloat/comparison.c =================================================================== --- uspace/lib/softfloat/comparison.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/softfloat/comparison.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -85,6 +85,8 @@ int is_float32_signan(float32 f) { - /* SigNaN : exp = 0xff and fraction = 0xxxxx..x (binary), - * where at least one x is nonzero */ + /* + * SigNaN : exp = 0xff and fraction = 0xxxxx..x (binary), + * where at least one x is nonzero + */ return ((f.parts.exp == 0xFF) && (f.parts.fraction < 0x400000) && (f.parts.fraction)); @@ -99,6 +101,8 @@ int is_float64_signan(float64 d) { - /* SigNaN : exp = 0x7ff and fraction = 0xxxxx..x (binary), - * where at least one x is nonzero */ + /* + * SigNaN : exp = 0x7ff and fraction = 0xxxxx..x (binary), + * where at least one x is nonzero + */ return ((d.parts.exp == 0x7FF) && (d.parts.fraction) && (d.parts.fraction < 0x8000000000000ll)); @@ -113,6 +117,8 @@ int is_float128_signan(float128 ld) { - /* SigNaN : exp = 0x7fff and fraction = 0xxxxx..x (binary), - * where at least one x is nonzero */ + /* + * SigNaN : exp = 0x7fff and fraction = 0xxxxx..x (binary), + * where at least one x is nonzero + */ return ((ld.parts.exp == 0x7FFF) && (ld.parts.frac_hi || ld.parts.frac_lo) && Index: uspace/lib/softfloat/div.c =================================================================== --- uspace/lib/softfloat/div.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/softfloat/div.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -481,7 +481,9 @@ &tmp_lolo /* dummy */, &tmp_hihi, &tmp_hilo, &tmp_lohi); - /* sub192(afrac_hi, afrac_lo, 0, + /* + * sub192(afrac_hi, afrac_lo, 0, * tmp_hihi, tmp_hilo, tmp_lohi - * &rem_hihi, &rem_hilo, &rem_lohi); */ + * &rem_hihi, &rem_hilo, &rem_lohi); + */ sub128(afrac_hi, afrac_lo, tmp_hihi, tmp_hilo, &rem_hihi, &rem_hilo); if (tmp_lohi > 0) { @@ -492,7 +494,9 @@ while ((int64_t) rem_hihi < 0) { --cfrac_hi; - /* add192(rem_hihi, rem_hilo, rem_lohi, + /* + * add192(rem_hihi, rem_hilo, rem_lohi, * 0, bfrac_hi, bfrac_lo, - * &rem_hihi, &rem_hilo, &rem_lohi); */ + * &rem_hihi, &rem_hilo, &rem_lohi); + */ add128(rem_hilo, rem_lohi, bfrac_hi, bfrac_lo, &rem_hilo, &rem_lohi); if (lt128(rem_hilo, rem_lohi, bfrac_hi, bfrac_lo)) { @@ -507,7 +511,9 @@ &tmp_hihi /* dummy */, &tmp_hilo, &tmp_lohi, &tmp_lolo); - /* sub192(rem_hilo, rem_lohi, 0, + /* + * sub192(rem_hilo, rem_lohi, 0, * tmp_hilo, tmp_lohi, tmp_lolo, - * &rem_hilo, &rem_lohi, &rem_lolo); */ + * &rem_hilo, &rem_lohi, &rem_lolo); + */ sub128(rem_hilo, rem_lohi, tmp_hilo, tmp_lohi, &rem_hilo, &rem_lohi); if (tmp_lolo > 0) { @@ -518,7 +524,9 @@ while ((int64_t) rem_hilo < 0) { --cfrac_lo; - /* add192(rem_hilo, rem_lohi, rem_lolo, + /* + * add192(rem_hilo, rem_lohi, rem_lolo, * 0, bfrac_hi, bfrac_lo, - * &rem_hilo, &rem_lohi, &rem_lolo); */ + * &rem_hilo, &rem_lohi, &rem_lolo); + */ add128(rem_lohi, rem_lolo, bfrac_hi, bfrac_lo, &rem_lohi, &rem_lolo); if (lt128(rem_lohi, rem_lolo, bfrac_hi, bfrac_lo)) { Index: uspace/lib/softint/generic/multiplication.c =================================================================== --- uspace/lib/softint/generic/multiplication.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/softint/generic/multiplication.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -93,5 +93,6 @@ } - /* (if OF checked) a1 or b1 is zero => result fits in 64 bits, + /* + * (if OF checked) a1 or b1 is zero => result fits in 64 bits, * no need to another overflow check */ @@ -107,6 +108,8 @@ t2 += t1; - /* t2 & (1ull << 63) - if this bit is set in unsigned long long, - * result does not fit in signed one */ + /* + * t2 & (1ull << 63) - if this bit is set in unsigned long long, + * result does not fit in signed one + */ if (SOFTINT_CHECK_OF && ((t2 < t1) || (t2 & (1ull << 63)))) { /* Error, overflow */ Index: uspace/lib/trackmod/types/trackmod.h =================================================================== --- uspace/lib/trackmod/types/trackmod.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/trackmod/types/trackmod.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -153,5 +153,6 @@ int vol_slide; /** Portamento amount (positive for tone and up portamento, - * negative for down portamento. */ + * negative for down portamento. + */ int portamento; /** Tone portamento target period. */ Index: uspace/lib/usb/include/usb/descriptor.h =================================================================== --- uspace/lib/usb/include/usb/descriptor.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usb/include/usb/descriptor.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -213,5 +213,6 @@ * Lower 10 bits represent the actuall size * Bits 11,12 specify addtional transfer opportunitities for - * HS INT and ISO transfers. */ + * HS INT and ISO transfers. + */ uint16_t max_packet_size; #define USB_ED_GET_MPS(ed) \ Index: uspace/lib/usbdev/include/usb/dev/driver.h =================================================================== --- uspace/lib/usbdev/include/usb/dev/driver.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbdev/include/usb/dev/driver.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -79,10 +79,10 @@ * .flags = 0 * }; - + * * static usb_endpoint_description_t *hub_endpoints[] = { * &poll_endpoint_description, * NULL * }; - + * * static usb_driver_t hub_driver = { * .endpoints = hub_endpoints, Index: uspace/lib/usbdev/src/altiface.c =================================================================== --- uspace/lib/usbdev/src/altiface.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbdev/src/altiface.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -136,6 +136,8 @@ if ((iface->descriptor_type != USB_DESCTYPE_INTERFACE) || (iface->interface_number != interface_number)) { - /* This is not a valid alternate interface descriptor - * for interface with number == interface_number. */ + /* + * This is not a valid alternate interface descriptor + * for interface with number == interface_number. + */ iface_ptr = usb_dp_get_sibling_descriptor(&dp_parser, &dp_data, dp_data.data, iface_ptr); Index: uspace/lib/usbdev/src/devdrv.c =================================================================== --- uspace/lib/usbdev/src/devdrv.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbdev/src/devdrv.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -453,6 +453,8 @@ } - /* This pipe was registered by the hub driver, - * during device initialization. */ + /* + * This pipe was registered by the hub driver, + * during device initialization. + */ errno_t rc = usb_pipe_initialize_default_control(&usb_dev->ctrl_pipe, usb_dev->bus_session); if (rc != EOK) { @@ -470,8 +472,10 @@ } - /* Create alternate interfaces. We will silently ignore failure. + /* + * Create alternate interfaces. We will silently ignore failure. * We might either control one interface or an entire device, * it makes no sense to speak about alternate interfaces when - * controlling a device. */ + * controlling a device. + */ usb_alternate_interfaces_init(&usb_dev->alternate_interfaces, usb_dev->descriptors.full_config, Index: uspace/lib/usbhid/include/usb/hid/hid_report_items.h =================================================================== --- uspace/lib/usbhid/include/usb/hid/hid_report_items.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhid/include/usb/hid/hid_report_items.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -53,5 +53,6 @@ /** Returns if the item is the short item or long item. Long items are not - * supported. */ + * supported. + */ #define USB_HID_ITEM_IS_LONG(data) (data == 0xFE) Index: uspace/lib/usbhid/include/usb/hid/hidpath.h =================================================================== --- uspace/lib/usbhid/include/usb/hid/hidpath.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhid/include/usb/hid/hidpath.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -97,5 +97,5 @@ /** * USB HID usage path structure. - * */ + */ typedef struct { /** Length of usage path */ @@ -103,5 +103,5 @@ /** Report id. Zero is reserved and means that report id is not used. - * */ + */ uint8_t report_id; Index: uspace/lib/usbhid/include/usb/hid/hidtypes.h =================================================================== --- uspace/lib/usbhid/include/usb/hid/hidtypes.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhid/include/usb/hid/hidtypes.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -82,5 +82,6 @@ /** Feature report. Describes device configuration information that - * can be sent to the device */ + * can be sent to the device + */ USB_HID_REPORT_TYPE_FEATURE = 3 } usb_hid_report_type_t; Index: uspace/lib/usbhid/src/hiddescriptor.c =================================================================== --- uspace/lib/usbhid/src/hiddescriptor.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhid/src/hiddescriptor.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -394,5 +394,6 @@ switch (ret) { case USB_HID_NEW_REPORT_ITEM: - /* store report item to report and create the + /* + * store report item to report and create the * new one store current collection path */ @@ -600,6 +601,8 @@ USB_HID_EXTENDED_USAGE(report_item->usages[report_item->usages_count - 1])); - /* append the new one which will be set by common usage/usage - * page */ + /* + * append the new one which will be set by common usage/usage + * page + */ usb_hid_report_path_append_item(usage_path, report_item->usage_page, Index: uspace/lib/usbhost/include/usb/host/hcd.h =================================================================== --- uspace/lib/usbhost/include/usb/host/hcd.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhost/include/usb/host/hcd.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -45,5 +45,6 @@ typedef struct device device_t; -/* Treat this header as read-only in driver code. +/* + * Treat this header as read-only in driver code. * It could be opaque, but why to complicate matters. */ @@ -71,5 +72,6 @@ /** Size of the device data to be allocated, and passed as the - * hc_device_t. */ + * hc_device_t. + */ size_t hc_device_size; Index: uspace/lib/usbhost/include/usb/host/usb_transfer_batch.h =================================================================== --- uspace/lib/usbhost/include/usb/host/usb_transfer_batch.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhost/include/usb/host/usb_transfer_batch.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -97,5 +97,5 @@ * Printf formatting string for dumping usb_transfer_batch_t. * [address:endpoint speed transfer_type-direction buffer_sizeB/max_packet_size] - * */ + */ #define USB_TRANSFER_BATCH_FMT "[%d:%d %s %s-%s %zuB/%zu]" Index: uspace/lib/usbhost/include/usb/host/utils/malloc32.h =================================================================== --- uspace/lib/usbhost/include/usb/host/utils/malloc32.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhost/include/usb/host/utils/malloc32.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -43,5 +43,6 @@ #include -/* Generic TDs and EDs require 16byte alignment, +/* + * Generic TDs and EDs require 16byte alignment, * Isochronous TD require 32byte alignment, * buffers do not have to be aligned. @@ -83,6 +84,8 @@ if (ret == EOK) { - /* Poison, accessing it should be enough to make sure - * the location is mapped, but poison works better */ + /* + * Poison, accessing it should be enough to make sure + * the location is mapped, but poison works better + */ memset(address, 0x5, real_size); return address; Index: uspace/lib/usbhost/src/bandwidth.c =================================================================== --- uspace/lib/usbhost/src/bandwidth.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhost/src/bandwidth.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -70,27 +70,35 @@ const size_t packet_count = ep->packets_per_uframe; - /* TODO: It may be that ISO and INT transfers use only one packet per - * transaction, but I did not find text in USB spec to confirm this */ + /* + * TODO: It may be that ISO and INT transfers use only one packet per + * transaction, but I did not find text in USB spec to confirm this + */ /* NOTE: All data packets will be considered to be max_packet_size */ switch (ep->device->speed) { case USB_SPEED_LOW: assert(type == USB_TRANSFER_INTERRUPT); - /* Protocol overhead 13B + /* + * Protocol overhead 13B * (3 SYNC bytes, 3 PID bytes, 2 Endpoint + CRC bytes, 2 * CRC bytes, and a 3-byte interpacket delay) - * see USB spec page 45-46. */ + * see USB spec page 45-46. + */ /* Speed penalty 8: low speed is 8-times slower*/ return packet_count * (13 + max_packet_size) * 8; case USB_SPEED_FULL: - /* Interrupt transfer overhead see above - * or page 45 of USB spec */ + /* + * Interrupt transfer overhead see above + * or page 45 of USB spec + */ if (type == USB_TRANSFER_INTERRUPT) return packet_count * (13 + max_packet_size); assert(type == USB_TRANSFER_ISOCHRONOUS); - /* Protocol overhead 9B + /* + * Protocol overhead 9B * (2 SYNC bytes, 2 PID bytes, 2 Endpoint + CRC bytes, 2 CRC * bytes, and a 1-byte interpacket delay) - * see USB spec page 42 */ + * see USB spec page 42 + */ return packet_count * (9 + max_packet_size); default: Index: uspace/lib/usbhost/src/hcd.c =================================================================== --- uspace/lib/usbhost/src/hcd.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/lib/usbhost/src/hcd.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -120,7 +120,9 @@ bus->ops->interrupt(bus, status); status = 0; - /* We should wait 1 frame - 1ms here, but this polling is a + /* + * We should wait 1 frame - 1ms here, but this polling is a * lame crutch anyway so don't hog the system. 10ms is still - * good enough for emergency mode */ + * good enough for emergency mode + */ async_usleep(10000); } Index: uspace/srv/audio/hound/audio_device.c =================================================================== --- uspace/srv/audio/hound/audio_device.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/audio/hound/audio_device.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -170,6 +170,8 @@ device_event_callback, dev); - /* Fill the buffer first. Fill the first two fragments, - * so that we stay one fragment ahead */ + /* + * Fill the buffer first. Fill the first two fragments, + * so that we stay one fragment ahead + */ pcm_format_silence(dev->buffer.base, dev->buffer.size, &dev->sink.format); Index: uspace/srv/bd/vbd/disk.c =================================================================== --- uspace/srv/bd/vbd/disk.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/bd/vbd/disk.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -403,5 +403,6 @@ /** Remove all disk partitions from our inventory leaving only the underlying - * liblabel partition structures. */ + * liblabel partition structures. + */ static errno_t vbds_disk_parts_add(vbds_disk_t *disk, label_t *label) { @@ -425,5 +426,6 @@ /** Remove all disk partitions from our inventory leaving only the underlying - * liblabel partition structures. */ + * liblabel partition structures. + */ static errno_t vbds_disk_parts_remove(vbds_disk_t *disk, vbds_rem_flag_t flag) { Index: uspace/srv/devman/client_conn.c =================================================================== --- uspace/srv/devman/client_conn.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/devman/client_conn.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -60,5 +60,6 @@ /** Find handle for the device instance identified by the device's path in the - * device tree. */ + * device tree. + */ static void devman_function_get_handle(cap_call_handle_t icall_handle, ipc_call_t *icall) { Index: uspace/srv/fs/cdfs/cdfs_ops.c =================================================================== --- uspace/srv/fs/cdfs/cdfs_ops.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/fs/cdfs/cdfs_ops.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -850,5 +850,6 @@ /** Verify that escape sequence corresonds to one of the allowed encoding - * escape sequences allowed for Joliet. */ + * escape sequences allowed for Joliet. + */ static errno_t cdfs_verify_joliet_esc_seq(uint8_t *seq) { @@ -1049,5 +1050,6 @@ } -/* Mount a session with session start offset +/* + * Mount a session with session start offset * */ Index: uspace/srv/fs/mfs/mfs.h =================================================================== --- uspace/srv/fs/mfs/mfs.h (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/fs/mfs/mfs.h (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -106,9 +106,11 @@ unsigned zsearch; - /* Indicates wether if the cached number of free zones + /* + * Indicates wether if the cached number of free zones * is to be considered valid or not. */ bool nfree_zones_valid; - /* Cached number of free zones, used to avoid to scan + /* + * Cached number of free zones, used to avoid to scan * the whole bitmap every time the mfs_free_block_count() * is invoked. Index: uspace/srv/fs/mfs/mfs_balloc.c =================================================================== --- uspace/srv/fs/mfs/mfs_balloc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/fs/mfs/mfs_balloc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -191,5 +191,6 @@ bitchunk_t *data = (bitchunk_t *) b->data; - /* Read the bitmap block, chunk per chunk, + /* + * Read the bitmap block, chunk per chunk, * counting the zero bits. */ Index: uspace/srv/fs/mfs/mfs_ops.c =================================================================== --- uspace/srv/fs/mfs/mfs_ops.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/fs/mfs/mfs_ops.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -246,5 +246,6 @@ if (sbi->log2_zone_size != 0) { - /* In MFS, file space is allocated per zones. + /* + * In MFS, file space is allocated per zones. * Zones are a collection of consecutive blocks on disk. * @@ -776,5 +777,6 @@ if (chino->i_nlinks <= 1 && S_ISDIR(chino->i_mode)) { - /* The child directory will be destroyed, decrease the + /* + * The child directory will be destroyed, decrease the * parent hard links counter. */ @@ -1239,5 +1241,6 @@ if (!sbi->nfree_zones_valid) { - /* The cached number of free zones is not valid, + /* + * The cached number of free zones is not valid, * we need to scan the bitmap to retrieve the * current value. Index: uspace/srv/hid/compositor/compositor.c =================================================================== --- uspace/srv/hid/compositor/compositor.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/hid/compositor/compositor.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -77,6 +77,8 @@ #define NAMESPACE "comp" -/* Until there is blitter support and some further optimizations, window - * animations are too slow to be practically usable. */ +/* + * Until there is blitter support and some further optimizations, window + * animations are too slow to be practically usable. + */ #ifndef ANIMATE_WINDOW_TRANSFORMS #define ANIMATE_WINDOW_TRANSFORMS 0 @@ -422,6 +424,8 @@ link != &window_list.head; link = link->prev) { - /* Determine what part of the window intersects with the - * updated area of the current viewport. */ + /* + * Determine what part of the window intersects with the + * updated area of the current viewport. + */ window_t *win = list_get_instance(link, window_t, link); if (!win->surface) { @@ -438,6 +442,8 @@ if (isec_win) { - /* Prepare conversion from global coordinates to viewport - * coordinates. */ + /* + * Prepare conversion from global coordinates to viewport + * coordinates. + */ transform = win->transform; double_point_t pos; @@ -470,5 +476,6 @@ if (isec_ghost) { - /* FIXME: Ghost is currently drawn based on the bounding + /* + * FIXME: Ghost is currently drawn based on the bounding * rectangle of the window, which is sufficient as long * as the windows can be rotated only by 90 degrees. @@ -476,5 +483,6 @@ * rotation, it should be drawn as four lines adjusted * by the transformation matrix. That would however - * require to equip libdraw with line drawing functionality. */ + * require to equip libdraw with line drawing functionality. + */ transform_t transform = ptr->ghost.transform; @@ -532,6 +540,8 @@ list_foreach(pointer_list, link, pointer_t, ptr) { - /* Determine what part of the pointer intersects with the - * updated area of the current viewport. */ + /* + * Determine what part of the pointer intersects with the + * updated area of the current viewport. + */ sysarg_t x_dmg_ptr, y_dmg_ptr, w_dmg_ptr, h_dmg_ptr; surface_t *sf_ptr = ptr->cursor.states[ptr->state]; @@ -543,9 +553,11 @@ if (isec_ptr) { - /* Pointer is currently painted directly by copying pixels. + /* + * Pointer is currently painted directly by copying pixels. * However, it is possible to draw the pointer similarly * as window by using drawctx_transfer. It would allow * more sophisticated control over drawing, but would also - * cost more regarding the performance. */ + * cost more regarding the performance. + */ sysarg_t x_vp = x_dmg_ptr - vp->pos.x; @@ -857,6 +869,8 @@ loc_service_unregister(win->out_dsid); - /* In case the client was killed, input fibril of the window might be - * still blocked on the condition within comp_window_get_event. */ + /* + * In case the client was killed, input fibril of the window might be + * still blocked on the condition within comp_window_get_event. + */ window_event_t *event_dummy = (window_event_t *) malloc(sizeof(window_event_t)); if (event_dummy) { Index: uspace/srv/hid/rfb/rfb.c =================================================================== --- uspace/srv/hid/rfb/rfb.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/hid/rfb/rfb.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -612,5 +612,6 @@ } - /* Security handshake + /* + * Security handshake * 1 security type supported, which is 1 - None */ Index: uspace/srv/locsrv/locsrv.c =================================================================== --- uspace/srv/locsrv/locsrv.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/locsrv/locsrv.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -67,10 +67,11 @@ LIST_INITIALIZE(servers_list); -/* Locking order: +/* + * Locking order: * servers_list_mutex * services_list_mutex * (loc_server_t *)->services_mutex * create_id_mutex - **/ + */ FIBRIL_MUTEX_INITIALIZE(services_list_mutex); @@ -97,5 +98,6 @@ service_id_t loc_create_id(void) { - /* TODO: allow reusing old ids after their unregistration + /* + * TODO: allow reusing old ids after their unregistration * and implement some version of LRU algorithm, avoid overflow */ @@ -389,5 +391,6 @@ fibril_mutex_lock(&servers_list_mutex); - /* TODO: + /* + * TODO: * Check that no server with name equal to * server->name is registered @@ -1057,6 +1060,8 @@ static void loc_get_services(cap_call_handle_t icall_handle, ipc_call_t *icall) { - /* FIXME: Use faster algorithm which can make better use - of namespaces */ + /* + * FIXME: Use faster algorithm which can make better use + * of namespaces + */ cap_call_handle_t chandle; Index: uspace/srv/net/tcp/test/ucall.c =================================================================== --- uspace/srv/net/tcp/test/ucall.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/net/tcp/test/ucall.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -135,5 +135,6 @@ /** Test establishing and then closing down a connection first on one side, - * then on_the other. */ + * then on_the other. + */ PCUT_TEST(conn_est_close_seq) { Index: uspace/srv/vfs/vfs_ipc.c =================================================================== --- uspace/srv/vfs/vfs_ipc.c (revision fac0ac7be7d127e6cc5c186e3c497bea39ed2e3b) +++ uspace/srv/vfs/vfs_ipc.c (revision 7c3fb9bd77e4d2f6c10517a052e567f176fa91ee) @@ -136,5 +136,6 @@ } - /* Now, we expect the client to send us data with the name of the file + /* + * Now we expect the client to send us data with the name of the file * system. */