Changeset 79ae36dd in mainline for uspace/lib/c/generic/task.c

Timestamp:

2011-06-08T19:01:55Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

File:

• uspace/lib/c/generic/task.c (modified) (10 diffs)

uspace/lib/c/generic/task.c

@@ -35 +35 @@
 
 #include <task.h>
-#include <libc.h>
-#include <stdlib.h>
-#include <errno.h>
 #include <loader/loader.h>
 #include <stdarg.h>
@@ -43 +40 @@
 #include <ipc/ns.h>
 #include <macros.h>
+#include <assert.h>
 #include <async.h>
+#include <errno.h>
+#include <malloc.h>
+#include <libc.h>
+#include "private/ns.h"
 
 task_id_t task_get_id(void)
@@ -68 +70 @@
 int task_set_name(const char *name)
 {
+        assert(name);
+        
         return __SYSCALL2(SYS_TASK_SET_NAME, (sysarg_t) name, str_size(name));
 }
@@ -88 +92 @@
  * loader API. Arguments are passed as a null-terminated array of strings.
  *
- * @param id    If not NULL, the ID of the task is stored here on success.
- * @param path  Pathname of the binary to execute.
- * @param argv  Command-line arguments.
- *
- * @return      Zero on success or negative error code.
+ * @param id   If not NULL, the ID of the task is stored here on success.
+ * @param path Pathname of the binary to execute.
+ * @param argv Command-line arguments.
+ *
+ * @return Zero on success or negative error code.
+ *
  */
 int task_spawnv(task_id_t *id, const char *path, const char *const args[])
 {
-        loader_t *ldr;
-        task_id_t task_id;
-        int rc;
-
         /* Connect to a program loader. */
-        ldr = loader_connect();
+        loader_t *ldr = loader_connect();
         if (ldr == NULL)
                 return EREFUSED;
         
         /* Get task ID. */
-        rc = loader_get_task_id(ldr, &task_id);
+        task_id_t task_id;
+        int rc = loader_get_task_id(ldr, &task_id);
         if (rc != EOK)
                 goto error;
@@ -163 +165 @@
         
         /* Success */
-        free(ldr);
-        
         if (id != NULL)
                 *id = task_id;
@@ -182 +182 @@
  * loader API. Arguments are passed as a null-terminated list of arguments.
  *
- * @param id    If not NULL, the ID of the task is stored here on success.
- * @param path  Pathname of the binary to execute.
- * @param ...   Command-line arguments.
- *
- * @return      Zero on success or negative error code.
+ * @param id   If not NULL, the ID of the task is stored here on success.
+ * @param path Pathname of the binary to execute.
+ * @param ...  Command-line arguments.
+ *
+ * @return Zero on success or negative error code.
+ *
  */
 int task_spawnl(task_id_t *task_id, const char *path, ...)
 {
+        /* Count the number of arguments. */
+        
         va_list ap;
-        int rc, cnt;
         const char *arg;
         const char **arglist;
-
-        /* Count the number of arguments. */
-        cnt = 0;
+        int cnt = 0;
+        
         va_start(ap, path);
         do {
@@ -203 +204 @@
         } while (arg != NULL);
         va_end(ap);
-
+        
         /* Allocate argument list. */
         arglist = malloc(cnt * sizeof(const char *));
         if (arglist == NULL)
                 return ENOMEM;
-
+        
         /* Fill in arguments. */
         cnt = 0;
@@ -217 +218 @@
         } while (arg != NULL);
         va_end(ap);
-
+        
         /* Spawn task. */
-        rc = task_spawnv(task_id, path, arglist);
-
+        int rc = task_spawnv(task_id, path, arglist);
+        
         /* Free argument list. */
         free(arglist);
@@ -228 +229 @@
 int task_wait(task_id_t id, task_exit_t *texit, int *retval)
 {
+        assert(texit);
+        assert(retval);
+        
+        async_exch_t *exch = async_exchange_begin(session_ns);
         sysarg_t te, rv;
-        int rc;
-
-        rc = (int) async_req_2_2(PHONE_NS, NS_TASK_WAIT, LOWER32(id),
+        int rc = (int) async_req_2_2(exch, NS_TASK_WAIT, LOWER32(id),
             UPPER32(id), &te, &rv);
+        async_exchange_end(exch);
+        
         *texit = te;
         *retval = rv;
-
+        
         return rc;
 }
@@ -241 +246 @@
 int task_retval(int val)
 {
-        return (int) async_req_1_0(PHONE_NS, NS_RETVAL, val);
+        async_exch_t *exch = async_exchange_begin(session_ns);
+        int rc = (int) async_req_1_0(exch, NS_RETVAL, val);
+        async_exchange_end(exch);
+        
+        return rc;
 }