Changeset 7837101e in mainline

Timestamp:

2010-12-16T16:58:41Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1b59023

Parents:

7bdcc45

Message:

Get rid of superfluous uses of CONVERT_SIZE.

Location:

uspace/srv/net

Files:

• il/arp/arp.c (modified) (5 diffs)
• il/ip/ip.c (modified) (4 diffs)
• nil/eth/eth.c (modified) (1 diff)

uspace/srv/net/il/arp/arp.c

@@ -483 +483 @@
         des_proto = des_hw + header->hardware_length;
         trans = arp_addr_find(&proto->addresses, (char *) src_proto,
-            CONVERT_SIZE(uint8_t, char, header->protocol_length));
+            header->protocol_length);
         /* Exists? */
         if (trans && trans->hw_addr) {
-                if (trans->hw_addr->length != CONVERT_SIZE(uint8_t, char,
-                    header->hardware_length)) {
+                if (trans->hw_addr->length != header->hardware_length)
                         return EINVAL;
-                }
                 memcpy(trans->hw_addr->value, src_hw, trans->hw_addr->length);
         }
         /* Is my protocol address? */
-        if (proto->addr->length != CONVERT_SIZE(uint8_t, char,
-            header->protocol_length)) {
+        if (proto->addr->length != header->protocol_length)
                 return EINVAL;
-        }
         if (!str_lcmp(proto->addr->value, (char *) des_proto,
             proto->addr->length)) {
@@ -507 +503 @@
                         fibril_condvar_initialize(&trans->cv);
                         rc = arp_addr_add(&proto->addresses, (char *) src_proto,
-                            CONVERT_SIZE(uint8_t, char, header->protocol_length),
-                            trans);
+                            header->protocol_length, trans);
                         if (rc != EOK) {
                                 /* The generic char map has already freed trans! */
@@ -516 +511 @@
                 if (!trans->hw_addr) {
                         trans->hw_addr = measured_string_create_bulk(
-                            (char *) src_hw, CONVERT_SIZE(uint8_t, char,
-                            header->hardware_length));
+                            (char *) src_hw, header->hardware_length);
                         if (!trans->hw_addr)
                                 return ENOMEM;
@@ -606 +600 @@
 
         /* ARP packet content size = header + (address + translation) * 2 */
-        length = 8 + 2 * (CONVERT_SIZE(char, uint8_t, proto->addr->length) +
-            CONVERT_SIZE(char, uint8_t, device->addr->length));
+        length = 8 + 2 * (proto->addr->length + device->addr->length);
         if (length > device->packet_dimension.content)
                 return ELIMIT;
@@ -640 +633 @@
 
         rc = packet_set_addr(packet, (uint8_t *) device->addr->value,
-            (uint8_t *) device->broadcast_addr->value,
-            CONVERT_SIZE(char, uint8_t, device->addr->length));
+            (uint8_t *) device->broadcast_addr->value, device->addr->length);
         if (rc != EOK) {
                 pq_release_remote(arp_globals.net_phone, packet_get_id(packet));

uspace/srv/net/il/ip/ip.c

@@ -639 +639 @@
         if (destination) {
                 rc = packet_set_addr(packet, NULL, (uint8_t *) destination->value,
-                    CONVERT_SIZE(char, uint8_t, destination->length));
+                    destination->length);
         } else {
                 rc = packet_set_addr(packet, NULL, NULL, 0);
@@ -687 +687 @@
                                 rc = packet_set_addr(next, NULL,
                                     (uint8_t *) destination->value,
-                                    CONVERT_SIZE(char, uint8_t,
-                                    destination->length));
+                                    destination->length);
                                 if (rc != EOK) {
                                         free(last_header);
@@ -718 +717 @@
                         rc = packet_set_addr(next, NULL,
                             (uint8_t *) destination->value,
-                            CONVERT_SIZE(char, uint8_t, destination->length));
+                            destination->length);
                         if (rc != EOK) {
                                 free(last_header);
@@ -1758 +1757 @@
                         // clear the ARP mapping if any
                         address.value = (char *) &header->destination_address;
-                        address.length = CONVERT_SIZE(uint8_t, char,
-                            sizeof(header->destination_address));
+                        address.length = sizeof(header->destination_address);
                         arp_clear_address_req(netif->arp->phone,
                             netif->device_id, SERVICE_IP, &address);

uspace/srv/net/nil/eth/eth.c

@@ -201 +201 @@
 
         eth_globals.broadcast_addr =
-            measured_string_create_bulk("\xFF\xFF\xFF\xFF\xFF\xFF",
-            CONVERT_SIZE(uint8_t, char, ETH_ADDR));
+            measured_string_create_bulk("\xFF\xFF\xFF\xFF\xFF\xFF", ETH_ADDR);
         if (!eth_globals.broadcast_addr) {
                 rc = ENOMEM;